1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <set>
#include <tuple>
#include "ash/accelerators/accelerator_table.h"
#include "base/hash/md5.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace ash {
namespace {
// The number of non-Search-based accelerators.
constexpr int kNonSearchAcceleratorsNum = 109;
// The hash of non-Search-based accelerators. See HashAcceleratorData().
constexpr char kNonSearchAcceleratorsHash[] =
"f59bc0d21b6c243361b02c8cbae92f0e";
struct Cmp {
bool operator()(const AcceleratorData& lhs,
const AcceleratorData& rhs) const {
// Do not check |action|.
return std::tie(lhs.trigger_on_press, lhs.keycode, lhs.modifiers) <
std::tie(rhs.trigger_on_press, rhs.keycode, rhs.modifiers);
}
};
std::string AcceleratorDataToString(const AcceleratorData& accelerator) {
return base::StringPrintf(
"trigger_on_press=%s keycode=%d shift=%s control=%s alt=%s search=%s",
accelerator.trigger_on_press ? "true" : "false", accelerator.keycode,
(accelerator.modifiers & ui::EF_SHIFT_DOWN) ? "true" : "false",
(accelerator.modifiers & ui::EF_CONTROL_DOWN) ? "true" : "false",
(accelerator.modifiers & ui::EF_ALT_DOWN) ? "true" : "false",
(accelerator.modifiers & ui::EF_COMMAND_DOWN) ? "true" : "false");
}
std::string HashAcceleratorData(
const std::vector<AcceleratorData> accelerators) {
base::MD5Context context;
base::MD5Init(&context);
for (const AcceleratorData& accelerator : accelerators)
base::MD5Update(&context, AcceleratorDataToString(accelerator));
base::MD5Digest digest;
base::MD5Final(&digest, &context);
return MD5DigestToBase16(digest);
}
} // namespace
TEST(AcceleratorTableTest, CheckDuplicatedAccelerators) {
std::set<AcceleratorData, Cmp> accelerators;
for (size_t i = 0; i < kAcceleratorDataLength; ++i) {
const AcceleratorData& entry = kAcceleratorData[i];
EXPECT_TRUE(accelerators.insert(entry).second)
<< "Duplicated accelerator: " << AcceleratorDataToString(entry);
}
for (size_t i = 0; i < kDisableWithNewMappingAcceleratorDataLength; ++i) {
const AcceleratorData& entry = kDisableWithNewMappingAcceleratorData[i];
EXPECT_TRUE(accelerators.insert(entry).second)
<< "Duplicated accelerator: " << AcceleratorDataToString(entry);
}
}
TEST(AcceleratorTableTest, CheckDuplicatedReservedActions) {
std::set<AcceleratorAction> actions;
for (size_t i = 0; i < kReservedActionsLength; ++i) {
EXPECT_TRUE(actions.insert(kReservedActions[i]).second)
<< "Duplicated action: " << kReservedActions[i];
}
}
TEST(AcceleratorTableTest, CheckDuplicatedActionsAllowedAtLoginOrLockScreen) {
std::set<AcceleratorAction> actions;
for (size_t i = 0; i < kActionsAllowedAtLoginOrLockScreenLength; ++i) {
EXPECT_TRUE(actions.insert(kActionsAllowedAtLoginOrLockScreen[i]).second)
<< "Duplicated action: " << kActionsAllowedAtLoginOrLockScreen[i];
}
for (size_t i = 0; i < kActionsAllowedAtLockScreenLength; ++i) {
EXPECT_TRUE(actions.insert(kActionsAllowedAtLockScreen[i]).second)
<< "Duplicated action: " << kActionsAllowedAtLockScreen[i];
}
}
TEST(AcceleratorTableTest, CheckDuplicatedActionsAllowedAtPowerMenu) {
std::set<AcceleratorAction> actions;
for (size_t i = 0; i < kActionsAllowedAtPowerMenuLength; ++i) {
EXPECT_TRUE(actions.insert(kActionsAllowedAtPowerMenu[i]).second)
<< "Duplicated action: " << kActionsAllowedAtPowerMenu[i];
}
}
TEST(AcceleratorTableTest, CheckDuplicatedActionsAllowedAtModalWindow) {
std::set<AcceleratorAction> actions;
for (size_t i = 0; i < kActionsAllowedAtModalWindowLength; ++i) {
EXPECT_TRUE(actions.insert(kActionsAllowedAtModalWindow[i]).second)
<< "Duplicated action: " << kActionsAllowedAtModalWindow[i]
<< " at index: " << i;
}
}
TEST(AcceleratorTableTest, CheckDuplicatedRepeatableActions) {
std::set<AcceleratorAction> actions;
for (size_t i = 0; i < kRepeatableActionsLength; ++i) {
EXPECT_TRUE(actions.insert(kRepeatableActions[i]).second)
<< "Duplicated action: " << kRepeatableActions[i] << " at index: " << i;
}
}
TEST(AcceleratorTableTest, CheckDeprecatedAccelerators) {
std::set<AcceleratorData, Cmp> deprecated_actions;
for (size_t i = 0; i < kDeprecatedAcceleratorsLength; ++i) {
// A deprecated action can never appear twice in the list.
const AcceleratorData& entry = kDeprecatedAccelerators[i];
EXPECT_TRUE(deprecated_actions.insert(entry).second)
<< "Duplicate deprecated accelerator: "
<< AcceleratorDataToString(entry);
}
std::set<AcceleratorAction> actions;
for (size_t i = 0; i < kDeprecatedAcceleratorsDataLength; ++i) {
// There must never be any duplicated actions.
const DeprecatedAcceleratorData& data = kDeprecatedAcceleratorsData[i];
EXPECT_TRUE(actions.insert(data.action).second)
<< "Deprecated action: " << data.action;
// The UMA histogram name must be of the format "Ash.Accelerators.*"
std::string uma_histogram(data.uma_histogram_name);
EXPECT_TRUE(base::StartsWith(uma_histogram, "Ash.Accelerators.",
base::CompareCase::SENSITIVE));
}
}
// All new accelerators should be Search-based and approved by UX.
TEST(AcceleratorTableTest, CheckSearchBasedAccelerators) {
std::vector<AcceleratorData> non_search_accelerators;
for (size_t i = 0; i < kAcceleratorDataLength; ++i) {
const AcceleratorData& entry = kAcceleratorData[i];
if (entry.modifiers & ui::EF_COMMAND_DOWN)
continue;
non_search_accelerators.emplace_back(entry);
}
for (size_t i = 0; i < kDisableWithNewMappingAcceleratorDataLength; ++i) {
const AcceleratorData& entry = kDisableWithNewMappingAcceleratorData[i];
if (entry.modifiers & ui::EF_COMMAND_DOWN)
continue;
non_search_accelerators.emplace_back(entry);
}
const int accelerators_number = non_search_accelerators.size();
EXPECT_EQ(accelerators_number, kNonSearchAcceleratorsNum)
<< "All new accelerators should be Search-based and approved by UX.";
std::stable_sort(non_search_accelerators.begin(),
non_search_accelerators.end(), Cmp());
const std::string non_search_accelerators_hash =
HashAcceleratorData(non_search_accelerators);
EXPECT_EQ(non_search_accelerators_hash, kNonSearchAcceleratorsHash)
<< "New accelerators must use the Search key. Please talk to the UX "
"team.\n"
"If you are removing a non-Search-based accelerator, please update "
"the date along with the following values\n"
<< "kNonSearchAcceleratorsNum=" << accelerators_number << " and "
<< "kNonSearchAcceleratorsHash=\"" << non_search_accelerators_hash
<< "\"";
}
} // namespace ash
|
