1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441
|
// Copyright 2015 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/display/cursor_window_controller.h"
#include "base/memory/raw_ptr.h"
#include <utility>
#include "ash/accessibility/accessibility_controller_impl.h"
#include "ash/constants/ash_constants.h"
#include "ash/constants/ash_pref_names.h"
#include "ash/display/display_util.h"
#include "ash/display/window_tree_host_manager.h"
#include "ash/session/session_controller_impl.h"
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "base/command_line.h"
#include "base/notreached.h"
#include "base/strings/stringprintf.h"
#include "components/prefs/pref_service.h"
#include "ui/aura/client/cursor_shape_client.h"
#include "ui/aura/window.h"
#include "ui/aura/window_tree_host.h"
#include "ui/base/cursor/cursor.h"
#include "ui/base/cursor/mojom/cursor_type.mojom-shared.h"
#include "ui/base/resource/mock_resource_bundle_delegate.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/base/resource/resource_scale_factor.h"
#include "ui/display/display.h"
#include "ui/display/screen.h"
#include "ui/display/test/display_manager_test_api.h"
#include "ui/events/test/event_generator.h"
#include "ui/gfx/color_utils.h"
#include "ui/gfx/geometry/dip_util.h"
#include "ui/gfx/geometry/point.h"
#include "ui/gfx/geometry/point_conversions.h"
#include "ui/gfx/geometry/size.h"
#include "ui/gfx/geometry/size_conversions.h"
#include "ui/gfx/geometry/skia_conversions.h"
#include "ui/gfx/image/image.h"
#include "ui/gfx/image/image_skia.h"
#include "ui/gfx/image/image_skia_rep.h"
#include "ui/gfx/image/image_skia_source.h"
#include "ui/wm/core/cursor_manager.h"
namespace ash {
using ::ui::mojom::CursorType;
class CursorWindowControllerTest : public AshTestBase {
public:
CursorWindowControllerTest() = default;
CursorWindowControllerTest(const CursorWindowControllerTest&) = delete;
CursorWindowControllerTest& operator=(const CursorWindowControllerTest&) =
delete;
~CursorWindowControllerTest() override = default;
// AshTestBase:
void SetUp() override {
AshTestBase::SetUp();
// Shell hides the cursor by default; show it for these tests.
Shell::Get()->cursor_manager()->ShowCursor();
cursor_window_controller_ =
Shell::Get()->window_tree_host_manager()->cursor_window_controller();
SetCursorCompositionEnabled(true);
}
CursorType GetCursorType() const {
return cursor_window_controller_->cursor_.type();
}
const gfx::Point& GetCursorHotPoint() const {
return cursor_window_controller_->hot_point_;
}
aura::Window* GetCursorWindow() const {
return cursor_window_controller_->cursor_window_.get();
}
const gfx::ImageSkia& GetCursorImage() const {
return cursor_window_controller_->GetCursorImageForTest();
}
int64_t GetCursorDisplayId() const {
return cursor_window_controller_->display_.id();
}
void SetCursorCompositionEnabled(bool enabled) {
// Cursor compositing will be enabled when high contrast mode is turned on.
// Cursor compositing will be disabled when high contrast mode is the only
// feature using it and is turned off.
Shell::Get()->accessibility_controller()->high_contrast().SetEnabled(
enabled);
}
CursorWindowController* cursor_window_controller() {
return cursor_window_controller_;
}
private:
// Not owned.
raw_ptr<CursorWindowController, DanglingUntriaged | ExperimentalAsh>
cursor_window_controller_;
};
// Test that the composited cursor moves to another display when the real cursor
// moves to another display.
TEST_F(CursorWindowControllerTest, MoveToDifferentDisplay) {
UpdateDisplay("300x200,300x200*2/r");
WindowTreeHostManager* window_tree_host_manager =
Shell::Get()->window_tree_host_manager();
int64_t primary_display_id = window_tree_host_manager->GetPrimaryDisplayId();
int64_t secondary_display_id =
display::test::DisplayManagerTestApi(display_manager())
.GetSecondaryDisplay()
.id();
aura::Window* primary_root =
window_tree_host_manager->GetRootWindowForDisplayId(primary_display_id);
aura::Window* secondary_root =
window_tree_host_manager->GetRootWindowForDisplayId(secondary_display_id);
ui::test::EventGenerator primary_generator(primary_root);
primary_generator.MoveMouseToInHost(20, 50);
EXPECT_TRUE(primary_root->Contains(GetCursorWindow()));
EXPECT_EQ(primary_display_id, GetCursorDisplayId());
EXPECT_EQ(CursorType::kNull, GetCursorType());
gfx::Point hot_point = GetCursorHotPoint();
EXPECT_EQ(gfx::Point(4, 4), hot_point);
gfx::Rect cursor_bounds = GetCursorWindow()->GetBoundsInScreen();
EXPECT_EQ(20, cursor_bounds.x() + hot_point.x());
EXPECT_EQ(50, cursor_bounds.y() + hot_point.y());
// The cursor can only be moved between displays via
// WindowTreeHost::MoveCursorTo(). EventGenerator uses a hack to move the
// cursor between displays.
// Screen location: 220, 50
// Root location: 20, 50
secondary_root->MoveCursorTo(gfx::Point(20, 50));
// Chrome relies on WindowTreeHost::MoveCursorTo() dispatching a mouse move
// asynchronously. This is implemented in a platform specific way. Generate a
// fake mouse move instead of waiting.
gfx::Point new_cursor_position_in_host(20, 50);
secondary_root->GetHost()->ConvertDIPToPixels(&new_cursor_position_in_host);
ui::test::EventGenerator secondary_generator(secondary_root);
secondary_generator.MoveMouseToInHost(new_cursor_position_in_host);
EXPECT_TRUE(secondary_root->Contains(GetCursorWindow()));
EXPECT_EQ(secondary_display_id, GetCursorDisplayId());
EXPECT_EQ(CursorType::kNull, GetCursorType());
hot_point = GetCursorHotPoint();
EXPECT_EQ(gfx::Point(3, 3), hot_point);
cursor_bounds = GetCursorWindow()->GetBoundsInScreen();
EXPECT_EQ(320, cursor_bounds.x() + hot_point.x());
EXPECT_EQ(50, cursor_bounds.y() + hot_point.y());
}
// Make sure that composition cursor inherits the visibility state.
TEST_F(CursorWindowControllerTest, VisibilityTest) {
ASSERT_TRUE(GetCursorWindow());
EXPECT_TRUE(GetCursorWindow()->IsVisible());
aura::client::CursorClient* client = Shell::Get()->cursor_manager();
client->HideCursor();
ASSERT_TRUE(GetCursorWindow());
EXPECT_FALSE(GetCursorWindow()->IsVisible());
// Normal cursor should be in the correct state.
SetCursorCompositionEnabled(false);
ASSERT_FALSE(GetCursorWindow());
ASSERT_FALSE(client->IsCursorVisible());
// Cursor was hidden.
SetCursorCompositionEnabled(true);
ASSERT_TRUE(GetCursorWindow());
EXPECT_FALSE(GetCursorWindow()->IsVisible());
// Goback to normal cursor and show the cursor.
SetCursorCompositionEnabled(false);
ASSERT_FALSE(GetCursorWindow());
ASSERT_FALSE(client->IsCursorVisible());
client->ShowCursor();
ASSERT_TRUE(client->IsCursorVisible());
// Cursor was shown.
SetCursorCompositionEnabled(true);
ASSERT_TRUE(GetCursorWindow());
EXPECT_TRUE(GetCursorWindow()->IsVisible());
}
namespace {
// Emulates the behavior of BitmapImageSource used in ResourceBundle.
class TestCursorImageSource : public gfx::ImageSkiaSource {
public:
TestCursorImageSource() = default;
TestCursorImageSource(const TestCursorImageSource&) = delete;
TestCursorImageSource operator=(const TestCursorImageSource&) = delete;
~TestCursorImageSource() override = default;
// gfx::ImageSkiaSource:
gfx::ImageSkiaRep GetImageForScale(float scale) override {
float resource_scale = ui::GetSupportedResourceScaleFactor(scale);
if (resource_scale == 1.f) {
return rep_1x_;
} else if (resource_scale == 2.f) {
return rep_2x_;
}
NOTREACHED();
return rep_1x_;
}
private:
static SkBitmap CreateSolidColorBitmap(SkColor color, int size) {
SkBitmap bitmap;
bitmap.allocN32Pixels(size, size);
bitmap.eraseColor(color);
return bitmap;
}
gfx::ImageSkiaRep rep_1x_ =
gfx::ImageSkiaRep(CreateSolidColorBitmap(SK_ColorBLACK, 25), 1.f);
gfx::ImageSkiaRep rep_2x_ =
gfx::ImageSkiaRep(CreateSolidColorBitmap(SK_ColorWHITE, 50), 2.f);
};
} // namespace
// Make sure that composition cursor uses correct assets with various scales.
TEST_F(CursorWindowControllerTest, ScaleUsesCorrectAssets) {
testing::NiceMock<ui::MockResourceBundleDelegate> mock_delegate;
gfx::ImageSkia image_skia(std::make_unique<TestCursorImageSource>(),
gfx::Size(25, 25));
auto get_pixel_value = [&](float scale) {
uint32_t* data = static_cast<uint32_t*>(
GetCursorImage().GetRepresentation(scale).GetBitmap().getPixels());
return data[0];
};
EXPECT_CALL(mock_delegate, GetImageNamed(testing::_))
.WillOnce(testing::Return(gfx::Image(image_skia)));
ui::ResourceBundle test_bundle(&mock_delegate);
auto* original =
ui::ResourceBundle::SwapSharedInstanceForTesting(&test_bundle);
// Force re-create composited cursor.
SetCursorCompositionEnabled(false);
SetCursorCompositionEnabled(true);
// The cursor should use 2x resources when dsf > 1.2.
EXPECT_EQ(SK_ColorWHITE, get_pixel_value(2.4f));
EXPECT_EQ(SK_ColorWHITE, get_pixel_value(2.f));
EXPECT_EQ(SK_ColorWHITE, get_pixel_value(1.25f));
EXPECT_EQ(SK_ColorBLACK, get_pixel_value(1.20f));
EXPECT_EQ(SK_ColorBLACK, get_pixel_value(1.15f));
EXPECT_EQ(SK_ColorBLACK, get_pixel_value(1.f));
EXPECT_EQ(SK_ColorBLACK, get_pixel_value(0.8f));
ui::ResourceBundle::SwapSharedInstanceForTesting(original);
}
// Test different properties of the composited cursor with different device
// scale factors and zoom levels.
TEST_F(CursorWindowControllerTest, DSF) {
const auto& cursor_shape_client = aura::client::GetCursorShapeClient();
auto cursor_test = [&](ui::Cursor cursor, float size, float cursor_scale) {
const float dsf =
display::Screen::GetScreen()->GetPrimaryDisplay().device_scale_factor();
SCOPED_TRACE(testing::Message() << cursor.type() << " at scale " << dsf
<< " and size " << size);
cursor_window_controller()->SetCursor(cursor);
const absl::optional<ui::CursorData> cursor_data =
cursor_shape_client.GetCursorData(cursor);
DCHECK(cursor_data);
// Software cursors look blurry if they are resized by the window they are
// rendered in, instead of by `ImageSkia`. Make sure
// `CursorWindowController` creates the cursor in a way that a
// representation for the display's device scale factor can be directly
// obtained.
const gfx::ImageSkiaRep& rep = GetCursorImage().GetRepresentation(dsf);
EXPECT_EQ(rep.scale(), dsf);
const gfx::Size kOriginalCursorSize =
// ImageSkiaRep::GetWidth() uses static_cast<int>.
gfx::ToFlooredSize(gfx::ConvertSizeToDips(
gfx::SkISizeToSize(cursor_data->bitmaps[0].dimensions()),
cursor_scale));
const gfx::Size kCursorSize =
size != 0 ? gfx::Size(size, size) : kOriginalCursorSize;
EXPECT_EQ(GetCursorImage().size(), kCursorSize);
// TODO(hferreiro): the cursor hotspot for non-custom cursors cannot be
// checked, since the software cursor uses
// `ui::GetSupportedResourceScaleFactorForRescale`, and
// `CursorLoader::GetCursorData` uses `ui::GetSupportedResourceScaleFactor`,
// and 2x cursor hotspots are not just twice the 1x hotspots.
if (cursor.type() == CursorType::kCustom) {
const gfx::Point kHotspot = gfx::ToFlooredPoint(
gfx::ConvertPointToDips(cursor_data->hotspot, cursor_scale));
const float rescale =
static_cast<float>(kCursorSize.width()) / kOriginalCursorSize.width();
EXPECT_EQ(GetCursorHotPoint(),
gfx::ScaleToCeiledPoint(kHotspot, rescale));
}
// The cursor window should have the same size as the cursor.
EXPECT_EQ(GetCursorWindow()->bounds().size(), GetCursorImage().size());
};
auto* const cursor_manager = Shell::Get()->cursor_manager();
DCHECK(cursor_manager);
for (const float device_scale_factor : {1.0f, 1.5f, 2.0f, 2.5f}) {
for (const float zoom : {0.8f, 1.0f, 1.25f}) {
UpdateDisplay(
base::StringPrintf("1000x500*%f@%f", device_scale_factor, zoom));
const float dsf = display::Screen::GetScreen()
->GetPrimaryDisplay()
.device_scale_factor();
for (const int size : {0, 32, 64}) {
cursor_manager->SetCursorSize(size == 0 ? ui::CursorSize::kNormal
: ui::CursorSize::kLarge);
Shell::Get()->SetLargeCursorSizeInDip(size);
// Default cursor.
cursor_test(CursorType::kPointer, size,
// Use the nearest resource scale factor.
ui::GetScaleForResourceScaleFactor(
ui::GetSupportedResourceScaleFactor(dsf)));
// Custom cursor.
SkBitmap bitmap;
bitmap.allocN32Pixels(20, 20);
// Custom cursors are always scaled at the device scale factor. See
// `WebCursor::GetNativeCursor`.
cursor_test(ui::Cursor::NewCustom(bitmap, gfx::Point(10, 10), dsf),
size, dsf);
}
}
}
}
// Test that cursor compositing is enabled if at least one of the features that
// use it is enabled.
TEST_F(CursorWindowControllerTest, ShouldEnableCursorCompositing) {
PrefService* prefs =
Shell::Get()->session_controller()->GetActivePrefService();
// Cursor compositing is disabled by default.
SetCursorCompositionEnabled(false);
EXPECT_FALSE(cursor_window_controller()->is_cursor_compositing_enabled());
// Enable large cursor, cursor compositing should be enabled.
prefs->SetBoolean(prefs::kAccessibilityLargeCursorEnabled, true);
EXPECT_TRUE(cursor_window_controller()->is_cursor_compositing_enabled());
// Disable large cursor, cursor compositing should be disabled.
prefs->SetBoolean(prefs::kAccessibilityLargeCursorEnabled, false);
EXPECT_FALSE(cursor_window_controller()->is_cursor_compositing_enabled());
}
TEST_F(CursorWindowControllerTest, CursorColoringSpotCheck) {
SetCursorCompositionEnabled(false);
EXPECT_FALSE(cursor_window_controller()->is_cursor_compositing_enabled());
// Try a few colors to ensure colorizing is working appropriately.
const struct {
SkColor cursor_color; // Set the cursor to this color.
SkColor not_found; // Spot-check: This color shouldn't be in the cursor.
SkColor found; // Spot-check: This color should be in the cursor.
gfx::NativeCursor cursor;
} kTestCases[] = {
// Cursors should still have white.
{SK_ColorMAGENTA, SK_ColorBLUE, SK_ColorWHITE, CursorType::kHand},
{SK_ColorBLUE, SK_ColorMAGENTA, SK_ColorWHITE, CursorType::kCell},
{SK_ColorGREEN, SK_ColorBLUE, SK_ColorWHITE, CursorType::kNoDrop},
// Also cursors should still have transparent.
{SK_ColorRED, SK_ColorGREEN, SK_ColorTRANSPARENT, CursorType::kPointer},
// The no drop cursor has red in it, check it's still there:
// Most of the cursor should be colored, but the red part shouldn't be
// re-colored.
{SK_ColorBLUE, SK_ColorGREEN, SkColorSetRGB(173, 8, 8),
CursorType::kNoDrop},
// Similarly, the copy cursor has green in it.
{SK_ColorBLUE, SK_ColorRED, SkColorSetRGB(19, 137, 16),
CursorType::kCopy},
};
for (const auto& test : kTestCases) {
// Setting a color enables cursor compositing.
cursor_window_controller()->SetCursorColor(test.cursor_color);
Shell::Get()->UpdateCursorCompositingEnabled();
EXPECT_TRUE(cursor_window_controller()->is_cursor_compositing_enabled());
cursor_window_controller()->SetCursor(test.cursor);
const SkBitmap* bitmap = GetCursorImage().bitmap();
// We should find |cursor_color| pixels in the cursor, but no black or
// |not_found| color pixels. All black pixels are recolored.
// We should also find |found| color.
bool has_color = false;
bool has_not_found_color = false;
bool has_found_color = false;
bool has_black = false;
for (int x = 0; x < bitmap->width(); ++x) {
for (int y = 0; y < bitmap->height(); ++y) {
SkColor color = bitmap->getColor(x, y);
if (color == test.cursor_color)
has_color = true;
else if (color == test.not_found)
has_not_found_color = true;
else if (color == test.found)
has_found_color = true;
else if (color == SK_ColorBLACK)
has_black = true;
}
}
EXPECT_TRUE(has_color) << color_utils::SkColorToRgbaString(
test.cursor_color);
EXPECT_TRUE(has_found_color)
<< color_utils::SkColorToRgbaString(test.found);
EXPECT_FALSE(has_not_found_color)
<< color_utils::SkColorToRgbaString(test.not_found);
EXPECT_FALSE(has_black);
}
// Set back to the default color and ensure cursor compositing is disabled.
cursor_window_controller()->SetCursorColor(kDefaultCursorColor);
Shell::Get()->UpdateCursorCompositingEnabled();
EXPECT_FALSE(cursor_window_controller()->is_cursor_compositing_enabled());
}
} // namespace ash
|