1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/frame/non_client_frame_view_ash.h"
#include "ash/public/cpp/test/shell_test_api.h"
#include "ash/public/cpp/window_properties.h"
#include "ash/root_window_controller.h"
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "ash/test/test_window_builder.h"
#include "ash/wm/desks/desks_util.h"
#include "ash/wm/resize_shadow.h"
#include "ash/wm/resize_shadow_controller.h"
#include "ash/wm/test/test_non_client_frame_view_ash.h"
#include "ash/wm/window_state.h"
#include "base/functional/bind.h"
#include "base/memory/raw_ptr.h"
#include "base/ranges/algorithm.h"
#include "chromeos/ui/base/chromeos_ui_constants.h"
#include "chromeos/ui/frame/caption_buttons/frame_caption_button_container_view.h"
#include "chromeos/ui/frame/caption_buttons/frame_size_button.h"
#include "chromeos/ui/frame/multitask_menu/multitask_button.h"
#include "chromeos/ui/frame/multitask_menu/multitask_menu_metrics.h"
#include "chromeos/ui/frame/multitask_menu/multitask_menu_view_test_api.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "ui/aura/window_event_dispatcher.h"
#include "ui/base/cursor/cursor.h"
#include "ui/base/cursor/mojom/cursor_type.mojom-shared.h"
#include "ui/base/hit_test.h"
#include "ui/compositor/layer.h"
#include "ui/compositor/scoped_animation_duration_scale_mode.h"
#include "ui/display/manager/display_manager.h"
#include "ui/events/test/event_generator.h"
#include "ui/views/bubble/bubble_dialog_delegate_view.h"
#include "ui/views/widget/any_widget_observer.h"
#include "ui/views/widget/widget.h"
#include "ui/wm/core/cursor_manager.h"
using chromeos::kResizeInsideBoundsSize;
using chromeos::kResizeOutsideBoundsSize;
namespace ash {
// The test tests that the mouse cursor is changed and that the resize shadows
// are shown when the mouse is hovered over the window edge.
class ResizeShadowAndCursorTest : public AshTestBase {
public:
ResizeShadowAndCursorTest() = default;
ResizeShadowAndCursorTest(const ResizeShadowAndCursorTest&) = delete;
ResizeShadowAndCursorTest& operator=(const ResizeShadowAndCursorTest&) =
delete;
~ResizeShadowAndCursorTest() override = default;
// AshTestBase override:
void SetUp() override {
AshTestBase::SetUp();
views::Widget* widget = views::Widget::CreateWindowWithContext(
new TestWidgetDelegateAsh(), GetContext(), gfx::Rect(0, 0, 200, 100));
widget->Show();
window_ = widget->GetNativeView();
// Add a child window to |window_| in order to properly test that the resize
// handles and the resize shadows are shown when the mouse is
// ash::kResizeInsideBoundsSize inside of |window_|'s edges.
aura::Window* child = TestWindowBuilder()
.SetColorWindowDelegate(SK_ColorWHITE)
.SetBounds(gfx::Rect(0, 10, 200, 90))
.Build()
.release();
window_->AddChild(child);
}
const ResizeShadow* GetShadow() const {
return Shell::Get()->resize_shadow_controller()->GetShadowForWindowForTest(
window_);
}
// Returns the hit test code if there is a resize shadow. Returns HTNOWHERE if
// there is no resize shadow.
int ResizeShadowHitTest() const {
auto* resize_shadow = GetShadow();
return resize_shadow ? resize_shadow->GetLastHitTestForTest() : HTNOWHERE;
}
// Returns true if there is a resize shadow with a given type. Default type is
// unlock for compatibility.
void VerifyResizeShadow(bool visible) const {
if (visible)
EXPECT_TRUE(GetShadow());
if (GetShadow()) {
const ui::Layer* shadow_layer = GetShadow()->GetLayerForTest();
EXPECT_EQ(visible, shadow_layer->GetTargetVisibility());
ASSERT_TRUE(window_->layer());
EXPECT_EQ(window_->layer()->parent(), shadow_layer->parent());
const auto& layers = shadow_layer->parent()->children();
// We don't care about the layer order if it's invisible.
if (visible) {
// Make sure the shadow layer is stacked directly beneath the window
// layer.
EXPECT_EQ(*(base::ranges::find(layers, shadow_layer) + 1),
window_->layer());
}
}
}
// Returns the current cursor type.
ui::mojom::CursorType GetCurrentCursorType() const {
return Shell::Get()->cursor_manager()->GetCursor().type();
}
// Called for each step of a scroll sequence initiated at the bottom right
// corner of |window_|. Tests whether the resize shadow is shown.
void ProcessBottomRightResizeGesture(ui::EventType type,
const gfx::Vector2dF& delta) {
if (type == ui::ET_GESTURE_SCROLL_END) {
// After gesture scroll ends, there should be no resize shadow.
VerifyResizeShadow(false);
} else {
VerifyResizeShadow(true);
EXPECT_EQ(HTBOTTOMRIGHT, ResizeShadowHitTest());
}
}
aura::Window* window() { return window_; }
private:
raw_ptr<aura::Window, DanglingUntriaged | ExperimentalAsh> window_;
};
// Test whether the resize shadows are visible and the cursor type based on the
// mouse's position.
TEST_F(ResizeShadowAndCursorTest, MouseHover) {
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
ASSERT_TRUE(WindowState::Get(window())->IsNormalStateType());
generator.MoveMouseTo(50, 50);
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNull, GetCurrentCursorType());
generator.MoveMouseTo(gfx::Point(50, 0));
VerifyResizeShadow(true);
EXPECT_EQ(HTTOP, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kNorthResize, GetCurrentCursorType());
generator.MoveMouseTo(50, 50);
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNull, GetCurrentCursorType());
generator.MoveMouseTo(200, 100);
VerifyResizeShadow(true);
EXPECT_EQ(HTBOTTOMRIGHT, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kSouthEastResize, GetCurrentCursorType());
generator.MoveMouseTo(50, 100);
VerifyResizeShadow(true);
EXPECT_EQ(HTBOTTOM, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kSouthResize, GetCurrentCursorType());
generator.MoveMouseTo(50, 100 + kResizeOutsideBoundsSize - 1);
VerifyResizeShadow(true);
EXPECT_EQ(HTBOTTOM, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kSouthResize, GetCurrentCursorType());
generator.MoveMouseTo(50, 100 + kResizeOutsideBoundsSize + 10);
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNull, GetCurrentCursorType());
generator.MoveMouseTo(50, 100 - kResizeInsideBoundsSize);
VerifyResizeShadow(true);
EXPECT_EQ(HTBOTTOM, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kSouthResize, GetCurrentCursorType());
generator.MoveMouseTo(50, 100 - kResizeInsideBoundsSize - 10);
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNull, GetCurrentCursorType());
}
// For windows that are not resizable, checks that there is no resize shadow,
// and for the correct cursor type for the cursor position.
TEST_F(ResizeShadowAndCursorTest, MouseHoverOverNonresizable) {
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
ASSERT_TRUE(WindowState::Get(window())->IsNormalStateType());
// Make the window nonresizable.
auto* const widget = views::Widget::GetWidgetForNativeWindow(window());
auto* widget_delegate = widget->widget_delegate();
widget_delegate->SetCanResize(false);
generator.MoveMouseTo(gfx::Point(50, 50));
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNull, GetCurrentCursorType());
generator.MoveMouseTo(gfx::Point(50, 0));
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNorthSouthNoResize, GetCurrentCursorType());
generator.MoveMouseTo(gfx::Point(50, 50));
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNull, GetCurrentCursorType());
generator.MoveMouseTo(gfx::Point(199, 99));
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNorthWestSouthEastNoResize,
GetCurrentCursorType());
generator.MoveMouseTo(gfx::Point(50, 99));
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNorthSouthNoResize, GetCurrentCursorType());
generator.MoveMouseTo(gfx::Point(50, 100 + kResizeOutsideBoundsSize - 1));
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNull, GetCurrentCursorType());
generator.MoveMouseTo(gfx::Point(50, 100 + kResizeOutsideBoundsSize + 10));
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNull, GetCurrentCursorType());
generator.MoveMouseTo(gfx::Point(50, 100 - kResizeInsideBoundsSize));
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNorthSouthNoResize, GetCurrentCursorType());
generator.MoveMouseTo(gfx::Point(50, 100 - kResizeInsideBoundsSize - 10));
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNull, GetCurrentCursorType());
}
TEST_F(ResizeShadowAndCursorTest, DefaultCursorOnBubbleWidgetCorners) {
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
// Create a dummy view for the bubble, adding it to the window.
views::View* child_view = new views::View();
child_view->SetBounds(200, 200, 10, 10);
views::Widget::GetWidgetForNativeWindow(window())
->GetRootView()
->AddChildView(child_view);
// Create the bubble widget.
views::Widget* bubble(views::BubbleDialogDelegateView::CreateBubble(
new views::BubbleDialogDelegateView(child_view,
views::BubbleBorder::NONE)));
bubble->Show();
// Get the screen rectangle for the bubble frame
const gfx::Rect bounds = bubble->GetNativeView()->GetBoundsInScreen();
EXPECT_THAT(
bounds,
::testing::AllOf(::testing::Property(&gfx::Rect::x, ::testing::Gt(0)),
::testing::Property(&gfx::Rect::y, ::testing::Gt(0))));
// The cursor at the frame corners should be the default cursor.
generator.MoveMouseTo(bounds.origin());
EXPECT_THAT(GetCurrentCursorType(),
::testing::Eq(ui::mojom::CursorType::kNull));
generator.MoveMouseTo(bounds.top_right());
EXPECT_THAT(GetCurrentCursorType(),
::testing::Eq(ui::mojom::CursorType::kNull));
generator.MoveMouseTo(bounds.bottom_left());
EXPECT_THAT(GetCurrentCursorType(),
::testing::Eq(ui::mojom::CursorType::kNull));
generator.MoveMouseTo(bounds.bottom_right());
EXPECT_THAT(GetCurrentCursorType(),
::testing::Eq(ui::mojom::CursorType::kNull));
}
TEST_F(ResizeShadowAndCursorTest, NoResizeShadowOnNonToplevelWindow) {
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
ASSERT_TRUE(WindowState::Get(window())->IsNormalStateType());
auto* embedded = views::Widget::CreateWindowWithContext(
new TestWidgetDelegateAsh(), GetContext(), gfx::Rect(0, 0, 100, 100));
embedded->Show();
window()->AddChild(embedded->GetNativeWindow());
embedded->GetNativeWindow()->SetName("BBB");
window()->SetName("AAAA");
embedded->SetBounds(gfx::Rect(10, 10, 100, 100));
generator.MoveMouseTo(50, 11);
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNull, GetCurrentCursorType());
EXPECT_FALSE(
Shell::Get()->resize_shadow_controller()->GetShadowForWindowForTest(
embedded->GetNativeWindow()));
generator.MoveMouseTo(gfx::Point(50, 0));
VerifyResizeShadow(true);
EXPECT_EQ(HTTOP, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kNorthResize, GetCurrentCursorType());
EXPECT_FALSE(
Shell::Get()->resize_shadow_controller()->GetShadowForWindowForTest(
embedded->GetNativeWindow()));
}
// Test that the resize shadows stay visible and that the cursor stays the same
// as long as a user is resizing a window.
TEST_F(ResizeShadowAndCursorTest, MouseDrag) {
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
ASSERT_TRUE(WindowState::Get(window())->IsNormalStateType());
gfx::Size initial_size(window()->bounds().size());
generator.MoveMouseTo(200, 50);
generator.PressLeftButton();
VerifyResizeShadow(true);
EXPECT_EQ(HTRIGHT, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kEastResize, GetCurrentCursorType());
generator.MoveMouseTo(210, 50);
VerifyResizeShadow(true);
EXPECT_EQ(HTRIGHT, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kEastResize, GetCurrentCursorType());
generator.ReleaseLeftButton();
VerifyResizeShadow(true);
EXPECT_EQ(HTRIGHT, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kEastResize, GetCurrentCursorType());
gfx::Size new_size(window()->bounds().size());
EXPECT_NE(new_size.ToString(), initial_size.ToString());
}
// Test that the resize shadows stay visible while resizing a window via touch.
TEST_F(ResizeShadowAndCursorTest, Touch) {
ASSERT_TRUE(WindowState::Get(window())->IsNormalStateType());
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
int start_x = 200 + kResizeOutsideBoundsSize - 1;
int start_y = 100 + kResizeOutsideBoundsSize - 1;
generator.GestureScrollSequenceWithCallback(
gfx::Point(start_x, start_y), gfx::Point(start_x + 50, start_y + 50),
base::Milliseconds(200), 3,
base::BindRepeating(
&ResizeShadowAndCursorTest::ProcessBottomRightResizeGesture,
base::Unretained(this)));
}
// Test that the resize shadows are not visible and that the default cursor is
// used when the window is maximized.
TEST_F(ResizeShadowAndCursorTest, MaximizeRestore) {
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
ASSERT_TRUE(WindowState::Get(window())->IsNormalStateType());
generator.MoveMouseTo(200, 50);
EXPECT_EQ(HTRIGHT, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kEastResize, GetCurrentCursorType());
generator.MoveMouseTo(200 - kResizeInsideBoundsSize, 50);
EXPECT_EQ(HTRIGHT, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kEastResize, GetCurrentCursorType());
WindowState::Get(window())->Maximize();
gfx::Rect bounds(window()->GetBoundsInRootWindow());
gfx::Point right_center(bounds.right() - 1,
(bounds.y() + bounds.bottom()) / 2);
generator.MoveMouseTo(right_center);
VerifyResizeShadow(false);
EXPECT_EQ(ui::mojom::CursorType::kNull, GetCurrentCursorType());
WindowState::Get(window())->Restore();
generator.MoveMouseTo(200, 50);
EXPECT_EQ(HTRIGHT, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kEastResize, GetCurrentCursorType());
generator.MoveMouseTo(200 - kResizeInsideBoundsSize, 50);
EXPECT_EQ(HTRIGHT, ResizeShadowHitTest());
EXPECT_EQ(ui::mojom::CursorType::kEastResize, GetCurrentCursorType());
}
// Verifies that the shadow hides when a window is minimized. Regression test
// for crbug.com/752583
TEST_F(ResizeShadowAndCursorTest, Minimize) {
ui::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
ASSERT_TRUE(WindowState::Get(window())->IsNormalStateType());
generator.MoveMouseTo(200, 50);
VerifyResizeShadow(true);
WindowState::Get(window())->Minimize();
VerifyResizeShadow(false);
WindowState::Get(window())->Restore();
VerifyResizeShadow(false);
}
// Verifies that the lock style shadow gets updated when the window's bounds
// changed.
TEST_F(ResizeShadowAndCursorTest, LockShadowBounds) {
window()->SetProperty(kResizeShadowTypeKey, ResizeShadowType::kLock);
Shell::Get()->resize_shadow_controller()->ShowShadow(window());
// Set window's bounds
const gfx::Rect kOldBounds(20, 30, 400, 300);
window()->SetBounds(kOldBounds);
auto* resize_shadow = GetShadow();
ASSERT_TRUE(resize_shadow);
VerifyResizeShadow(true);
auto* layer = resize_shadow->GetLayerForTest();
constexpr int kVisualThickness = 6;
EXPECT_EQ(gfx::Rect(kOldBounds.width() + kVisualThickness * 2,
kOldBounds.height() + kVisualThickness * 2)
.ToString(),
gfx::Rect(layer->GetTargetBounds().size()).ToString());
// Change the window's bounds, the shadow's should be updated too.
gfx::Rect kNewBounds(50, 60, 500, 400);
window()->SetBounds(kNewBounds);
EXPECT_EQ(gfx::Rect(kNewBounds.width() + kVisualThickness * 2,
kNewBounds.height() + kVisualThickness * 2)
.ToString(),
gfx::Rect(layer->GetTargetBounds().size()).ToString());
}
// Tests that shadow gets updated according to the window's visibility.
TEST_F(ResizeShadowAndCursorTest, ShowHideLockShadow) {
ASSERT_FALSE(GetShadow());
window()->SetProperty(kResizeShadowTypeKey, ResizeShadowType::kLock);
// Test shown window.
window()->Show();
Shell::Get()->resize_shadow_controller()->ShowShadow(window());
ASSERT_TRUE(GetShadow());
VerifyResizeShadow(true);
Shell::Get()->resize_shadow_controller()->HideShadow(window());
VerifyResizeShadow(false);
Shell::Get()->resize_shadow_controller()->TryShowAllShadows();
VerifyResizeShadow(true);
Shell::Get()->resize_shadow_controller()->HideAllShadows();
VerifyResizeShadow(false);
// Test hidden window.
window()->Hide();
Shell::Get()->resize_shadow_controller()->ShowShadow(window());
VerifyResizeShadow(false);
Shell::Get()->resize_shadow_controller()->HideShadow(window());
VerifyResizeShadow(false);
Shell::Get()->resize_shadow_controller()->TryShowAllShadows();
VerifyResizeShadow(false);
Shell::Get()->resize_shadow_controller()->HideAllShadows();
VerifyResizeShadow(false);
}
// Tests that shadow gets updated when the window's visibility changed.
TEST_F(ResizeShadowAndCursorTest, WindowVisibilityChange) {
ASSERT_FALSE(GetShadow());
window()->SetProperty(kResizeShadowTypeKey, ResizeShadowType::kLock);
Shell::Get()->resize_shadow_controller()->ShowShadow(window());
ASSERT_TRUE(GetShadow());
window()->Show();
VerifyResizeShadow(true);
window()->Hide();
VerifyResizeShadow(false);
window()->Show();
VerifyResizeShadow(true);
}
// Tests that shadow type gets updated according to the window's property.
TEST_F(ResizeShadowAndCursorTest, ResizeShadowTypeChange) {
ASSERT_FALSE(GetShadow());
window()->SetProperty(kResizeShadowTypeKey, ResizeShadowType::kLock);
Shell::Get()->resize_shadow_controller()->ShowShadow(window());
ASSERT_TRUE(GetShadow());
ASSERT_EQ(GetShadow()->GetResizeShadowTypeForTest(), ResizeShadowType::kLock);
Shell::Get()->resize_shadow_controller()->HideShadow(window());
window()->SetProperty(kResizeShadowTypeKey, ResizeShadowType::kUnlock);
Shell::Get()->resize_shadow_controller()->ShowShadow(window());
ASSERT_EQ(GetShadow()->GetResizeShadowTypeForTest(),
ResizeShadowType::kUnlock);
Shell::Get()->resize_shadow_controller()->HideShadow(window());
}
// Tests that shadow gets updated when the window's state changed.
TEST_F(ResizeShadowAndCursorTest, WindowStateChange) {
ASSERT_FALSE(GetShadow());
auto* const window_state = WindowState::Get(window());
ASSERT_TRUE(window_state->IsNormalStateType());
window()->SetProperty(kResizeShadowTypeKey, ResizeShadowType::kLock);
Shell::Get()->resize_shadow_controller()->ShowShadow(window());
VerifyResizeShadow(true);
window_state->Maximize();
VerifyResizeShadow(false);
window_state->Restore();
VerifyResizeShadow(true);
window_state->Minimize();
VerifyResizeShadow(false);
window_state->Unminimize();
VerifyResizeShadow(true);
}
// Tests that shadow gets hidden and restored according to the oveview mode
// state.
TEST_F(ResizeShadowAndCursorTest, OverviewModeChange) {
ASSERT_FALSE(GetShadow());
window()->SetProperty(kResizeShadowTypeKey, ResizeShadowType::kLock);
// Requests ShowShadow() before entering overview.
Shell::Get()->resize_shadow_controller()->ShowShadow(window());
ASSERT_TRUE(GetShadow());
window()->Show();
VerifyResizeShadow(true);
EnterOverview();
VerifyResizeShadow(false);
ExitOverview();
VerifyResizeShadow(true);
Shell::Get()->resize_shadow_controller()->HideAllShadows();
// Requests ShowShadow() after entering overview.
EnterOverview();
Shell::Get()->resize_shadow_controller()->ShowShadow(window());
VerifyResizeShadow(false);
ExitOverview();
VerifyResizeShadow(true);
}
// Tests that the code does not break when we unparent a window with a shadow
// and then try to rearrange the hierarchy. (b/257306979)
TEST_F(ResizeShadowAndCursorTest, ShadowCanExistInUnparentedWindow) {
ASSERT_FALSE(GetShadow());
window()->SetProperty(kResizeShadowTypeKey, ResizeShadowType::kLock);
auto* controller = Shell::Get()->resize_shadow_controller();
controller->ShowShadow(window());
ASSERT_TRUE(GetShadow());
window()->Show();
auto* parent = window()->parent();
parent->RemoveChild(window());
// Previously this would break the code because a hierarchy change on an
// unparented window with a shadow would try to use the window layer's null
// parent layer to reparent the shadow.
ASSERT_TRUE(parent);
parent->AddChild(window());
}
// Tests that the resize shadow will observe a new color provider source when
// the window is reparented to other root windows.
TEST_F(ResizeShadowAndCursorTest, NoCrashOnRootWindowChange) {
// Create a resize shadow on primary root window.
Shell::Get()->resize_shadow_controller()->ShowShadow(window());
// The color provider source of primary root window should be observed by
// resize shadow.
EXPECT_TRUE(Shell::GetPrimaryRootWindowController()
->color_provider_source()
->observers_for_testing()
.HasObserver(GetShadow()));
// Add an secondary display.
display_manager()->AddRemoveDisplay();
aura::Window* secondary_root = nullptr;
for (auto* root : Shell::GetAllRootWindows()) {
if (root != Shell::GetPrimaryRootWindow()) {
secondary_root = root;
break;
}
}
EXPECT_TRUE(!!secondary_root);
// Move the window to secondary display and the resize shadow should observe
// the color provider source of secondary root window.
Shell::GetContainer(secondary_root, desks_util::GetActiveDeskContainerId())
->AddChild(window());
EXPECT_TRUE(RootWindowController::ForWindow(secondary_root)
->color_provider_source()
->observers_for_testing()
.HasObserver(GetShadow()));
// Remove secondary root window. The window will be reparent to primary
// display, the resize shadow will observe the color provider source of
// primary root window, and there should be no crash.
display_manager()->AddRemoveDisplay();
EXPECT_TRUE(Shell::GetPrimaryRootWindowController()
->color_provider_source()
->observers_for_testing()
.HasObserver(GetShadow()));
}
// Tests if the resize shadow is beneath window when float the window by
// multi-task menu.
TEST_F(ResizeShadowAndCursorTest, KeepShadowBeneathFloatWindow) {
// Create a resizable test window whose size should be larger than the normal
// floating window size.
auto test_window =
CreateAppWindow(/*bounds_in_screen=*/gfx::Rect(10, 10, 800, 600));
// Create a resize shadow for the native window.
auto* resize_shadow_controller = Shell::Get()->resize_shadow_controller();
resize_shadow_controller->ShowShadow(test_window.get());
auto* resize_shadow =
resize_shadow_controller->GetShadowForWindowForTest(test_window.get());
EXPECT_TRUE(resize_shadow);
// Open multi-task menu by hovering on the resize button.
// TODO(b/300668220): Extract this block into a helper.
views::NamedWidgetShownWaiter waiter(views::test::AnyWidgetTestPasskey{},
"MultitaskMenuBubbleWidget");
chromeos::FrameCaptionButtonContainerView::TestApi test_api(
NonClientFrameViewAsh::Get(test_window.get())
->GetHeaderView()
->caption_button_container());
auto* size_button =
static_cast<chromeos::FrameSizeButton*>(test_api.size_button());
size_button->ShowMultitaskMenu(
chromeos::MultitaskMenuEntryType::kFrameSizeButtonHover);
waiter.WaitIfNeededAndGet();
// Click on the floating window option.
ui::ScopedAnimationDurationScaleMode zero_duration_mode(
ui::ScopedAnimationDurationScaleMode::ZERO_DURATION);
auto* menu_view = static_cast<chromeos::MultitaskMenu*>(
size_button->multitask_menu_widget_for_testing()
->widget_delegate()
->AsDialogDelegate())
->multitask_menu_view();
LeftClickOn(chromeos::MultitaskMenuViewTestApi(menu_view).GetFloatButton());
EXPECT_TRUE(WindowState::Get(test_window.get())->IsFloated());
// Check if the resize shadow layer is beneath the window layer. We check
// their positions in their parent layer's children container. The highest
// index is the topmost.
auto* shadow_layer = resize_shadow->GetLayerForTest();
auto parent_children = shadow_layer->parent()->children();
auto* window_layer = test_window->layer();
auto shadow_iter =
std::find(parent_children.begin(), parent_children.end(), shadow_layer);
auto window_iter =
std::find(parent_children.begin(), parent_children.end(), window_layer);
EXPECT_LT(std::distance(parent_children.begin(), shadow_iter),
std::distance(parent_children.begin(), window_iter));
}
} // namespace ash
|