1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/wm/window_util.h"
#include "ash/public/cpp/presentation_time_recorder.h"
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "ash/wm/test/fake_window_state.h"
#include "ash/wm/window_positioning_utils.h"
#include "ash/wm/window_state.h"
#include "ash/wm/window_state_delegate.h"
#include "ash/wm/wm_event.h"
#include "base/containers/contains.h"
#include "ui/aura/test/test_windows.h"
#include "ui/aura/window.h"
#include "ui/compositor/layer.h"
#include "ui/display/screen.h"
#include "ui/events/base_event_utils.h"
#include "ui/wm/core/window_util.h"
namespace ash {
namespace window_util {
namespace {
std::string GetAdjustedBounds(const gfx::Rect& visible,
gfx::Rect to_be_adjusted) {
AdjustBoundsToEnsureMinimumWindowVisibility(visible, &to_be_adjusted);
return to_be_adjusted.ToString();
}
} // namespace
using WindowUtilTest = AshTestBase;
TEST_F(WindowUtilTest, AdjustBoundsToEnsureMinimumVisibility) {
const gfx::Rect visible_bounds(0, 0, 100, 100);
EXPECT_EQ("0,0 90x90",
GetAdjustedBounds(visible_bounds, gfx::Rect(0, 0, 90, 90)));
EXPECT_EQ("0,0 100x100",
GetAdjustedBounds(visible_bounds, gfx::Rect(0, 0, 150, 150)));
EXPECT_EQ("-50,0 100x100",
GetAdjustedBounds(visible_bounds, gfx::Rect(-50, -50, 150, 150)));
EXPECT_EQ("-75,10 100x100",
GetAdjustedBounds(visible_bounds, gfx::Rect(-100, 10, 150, 150)));
EXPECT_EQ("75,75 100x100",
GetAdjustedBounds(visible_bounds, gfx::Rect(100, 100, 150, 150)));
// For windows that have smaller dimensions than kMinimumOnScreenArea,
// we should adjust bounds accordingly, leaving no white space.
EXPECT_EQ("50,80 20x20",
GetAdjustedBounds(visible_bounds, gfx::Rect(50, 80, 20, 20)));
EXPECT_EQ("80,50 20x20",
GetAdjustedBounds(visible_bounds, gfx::Rect(80, 50, 20, 20)));
EXPECT_EQ("0,50 20x20",
GetAdjustedBounds(visible_bounds, gfx::Rect(0, 50, 20, 20)));
EXPECT_EQ("50,0 20x20",
GetAdjustedBounds(visible_bounds, gfx::Rect(50, 0, 20, 20)));
EXPECT_EQ("50,80 20x20",
GetAdjustedBounds(visible_bounds, gfx::Rect(50, 100, 20, 20)));
EXPECT_EQ("80,50 20x20",
GetAdjustedBounds(visible_bounds, gfx::Rect(100, 50, 20, 20)));
EXPECT_EQ("0,50 20x20",
GetAdjustedBounds(visible_bounds, gfx::Rect(-10, 50, 20, 20)));
EXPECT_EQ("50,0 20x20",
GetAdjustedBounds(visible_bounds, gfx::Rect(50, -10, 20, 20)));
const gfx::Rect visible_bounds_right(200, 50, 100, 100);
EXPECT_EQ("210,60 90x90", GetAdjustedBounds(visible_bounds_right,
gfx::Rect(210, 60, 90, 90)));
EXPECT_EQ("210,60 100x100", GetAdjustedBounds(visible_bounds_right,
gfx::Rect(210, 60, 150, 150)));
EXPECT_EQ("125,50 100x100",
GetAdjustedBounds(visible_bounds_right, gfx::Rect(0, 0, 150, 150)));
EXPECT_EQ("275,50 100x100", GetAdjustedBounds(visible_bounds_right,
gfx::Rect(300, 20, 150, 150)));
EXPECT_EQ(
"125,125 100x100",
GetAdjustedBounds(visible_bounds_right, gfx::Rect(-100, 150, 150, 150)));
const gfx::Rect visible_bounds_left(-200, -50, 100, 100);
EXPECT_EQ("-190,-40 90x90", GetAdjustedBounds(visible_bounds_left,
gfx::Rect(-190, -40, 90, 90)));
EXPECT_EQ(
"-190,-40 100x100",
GetAdjustedBounds(visible_bounds_left, gfx::Rect(-190, -40, 150, 150)));
EXPECT_EQ(
"-250,-40 100x100",
GetAdjustedBounds(visible_bounds_left, gfx::Rect(-250, -40, 150, 150)));
EXPECT_EQ(
"-275,-50 100x100",
GetAdjustedBounds(visible_bounds_left, gfx::Rect(-400, -60, 150, 150)));
EXPECT_EQ("-125,0 100x100",
GetAdjustedBounds(visible_bounds_left, gfx::Rect(0, 0, 150, 150)));
}
TEST_F(WindowUtilTest, MoveWindowToDisplay) {
UpdateDisplay("500x400, 600x400");
std::unique_ptr<aura::Window> window(
CreateTestWindowInShellWithBounds(gfx::Rect(12, 20, 100, 100)));
display::Screen* screen = display::Screen::GetScreen();
const int64_t original_display_id =
screen->GetDisplayNearestWindow(window.get()).id();
EXPECT_EQ(screen->GetPrimaryDisplay().id(), original_display_id);
const int original_container_id = window->parent()->GetId();
const aura::Window* original_root = window->GetRootWindow();
ASSERT_EQ(2, screen->GetNumDisplays());
const int64_t secondary_display_id = screen->GetAllDisplays()[1].id();
EXPECT_NE(original_display_id, secondary_display_id);
EXPECT_TRUE(MoveWindowToDisplay(window.get(), secondary_display_id));
EXPECT_EQ(secondary_display_id,
screen->GetDisplayNearestWindow(window.get()).id());
EXPECT_EQ(original_container_id, window->parent()->GetId());
EXPECT_NE(original_root, window->GetRootWindow());
EXPECT_TRUE(MoveWindowToDisplay(window.get(), original_display_id));
EXPECT_EQ(original_display_id,
screen->GetDisplayNearestWindow(window.get()).id());
EXPECT_EQ(original_container_id, window->parent()->GetId());
EXPECT_EQ(original_root, window->GetRootWindow());
}
// Tests that locking and unlocking the screen does not alter the display of a
// window moved by MoveWindowToDisplay.
TEST_F(WindowUtilTest, MoveWindowToDisplayAndLockScreen) {
UpdateDisplay("500x400, 600x400");
auto window = CreateTestWindow(gfx::Rect(12, 20, 100, 100));
display::Screen* screen = display::Screen::GetScreen();
ASSERT_EQ(2, screen->GetNumDisplays());
const int64_t primary_display_id = screen->GetAllDisplays()[0].id();
const int64_t secondary_display_id = screen->GetAllDisplays()[1].id();
ASSERT_EQ(primary_display_id,
screen->GetDisplayNearestWindow(window.get()).id());
EXPECT_TRUE(MoveWindowToDisplay(window.get(), secondary_display_id));
EXPECT_EQ(secondary_display_id,
screen->GetDisplayNearestWindow(window.get()).id());
// Tests that after locking and unlocking the screen the window remains on the
// secondary display.
GetSessionControllerClient()->LockScreen();
GetSessionControllerClient()->UnlockScreen();
EXPECT_EQ(secondary_display_id,
screen->GetDisplayNearestWindow(window.get()).id());
// Move the window to the primary display. Tests that after locking and
// unlocking the screen the window remains on the secondary display.
EXPECT_TRUE(MoveWindowToDisplay(window.get(), primary_display_id));
GetSessionControllerClient()->LockScreen();
GetSessionControllerClient()->UnlockScreen();
EXPECT_EQ(primary_display_id,
screen->GetDisplayNearestWindow(window.get()).id());
}
TEST_F(WindowUtilTest, EnsureTransientRoots) {
// Create two windows which have no transient children or parents. Test that
// neither of them get removed when running EnsureTransientRoots.
auto window1 = CreateTestWindow();
auto window2 = CreateTestWindow();
std::vector<aura::Window*> window_list = {window1.get(), window2.get()};
EnsureTransientRoots(&window_list);
ASSERT_EQ(2u, window_list.size());
// Create two windows whose transient roots are |window1|. One is a direct
// transient child and one is a transient descendant. Test that both get
// removed when calling EnsureTransientRoots.
auto descendant1 = CreateTestWindow();
auto descendant2 = CreateTestWindow();
::wm::AddTransientChild(descendant1.get(), descendant2.get());
::wm::AddTransientChild(window1.get(), descendant1.get());
window_list.push_back(descendant1.get());
window_list.push_back(descendant2.get());
EnsureTransientRoots(&window_list);
ASSERT_EQ(2u, window_list.size());
ASSERT_TRUE(base::Contains(window_list, window1.get()));
ASSERT_TRUE(base::Contains(window_list, window2.get()));
// Create a window which has a transient parent that is not in |window_list|.
// Test that the window is replaced with its transient root when calling
// EnsureTransientRoots.
auto window3 = CreateTestWindow();
auto descendant3 = CreateTestWindow();
::wm::AddTransientChild(window3.get(), descendant3.get());
window_list.push_back(descendant3.get());
EnsureTransientRoots(&window_list);
EXPECT_EQ(3u, window_list.size());
EXPECT_TRUE(base::Contains(window_list, window3.get()));
EXPECT_FALSE(base::Contains(window_list, descendant3.get()));
// Create two windows which have the same transient parent that is not in
// |window_list|. Test that one of the windows is replaced with its transient
// root and the other is removed from |window_list| when calling
// EnsureTransientRoots.
auto window4 = CreateTestWindow();
auto descendant4 = CreateTestWindow();
auto descendant5 = CreateTestWindow();
::wm::AddTransientChild(window4.get(), descendant4.get());
::wm::AddTransientChild(window4.get(), descendant5.get());
window_list.push_back(descendant4.get());
window_list.push_back(descendant5.get());
EnsureTransientRoots(&window_list);
EXPECT_EQ(4u, window_list.size());
EXPECT_TRUE(base::Contains(window_list, window4.get()));
EXPECT_FALSE(base::Contains(window_list, descendant4.get()));
EXPECT_FALSE(base::Contains(window_list, descendant5.get()));
}
TEST_F(WindowUtilTest,
MinimizeAndHideWithoutAnimationMinimizesArcWindowsBeforeHiding) {
auto window = CreateTestWindow();
auto* state = new FakeWindowState(chromeos::WindowStateType::kNormal);
WindowState::Get(window.get())
->SetStateObject(std::unique_ptr<WindowState::State>(state));
std::vector<aura::Window*> windows = {window.get()};
MinimizeAndHideWithoutAnimation(windows);
EXPECT_FALSE(window->IsVisible());
EXPECT_TRUE(state->was_visible_on_minimize());
}
TEST_F(WindowUtilTest, InteriorTargeter) {
auto window = CreateTestWindow();
window->SetBounds(gfx::Rect(0, 0, 100, 100));
WindowState::Get(window.get())->Maximize();
InstallResizeHandleWindowTargeterForWindow(window.get());
auto* child = aura::test::CreateTestWindowWithDelegateAndType(
aura::test::TestWindowDelegate::CreateSelfDestroyingDelegate(),
aura::client::WINDOW_TYPE_UNKNOWN, 1, gfx::Rect(window->bounds().size()),
window.get(),
/*show_on_creation=*/true);
ui::EventTarget* root_target = window->GetRootWindow();
auto* targeter = root_target->GetEventTargeter();
{
ui::MouseEvent mouse(ui::ET_MOUSE_MOVED, gfx::Point(0, 0), gfx::Point(0, 0),
ui::EventTimeForNow(), ui::EF_NONE, ui::EF_NONE);
EXPECT_EQ(child, targeter->FindTargetForEvent(root_target, &mouse));
}
// InteriorEventTargeter is now active and should pass an event at the edge to
// its parent.
WindowState::Get(window.get())->Restore();
{
ui::MouseEvent mouse(ui::ET_MOUSE_MOVED, gfx::Point(0, 0), gfx::Point(0, 0),
ui::EventTimeForNow(), ui::EF_NONE, ui::EF_NONE);
EXPECT_EQ(window.get(), targeter->FindTargetForEvent(root_target, &mouse));
}
}
TEST_F(WindowUtilTest, PinWindow) {
auto window_state_delegate = std::make_unique<FakeWindowStateDelegate>();
auto* window_state_delegate_ptr = window_state_delegate.get();
EXPECT_EQ(window_state_delegate_ptr->toggle_locked_fullscreen_count(), 0);
auto window = CreateTestWindow();
WindowState* window_state = WindowState::Get(window.get());
window_state->SetDelegate(std::move(window_state_delegate));
window_util::PinWindow(window.get(), /* trusted */ false);
EXPECT_TRUE(WindowState::Get(window.get())->IsPinned());
EXPECT_FALSE(WindowState::Get(window.get())->IsTrustedPinned());
EXPECT_EQ(window_state_delegate_ptr->toggle_locked_fullscreen_count(), 1);
WindowState::Get(window.get())->Restore();
EXPECT_FALSE(WindowState::Get(window.get())->IsPinned());
EXPECT_FALSE(WindowState::Get(window.get())->IsTrustedPinned());
EXPECT_EQ(window_state_delegate_ptr->toggle_locked_fullscreen_count(), 2);
window_util::PinWindow(window.get(), /* trusted */ true);
EXPECT_TRUE(WindowState::Get(window.get())->IsPinned());
EXPECT_TRUE(WindowState::Get(window.get())->IsTrustedPinned());
EXPECT_EQ(window_state_delegate_ptr->toggle_locked_fullscreen_count(), 3);
}
TEST_F(WindowUtilTest, PinWindow_TabletMode) {
// Use tablet mode controller.
Shell::Get()->tablet_mode_controller()->SetEnabledForTest(true);
auto window_state_delegate = std::make_unique<FakeWindowStateDelegate>();
auto* window_state_delegate_ptr = window_state_delegate.get();
EXPECT_EQ(window_state_delegate_ptr->toggle_locked_fullscreen_count(), 0);
auto window = CreateTestWindow();
WindowState* window_state = WindowState::Get(window.get());
window_state->SetDelegate(std::move(window_state_delegate));
window_util::PinWindow(window.get(), /* trusted */ false);
EXPECT_TRUE(WindowState::Get(window.get())->IsPinned());
EXPECT_FALSE(WindowState::Get(window.get())->IsTrustedPinned());
EXPECT_EQ(window_state_delegate_ptr->toggle_locked_fullscreen_count(), 1);
WindowState::Get(window.get())->Restore();
EXPECT_FALSE(WindowState::Get(window.get())->IsPinned());
EXPECT_FALSE(WindowState::Get(window.get())->IsTrustedPinned());
EXPECT_EQ(window_state_delegate_ptr->toggle_locked_fullscreen_count(), 2);
window_util::PinWindow(window.get(), /* trusted */ true);
EXPECT_TRUE(WindowState::Get(window.get())->IsPinned());
EXPECT_TRUE(WindowState::Get(window.get())->IsTrustedPinned());
EXPECT_EQ(window_state_delegate_ptr->toggle_locked_fullscreen_count(), 3);
}
TEST_F(WindowUtilTest, ShouldRoundThumbnailWindow) {
const float rounding = 30.f;
auto backdrop_view = std::make_unique<views::View>();
backdrop_view->SetPaintToLayer();
backdrop_view->layer()->SetRoundedCornerRadius(
{rounding, rounding, rounding, rounding});
// Note that `SetPosition` does nothing since this view is floating. For this
// test this is fine, but if we need to have a position, we need to attach
// this view to a views tree.
backdrop_view->SetBounds(0, 0, 300, 200);
ASSERT_EQ(gfx::Rect(300, 200), backdrop_view->GetBoundsInScreen());
// If the thumbnail covers the backdrop completely, it should be rounded as
// well.
EXPECT_TRUE(ShouldRoundThumbnailWindow(backdrop_view.get(),
gfx::RectF(300.f, 200.f)));
// If the thumbnail is completely within the backdrop's bounds including
// rounding, it doesn't need to be rounded.
EXPECT_FALSE(ShouldRoundThumbnailWindow(backdrop_view.get(),
gfx::RectF(0.f, 30.f, 300.f, 140.f)));
EXPECT_FALSE(ShouldRoundThumbnailWindow(backdrop_view.get(),
gfx::RectF(30.f, 0.f, 240.f, 200.f)));
// The thumbnail partially covers the part of the backdrop that will not get
// drawn. We should round the thumbnail as well in this case, otherwise the
// corner will be drawn over the rounding.
EXPECT_TRUE(ShouldRoundThumbnailWindow(backdrop_view.get(),
gfx::RectF(0.f, 15.f, 300.f, 170.f)));
EXPECT_TRUE(ShouldRoundThumbnailWindow(backdrop_view.get(),
gfx::RectF(15.f, 0.f, 270.f, 200.f)));
}
} // namespace window_util
} // namespace ash
|
