1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/scoped_observation.h"
#include "base/containers/contains.h"
#include "base/ranges/algorithm.h"
#include "base/scoped_observation_traits.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
namespace {
class TestSourceObserver {
public:
virtual ~TestSourceObserver() = default;
};
class TestSource {
public:
void AddObserver(TestSourceObserver* observer);
void RemoveObserver(TestSourceObserver* observer);
bool HasObserver(TestSourceObserver* observer) const;
size_t num_observers() const { return observers_.size(); }
private:
std::vector<TestSourceObserver*> observers_;
};
void TestSource::AddObserver(TestSourceObserver* observer) {
observers_.push_back(observer);
}
void TestSource::RemoveObserver(TestSourceObserver* observer) {
auto it = base::ranges::find(observers_, observer);
EXPECT_TRUE(it != observers_.end());
observers_.erase(it);
}
bool TestSource::HasObserver(TestSourceObserver* observer) const {
return base::Contains(observers_, observer);
}
using TestScopedObservation = ScopedObservation<TestSource, TestSourceObserver>;
} // namespace
TEST(ScopedObservationTest, RemovesObservationOnDestruction) {
TestSource s1;
{
TestSourceObserver o1;
TestScopedObservation obs(&o1);
const TestScopedObservation& cobs = obs;
EXPECT_EQ(0u, s1.num_observers());
EXPECT_FALSE(s1.HasObserver(&o1));
EXPECT_EQ(obs.GetSource(), nullptr);
EXPECT_EQ(cobs.GetSource(), nullptr);
obs.Observe(&s1);
EXPECT_EQ(1u, s1.num_observers());
EXPECT_TRUE(s1.HasObserver(&o1));
TestSource* const got_source = obs.GetSource();
EXPECT_EQ(got_source, &s1);
EXPECT_EQ(cobs.GetSource(), &s1);
}
// Test that the observation is removed when it goes out of scope.
EXPECT_EQ(0u, s1.num_observers());
}
TEST(ScopedObservationTest, Reset) {
TestSource s1;
TestSourceObserver o1;
TestScopedObservation obs(&o1);
const TestScopedObservation& cobs = obs;
EXPECT_EQ(0u, s1.num_observers());
EXPECT_EQ(obs.GetSource(), nullptr);
EXPECT_EQ(cobs.GetSource(), nullptr);
obs.Reset();
EXPECT_EQ(obs.GetSource(), nullptr);
EXPECT_EQ(cobs.GetSource(), nullptr);
obs.Observe(&s1);
EXPECT_EQ(1u, s1.num_observers());
EXPECT_TRUE(s1.HasObserver(&o1));
EXPECT_EQ(obs.GetSource(), &s1);
EXPECT_EQ(cobs.GetSource(), &s1);
obs.Reset();
EXPECT_EQ(0u, s1.num_observers());
EXPECT_EQ(obs.GetSource(), nullptr);
EXPECT_EQ(cobs.GetSource(), nullptr);
// Safe to call with no observation.
obs.Reset();
EXPECT_EQ(0u, s1.num_observers());
EXPECT_EQ(obs.GetSource(), nullptr);
EXPECT_EQ(cobs.GetSource(), nullptr);
}
TEST(ScopedObservationTest, IsObserving) {
TestSource s1;
TestSourceObserver o1;
TestScopedObservation obs(&o1);
const TestScopedObservation& cobs = obs;
EXPECT_FALSE(cobs.IsObserving());
EXPECT_EQ(obs.GetSource(), nullptr);
EXPECT_EQ(cobs.GetSource(), nullptr);
obs.Observe(&s1);
EXPECT_TRUE(cobs.IsObserving());
EXPECT_EQ(obs.GetSource(), &s1);
EXPECT_EQ(cobs.GetSource(), &s1);
obs.Reset();
EXPECT_FALSE(cobs.IsObserving());
EXPECT_EQ(obs.GetSource(), nullptr);
EXPECT_EQ(cobs.GetSource(), nullptr);
}
TEST(ScopedObservationTest, IsObservingSource) {
TestSource s1;
TestSource s2;
TestSourceObserver o1;
TestScopedObservation obs(&o1);
const TestScopedObservation& cobs = obs;
EXPECT_FALSE(cobs.IsObservingSource(&s1));
EXPECT_FALSE(cobs.IsObservingSource(&s2));
EXPECT_EQ(obs.GetSource(), nullptr);
EXPECT_EQ(cobs.GetSource(), nullptr);
obs.Observe(&s1);
EXPECT_TRUE(cobs.IsObservingSource(&s1));
EXPECT_FALSE(cobs.IsObservingSource(&s2));
EXPECT_EQ(obs.GetSource(), &s1);
EXPECT_EQ(cobs.GetSource(), &s1);
obs.Reset();
EXPECT_FALSE(cobs.IsObservingSource(&s1));
EXPECT_FALSE(cobs.IsObservingSource(&s2));
EXPECT_EQ(obs.GetSource(), nullptr);
EXPECT_EQ(cobs.GetSource(), nullptr);
}
namespace {
// A test source with oddly named Add/Remove functions.
class TestSourceWithNonDefaultNames {
public:
void AddFoo(TestSourceObserver* observer) { impl_.AddObserver(observer); }
void RemoveFoo(TestSourceObserver* observer) {
impl_.RemoveObserver(observer);
}
const TestSource& impl() const { return impl_; }
private:
TestSource impl_;
};
using TestScopedObservationWithNonDefaultNames =
ScopedObservation<TestSourceWithNonDefaultNames, TestSourceObserver>;
} // namespace
template <>
struct ScopedObservationTraits<TestSourceWithNonDefaultNames,
TestSourceObserver> {
static void AddObserver(TestSourceWithNonDefaultNames* source,
TestSourceObserver* observer) {
source->AddFoo(observer);
}
static void RemoveObserver(TestSourceWithNonDefaultNames* source,
TestSourceObserver* observer) {
source->RemoveFoo(observer);
}
};
TEST(ScopedObservationTest, NonDefaultNames) {
TestSourceWithNonDefaultNames s1;
TestSourceObserver o1;
EXPECT_EQ(0u, s1.impl().num_observers());
{
TestScopedObservationWithNonDefaultNames obs(&o1);
obs.Observe(&s1);
EXPECT_EQ(1u, s1.impl().num_observers());
EXPECT_TRUE(s1.impl().HasObserver(&o1));
}
EXPECT_EQ(0u, s1.impl().num_observers());
}
namespace {
// A forward-declared test source.
class TestSourceFwd;
class ObservationHolder : public TestSourceObserver {
public:
// Declared but not defined since TestSourceFwd is not yet defined.
explicit ObservationHolder(TestSourceFwd* source);
private:
// ScopedObservation<> is instantiated with a forward-declared parameter.
ScopedObservation<TestSourceFwd, TestSourceObserver> obs_{this};
};
// TestSourceFwd gets an actual definition!
class TestSourceFwd : public TestSource {};
// Calling ScopedObservation::Observe() requires an actual definition rather
// than just a forward declaration; make sure it compiles now that there is a
// definition.
ObservationHolder::ObservationHolder(TestSourceFwd* source) {
obs_.Observe(source);
}
} // namespace
TEST(ScopedObservationTest, ForwardDeclaredSource) {
TestSourceFwd s;
ASSERT_EQ(s.num_observers(), 0U);
{
ObservationHolder o(&s);
ASSERT_EQ(s.num_observers(), 1U);
}
ASSERT_EQ(s.num_observers(), 0U);
}
namespace {
class TestSourceWithNonDefaultNamesFwd;
class ObservationWithNonDefaultNamesHolder : public TestSourceObserver {
public:
// Declared but not defined since TestSourceWithNonDefaultNamesFwd is not yet
// defined.
explicit ObservationWithNonDefaultNamesHolder(
TestSourceWithNonDefaultNamesFwd* source);
private:
// ScopedObservation<> is instantiated with a forward-declared parameter.
ScopedObservation<TestSourceWithNonDefaultNamesFwd, TestSourceObserver> obs_{
this};
};
// TestSourceWithNonDefaultNamesFwd gets an actual definition!
class TestSourceWithNonDefaultNamesFwd : public TestSourceWithNonDefaultNames {
};
} // namespace
// Now we define the corresponding traits. ScopedObservationTraits
// specializations must be defined in base::, since that is where the primary
// template definition lives.
template <>
struct ScopedObservationTraits<TestSourceWithNonDefaultNamesFwd,
TestSourceObserver> {
static void AddObserver(TestSourceWithNonDefaultNamesFwd* source,
TestSourceObserver* observer) {
source->AddFoo(observer);
}
static void RemoveObserver(TestSourceWithNonDefaultNamesFwd* source,
TestSourceObserver* observer) {
source->RemoveFoo(observer);
}
};
namespace {
// Calling ScopedObservation::Observe() requires an actual definition rather
// than just a forward declaration; make sure it compiles now that there is
// a definition.
ObservationWithNonDefaultNamesHolder::ObservationWithNonDefaultNamesHolder(
TestSourceWithNonDefaultNamesFwd* source) {
obs_.Observe(source);
}
} // namespace
TEST(ScopedObservationTest, ForwardDeclaredSourceWithNonDefaultNames) {
TestSourceWithNonDefaultNamesFwd s;
ASSERT_EQ(s.impl().num_observers(), 0U);
{
ObservationWithNonDefaultNamesHolder o(&s);
ASSERT_EQ(s.impl().num_observers(), 1U);
}
ASSERT_EQ(s.impl().num_observers(), 0U);
}
} // namespace base
|