1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296
|
// Copyright 2018 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/shortcut_viewer/keyboard_shortcut_viewer_metadata.h"
#include <set>
#include <string>
#include <tuple>
#include <vector>
#include "ash/constants/ash_features.h"
#include "ash/public/cpp/accelerators.h"
#include "ash/public/cpp/keyboard_shortcut_item.h"
#include "ash/shortcut_viewer/strings/grit/shortcut_viewer_strings.h"
#include "base/hash/md5.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "build/branding_buildflags.h"
#include "chrome/browser/ui/views/accelerator_table.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/base/ui_base_features.h"
namespace {
// The total number of Ash accelerators.
constexpr int kAshAcceleratorsTotalNum = 147;
// The hash of Ash accelerators.
constexpr char kAshAcceleratorsHash[] = "6b946ad3ceb8263615f2c47dc7e240a8";
#if BUILDFLAG(GOOGLE_CHROME_BRANDING)
// Internal builds add an extra accelerator for the Feedback app.
// The total number of Chrome accelerators (available on Chrome OS).
constexpr int kChromeAcceleratorsTotalNum = 103;
// The hash of Chrome accelerators (available on Chrome OS).
constexpr char kChromeAcceleratorsHash[] = "e9e2edcc3a1a7332c960f7b3a00ee8cc";
#else
// The total number of Chrome accelerators (available on Chrome OS).
constexpr int kChromeAcceleratorsTotalNum = 102;
// The hash of Chrome accelerators (available on Chrome OS).
constexpr char kChromeAcceleratorsHash[] = "253127d58865152a7e549bf2caa24027";
#endif // BUILDFLAG(GOOGLE_CHROME_BRANDING)
const char* BooleanToString(bool value) {
return value ? "true" : "false";
}
std::string ModifiersToString(int modifiers) {
return base::StringPrintf("shift=%s control=%s alt=%s search=%s",
BooleanToString(modifiers & ui::EF_SHIFT_DOWN),
BooleanToString(modifiers & ui::EF_CONTROL_DOWN),
BooleanToString(modifiers & ui::EF_ALT_DOWN),
BooleanToString(modifiers & ui::EF_COMMAND_DOWN));
}
std::string AshAcceleratorDataToString(
const ash::AcceleratorData& accelerator) {
return base::StringPrintf("trigger_on_press=%s keycode=%d action=%d ",
BooleanToString(accelerator.trigger_on_press),
accelerator.keycode, accelerator.action) +
ModifiersToString(accelerator.modifiers);
}
std::string ChromeAcceleratorMappingToString(
const AcceleratorMapping& accelerator) {
return base::StringPrintf("keycode=%d command_id=%d ", accelerator.keycode,
accelerator.command_id) +
ModifiersToString(accelerator.modifiers);
}
struct AshAcceleratorDataCmp {
bool operator()(const ash::AcceleratorData& lhs,
const ash::AcceleratorData& rhs) {
return std::tie(lhs.trigger_on_press, lhs.keycode, lhs.modifiers) <
std::tie(rhs.trigger_on_press, rhs.keycode, rhs.modifiers);
}
};
struct ChromeAcceleratorMappingCmp {
bool operator()(const AcceleratorMapping& lhs,
const AcceleratorMapping& rhs) {
return std::tie(lhs.keycode, lhs.modifiers) <
std::tie(rhs.keycode, rhs.modifiers);
}
};
std::string HashAshAcceleratorData(
const std::vector<ash::AcceleratorData>& accelerators) {
base::MD5Context context;
base::MD5Init(&context);
for (const auto& accelerator : accelerators)
base::MD5Update(&context, AshAcceleratorDataToString(accelerator));
base::MD5Digest digest;
base::MD5Final(&digest, &context);
return MD5DigestToBase16(digest);
}
std::string HashChromeAcceleratorMapping(
const std::vector<AcceleratorMapping>& accelerators) {
base::MD5Context context;
base::MD5Init(&context);
for (const auto& accelerator : accelerators)
base::MD5Update(&context, ChromeAcceleratorMappingToString(accelerator));
base::MD5Digest digest;
base::MD5Final(&digest, &context);
return MD5DigestToBase16(digest);
}
std::string AcceleratorIdToString(const ash::AcceleratorId& accelerator_id) {
return base::StringPrintf("keycode=%d ", accelerator_id.keycode) +
ModifiersToString(accelerator_id.modifiers);
}
std::string AcceleratorIdsToString(
const std::vector<ash::AcceleratorId>& accelerator_ids) {
std::vector<std::string> msgs;
for (const auto& id : accelerator_ids)
msgs.emplace_back(AcceleratorIdToString(id));
return base::JoinString(msgs, ", ");
}
class KeyboardShortcutViewerMetadataTest : public testing::Test {
public:
KeyboardShortcutViewerMetadataTest() = default;
KeyboardShortcutViewerMetadataTest(
const KeyboardShortcutViewerMetadataTest&) = delete;
KeyboardShortcutViewerMetadataTest& operator=(
const KeyboardShortcutViewerMetadataTest&) = delete;
~KeyboardShortcutViewerMetadataTest() override = default;
void SetUp() override {
for (size_t i = 0; i < ash::kAcceleratorDataLength; ++i) {
const ash::AcceleratorData& accel_data = ash::kAcceleratorData[i];
ash_accelerator_ids_.insert({accel_data.keycode, accel_data.modifiers});
}
if (::features::IsImprovedKeyboardShortcutsEnabled()) {
for (size_t i = 0;
i <
ash::kEnabledWithImprovedDesksKeyboardShortcutsAcceleratorDataLength;
++i) {
const ash::AcceleratorData& accel_data =
ash::kEnabledWithImprovedDesksKeyboardShortcutsAcceleratorData[i];
ash_accelerator_ids_.insert({accel_data.keycode, accel_data.modifiers});
}
}
for (const auto& accel_mapping : GetAcceleratorList()) {
chrome_accelerator_ids_.insert(
{accel_mapping.keycode, accel_mapping.modifiers});
}
testing::Test::SetUp();
}
protected:
// Ash accelerator ids.
std::set<ash::AcceleratorId> ash_accelerator_ids_;
// Chrome accelerator ids.
std::set<ash::AcceleratorId> chrome_accelerator_ids_;
};
} // namespace
// Test that AcceleratorId has at least one corresponding accelerators in ash or
// chrome. Some |accelerator_id| might exist in both accelerator_tables, such as
// new window and new tab.
TEST_F(KeyboardShortcutViewerMetadataTest, CheckAcceleratorIdHasAccelerator) {
for (const auto& shortcut_item :
keyboard_shortcut_viewer::GetKeyboardShortcutItemList()) {
if (shortcut_item.description_message_id ==
IDS_KSV_DESCRIPTION_DESKS_NEW_DESK ||
shortcut_item.description_message_id ==
IDS_KSV_DESCRIPTION_DESKS_REMOVE_CURRENT_DESK ||
shortcut_item.description_message_id ==
IDS_KSV_DESCRIPTION_CARET_BROWSING_TOGGLE) {
// Ignore these for now until https://crbug.com/976487 is fixed.
// These two accelerators have to be listed differently in the keyboard
// shortcut viewer than how they are actually defined in the accelerator
// table due to the SEARCH + "1","2"..."0","=","-" remapping to F1...F12
// respectively.
continue;
}
for (const auto& accelerator_id : shortcut_item.accelerator_ids) {
int number_of_accelerator = ash_accelerator_ids_.count(accelerator_id) +
chrome_accelerator_ids_.count(accelerator_id);
EXPECT_GE(number_of_accelerator, 1)
<< "accelerator_id has no corresponding accelerator: "
<< AcceleratorIdToString(accelerator_id);
}
}
}
// Test that AcceleratorIds have no duplicates.
TEST_F(KeyboardShortcutViewerMetadataTest, CheckAcceleratorIdsNoDuplicates) {
std::set<ash::AcceleratorId> accelerator_ids;
for (const auto& shortcut_item :
keyboard_shortcut_viewer::GetKeyboardShortcutItemList()) {
for (const auto& accelerator_id : shortcut_item.accelerator_ids) {
EXPECT_TRUE(accelerator_ids.insert(accelerator_id).second)
<< "Has duplicated accelerator_id: "
<< AcceleratorIdToString(accelerator_id);
}
}
}
// Test that metadata with empty |shortcut_key_codes| and grouped AcceleratorIds
// should have the same modifiers.
TEST_F(KeyboardShortcutViewerMetadataTest,
CheckModifiersEqualForGroupedAcceleratorIdsWithEmptyShortcutKeyCodes) {
for (const auto& shortcut_item :
keyboard_shortcut_viewer::GetKeyboardShortcutItemList()) {
// This test only checks metadata with empty |shortcut_key_codes| and
// grouped |accelerator_ids|.
if (!shortcut_item.shortcut_key_codes.empty() ||
shortcut_item.accelerator_ids.size() <= 1)
continue;
const int modifiers = shortcut_item.accelerator_ids[0].modifiers;
for (const auto& accelerator_id : shortcut_item.accelerator_ids) {
EXPECT_EQ(modifiers, accelerator_id.modifiers)
<< "Grouped accelerator_ids with empty shortcut_key_codes should "
"have same modifiers: "
<< AcceleratorIdsToString(shortcut_item.accelerator_ids);
}
}
}
// TODO (http://b/291803593): Remove the test.
// Test that modifying Ash/Chrome accelerator should update
// KeyboardShortcutViewerMetadata. (https://crbug.com/826037).
// 1. If you are adding/deleting/modifying shortcuts, please also
// add/delete/modify the corresponding strings and items to the list of
// KeyboardShortcutItem.
// 2. Please update the number and hash value of Ash/Chrome accelerators (these
// available on Chrome OS) on the top of this file. The new number and hash
// value will be provided in the test output.
// 3. If there is no corrensponding item in the Keyboard Shortcut Viewer, please
// consider adding the shortcut to it or only update 2.
TEST_F(KeyboardShortcutViewerMetadataTest,
DISABLED_ModifyAcceleratorShouldUpdateMetadata) {
std::vector<ash::AcceleratorData> ash_accelerators;
std::vector<AcceleratorMapping> chrome_accelerators;
for (size_t i = 0; i < ash::kAcceleratorDataLength; ++i)
ash_accelerators.emplace_back(ash::kAcceleratorData[i]);
for (size_t i = 0; i < ash::kDisableWithNewMappingAcceleratorDataLength; ++i)
ash_accelerators.emplace_back(
ash::kDisableWithNewMappingAcceleratorData[i]);
for (const auto& accel_mapping : GetAcceleratorList())
chrome_accelerators.emplace_back(accel_mapping);
if (::features::IsImprovedKeyboardShortcutsEnabled()) {
for (size_t i = 0;
i <
ash::kEnabledWithImprovedDesksKeyboardShortcutsAcceleratorDataLength;
++i) {
ash_accelerators.emplace_back(
ash::kEnabledWithImprovedDesksKeyboardShortcutsAcceleratorData[i]);
}
}
const char kCommonMessage[] =
"If you are modifying Chrome OS available shortcuts, please update "
"Keyboard Shortcut Viewer shortcuts and the following value(s) on the "
"top of this file:\n";
const int ash_accelerators_number = ash_accelerators.size();
EXPECT_EQ(ash_accelerators_number, kAshAcceleratorsTotalNum)
<< kCommonMessage
<< "kAshAcceleratorsTotalNum=" << ash_accelerators_number << "\n";
std::stable_sort(ash_accelerators.begin(), ash_accelerators.end(),
AshAcceleratorDataCmp());
const std::string ash_accelerators_hash =
HashAshAcceleratorData(ash_accelerators);
EXPECT_EQ(ash_accelerators_hash, kAshAcceleratorsHash)
<< kCommonMessage << "kAshAcceleratorsHash=\"" << ash_accelerators_hash
<< "\"\n";
const int chrome_accelerators_number = chrome_accelerators.size();
EXPECT_EQ(chrome_accelerators_number, kChromeAcceleratorsTotalNum)
<< kCommonMessage
<< "kChromeAcceleratorsTotalNum=" << chrome_accelerators_number << "\n";
std::stable_sort(chrome_accelerators.begin(), chrome_accelerators.end(),
ChromeAcceleratorMappingCmp());
const std::string chrome_accelerators_hash =
HashChromeAcceleratorMapping(chrome_accelerators);
EXPECT_EQ(chrome_accelerators_hash, kChromeAcceleratorsHash)
<< kCommonMessage << "kChromeAcceleratorsHash=\""
<< chrome_accelerators_hash << "\"\n";
}
|