File: commander_frontend_views_browsertest.cc

package info (click to toggle)
chromium 120.0.6099.224-1~deb11u1
  • links: PTS, VCS
  • area: main
  • in suites: bullseye
  • size: 6,112,112 kB
  • sloc: cpp: 32,907,025; ansic: 8,148,123; javascript: 3,679,536; python: 2,031,248; asm: 959,718; java: 804,675; xml: 617,256; sh: 111,417; objc: 100,835; perl: 88,443; cs: 53,032; makefile: 29,579; fortran: 24,137; php: 21,162; tcl: 21,147; sql: 20,809; ruby: 17,735; pascal: 12,864; yacc: 8,045; lisp: 3,388; lex: 1,323; ada: 727; awk: 329; jsp: 267; csh: 117; exp: 43; sed: 37
file content (281 lines) | stat: -rw-r--r-- 9,803 bytes parent folder | download
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "chrome/browser/ui/views/commander_frontend_views.h"

#include <tuple>

#include "base/memory/raw_ptr.h"
#include "chrome/browser/ui/commander/commander_backend.h"
#include "chrome/browser/ui/commander/commander_view_model.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "content/public/test/browser_test.h"
#include "ui/views/test/widget_test.h"
#include "ui/views/widget/any_widget_observer.h"
#include "ui/views/widget/widget.h"

class CommanderFrontendViewsTest : public InProcessBrowserTest {
 public:
  // TODO(lgrey): This is copied over from CommanderControllerUnittest, with
  // modifications. If we need it one more time, extract to a common file.
  class TestBackend : public commander::CommanderBackend {
   public:
    void OnTextChanged(const std::u16string& text, Browser* browser) override {
      text_changed_invocations_.push_back(text);
    }
    void OnCommandSelected(size_t command_index, int result_set_id) override {
      command_selected_invocations_.push_back(command_index);
    }
    void OnCompositeCommandCancelled() override {
      composite_command_cancelled_invocation_count_++;
    }
    void SetUpdateCallback(commander::CommanderBackend::ViewModelUpdateCallback
                               callback) override {
      callback_ = std::move(callback);
    }
    void Reset() override { reset_invocation_count_++; }

    void CallCallback() {
      commander::CommanderViewModel vm;
      CallCallback(vm);
    }

    void CallCallback(commander::CommanderViewModel vm) { callback_.Run(vm); }

    const std::vector<std::u16string> text_changed_invocations() {
      return text_changed_invocations_;
    }
    const std::vector<size_t> command_selected_invocations() {
      return command_selected_invocations_;
    }

    int composite_command_cancelled_invocation_count() {
      return composite_command_cancelled_invocation_count_;
    }
    int reset_invocation_count() { return reset_invocation_count_; }

   private:
    commander::CommanderBackend::ViewModelUpdateCallback callback_;
    std::vector<std::u16string> text_changed_invocations_;
    std::vector<size_t> command_selected_invocations_;
    int composite_command_cancelled_invocation_count_ = 0;
    int reset_invocation_count_ = 0;
  };

 protected:
  views::Widget* WaitForCommanderWidgetAttachedTo(Browser* browser) {
    if (IsWidgetAttachedToBrowser(browser)) {
      expected_browser_ = nullptr;
      return active_widget_;
    }
    expected_browser_ = browser;

    run_loop_ = std::make_unique<base::RunLoop>();
    run_loop_->Run();
    EXPECT_TRUE(IsWidgetAttachedToBrowser(browser));
    return active_widget_;
  }
  void WaitForCommanderWidgetToClose() {
    if (!active_widget_)
      return;
    run_loop_ = std::make_unique<base::RunLoop>();
    run_loop_->Run();
    EXPECT_TRUE(!active_widget_);
  }
  std::unique_ptr<TestBackend> backend_;

 private:
  void SetUpOnMainThread() override {
    backend_ = std::make_unique<TestBackend>();
    observer_ = std::make_unique<views::AnyWidgetObserver>(
        views::test::AnyWidgetTestPasskey());
    // Unretained is safe since we own observer.
    observer_->set_shown_callback(base::BindRepeating(
        &CommanderFrontendViewsTest::OnWidgetShown, base::Unretained(this)));
    observer_->set_closing_callback(base::BindRepeating(
        &CommanderFrontendViewsTest::OnWidgetClosed, base::Unretained(this)));
  }

  void TearDownOnMainThread() override {
    observer_.reset();
    run_loop_.reset();
    backend_.reset();
  }

  void OnWidgetShown(views::Widget* widget) {
    if (widget->GetName() == "Quick Commands") {
      active_widget_ = widget;
      if (IsWidgetAttachedToBrowser(expected_browser_)) {
        expected_browser_ = nullptr;
        if (run_loop_)
          run_loop_->Quit();
      }
    }
  }

  void OnWidgetClosed(views::Widget* widget) {
    if (widget == active_widget_) {
      active_widget_ = nullptr;
      if (run_loop_)
        run_loop_->Quit();
    }
  }

  bool IsWidgetAttachedToBrowser(const Browser* browser) {
    if (!active_widget_ || !browser)
      return false;
    views::Widget* browser_widget =
        BrowserView::GetBrowserViewForBrowser(browser)->GetWidget();
    return active_widget_->parent() == browser_widget;
  }

  std::unique_ptr<views::AnyWidgetObserver> observer_;
  raw_ptr<views::Widget> active_widget_ = nullptr;
  raw_ptr<Browser> expected_browser_ = nullptr;
  std::unique_ptr<base::RunLoop> run_loop_;
};

IN_PROC_BROWSER_TEST_F(CommanderFrontendViewsTest, ShowShowsWidget) {
  auto frontend = std::make_unique<CommanderFrontendViews>(backend_.get());

  frontend->Show(browser());
  EXPECT_TRUE(WaitForCommanderWidgetAttachedTo(browser()));
  frontend->Hide();
}

IN_PROC_BROWSER_TEST_F(CommanderFrontendViewsTest, HideHidesWidget) {
  auto frontend = std::make_unique<CommanderFrontendViews>(backend_.get());

  frontend->Show(browser());
  EXPECT_TRUE(WaitForCommanderWidgetAttachedTo(browser()));
  EXPECT_EQ(backend_->reset_invocation_count(), 0);

  frontend->Hide();
  WaitForCommanderWidgetToClose();
  EXPECT_EQ(backend_->reset_invocation_count(), 1);
}

IN_PROC_BROWSER_TEST_F(CommanderFrontendViewsTest, DismissHidesWidget) {
  auto frontend = std::make_unique<CommanderFrontendViews>(backend_.get());

  frontend->Show(browser());
  EXPECT_TRUE(WaitForCommanderWidgetAttachedTo(browser()));
  EXPECT_EQ(backend_->reset_invocation_count(), 0);

  frontend->OnDismiss();
  WaitForCommanderWidgetToClose();
  EXPECT_EQ(backend_->reset_invocation_count(), 1);
}

IN_PROC_BROWSER_TEST_F(CommanderFrontendViewsTest, ViewModelCloseHidesWidget) {
  auto frontend = std::make_unique<CommanderFrontendViews>(backend_.get());

  frontend->Show(browser());
  EXPECT_TRUE(WaitForCommanderWidgetAttachedTo(browser()));
  EXPECT_EQ(backend_->reset_invocation_count(), 0);

  commander::CommanderViewModel vm;
  vm.action = commander::CommanderViewModel::Action::kClose;
  backend_->CallCallback(vm);
  WaitForCommanderWidgetToClose();
  EXPECT_EQ(backend_->reset_invocation_count(), 1);
}

IN_PROC_BROWSER_TEST_F(CommanderFrontendViewsTest, ToggleShowsWidget) {
  auto frontend = std::make_unique<CommanderFrontendViews>(backend_.get());

  frontend->ToggleForBrowser(browser());
  EXPECT_TRUE(WaitForCommanderWidgetAttachedTo(browser()));

  frontend->Hide();
}

IN_PROC_BROWSER_TEST_F(CommanderFrontendViewsTest, ToggleHidesWidget) {
  auto frontend = std::make_unique<CommanderFrontendViews>(backend_.get());

  frontend->Show(browser());
  EXPECT_TRUE(WaitForCommanderWidgetAttachedTo(browser()));

  frontend->ToggleForBrowser(browser());
  WaitForCommanderWidgetToClose();
  EXPECT_EQ(backend_->reset_invocation_count(), 1);
}

// Ensure that calling toggle twice in a row does the right thing.
IN_PROC_BROWSER_TEST_F(CommanderFrontendViewsTest, ToggleTogglesWidget) {
  auto frontend = std::make_unique<CommanderFrontendViews>(backend_.get());

  frontend->ToggleForBrowser(browser());
  EXPECT_TRUE(WaitForCommanderWidgetAttachedTo(browser()));

  frontend->ToggleForBrowser(browser());
  WaitForCommanderWidgetToClose();
  EXPECT_EQ(backend_->reset_invocation_count(), 1);
}

IN_PROC_BROWSER_TEST_F(CommanderFrontendViewsTest, OnHeightChangedSizesWidget) {
  auto frontend = std::make_unique<CommanderFrontendViews>(backend_.get());

  frontend->Show(browser());
  views::Widget* commander_widget = WaitForCommanderWidgetAttachedTo(browser());

  int old_height = commander_widget->GetRootView()->height();
  int new_height = 200;
  // Ensure changing height isn't a no-op.
  EXPECT_NE(old_height, new_height);

  frontend->OnHeightChanged(200);
  EXPECT_EQ(new_height, commander_widget->GetRootView()->height());
  frontend->Hide();
}

IN_PROC_BROWSER_TEST_F(CommanderFrontendViewsTest, PassesOnOptionSelected) {
  auto frontend = std::make_unique<CommanderFrontendViews>(backend_.get());

  frontend->Show(browser());
  std::ignore = WaitForCommanderWidgetAttachedTo(browser());

  frontend->OnOptionSelected(8, 13);
  ASSERT_EQ(backend_->command_selected_invocations().size(), 1u);
  EXPECT_EQ(backend_->command_selected_invocations().back(), 8u);
  frontend->Hide();
}

IN_PROC_BROWSER_TEST_F(CommanderFrontendViewsTest, PassesOnTextChanged) {
  auto frontend = std::make_unique<CommanderFrontendViews>(backend_.get());
  frontend->Show(browser());
  std::ignore = WaitForCommanderWidgetAttachedTo(browser());

  const std::u16string input = u"orange";
  frontend->OnTextChanged(input);
  ASSERT_EQ(backend_->text_changed_invocations().size(), 1u);
  EXPECT_EQ(backend_->text_changed_invocations().back(), input);
  frontend->Hide();
}

IN_PROC_BROWSER_TEST_F(CommanderFrontendViewsTest,
                       PassesOnCompositeCommandCancelled) {
  auto frontend = std::make_unique<CommanderFrontendViews>(backend_.get());
  frontend->Show(browser());
  std::ignore = WaitForCommanderWidgetAttachedTo(browser());

  EXPECT_EQ(backend_->composite_command_cancelled_invocation_count(), 0);
  frontend->OnCompositeCommandCancelled();
  EXPECT_EQ(backend_->composite_command_cancelled_invocation_count(), 1);
  frontend->Hide();
}
IN_PROC_BROWSER_TEST_F(CommanderFrontendViewsTest, HidesOnFocusLoss) {
  auto frontend = std::make_unique<CommanderFrontendViews>(backend_.get());

  frontend->Show(browser());
  views::Widget* widget = WaitForCommanderWidgetAttachedTo(browser());
  EXPECT_TRUE(widget);
  EXPECT_EQ(backend_->reset_invocation_count(), 0);

  // Activate the main browser window.
  widget->parent()->Activate();
  WaitForCommanderWidgetToClose();
  EXPECT_EQ(backend_->reset_invocation_count(), 1);
}