1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
|
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "build/build_config.h"
#include "chrome/browser/ui/exclusive_access/exclusive_access_test.h"
#include "chrome/browser/ui/views/exclusive_access_bubble_views.h"
#include "chrome/browser/ui/views/frame/browser_view.h"
#include "content/public/test/browser_test.h"
#include "ui/views/widget/widget.h"
#include "ui/views/widget/widget_observer.h"
class ExclusiveAccessBubbleViewsTest : public ExclusiveAccessTest,
public views::WidgetObserver {
public:
ExclusiveAccessBubbleViewsTest() {}
ExclusiveAccessBubbleViewsTest(const ExclusiveAccessBubbleViewsTest&) =
delete;
ExclusiveAccessBubbleViewsTest& operator=(
const ExclusiveAccessBubbleViewsTest&) = delete;
ExclusiveAccessBubbleViews* bubble() {
BrowserView* browser_view =
BrowserView::GetBrowserViewForBrowser(browser());
return browser_view->exclusive_access_bubble();
}
// WidgetObserver:
void OnWidgetDestroying(views::Widget* widget) override {
was_observing_in_destroying_ = widget->HasObserver(bubble());
was_destroying_ = true;
widget->RemoveObserver(this);
}
protected:
bool was_destroying_ = false;
bool was_observing_in_destroying_ = false;
};
// Simulate obscure codepaths resulting in the bubble Widget being closed before
// the ExclusiveAccessBubbleViews destructor asks for it. If a close bypasses
// the destructor, animations could still be running that attempt to manipulate
// a destroyed Widget and crash.
IN_PROC_BROWSER_TEST_F(ExclusiveAccessBubbleViewsTest, NativeClose) {
EXPECT_FALSE(bubble());
EnterActiveTabFullscreen();
EXPECT_TRUE(bubble());
bubble()->GetView()->GetWidget()->AddObserver(this);
// Simulate the bubble being closed out from under its controller, which seems
// to happen in some odd corner cases, like system log-off while the bubble is
// showing.
bubble()->GetView()->GetWidget()->CloseNow();
EXPECT_FALSE(bubble());
// Verify that teardown is really happening via OnWidgetDestroyed() rather
// than the usual path via the ExclusiveAccessBubbleViews destructor. Since
// the destructor always first removes ExclusiveAccessBubbleViews as an
// observer before starting the close, checking in OnWidgetDestroyed that it's
// still observing achieves this.
EXPECT_TRUE(was_observing_in_destroying_);
EXPECT_TRUE(was_destroying_);
}
// Tests that creating an exclusive access bubble for a download does not crash,
// despite the type being EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE. See
// crbug.com/1472150.
IN_PROC_BROWSER_TEST_F(ExclusiveAccessBubbleViewsTest, CreateForDownload) {
ExclusiveAccessBubbleViews bubble(
BrowserView::GetBrowserViewForBrowser(browser()), GURL(),
EXCLUSIVE_ACCESS_BUBBLE_TYPE_NONE, /*notify_download=*/true,
base::DoNothing());
EXPECT_TRUE(IsBubbleDownloadNotification(&bubble));
}
|
