1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/views/extensions/extensions_menu_main_page_view.h"
#include "base/feature_list.h"
#include "base/ranges/algorithm.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/user_action_tester.h"
#include "base/test/to_vector.h"
#include "chrome/app/vector_icons/vector_icons.h"
#include "chrome/browser/extensions/active_tab_permission_granter.h"
#include "chrome/browser/extensions/chrome_test_extension_loader.h"
#include "chrome/browser/extensions/extension_action_runner.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/site_permissions_helper.h"
#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/ui/color/chrome_color_id.h"
#include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
#include "chrome/browser/ui/views/controls/hover_button.h"
#include "chrome/browser/ui/views/extensions/extensions_menu_button.h"
#include "chrome/browser/ui/views/extensions/extensions_menu_coordinator.h"
#include "chrome/browser/ui/views/extensions/extensions_menu_item_view.h"
#include "chrome/browser/ui/views/extensions/extensions_menu_site_permissions_page_view.h"
#include "chrome/browser/ui/views/extensions/extensions_menu_view_controller.h"
#include "chrome/browser/ui/views/extensions/extensions_request_access_button.h"
#include "chrome/browser/ui/views/extensions/extensions_toolbar_button.h"
#include "chrome/browser/ui/views/extensions/extensions_toolbar_unittest.h"
#include "chrome/grit/generated_resources.h"
#include "content/public/browser/web_contents.h"
#include "extensions/browser/permissions_manager.h"
#include "extensions/browser/test_extension_registry_observer.h"
#include "extensions/common/extension_features.h"
#include "extensions/test/permissions_manager_waiter.h"
#include "extensions/test/test_extension_dir.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "ui/gfx/image/image_unittest_util.h"
#include "ui/views/controls/styled_label.h"
#include "ui/views/vector_icons.h"
#include "ui/views/view_utils.h"
namespace {
using PermissionsManager = extensions::PermissionsManager;
using SitePermissionsHelper = extensions::SitePermissionsHelper;
// Returns the extension names from the given `menu_items`.
std::vector<std::string> GetNamesFromMenuItems(
std::vector<ExtensionMenuItemView*> menu_items) {
return base::test::ToVector(menu_items, [](ExtensionMenuItemView* item) {
return base::UTF16ToUTF8(
item->primary_action_button_for_testing()->label_text_for_testing());
});
}
} // namespace
class ExtensionsMenuMainPageViewUnitTest : public ExtensionsToolbarUnitTest {
public:
ExtensionsMenuMainPageViewUnitTest();
~ExtensionsMenuMainPageViewUnitTest() override = default;
ExtensionsMenuMainPageViewUnitTest(
const ExtensionsMenuMainPageViewUnitTest&) = delete;
ExtensionsMenuMainPageViewUnitTest& operator=(
const ExtensionsMenuMainPageViewUnitTest&) = delete;
// Opens menu on "main page" by default.
void ShowMenu();
// Asserts there is exactly one menu item and then returns it.
ExtensionMenuItemView* GetOnlyMenuItem();
// Returns the extension names in the request access section. If it's empty,
// the section is not visible.
std::vector<extensions::ExtensionId> GetExtensionsInRequestAccessSection();
// Returns the extension ids in the request access button in the toolbar.
std::vector<extensions::ExtensionId> GetExtensionsInRequestAccessButton();
// Since this is a unittest, the extensions menu widget sometimes needs a
// nudge to re-layout the views.
void LayoutMenuIfNecessary();
void ClickSitePermissionsButton(ExtensionMenuItemView* menu_item);
// Clicks the site access toggle in the extension's menu main page. If
// `active_tab_only` is false, it waits for user site access updated (toggling
// an extension with just active tab grants tab permission, but doesn't change
// the extension site access).
void ClickSiteAccessToggle(ExtensionMenuItemView* menu_item,
bool active_tab_only = false);
content::WebContentsTester* web_contents_tester() {
return web_contents_tester_;
}
ExtensionsMenuMainPageView* main_page();
ExtensionsMenuSitePermissionsPageView* site_permissions_page();
std::vector<ExtensionMenuItemView*> menu_items();
// ExtensionsToolbarUnitTest:
void SetUp() override;
private:
base::test::ScopedFeatureList scoped_feature_list_;
raw_ptr<content::WebContentsTester, DanglingUntriaged> web_contents_tester_;
};
ExtensionsMenuMainPageViewUnitTest::ExtensionsMenuMainPageViewUnitTest() {
scoped_feature_list_.InitAndEnableFeature(
extensions_features::kExtensionsMenuAccessControl);
}
void ExtensionsMenuMainPageViewUnitTest::ShowMenu() {
menu_coordinator()->Show(extensions_button(), extensions_container());
}
ExtensionMenuItemView* ExtensionsMenuMainPageViewUnitTest::GetOnlyMenuItem() {
std::vector<ExtensionMenuItemView*> items = menu_items();
if (items.size() != 1u) {
ADD_FAILURE() << "Not exactly one item; size is: " << items.size();
return nullptr;
}
return *items.begin();
}
std::vector<extensions::ExtensionId>
ExtensionsMenuMainPageViewUnitTest::GetExtensionsInRequestAccessSection() {
ExtensionsMenuMainPageView* page = main_page();
return page ? page->GetExtensionsRequestingAccessForTesting()
: std::vector<std::string>();
}
std::vector<extensions::ExtensionId>
ExtensionsMenuMainPageViewUnitTest::GetExtensionsInRequestAccessButton() {
return extensions_container()
->GetExtensionsToolbarControls()
->request_access_button()
->GetExtensionIdsForTesting();
}
void ExtensionsMenuMainPageViewUnitTest::LayoutMenuIfNecessary() {
menu_coordinator()->GetExtensionsMenuWidget()->LayoutRootViewIfNecessary();
}
void ExtensionsMenuMainPageViewUnitTest::ClickSitePermissionsButton(
ExtensionMenuItemView* menu_item) {
ClickButton(menu_item->site_permissions_button_for_testing());
WaitForAnimation();
}
void ExtensionsMenuMainPageViewUnitTest::ClickSiteAccessToggle(
ExtensionMenuItemView* menu_item,
bool active_tab_only) {
extensions::PermissionsManagerWaiter waiter(
PermissionsManager::Get(browser()->profile()));
ClickButton(menu_item->site_access_toggle_for_testing());
if (!active_tab_only) {
waiter.WaitForExtensionPermissionsUpdate();
}
WaitForAnimation();
LayoutMenuIfNecessary();
}
ExtensionsMenuMainPageView* ExtensionsMenuMainPageViewUnitTest::main_page() {
ExtensionsMenuViewController* menu_controller =
menu_coordinator()->GetControllerForTesting();
return menu_controller ? menu_controller->GetMainPageViewForTesting()
: nullptr;
}
ExtensionsMenuSitePermissionsPageView*
ExtensionsMenuMainPageViewUnitTest::site_permissions_page() {
ExtensionsMenuViewController* menu_controller =
menu_coordinator()->GetControllerForTesting();
return menu_controller ? menu_controller->GetSitePermissionsPageForTesting()
: nullptr;
}
std::vector<ExtensionMenuItemView*>
ExtensionsMenuMainPageViewUnitTest::menu_items() {
ExtensionsMenuMainPageView* page = main_page();
return page ? page->GetMenuItems() : std::vector<ExtensionMenuItemView*>();
}
void ExtensionsMenuMainPageViewUnitTest::SetUp() {
ExtensionsToolbarUnitTest::SetUp();
// Menu needs web contents at construction, so we need to add them to every
// test.
web_contents_tester_ = AddWebContentsAndGetTester();
}
TEST_F(ExtensionsMenuMainPageViewUnitTest, ExtensionsAreSorted) {
constexpr char kExtensionZName[] = "Z Extension";
InstallExtension(kExtensionZName);
constexpr char kExtensionAName[] = "A Extension";
InstallExtension(kExtensionAName);
constexpr char kExtensionBName[] = "b Extension";
InstallExtension(kExtensionBName);
constexpr char kExtensionCName[] = "C Extension";
InstallExtension(kExtensionCName);
ShowMenu();
std::vector<ExtensionMenuItemView*> items = menu_items();
ASSERT_EQ(items.size(), 4u);
// Basic std::sort would do A,C,Z,b however we want A,b,C,Z
std::vector<std::string> expected_items{kExtensionAName, kExtensionBName,
kExtensionCName, kExtensionZName};
EXPECT_EQ(GetNamesFromMenuItems(items), expected_items);
}
// Verifies the site access toggle and site permissions button properties for an
// extension that doesn't request site access.
TEST_F(ExtensionsMenuMainPageViewUnitTest, NoSiteAccessRequested) {
auto extension = InstallExtension("Extension");
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
ShowMenu();
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
// When site setting is set to "customize by extension" (default):
// - site access toggle is hidden.
// - site permissions button is visible, disabled, has no icon and has
// "none" text.
EXPECT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_FALSE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_NONE));
// when site setting is set to "block all extensions":
// - site access toggle is hidden
// - site permissions button is hidden
UpdateUserSiteSetting(
PermissionsManager::UserSiteSetting::kBlockAllExtensions, url);
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_permissions_button_for_testing()->GetVisible());
}
// Verifies the site access toggle and site permissions button properties for an
// enterprise extension that doesn't request host permissions.
TEST_F(ExtensionsMenuMainPageViewUnitTest,
NoSiteAccessRequested_EnterpriseExtension) {
auto extension =
InstallEnterpriseExtension("Extension", /*host_permissions*/ {});
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
ShowMenu();
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
// When site setting is set to "customize by extension" (default):
// - site access toggle is hidden.
// - site permissions button is visible, disabled, has no icon and has
// "none" text.
EXPECT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_FALSE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_NONE));
// When site setting is set to "block all extensions":
// - site access toggle is hidden
// - site permissions button is hidden
UpdateUserSiteSetting(
PermissionsManager::UserSiteSetting::kBlockAllExtensions, url);
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_permissions_button_for_testing()->GetVisible());
}
// Verifies the site access toggle and site permissions button properties when
// toggling site access for an extension that requests host permissions for a
// specific site.
TEST_F(ExtensionsMenuMainPageViewUnitTest,
HostPermissionsRequested_ToggleSiteAccess_OnSite) {
const GURL url("http://www.example.com");
auto extension =
InstallExtensionWithHostPermissions("Extension", {url.spec()});
web_contents_tester()->NavigateAndCommit(url);
ShowMenu();
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
// By default, site setting is set to "customize by extension" (default) and
// extension has granted "on site" access:
// - site access toggle is visible and on.
// - site permissions button is visible, enabled, with icon and has "on
// site" text.
ASSERT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
ASSERT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnSite);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_SITE));
// When site access is toggled OFF:
// - extension site access is "on click".
// - site access toggle is visible and off.
// - site permissions button is visible, enabled, with icon and has "on
// click" text.
ClickSiteAccessToggle(menu_item);
EXPECT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnClick);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_CLICK));
// When site access is toggled ON:
// - extension site access is "on site".
// - site access toggle is visible and on.
// - site permissions button is visible, enabled, with icon and has "on
// site" text.
ClickSiteAccessToggle(menu_item);
EXPECT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnSite);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_SITE));
}
// Verifies the site access toggle and site permissions button properties when
// toggling site access for an extension that requests host permissions for all
// sites.
TEST_F(ExtensionsMenuMainPageViewUnitTest,
HostPermissionsRequested_ToggleSiteAccess_OnAllSites) {
auto extension =
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
ShowMenu();
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
// By default, site setting is set to "customize by extension" (default) and
// extension has granted "on all sites" access:
// - site access toggle is visible and on.
// - site permissions button is visible, enabled, with icon and has "on
// all sites" text.
ASSERT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
ASSERT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnAllSites);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_ALL_SITES));
// When site access is toggled OFF:
// - extension site access is changed to "on click".
// - site access toggle is visible and off.
// - site permissions button is visible, enabled, with icon and has "on
// click" text.
ClickSiteAccessToggle(menu_item);
EXPECT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnClick);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_CLICK));
// When site access is toggled ON:
// - extension site access is "on site". Even though previously extension
// had on all sites, toggling site access on grants access just to this
// site. User can still grant all sites in the site permissions page.
// - site access toggle is visible and on.
// - site permissions button is visible, enabled, with icon and has "on
// site" text.
ClickSiteAccessToggle(menu_item);
EXPECT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnSite);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_SITE));
}
// Verifies the site access toggle and site permissions button properties for an
// extension that requests host permissions when host permission change with the
// menu open.
TEST_F(ExtensionsMenuMainPageViewUnitTest,
HostPermissionsRequested_DynamicUpdates) {
auto extension =
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
ShowMenu();
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
// When site setting is set to "customize by extension" and extension site
// permissions are granted "on all sites" (default):
// - site access toggle is visible and on.
// - site permissions button is visible, enabled, with icon and has "on all
// sites" text.
ASSERT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
ASSERT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnAllSites);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_ALL_SITES));
// When site setting is set to "customize by extension" and extension site
// permissions are withheld.
// - site access toggle is visible and off
// - site permissions button is visible, enabled, with icon and has "on
// click" text.
WithholdHostPermissions(extension.get());
LayoutMenuIfNecessary();
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_CLICK));
// When site setting is set to "block all extensions":
// - site access toggle is hidden.
// - site permissions button is hidden.
UpdateUserSiteSetting(
PermissionsManager::UserSiteSetting::kBlockAllExtensions, url);
LayoutMenuIfNecessary();
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_permissions_button_for_testing()->GetVisible());
}
// Verifies the site access toggle and site permissions button properties for an
// extension that requests host permissions.
TEST_F(ExtensionsMenuMainPageViewUnitTest,
HostPermissionsRequested_EnterpriseExtension) {
auto extension =
InstallEnterpriseExtension("Extension",
/*host_permissions=*/{"<all_urls>"});
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
ShowMenu();
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
// When site setting is set to "customize by extension" and has granted "on
// all sites" access (default):
// - site access toggle is hidden, because extension has site access but
// user cannot withheld it.
// - site permissions button is visible, disabled, has no icon and has "on
// all sites".
ASSERT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
ASSERT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnAllSites);
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_ALL_SITES));
EXPECT_FALSE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
// When site setting is set to "block all extensions":
// - extension site access is still "on all sites".
// - site access toggle is hidden.
// - site permissions button is visible, disabled, has no icon and has "on
// all sites" text.
// Note: Policy-installed extension can still run on the site even if the
// user blocked all extensions because enterprise-installed extensions take
// priority over user settings. Therefore, the button is visible (so the
// user can see that it can run), but not clickable (because the user can't
// modify the settings).
UpdateUserSiteSetting(
PermissionsManager::UserSiteSetting::kBlockAllExtensions, url);
EXPECT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnAllSites);
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_ALL_SITES));
EXPECT_FALSE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
}
// Verifies the site access toggle and site permissions button properties when
// toggling site access for an extension that only requests active tab.
// TODO(crbug.com/1445397): Flaky on various builders.
TEST_F(ExtensionsMenuMainPageViewUnitTest,
DISABLED_ActiveTabRequested_ToggleSiteAccess) {
auto extension = InstallExtensionWithPermissions("Extension", {"activeTab"});
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
ShowMenu();
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
// By default, site setting is set to "customize by extension" (default) and
// extension has not active tab granted.
// - site access toggle is visible and off.
// - site permissions button is visible, enabled, with icon and has "on
// click" text.
ASSERT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
ASSERT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnClick);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_CLICK));
// When site access toggle is toggled ON:
// - extension site access is "on click". Since extension only requested
// active tab, toggling site access on grants tab permissions but doesn't
// change the user site access.
// - site access toggle is visible and on.
// - site permissions button is visible, enabled, with icon and has "on
// click" text.
ClickSiteAccessToggle(menu_item, /*active_tab_only=*/true);
EXPECT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnClick);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_CLICK));
// When site access toggle is toggled OFF:
// - extension site access is "on click".
// - site access toggle is visible and off.
// - site permissions button is visible, enabled, with icon and has "on
// click" text.
EXPECT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnClick);
ClickSiteAccessToggle(menu_item, /*active_tab_only=*/true);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_CLICK));
}
// Verifies the site access toggle and site permissions button properties when
// toggling an extension off that has "on click" site access and granted tab
// permissions (meaning it has access to the current site).
TEST_F(ExtensionsMenuMainPageViewUnitTest,
ActiveTabRequested_ToggleSiteAccess_UngrantTabPermissions) {
auto extension = InstallExtensionWithPermissions("Extension", {"activeTab"});
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
ShowMenu();
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
// By default, extension has not active tab granted. Thus, extension:
// - site interaction is "active tab".
// - site access is "on click".
// - site access toggle is visible and off.
// - site permissions button is visible, enabled, with icon and has "on
// click" text.
EXPECT_EQ(GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kActiveTab);
EXPECT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnClick);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_CLICK));
auto* action_runner =
extensions::ExtensionActionRunner::GetForWebContents(web_contents);
ASSERT_TRUE(action_runner);
action_runner->accept_bubble_for_testing(false);
// When extension is granted tab permissions it has:
// - site interaction is "granted".
// - site access is "on click" since granting tab permissions doesn't change
// site access.
// - site access toggle is visible and on.
// - site permissions button is visible, enabled, with icon and has "on
// click" text.
action_runner->GrantTabPermissions({extension.get()});
EXPECT_EQ(GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kGranted);
EXPECT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnClick);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_CLICK));
// When extension is toggled OFF:
// - site interaction is "active tab".
// - site access is "on click".
// - site access toggle is visible and off.
// - site permissions button is visible, enabled, with icon and has "on
// click" text.
ClickSiteAccessToggle(menu_item, /*active_tab_only=*/true);
EXPECT_EQ(GetSiteInteraction(*extension, web_contents),
SitePermissionsHelper::SiteInteraction::kActiveTab);
EXPECT_EQ(GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnClick);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_CLICK));
}
// Verifies the site access toggle and site permissions button properties for an
// extension that only requests active tab when site permissions change with the
// menu open.
TEST_F(ExtensionsMenuMainPageViewUnitTest, ActiveTabRequested_DynamicUpdates) {
auto extension = InstallExtensionWithPermissions("Extension", {"activeTab"});
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
ShowMenu();
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
// When site setting is set to "customize by extension" (default) and active
// tab is not granted:
// - site access toggle is visible and off.
// - site permissions button is visible, enabled, with icon and has "on
// click" text.
ASSERT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_CLICK));
// When site setting is set to "customize by extension" active tab is granted:
// - site access toggle is visible and on.
// - site permissions button is visible, enabled, with icon and has "on
// click" text. Since extension only requested active tab, toggling site
// access on grants tab permissions but doesn't change the user site
// access.
extensions::ActiveTabPermissionGranter* active_tab_permission_granter =
extensions::TabHelper::FromWebContents(
browser()->tab_strip_model()->GetActiveWebContents())
->active_tab_permission_granter();
ASSERT_TRUE(active_tab_permission_granter);
active_tab_permission_granter->GrantIfRequested(extension.get());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_CLICK));
// Navigating to the same url after navigating to other url should remove tab
// permissions. Therefore:
// - site access toggle is visible and off.
// - site permissions button is visible, enabled, with icon and has "on
// click" text.
// Note: refreshing the page doesn't revoke tab permissions, thus we
// need to re navigate to the url.
web_contents_tester()->NavigateAndCommit(GURL("http://other-url.com"));
web_contents_tester()->NavigateAndCommit(url);
EXPECT_TRUE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetIsOn());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
EXPECT_EQ(
menu_item->site_permissions_button_for_testing()->title()->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MAIN_PAGE_EXTENSION_SITE_ACCESS_ON_CLICK));
// When site setting is set to "block all extensions":
// - site access toggle is hidden.
// - site permissions button is hidden.
UpdateUserSiteSetting(
PermissionsManager::UserSiteSetting::kBlockAllExtensions, url);
EXPECT_FALSE(menu_item->site_access_toggle_for_testing()->GetVisible());
EXPECT_FALSE(menu_item->site_permissions_button_for_testing()->GetVisible());
}
// Verifies the site permissions button opens the site permissions page when it
// is enabled.
TEST_F(ExtensionsMenuMainPageViewUnitTest,
SitePermissionsButton_OpenSitePermissionsPage) {
auto extension =
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
ShowMenu();
ExtensionMenuItemView* menu_item = GetOnlyMenuItem();
// Button is visible, enabled and has an icon when site setting is set to
// "customize by extension" (default setting).
EXPECT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetVisible());
EXPECT_TRUE(menu_item->site_permissions_button_for_testing()->GetEnabled());
EXPECT_TRUE(
menu_item->site_permissions_button_icon_for_testing()->GetVisible());
// Clicking on an extension's site permission enabled button should open
// its site permission page in the menu.
ClickSitePermissionsButton(menu_item);
EXPECT_FALSE(main_page());
ExtensionsMenuSitePermissionsPageView* page = site_permissions_page();
ASSERT_TRUE(page);
EXPECT_EQ(page->extension_id(), extension->id());
}
TEST_F(ExtensionsMenuMainPageViewUnitTest,
AddAndRemoveExtensionWhenMainPageIsOpen) {
constexpr char kExtensionA[] = "A Extension";
constexpr char kExtensionC[] = "C Extension";
InstallExtension(kExtensionA);
InstallExtension(kExtensionC);
ShowMenu();
// Verify the order of the extensions is A,C.
{
std::vector<ExtensionMenuItemView*> items = menu_items();
ASSERT_EQ(items.size(), 2u);
std::vector<std::string> expected_names{kExtensionA, kExtensionC};
EXPECT_EQ(GetNamesFromMenuItems(items), expected_names);
}
// Add a new extension while the menu is open.
constexpr char kExtensionB[] = "B Extension";
auto extensionB = InstallExtension(kExtensionB);
LayoutMenuIfNecessary();
// Extension should be added in the correct place.
// Verify the new order is A,B,C.
{
std::vector<ExtensionMenuItemView*> items = menu_items();
ASSERT_EQ(items.size(), 3u);
std::vector<std::string> expected_names{kExtensionA, kExtensionB,
kExtensionC};
EXPECT_EQ(GetNamesFromMenuItems(items), expected_names);
}
// Remove a extension while the menu is open
UninstallExtension(extensionB->id());
LayoutMenuIfNecessary();
// Verify the new order is A,C.
{
std::vector<ExtensionMenuItemView*> items = menu_items();
ASSERT_EQ(items.size(), 2u);
std::vector<std::string> expected_names{kExtensionA, kExtensionC};
EXPECT_EQ(GetNamesFromMenuItems(items), expected_names);
}
}
// Verifies the pin button appears on the menu item, in place of context menu
// button when state is normal, when an extension is pinned.
TEST_F(ExtensionsMenuMainPageViewUnitTest, PinnedExtensions) {
auto extension = InstallExtension("Test Extension");
ShowMenu();
EXPECT_EQ(menu_items().size(), 1u);
HoverButton* context_menu_button =
GetOnlyMenuItem()->context_menu_button_for_testing();
const ui::ColorProvider* color_provider =
context_menu_button->GetColorProvider();
auto pin_icon = gfx::Image(gfx::CreateVectorIcon(
views::kPinIcon,
color_provider->GetColor(kColorExtensionMenuPinButtonIcon)));
auto three_dot_icon = gfx::Image(gfx::CreateVectorIcon(
kBrowserToolsIcon, color_provider->GetColor(kColorExtensionMenuIcon)));
// Verify context menu button has three dot icon for all button states.
EXPECT_TRUE(gfx::test::AreImagesEqual(
gfx::Image(context_menu_button->GetImage(views::Button::STATE_NORMAL)),
three_dot_icon));
EXPECT_TRUE(gfx::test::AreImagesEqual(
gfx::Image(context_menu_button->GetImage(views::Button::STATE_HOVERED)),
three_dot_icon));
EXPECT_TRUE(gfx::test::AreImagesEqual(
gfx::Image(context_menu_button->GetImage(views::Button::STATE_PRESSED)),
three_dot_icon));
// Pin extension.
auto* toolbar_model = ToolbarActionsModel::Get(profile());
ASSERT_TRUE(toolbar_model);
toolbar_model->SetActionVisibility(extension->id(), true);
LayoutMenuIfNecessary();
// Verify context menu button changes to pin icon only in normal state.
// Pin icon is tested by checking it is NOT the three dot icon because of a
// weird reason when retrieving the pin icon. We can do this because a) no
// other icon is expected, and b) pin icon correctly appears when manually
// testing.
EXPECT_FALSE(gfx::test::AreImagesEqual(
gfx::Image(context_menu_button->GetImage(views::Button::STATE_NORMAL)),
three_dot_icon));
EXPECT_TRUE(gfx::test::AreImagesEqual(
gfx::Image(context_menu_button->GetImage(views::Button::STATE_HOVERED)),
three_dot_icon));
EXPECT_TRUE(gfx::test::AreImagesEqual(
gfx::Image(context_menu_button->GetImage(views::Button::STATE_PRESSED)),
three_dot_icon));
// Unpin extension.
toolbar_model->SetActionVisibility(extension->id(), false);
LayoutMenuIfNecessary();
// Verify context menu button has three dot icon for all button states.
EXPECT_TRUE(gfx::test::AreImagesEqual(
gfx::Image(context_menu_button->GetImage(views::Button::STATE_NORMAL)),
three_dot_icon));
EXPECT_TRUE(gfx::test::AreImagesEqual(
gfx::Image(context_menu_button->GetImage(views::Button::STATE_HOVERED)),
three_dot_icon));
EXPECT_TRUE(gfx::test::AreImagesEqual(
gfx::Image(context_menu_button->GetImage(views::Button::STATE_PRESSED)),
three_dot_icon));
}
TEST_F(ExtensionsMenuMainPageViewUnitTest, DisableAndEnableExtension) {
constexpr char kName[] = "Test Extension";
auto extension_id = InstallExtension(kName)->id();
ShowMenu();
EXPECT_EQ(menu_items().size(), 1u);
DisableExtension(extension_id);
LayoutMenuIfNecessary();
EXPECT_EQ(menu_items().size(), 0u);
EnableExtension(extension_id);
LayoutMenuIfNecessary();
EXPECT_EQ(menu_items().size(), 1u);
}
// Tests that when an extension is reloaded it remains visible in the extensions
// menu.
// TODO(crbug.com/1390952): Verify context menu button shows the correct icon as
// pinned state is also preserved when a reload happens. Add this functionality
// when showing pin icon instead of context menu when extension is pinned is
// added.
TEST_F(ExtensionsMenuMainPageViewUnitTest, ReloadExtension) {
// The extension must have a manifest to be reloaded.
extensions::TestExtensionDir extension_directory;
constexpr char kManifest[] = R"({
"name": "Test Extension",
"version": "1",
"manifest_version": 3
})";
extension_directory.WriteManifest(kManifest);
extensions::ChromeTestExtensionLoader loader(profile());
scoped_refptr<const extensions::Extension> extension =
loader.LoadExtension(extension_directory.UnpackedPath());
ShowMenu();
EXPECT_EQ(menu_items().size(), 1u);
// Reload the extension.
extensions::TestExtensionRegistryObserver registry_observer(
extensions::ExtensionRegistry::Get(profile()));
ReloadExtension(extension->id());
ASSERT_TRUE(registry_observer.WaitForExtensionLoaded());
LayoutMenuIfNecessary();
// Verify the extension is visible in the menu.
EXPECT_EQ(menu_items().size(), 1u);
}
// Tests that a when an extension is reloaded with manifest errors, and
// therefore fails to be loaded into Chrome, it's removed from the
// extensions menu.
TEST_F(ExtensionsMenuMainPageViewUnitTest, ReloadExtensionFailed) {
extensions::TestExtensionDir extension_directory;
constexpr char kManifest[] = R"({
"name": "Test Extension",
"version": "1",
"manifest_version": 3
})";
extension_directory.WriteManifest(kManifest);
extensions::ChromeTestExtensionLoader loader(profile());
scoped_refptr<const extensions::Extension> extension =
loader.LoadExtension(extension_directory.UnpackedPath());
ShowMenu();
EXPECT_EQ(menu_items().size(), 1u);
// Replace the extension's valid manifest with one containing errors. In this
// case, 'version' keys is missing.
constexpr char kManifestWithErrors[] = R"({
"name": "Test",
"manifest_version": 3,
})";
extension_directory.WriteManifest(kManifestWithErrors);
// Reload the extension. It should fail due to the manifest errors.
extension_service()->ReloadExtensionWithQuietFailure(extension->id());
base::RunLoop().RunUntilIdle();
LayoutMenuIfNecessary();
// Verify the extension is no longer visible in the menu.
EXPECT_EQ(menu_items().size(), 0u);
}
// Tests that extension's site permission button is always hidden when site is
// restricted.
TEST_F(ExtensionsMenuMainPageViewUnitTest, RestrictedSite) {
constexpr char kExtension[] = "Extension";
constexpr char kEnterpriseExtension[] = "Enterprise extension";
InstallExtension(kExtension);
InstallEnterpriseExtension(kEnterpriseExtension,
/*host_permissions=*/{"<all_urls>"});
const GURL restricted_url("chrome://extensions");
auto restricted_origin = url::Origin::Create(restricted_url);
web_contents_tester()->NavigateAndCommit(restricted_url);
// By default, site settings is set to "customize by extension".
PermissionsManager* permissions_manager = PermissionsManager::Get(profile());
EXPECT_EQ(permissions_manager->GetUserSiteSetting(restricted_origin),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
ShowMenu();
ASSERT_EQ(menu_items().size(), 2u);
// Both extension's site permissions button should be hidden.
EXPECT_FALSE(
menu_items()[0]->site_permissions_button_for_testing()->GetVisible());
EXPECT_FALSE(
menu_items()[1]->site_permissions_button_for_testing()->GetVisible());
// Change site settings to "block all extensions".
extensions::PermissionsManagerWaiter waiter(
PermissionsManager::Get(browser()->profile()));
permissions_manager->UpdateUserSiteSetting(
restricted_origin,
PermissionsManager::UserSiteSetting::kBlockAllExtensions);
waiter.WaitForUserPermissionsSettingsChange();
// Both extension's site permission button should still be hidden (restricted
// sites have priority over enterprise extensions).
EXPECT_FALSE(
menu_items()[0]->site_permissions_button_for_testing()->GetVisible());
EXPECT_FALSE(
menu_items()[1]->site_permissions_button_for_testing()->GetVisible());
}
// Tests that the message section only displays the text container when the
// site restricts access to all extensions.
TEST_F(ExtensionsMenuMainPageViewUnitTest, MessageSection_RestrictedAccess) {
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
const GURL restricted_url("chrome://extensions");
web_contents_tester()->NavigateAndCommit(restricted_url);
ShowMenu();
views::View* text_container = main_page()->GetTextContainerForTesting();
views::View* reload_container = main_page()->GetReloadContainerForTesting();
views::View* requests_access_container =
main_page()->GetRequestsAccessContainerForTesting();
// Only the text container is displayed with restricted site message, when
// site restricts access to all extensions.
EXPECT_TRUE(text_container->GetVisible());
EXPECT_FALSE(reload_container->GetVisible());
EXPECT_FALSE(requests_access_container->GetVisible());
EXPECT_EQ(views::AsViewClass<views::Label>(text_container->children()[0])
->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MESSAGE_SECTION_RESTRICTED_ACCESS_TEXT));
}
// Tests that the message section only displays the text container when the
// user has blocked all extensions on the site.
TEST_F(ExtensionsMenuMainPageViewUnitTest, MessageSection_UserBlockedAccess) {
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
// Block all extensions on `url`.
UpdateUserSiteSetting(
PermissionsManager::UserSiteSetting::kBlockAllExtensions, url);
ASSERT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kBlockAllExtensions);
ShowMenu();
views::View* text_container = main_page()->GetTextContainerForTesting();
views::View* reload_container = main_page()->GetReloadContainerForTesting();
views::View* requests_access_container =
main_page()->GetRequestsAccessContainerForTesting();
// Only the text container is displayed when all the extensions are blocked on
// this site.
EXPECT_TRUE(text_container->GetVisible());
EXPECT_FALSE(reload_container->GetVisible());
EXPECT_FALSE(requests_access_container->GetVisible());
// Container has blocked site message and tooltip icon is hidden since there
// are not enterprise extensions that still have access.
EXPECT_EQ(views::AsViewClass<views::Label>(text_container->children()[0])
->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MESSAGE_SECTION_USER_BLOCKED_ACCESS_TEXT));
EXPECT_FALSE(text_container->children()[1]->GetVisible());
}
// Tests that the message section only displays the text container (and the
// tooltip icon is visible since at least one extension is installed by
// enterprise) when the user has blocked all extensions on the site.
TEST_F(ExtensionsMenuMainPageViewUnitTest,
MessageSection_UserBlockedAccess_Enterprise) {
InstallEnterpriseExtension("Extension", {"<all_urls>"});
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
// Block all extensions on `url`.
UpdateUserSiteSetting(
PermissionsManager::UserSiteSetting::kBlockAllExtensions, url);
ASSERT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kBlockAllExtensions);
ShowMenu();
views::View* text_container = main_page()->GetTextContainerForTesting();
views::View* reload_container = main_page()->GetReloadContainerForTesting();
views::View* requests_access_container =
main_page()->GetRequestsAccessContainerForTesting();
// Only the text container is displayed when all the extensions are blocked on
// this site.
EXPECT_TRUE(text_container->GetVisible());
EXPECT_FALSE(reload_container->GetVisible());
EXPECT_FALSE(requests_access_container->GetVisible());
// Container has blocked site message and tooltip icon is visible since there
// is an enterprise extensions that still has access.
EXPECT_EQ(views::AsViewClass<views::Label>(text_container->children()[0])
->GetText(),
l10n_util::GetStringUTF16(
IDS_EXTENSIONS_MENU_MESSAGE_SECTION_USER_BLOCKED_ACCESS_TEXT));
EXPECT_TRUE(text_container->children()[1]->GetVisible());
}
// Tests that all the containers in the message section are hidden when the user
// can customize the extensions site access but no extension is requesting site
// access.
TEST_F(ExtensionsMenuMainPageViewUnitTest,
MessageSection_UserCustomizedAccess_NoExtensions) {
// Install extensions that cannot request site access in the menu because
// they don't request host permissions, or because they are granted host
// permissions by enterprise.
InstallExtensionWithHostPermissions("Extension", {});
InstallEnterpriseExtension("Enterprise extension",
/*host_permissions=*/{"<all_urls>"});
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
ShowMenu();
views::View* text_container = main_page()->GetTextContainerForTesting();
views::View* reload_container = main_page()->GetReloadContainerForTesting();
views::View* requests_access_container =
main_page()->GetRequestsAccessContainerForTesting();
// Message section is hidden (all containers are not visible) when user can
// customize the site access of each extension, but no extension is requesting
// site access.
ASSERT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
EXPECT_FALSE(text_container->GetVisible());
EXPECT_FALSE(reload_container->GetVisible());
EXPECT_FALSE(requests_access_container->GetVisible());
}
// Test that the message section only displays the requests access container
// when the user can customize the extensions site access and at least 1+
// extensios are requesting site access.
TEST_F(ExtensionsMenuMainPageViewUnitTest,
MessageSection_UserCustomizedAccess_Extensions) {
// Install two extension that requests host permissions.
auto extension_A =
InstallExtensionWithHostPermissions("Extension A", {"<all_urls>"});
auto extension_B =
InstallExtensionWithHostPermissions("Extension B", {"<all_urls>"});
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
// By default, user can customize the site access of each extension and site
// access will be granted
ASSERT_EQ(GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
ShowMenu();
views::View* text_container = main_page()->GetTextContainerForTesting();
views::View* reload_container = main_page()->GetReloadContainerForTesting();
views::View* requests_access_container =
main_page()->GetRequestsAccessContainerForTesting();
// Message section is hidden (all containers are not visible) when user can
// customize site access but all extensions have granted access.
EXPECT_FALSE(text_container->GetVisible());
EXPECT_FALSE(reload_container->GetVisible());
EXPECT_FALSE(requests_access_container->GetVisible());
// Message section shows request access container with extension A
// when its site access is withheld.
WithholdHostPermissions(extension_A.get());
LayoutMenuIfNecessary();
EXPECT_FALSE(text_container->GetVisible());
EXPECT_FALSE(reload_container->GetVisible());
EXPECT_TRUE(requests_access_container->GetVisible());
EXPECT_THAT(GetExtensionsInRequestAccessSection(),
testing::ElementsAre(extension_A->id()));
// Message section shows requests access container with extension A if its
// site access is still withheld when any other extension is updated.
// Extension B is not included because it has granted site access.
UpdateUserSiteAccess(*extension_B.get(),
browser()->tab_strip_model()->GetActiveWebContents(),
extensions::PermissionsManager::UserSiteAccess::kOnSite);
LayoutMenuIfNecessary();
EXPECT_FALSE(text_container->GetVisible());
EXPECT_FALSE(reload_container->GetVisible());
EXPECT_TRUE(requests_access_container->GetVisible());
EXPECT_THAT(GetExtensionsInRequestAccessSection(),
testing::ElementsAre(extension_A->id()));
}
TEST_F(ExtensionsMenuMainPageViewUnitTest,
MessageSection_UserCustomizedAccess_AllowExtension) {
auto extension =
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
WithholdHostPermissions(extension.get());
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
ShowMenu();
views::View* requests_access_container =
main_page()->GetRequestsAccessContainerForTesting();
constexpr char kActivatedUserAction[] =
"Extensions.Toolbar.ExtensionActivatedFromAllowingRequestAccessInMenu";
base::UserActionTester user_action_tester;
auto* permissions = PermissionsManager::Get(profile());
// When extension is requesting site access:
// - message section (menu) includes extension and is visible.
// - request access button (toolbar) includes extension.
// - action has not been run.
// - site access is "on click".
EXPECT_TRUE(requests_access_container->GetVisible());
EXPECT_THAT(GetExtensionsInRequestAccessSection(),
testing::ElementsAre(extension->id()));
EXPECT_THAT(GetExtensionsInRequestAccessButton(),
testing::ElementsAre(extension->id()));
EXPECT_EQ(user_action_tester.GetActionCount(kActivatedUserAction), 0);
EXPECT_EQ(permissions->GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnClick);
// Click on the allow button for the extension.
views::View* extension_entry =
main_page()->GetExtensionRequestingAccessEntryForTesting(extension->id());
ASSERT_TRUE(extension_entry);
views::Button* extension_allow_button =
static_cast<views::Button*>(extension_entry->children()[3]);
ClickButton(extension_allow_button);
WaitForAnimation();
LayoutContainerIfNecessary();
LayoutMenuIfNecessary();
// When extension is granted site access via 'allow' button:
// - message section (menu) does not include extension and is hidden
// - request access button (toolbar) does not include extension
// - action has been run
// - site access is still "on click" since clicking the button grants one
// time access
EXPECT_FALSE(requests_access_container->GetVisible());
EXPECT_TRUE(GetExtensionsInRequestAccessSection().empty());
EXPECT_TRUE(GetExtensionsInRequestAccessButton().empty());
EXPECT_EQ(user_action_tester.GetActionCount(kActivatedUserAction), 1);
EXPECT_EQ(permissions->GetUserSiteAccess(*extension, url),
PermissionsManager::UserSiteAccess::kOnClick);
}
TEST_F(ExtensionsMenuMainPageViewUnitTest,
MessageSection_UserCustomizedAccess_DismissExtension) {
auto extension =
InstallExtensionWithHostPermissions("Extension", {"<all_urls>"});
WithholdHostPermissions(extension.get());
const GURL url("http://www.example.com");
web_contents_tester()->NavigateAndCommit(url);
ShowMenu();
// When extension is requesting site access:
// - message section (menu) includes extension and is visible.
// - request access button (toolbar) includes extension.
EXPECT_TRUE(
main_page()->GetRequestsAccessContainerForTesting()->GetVisible());
EXPECT_THAT(GetExtensionsInRequestAccessSection(),
testing::ElementsAre(extension->id()));
EXPECT_THAT(GetExtensionsInRequestAccessButton(),
testing::ElementsAre(extension->id()));
// Click on the dismiss button for the extension.
views::View* extension_entry =
main_page()->GetExtensionRequestingAccessEntryForTesting(extension->id());
ASSERT_TRUE(extension_entry);
ASSERT_EQ(extension_entry->children().size(), 4u);
views::Button* extension_dismiss_button =
static_cast<views::Button*>(extension_entry->children()[2]);
ClickButton(extension_dismiss_button);
WaitForAnimation();
LayoutContainerIfNecessary();
LayoutMenuIfNecessary();
// When the extension requests are dismissed:
// - message section (menu) does not include extension and is hidden
// - request access button (toolbar) does not include extension
EXPECT_FALSE(
main_page()->GetRequestsAccessContainerForTesting()->GetVisible());
EXPECT_TRUE(GetExtensionsInRequestAccessSection().empty());
EXPECT_TRUE(GetExtensionsInRequestAccessButton().empty());
// Re navigate to the same page.
// Note: refreshing the page doesn't revoke tab permissions, thus we
// need to re navigate to the url.
web_contents_tester()->NavigateAndCommit(GURL("http://other-url.com"));
web_contents_tester()->NavigateAndCommit(url);
// Navigating to the same url should show again the extension requesting
// access, since dismiss is only one time tab permission:
// - message section (menu) includes extension and is visible.
// - request access button (toolbar) includes extension.
EXPECT_TRUE(
main_page()->GetRequestsAccessContainerForTesting()->GetVisible());
EXPECT_THAT(GetExtensionsInRequestAccessSection(),
testing::ElementsAre(extension->id()));
EXPECT_THAT(GetExtensionsInRequestAccessButton(),
testing::ElementsAre(extension->id()));
}
|