1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/strings/utf_string_conversions.h"
#include "base/test/bind.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/test/test_browser_dialog.h"
#include "chrome/browser/ui/web_applications/web_app_dialogs.h"
#include "chrome/browser/web_applications/web_app_helpers.h"
#include "chrome/browser/web_applications/web_app_install_info.h"
#include "chrome/common/chrome_features.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "components/webapps/browser/installable/installable_metrics.h"
#include "components/webapps/browser/installable/ml_install_operation_tracker.h"
#include "components/webapps/browser/installable/ml_installability_promoter.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/content_features.h"
#include "content/public/test/browser_test.h"
#include "third_party/blink/public/common/features.h"
class WebAppConfirmViewBrowserTest
: public DialogBrowserTest,
public ::testing::WithParamInterface<bool> {
public:
WebAppConfirmViewBrowserTest() = default;
WebAppConfirmViewBrowserTest(const WebAppConfirmViewBrowserTest&) = delete;
WebAppConfirmViewBrowserTest& operator=(const WebAppConfirmViewBrowserTest&) =
delete;
// DialogBrowserTest:
void ShowUi(const std::string& name) override {
auto app_info = std::make_unique<web_app::WebAppInstallInfo>(
web_app::GenerateManifestIdFromStartUrlOnly(
GURL("https://example.com")));
app_info->title = u"Test app";
app_info->start_url = GURL("https://example.com");
auto callback = [](bool result,
std::unique_ptr<web_app::WebAppInstallInfo>) {};
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
std::unique_ptr<webapps::MlInstallOperationTracker> install_tracker =
webapps::MLInstallabilityPromoter::FromWebContents(web_contents)
->RegisterCurrentInstallForWebContents(
webapps::WebappInstallSource::MENU_CREATE_SHORTCUT);
web_app::ShowWebAppInstallDialog(web_contents, std::move(app_info),
std::move(install_tracker),
base::BindLambdaForTesting(callback));
}
void SetUp() override {
if (GetParam()) {
feature_list.InitWithFeatures({blink::features::kDesktopPWAsTabStrip,
features::kDesktopPWAsTabStripSettings},
{});
} else {
feature_list.InitWithFeatures({},
{blink::features::kDesktopPWAsTabStrip,
features::kDesktopPWAsTabStripSettings});
}
DialogBrowserTest::SetUp();
}
private:
base::test::ScopedFeatureList feature_list;
};
IN_PROC_BROWSER_TEST_P(WebAppConfirmViewBrowserTest, ShowWebAppInstallDialog) {
auto app_info = std::make_unique<web_app::WebAppInstallInfo>(
web_app::GenerateManifestIdFromStartUrlOnly(GURL("https://example.com")));
app_info->title = u"Test app";
app_info->start_url = GURL("https://example.com");
web_app::SetAutoAcceptWebAppDialogForTesting(/*auto_accept=*/true,
/*auto_open_in_window=*/true);
bool is_accepted = false;
auto callback = [&is_accepted](bool result,
std::unique_ptr<web_app::WebAppInstallInfo>) {
is_accepted = result;
};
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
std::unique_ptr<webapps::MlInstallOperationTracker> install_tracker =
webapps::MLInstallabilityPromoter::FromWebContents(web_contents)
->RegisterCurrentInstallForWebContents(
webapps::WebappInstallSource::MENU_CREATE_SHORTCUT);
web_app::ShowWebAppInstallDialog(web_contents, std::move(app_info),
std::move(install_tracker),
base::BindLambdaForTesting(callback));
EXPECT_TRUE(is_accepted);
}
IN_PROC_BROWSER_TEST_P(WebAppConfirmViewBrowserTest, InvokeUi_default) {
ShowAndVerifyUi();
}
IN_PROC_BROWSER_TEST_P(WebAppConfirmViewBrowserTest, NormalizeTitles) {
web_app::SetAutoAcceptWebAppDialogForTesting(/*auto_accept=*/true,
/*auto_open_in_window=*/true);
struct TestCases {
std::u16string input;
std::u16string expected_result;
} test_cases[] = {
{u"App Title", u"App Title"},
{u"http://example.com", u"example.com"},
{u"https://example.com", u"example.com"},
};
for (const TestCases& test_case : test_cases) {
auto app_info = std::make_unique<web_app::WebAppInstallInfo>(
web_app::GenerateManifestIdFromStartUrlOnly(
GURL("https://example.com")));
app_info->title = test_case.input;
app_info->start_url = GURL("https://example.com");
bool is_accepted = false;
std::u16string title;
auto callback = [&is_accepted, &title](
bool result,
std::unique_ptr<web_app::WebAppInstallInfo> info) {
is_accepted = result;
title = info->title;
};
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
std::unique_ptr<webapps::MlInstallOperationTracker> install_tracker =
webapps::MLInstallabilityPromoter::FromWebContents(web_contents)
->RegisterCurrentInstallForWebContents(
webapps::WebappInstallSource::MENU_CREATE_SHORTCUT);
web_app::ShowWebAppInstallDialog(web_contents, std::move(app_info),
std::move(install_tracker),
base::BindLambdaForTesting(callback));
EXPECT_TRUE(is_accepted) << test_case.input;
EXPECT_EQ(test_case.expected_result, title) << test_case.input;
}
}
INSTANTIATE_TEST_SUITE_P(All,
WebAppConfirmViewBrowserTest,
::testing::Values(false, true));
|
