1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <memory>
#include "base/command_line.h"
#include "base/test/scoped_command_line.h"
#include "base/time/time.h"
#include "components/component_updater/component_updater_command_line_config_policy.h"
#include "components/component_updater/component_updater_switches.h"
#include "components/component_updater/configurator_impl.h"
#include "components/update_client/command_line_config_policy.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace component_updater {
class ComponentUpdaterConfiguratorImplTest : public testing::Test {
public:
ComponentUpdaterConfiguratorImplTest() = default;
ComponentUpdaterConfiguratorImplTest(
const ComponentUpdaterConfiguratorImplTest&) = delete;
ComponentUpdaterConfiguratorImplTest& operator=(
const ComponentUpdaterConfiguratorImplTest&) = delete;
~ComponentUpdaterConfiguratorImplTest() override = default;
};
TEST_F(ComponentUpdaterConfiguratorImplTest, FastUpdate) {
// Test the default timing values when no command line argument is present.
base::CommandLine cmdline(base::CommandLine::NO_PROGRAM);
std::unique_ptr<ConfiguratorImpl> config = std::make_unique<ConfiguratorImpl>(
ComponentUpdaterCommandLineConfigPolicy(&cmdline), false);
CHECK_EQ(base::Minutes(1), config->InitialDelay());
CHECK_EQ(base::Hours(5), config->NextCheckDelay());
CHECK_EQ(base::Minutes(30), config->OnDemandDelay());
CHECK_EQ(base::Minutes(15), config->UpdateDelay());
// Test the fast-update timings.
cmdline.AppendSwitchASCII("--component-updater", "fast-update");
config = std::make_unique<ConfiguratorImpl>(
ComponentUpdaterCommandLineConfigPolicy(&cmdline), false);
CHECK_EQ(base::Seconds(10), config->InitialDelay());
CHECK_EQ(base::Hours(5), config->NextCheckDelay());
CHECK_EQ(base::Seconds(2), config->OnDemandDelay());
CHECK_EQ(base::Seconds(10), config->UpdateDelay());
}
TEST_F(ComponentUpdaterConfiguratorImplTest, FastUpdateWithCustomPolicy) {
// Test the default timing values when no command line argument is present
// (default).
class DefaultCommandLineConfigPolicy
: public update_client::CommandLineConfigPolicy {
public:
DefaultCommandLineConfigPolicy() = default;
// update_client::CommandLineConfigPolicy overrides.
bool BackgroundDownloadsEnabled() const override { return false; }
bool DeltaUpdatesEnabled() const override { return false; }
bool FastUpdate() const override { return false; }
bool PingsEnabled() const override { return false; }
bool TestRequest() const override { return false; }
GURL UrlSourceOverride() const override { return GURL(); }
};
std::unique_ptr<ConfiguratorImpl> config = std::make_unique<ConfiguratorImpl>(
DefaultCommandLineConfigPolicy(), false);
CHECK_EQ(base::Minutes(1), config->InitialDelay());
CHECK_EQ(base::Hours(5), config->NextCheckDelay());
CHECK_EQ(base::Minutes(30), config->OnDemandDelay());
CHECK_EQ(base::Minutes(15), config->UpdateDelay());
// Test the fast-update timings.
class FastUpdateCommandLineConfigurator
: public DefaultCommandLineConfigPolicy {
public:
FastUpdateCommandLineConfigurator() = default;
bool FastUpdate() const override { return true; }
};
config = std::make_unique<ConfiguratorImpl>(
FastUpdateCommandLineConfigurator(), false);
CHECK_EQ(base::Seconds(10), config->InitialDelay());
CHECK_EQ(base::Hours(5), config->NextCheckDelay());
CHECK_EQ(base::Seconds(2), config->OnDemandDelay());
CHECK_EQ(base::Seconds(10), config->UpdateDelay());
}
TEST_F(ComponentUpdaterConfiguratorImplTest, InitialDelay) {
std::unique_ptr<ConfiguratorImpl> config = std::make_unique<ConfiguratorImpl>(
update_client::CommandLineConfigPolicy(), false);
CHECK_EQ(base::Minutes(1), config->InitialDelay());
class CommandLineConfigPolicy
: public update_client::CommandLineConfigPolicy {
public:
CommandLineConfigPolicy() = default;
// update_client::CommandLineConfigPolicy overrides.
bool BackgroundDownloadsEnabled() const override { return false; }
bool DeltaUpdatesEnabled() const override { return false; }
bool FastUpdate() const override { return fast_update_; }
bool PingsEnabled() const override { return false; }
bool TestRequest() const override { return false; }
GURL UrlSourceOverride() const override { return GURL(); }
base::TimeDelta InitialDelay() const override { return initial_delay_; }
void set_fast_update(bool fast_update) { fast_update_ = fast_update; }
void set_initial_delay(base::TimeDelta initial_delay) {
initial_delay_ = initial_delay;
}
private:
base::TimeDelta initial_delay_ = base::Seconds(0);
bool fast_update_ = false;
};
{
CommandLineConfigPolicy clcp;
clcp.set_fast_update(true);
config = std::make_unique<ConfiguratorImpl>(clcp, false);
CHECK_EQ(base::Seconds(10), config->InitialDelay());
}
{
CommandLineConfigPolicy clcp;
clcp.set_fast_update(false);
config = std::make_unique<ConfiguratorImpl>(clcp, false);
CHECK_EQ(base::Minutes(1), config->InitialDelay());
}
{
CommandLineConfigPolicy clcp;
clcp.set_initial_delay(base::Minutes(2));
config = std::make_unique<ConfiguratorImpl>(clcp, false);
CHECK_EQ(base::Minutes(2), config->InitialDelay());
}
{
base::test::ScopedCommandLine scoped_command_line;
base::CommandLine* command_line =
scoped_command_line.GetProcessCommandLine();
command_line->AppendSwitchASCII(switches::kComponentUpdater,
"initial-delay=3.14");
config = std::make_unique<ConfiguratorImpl>(
ComponentUpdaterCommandLineConfigPolicy(command_line), false);
CHECK_EQ(base::Seconds(3.14), config->InitialDelay());
}
}
TEST_F(ComponentUpdaterConfiguratorImplTest, TestRequest) {
class CommandLineConfigPolicy
: public update_client::CommandLineConfigPolicy {
public:
CommandLineConfigPolicy() = default;
// update_client::CommandLineConfigPolicy overrides.
bool BackgroundDownloadsEnabled() const override { return false; }
bool DeltaUpdatesEnabled() const override { return false; }
bool FastUpdate() const override { return false; }
bool PingsEnabled() const override { return false; }
bool TestRequest() const override { return test_request_; }
GURL UrlSourceOverride() const override { return GURL(); }
base::TimeDelta InitialDelay() const override { return base::Seconds(0); }
void set_test_request(bool test_request) { test_request_ = test_request; }
private:
bool test_request_ = false;
};
auto config = std::make_unique<ConfiguratorImpl>(
update_client::CommandLineConfigPolicy(), false);
EXPECT_TRUE(config->ExtraRequestParams().empty());
CommandLineConfigPolicy clcp;
config = std::make_unique<ConfiguratorImpl>(clcp, false);
auto extra_request_params = config->ExtraRequestParams();
EXPECT_EQ(0u, extra_request_params.count("testrequest"));
EXPECT_EQ(0u, extra_request_params.count("testsource"));
clcp.set_test_request(true);
config = std::make_unique<ConfiguratorImpl>(clcp, false);
extra_request_params = config->ExtraRequestParams();
EXPECT_EQ("1", extra_request_params["testrequest"]);
EXPECT_EQ("dev", extra_request_params["testsource"]);
}
} // namespace component_updater
|
