1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423
|
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/metrics/metrics_log_store.h"
#include "components/metrics/metrics_logs_event_manager.h"
#include "components/metrics/metrics_pref_names.h"
#include "components/metrics/test/test_metrics_service_client.h"
#include "components/metrics/unsent_log_store_metrics_impl.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/testing_pref_service.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace metrics {
namespace {
const char kTestPrefName[] = "TestPref";
class TestUnsentLogStore : public UnsentLogStore {
public:
explicit TestUnsentLogStore(PrefService* service)
: UnsentLogStore(std::make_unique<UnsentLogStoreMetricsImpl>(),
service,
kTestPrefName,
nullptr,
// Set to 3 so logs are not dropped in the test.
UnsentLogStore::UnsentLogStoreLimits{
.min_log_count = 3,
},
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr) {}
~TestUnsentLogStore() override = default;
TestUnsentLogStore(const TestUnsentLogStore&) = delete;
TestUnsentLogStore& operator=(const TestUnsentLogStore&) = delete;
static void RegisterPrefs(PrefRegistrySimple* registry) {
registry->RegisterListPref(kTestPrefName);
}
};
class MetricsLogStoreTest : public testing::Test {
public:
MetricsLogStoreTest() {
MetricsLogStore::RegisterPrefs(pref_service_.registry());
TestUnsentLogStore::RegisterPrefs(pref_service_.registry());
}
MetricsLogStoreTest(const MetricsLogStoreTest&) = delete;
MetricsLogStoreTest& operator=(const MetricsLogStoreTest&) = delete;
~MetricsLogStoreTest() override {}
MetricsLog* CreateLog(MetricsLog::LogType log_type) {
return new MetricsLog("0a94430b-18e5-43c8-a657-580f7e855ce1", 0, log_type,
&client_);
}
// Returns the stored number of logs of the given type.
size_t TypeCount(MetricsLog::LogType log_type) {
const char* pref = log_type == MetricsLog::INITIAL_STABILITY_LOG
? prefs::kMetricsInitialLogs
: prefs::kMetricsOngoingLogs;
return pref_service_.GetList(pref).size();
}
TestMetricsServiceClient client_;
TestingPrefServiceSimple pref_service_;
};
} // namespace
TEST_F(MetricsLogStoreTest, StandardFlow) {
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
log_store.LoadPersistedUnsentLogs();
// Make sure a new manager has a clean slate.
EXPECT_FALSE(log_store.has_staged_log());
EXPECT_FALSE(log_store.has_unsent_logs());
log_store.StoreLog("a", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
EXPECT_TRUE(log_store.has_unsent_logs());
EXPECT_FALSE(log_store.has_staged_log());
log_store.StageNextLog();
EXPECT_TRUE(log_store.has_staged_log());
EXPECT_FALSE(log_store.staged_log().empty());
log_store.DiscardStagedLog();
EXPECT_FALSE(log_store.has_staged_log());
EXPECT_FALSE(log_store.has_unsent_logs());
}
TEST_F(MetricsLogStoreTest, StoreAndLoad) {
// Set up some in-progress logging in a scoped log manager simulating the
// leadup to quitting, then persist as would be done on quit.
{
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
log_store.LoadPersistedUnsentLogs();
EXPECT_FALSE(log_store.has_unsent_logs());
log_store.StoreLog("a", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.TrimAndPersistUnsentLogs(/*overwrite_in_memory_store=*/true);
EXPECT_EQ(0U, TypeCount(MetricsLog::INITIAL_STABILITY_LOG));
EXPECT_EQ(1U, TypeCount(MetricsLog::ONGOING_LOG));
}
// Relaunch load and store more logs.
{
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
log_store.LoadPersistedUnsentLogs();
EXPECT_TRUE(log_store.has_unsent_logs());
EXPECT_EQ(0U, TypeCount(MetricsLog::INITIAL_STABILITY_LOG));
EXPECT_EQ(1U, TypeCount(MetricsLog::ONGOING_LOG));
log_store.StoreLog("x", MetricsLog::INITIAL_STABILITY_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.StageNextLog();
log_store.StoreLog("b", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
EXPECT_TRUE(log_store.has_unsent_logs());
EXPECT_TRUE(log_store.has_staged_log());
EXPECT_EQ(0U, TypeCount(MetricsLog::INITIAL_STABILITY_LOG));
EXPECT_EQ(1U, TypeCount(MetricsLog::ONGOING_LOG));
log_store.TrimAndPersistUnsentLogs(/*overwrite_in_memory_store=*/true);
EXPECT_EQ(1U, TypeCount(MetricsLog::INITIAL_STABILITY_LOG));
EXPECT_EQ(2U, TypeCount(MetricsLog::ONGOING_LOG));
}
// Relaunch and verify that once logs are handled they are not re-persisted.
{
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
log_store.LoadPersistedUnsentLogs();
EXPECT_TRUE(log_store.has_unsent_logs());
log_store.StageNextLog();
log_store.DiscardStagedLog();
// The initial log should be sent first; update the persisted storage to
// verify.
log_store.TrimAndPersistUnsentLogs(/*overwrite_in_memory_store=*/true);
EXPECT_EQ(0U, TypeCount(MetricsLog::INITIAL_STABILITY_LOG));
EXPECT_EQ(2U, TypeCount(MetricsLog::ONGOING_LOG));
// Handle the first ongoing log.
log_store.StageNextLog();
log_store.DiscardStagedLog();
EXPECT_TRUE(log_store.has_unsent_logs());
// Handle the last log.
log_store.StageNextLog();
log_store.DiscardStagedLog();
EXPECT_FALSE(log_store.has_unsent_logs());
// Nothing should have changed "on disk" since TrimAndPersistUnsentLogs
// hasn't been called again.
EXPECT_EQ(2U, TypeCount(MetricsLog::ONGOING_LOG));
// Persist, and make sure nothing is left.
log_store.TrimAndPersistUnsentLogs(/*overwrite_in_memory_store=*/true);
EXPECT_EQ(0U, TypeCount(MetricsLog::INITIAL_STABILITY_LOG));
EXPECT_EQ(0U, TypeCount(MetricsLog::ONGOING_LOG));
}
}
TEST_F(MetricsLogStoreTest, StoreStagedOngoingLog) {
// Ensure that types are preserved when storing staged logs.
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
log_store.LoadPersistedUnsentLogs();
log_store.StoreLog("a", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.StageNextLog();
log_store.TrimAndPersistUnsentLogs(/*overwrite_in_memory_store=*/true);
EXPECT_EQ(0U, TypeCount(MetricsLog::INITIAL_STABILITY_LOG));
EXPECT_EQ(1U, TypeCount(MetricsLog::ONGOING_LOG));
}
TEST_F(MetricsLogStoreTest, StoreStagedInitialLog) {
// Ensure that types are preserved when storing staged logs.
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
log_store.LoadPersistedUnsentLogs();
log_store.StoreLog("b", MetricsLog::INITIAL_STABILITY_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.StageNextLog();
log_store.TrimAndPersistUnsentLogs(/*overwrite_in_memory_store=*/true);
EXPECT_EQ(1U, TypeCount(MetricsLog::INITIAL_STABILITY_LOG));
EXPECT_EQ(0U, TypeCount(MetricsLog::ONGOING_LOG));
}
TEST_F(MetricsLogStoreTest, LargeLogDiscarding) {
// Set the size threshold very low, to verify that it's honored.
client_.set_max_ongoing_log_size_bytes(1);
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
log_store.LoadPersistedUnsentLogs();
log_store.StoreLog("persisted", MetricsLog::INITIAL_STABILITY_LOG,
LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.StoreLog("not_persisted", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
// Only the stability log should be written out, due to the threshold.
log_store.TrimAndPersistUnsentLogs(/*overwrite_in_memory_store=*/true);
EXPECT_EQ(1U, TypeCount(MetricsLog::INITIAL_STABILITY_LOG));
EXPECT_EQ(0U, TypeCount(MetricsLog::ONGOING_LOG));
}
TEST_F(MetricsLogStoreTest, DiscardOrder) {
// Ensure that the correct log is discarded if new logs are pushed while
// a log is staged.
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
log_store.LoadPersistedUnsentLogs();
log_store.StoreLog("a", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.StoreLog("b", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.StageNextLog();
log_store.StoreLog("c", MetricsLog::INITIAL_STABILITY_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
EXPECT_EQ(2U, log_store.ongoing_log_count());
EXPECT_EQ(1U, log_store.initial_log_count());
// Should discard the ongoing log staged earlier.
log_store.DiscardStagedLog();
EXPECT_EQ(1U, log_store.ongoing_log_count());
EXPECT_EQ(1U, log_store.initial_log_count());
// Initial log should be staged next.
log_store.StageNextLog();
log_store.DiscardStagedLog();
EXPECT_EQ(1U, log_store.ongoing_log_count());
EXPECT_EQ(0U, log_store.initial_log_count());
}
TEST_F(MetricsLogStoreTest, WritesToAlternateOngoingLogStore) {
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
std::unique_ptr<TestUnsentLogStore> alternate_ongoing_log_store =
std::make_unique<TestUnsentLogStore>(&pref_service_);
TestUnsentLogStore* alternate_ongoing_log_store_ptr =
alternate_ongoing_log_store.get();
// Needs to be called before writing logs to alternate ongoing store since
// SetAlternateOngoingLogStore loads persisted unsent logs and assumes that
// the native initial and ongoing unsent logs have already been loaded.
log_store.LoadPersistedUnsentLogs();
log_store.StoreLog("a", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.SetAlternateOngoingLogStore(std::move(alternate_ongoing_log_store));
log_store.StoreLog("b", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.StoreLog("c", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
EXPECT_EQ(1U, log_store.ongoing_log_count());
EXPECT_EQ(2U, alternate_ongoing_log_store_ptr->size());
}
TEST_F(MetricsLogStoreTest, AlternateOngoingLogStoreGetsEventsLogsManager) {
// Create a MetricsLogStore with a MetricsLogsEventManager.
MetricsLogsEventManager logs_event_manager;
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(), &logs_event_manager);
// Create an UnsentLogStore that will be used as an alternate ongoing log
// store.
std::unique_ptr<TestUnsentLogStore> alternate_ongoing_log_store =
std::make_unique<TestUnsentLogStore>(&pref_service_);
TestUnsentLogStore* alternate_ongoing_log_store_ptr =
alternate_ongoing_log_store.get();
// Verify that |alternate_ongoing_log_store| has no logs event manager.
EXPECT_FALSE(
alternate_ongoing_log_store_ptr->GetLogsEventManagerForTesting());
// Needs to be called before we can set |log_store|'s alternate ongoing log
// store.
log_store.LoadPersistedUnsentLogs();
// Verify that after setting |log_store|'s alternate ongoing log store to
// |alternate_ongoing_log_store|, the latter should have the former's logs
// event manager.
log_store.SetAlternateOngoingLogStore(std::move(alternate_ongoing_log_store));
EXPECT_EQ(alternate_ongoing_log_store_ptr->GetLogsEventManagerForTesting(),
&logs_event_manager);
}
TEST_F(MetricsLogStoreTest, StagesInitialOverBothOngoing) {
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
std::unique_ptr<TestUnsentLogStore> alternate_ongoing_log_store =
std::make_unique<TestUnsentLogStore>(&pref_service_);
TestUnsentLogStore* alternate_ongoing_log_store_ptr =
alternate_ongoing_log_store.get();
// Needs to be called before writing logs to alternate ongoing store since
// SetAlternateOngoingLogStore loads persisted unsent logs and assumes that
// the native initial and ongoing unsent logs have already been loaded.
log_store.LoadPersistedUnsentLogs();
log_store.StoreLog("a", MetricsLog::INITIAL_STABILITY_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.StoreLog("b", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.SetAlternateOngoingLogStore(std::move(alternate_ongoing_log_store));
log_store.StoreLog("c", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.StageNextLog();
log_store.DiscardStagedLog();
// Discarded log should be from initial_log_store.
EXPECT_EQ(0U, log_store.initial_log_count());
EXPECT_EQ(1U, log_store.ongoing_log_count());
EXPECT_EQ(1U, alternate_ongoing_log_store_ptr->size());
}
TEST_F(MetricsLogStoreTest, StagesAlternateOverOngoing) {
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
std::unique_ptr<TestUnsentLogStore> alternate_ongoing_log_store =
std::make_unique<TestUnsentLogStore>(&pref_service_);
TestUnsentLogStore* alternate_ongoing_log_store_ptr =
alternate_ongoing_log_store.get();
// Needs to be called before writing logs to alternate ongoing store since
// SetAlternateOngoingLogStore loads persisted unsent logs and assumes that
// the native initial and ongoing unsent logs have already been loaded.
log_store.LoadPersistedUnsentLogs();
log_store.StoreLog("a", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.SetAlternateOngoingLogStore(std::move(alternate_ongoing_log_store));
log_store.StoreLog("b", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.StageNextLog();
log_store.DiscardStagedLog();
// Discarded log should be from alternate_ongoing_log_store.
EXPECT_EQ(1U, log_store.ongoing_log_count());
EXPECT_EQ(0U, alternate_ongoing_log_store_ptr->size());
}
TEST_F(MetricsLogStoreTest,
UnboundAlternateOngoingLogStoreWritesToNativeOngoing) {
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
std::unique_ptr<TestUnsentLogStore> alternate_ongoing_log_store =
std::make_unique<TestUnsentLogStore>(&pref_service_);
// Needs to be called before writing logs to alternate ongoing store since
// SetAlternateOngoingLogStore loads persisted unsent logs and assumes that
// the native initial and ongoing unsent logs have already been loaded.
log_store.LoadPersistedUnsentLogs();
log_store.SetAlternateOngoingLogStore(std::move(alternate_ongoing_log_store));
// Should be written to alternate ongoing log store.
log_store.StoreLog("a", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.UnsetAlternateOngoingLogStore();
// Should be in native ongoing log store.
log_store.StoreLog("b", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
log_store.StoreLog("c", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
EXPECT_EQ(2U, log_store.ongoing_log_count());
}
TEST_F(MetricsLogStoreTest,
StageOngoingLogWhenAlternateOngoingLogStoreIsEmpty) {
MetricsLogStore log_store(&pref_service_, client_.GetStorageLimits(),
/*signing_key=*/std::string(),
/*logs_event_manager=*/nullptr);
std::unique_ptr<TestUnsentLogStore> alternate_ongoing_log_store =
std::make_unique<TestUnsentLogStore>(&pref_service_);
// Needs to be called before writing logs to alternate ongoing store since
// SetAlternateOngoingLogStore loads persisted unsent logs and assumes that
// the native initial and ongoing unsent logs have already been loaded.
log_store.LoadPersistedUnsentLogs();
// Should be written to ongoing log store.
log_store.StoreLog("a", MetricsLog::ONGOING_LOG, LogMetadata(),
MetricsLogsEventManager::CreateReason::kUnknown);
// Ensure that the log was stored in ongoing log.
EXPECT_EQ(1U, log_store.ongoing_log_count());
log_store.SetAlternateOngoingLogStore(std::move(alternate_ongoing_log_store));
log_store.StageNextLog();
log_store.DiscardStagedLog();
// Discarded log should be from ongoing.
EXPECT_EQ(0U, log_store.ongoing_log_count());
}
} // namespace metrics
|