1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350
|
// Copyright 2011 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/prefs/pref_member.h"
#include <memory>
#include "base/functional/bind.h"
#include "base/location.h"
#include "base/memory/raw_ptr.h"
#include "base/synchronization/waitable_event.h"
#include "base/task/sequenced_task_runner.h"
#include "base/task/thread_pool.h"
#include "base/test/task_environment.h"
#include "components/prefs/pref_registry_simple.h"
#include "components/prefs/testing_pref_service.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
const char kBoolPref[] = "bool";
const char kIntPref[] = "int";
const char kDoublePref[] = "double";
const char kStringPref[] = "string";
const char kStringListPref[] = "string_list";
void RegisterTestPrefs(PrefRegistrySimple* registry) {
registry->RegisterBooleanPref(kBoolPref, false);
registry->RegisterIntegerPref(kIntPref, 0);
registry->RegisterDoublePref(kDoublePref, 0.0);
registry->RegisterStringPref(kStringPref, "default");
registry->RegisterListPref(kStringListPref);
}
class GetPrefValueHelper
: public base::RefCountedThreadSafe<GetPrefValueHelper> {
public:
GetPrefValueHelper()
: value_(false),
task_runner_(base::ThreadPool::CreateSequencedTaskRunner({})) {}
void Init(const std::string& pref_name, PrefService* prefs) {
pref_.Init(pref_name, prefs);
pref_.MoveToSequence(task_runner_);
}
void Destroy() {
pref_.Destroy();
}
void FetchValue() {
base::WaitableEvent event(base::WaitableEvent::ResetPolicy::MANUAL,
base::WaitableEvent::InitialState::NOT_SIGNALED);
ASSERT_TRUE(task_runner_->PostTask(
FROM_HERE,
base::BindOnce(&GetPrefValueHelper::GetPrefValue, this, &event)));
event.Wait();
}
bool value() { return value_; }
private:
friend class base::RefCountedThreadSafe<GetPrefValueHelper>;
~GetPrefValueHelper() {}
void GetPrefValue(base::WaitableEvent* event) {
value_ = pref_.GetValue();
event->Signal();
}
BooleanPrefMember pref_;
bool value_;
// The sequence |pref_| runs on.
scoped_refptr<base::SequencedTaskRunner> task_runner_;
};
class PrefMemberTestClass {
public:
explicit PrefMemberTestClass(PrefService* prefs)
: observe_cnt_(0), prefs_(prefs) {
str_.Init(kStringPref, prefs,
base::BindRepeating(&PrefMemberTestClass::OnPreferenceChanged,
base::Unretained(this)));
}
void OnPreferenceChanged(const std::string& pref_name) {
EXPECT_EQ(pref_name, kStringPref);
EXPECT_EQ(str_.GetValue(), prefs_->GetString(kStringPref));
EXPECT_EQ(str_.IsDefaultValue(),
prefs_->FindPreference(kStringPref)->IsDefaultValue());
++observe_cnt_;
}
StringPrefMember str_;
int observe_cnt_;
private:
raw_ptr<PrefService> prefs_;
};
} // anonymous namespace
class PrefMemberTest : public testing::Test {
base::test::TaskEnvironment task_environment_;
};
TEST_F(PrefMemberTest, BasicGetAndSet) {
TestingPrefServiceSimple prefs;
RegisterTestPrefs(prefs.registry());
// Test bool
BooleanPrefMember boolean;
boolean.Init(kBoolPref, &prefs);
// Check the defaults
EXPECT_FALSE(prefs.GetBoolean(kBoolPref));
EXPECT_FALSE(boolean.GetValue());
EXPECT_FALSE(*boolean);
EXPECT_TRUE(boolean.IsDefaultValue());
// Try changing through the member variable.
boolean.SetValue(true);
EXPECT_TRUE(boolean.GetValue());
EXPECT_TRUE(prefs.GetBoolean(kBoolPref));
EXPECT_TRUE(*boolean);
EXPECT_FALSE(boolean.IsDefaultValue());
// Try changing back through the pref.
prefs.SetBoolean(kBoolPref, false);
EXPECT_FALSE(prefs.GetBoolean(kBoolPref));
EXPECT_FALSE(boolean.GetValue());
EXPECT_FALSE(*boolean);
EXPECT_FALSE(boolean.IsDefaultValue());
// Test int
IntegerPrefMember integer;
integer.Init(kIntPref, &prefs);
// Check the defaults
EXPECT_EQ(0, prefs.GetInteger(kIntPref));
EXPECT_EQ(0, integer.GetValue());
EXPECT_EQ(0, *integer);
EXPECT_TRUE(integer.IsDefaultValue());
// Try changing through the member variable.
integer.SetValue(5);
EXPECT_EQ(5, integer.GetValue());
EXPECT_EQ(5, prefs.GetInteger(kIntPref));
EXPECT_EQ(5, *integer);
EXPECT_FALSE(integer.IsDefaultValue());
// Try changing back through the pref.
prefs.SetInteger(kIntPref, 2);
EXPECT_EQ(2, prefs.GetInteger(kIntPref));
EXPECT_EQ(2, integer.GetValue());
EXPECT_EQ(2, *integer);
EXPECT_FALSE(integer.IsDefaultValue());
// Test double
DoublePrefMember double_member;
double_member.Init(kDoublePref, &prefs);
// Check the defaults
EXPECT_EQ(0.0, prefs.GetDouble(kDoublePref));
EXPECT_EQ(0.0, double_member.GetValue());
EXPECT_EQ(0.0, *double_member);
EXPECT_TRUE(double_member.IsDefaultValue());
// Try changing through the member variable.
double_member.SetValue(1.0);
EXPECT_EQ(1.0, double_member.GetValue());
EXPECT_EQ(1.0, prefs.GetDouble(kDoublePref));
EXPECT_EQ(1.0, *double_member);
EXPECT_FALSE(double_member.IsDefaultValue());
// Try changing back through the pref.
prefs.SetDouble(kDoublePref, 3.0);
EXPECT_EQ(3.0, prefs.GetDouble(kDoublePref));
EXPECT_EQ(3.0, double_member.GetValue());
EXPECT_EQ(3.0, *double_member);
EXPECT_FALSE(double_member.IsDefaultValue());
// Test string
StringPrefMember string;
string.Init(kStringPref, &prefs);
// Check the defaults
EXPECT_EQ("default", prefs.GetString(kStringPref));
EXPECT_EQ("default", string.GetValue());
EXPECT_EQ("default", *string);
EXPECT_TRUE(string.IsDefaultValue());
// Try changing through the member variable.
string.SetValue("foo");
EXPECT_EQ("foo", string.GetValue());
EXPECT_EQ("foo", prefs.GetString(kStringPref));
EXPECT_EQ("foo", *string);
EXPECT_FALSE(string.IsDefaultValue());
// Try changing back through the pref.
prefs.SetString(kStringPref, "bar");
EXPECT_EQ("bar", prefs.GetString(kStringPref));
EXPECT_EQ("bar", string.GetValue());
EXPECT_EQ("bar", *string);
EXPECT_FALSE(string.IsDefaultValue());
// Test string list
base::Value::List expected_list;
std::vector<std::string> expected_vector;
StringListPrefMember string_list;
string_list.Init(kStringListPref, &prefs);
// Check the defaults
EXPECT_EQ(expected_list, prefs.GetList(kStringListPref));
EXPECT_EQ(expected_vector, string_list.GetValue());
EXPECT_EQ(expected_vector, *string_list);
EXPECT_TRUE(string_list.IsDefaultValue());
// Try changing through the pref member.
expected_list.Append("foo");
expected_vector.push_back("foo");
string_list.SetValue(expected_vector);
EXPECT_EQ(expected_list, prefs.GetList(kStringListPref));
EXPECT_EQ(expected_vector, string_list.GetValue());
EXPECT_EQ(expected_vector, *string_list);
EXPECT_FALSE(string_list.IsDefaultValue());
// Try adding through the pref.
expected_list.Append("bar");
expected_vector.push_back("bar");
prefs.SetList(kStringListPref, expected_list.Clone());
EXPECT_EQ(expected_list, prefs.GetList(kStringListPref));
EXPECT_EQ(expected_vector, string_list.GetValue());
EXPECT_EQ(expected_vector, *string_list);
EXPECT_FALSE(string_list.IsDefaultValue());
// Try removing through the pref.
expected_list.erase(expected_list.begin());
expected_vector.erase(expected_vector.begin());
prefs.SetList(kStringListPref, expected_list.Clone());
EXPECT_EQ(expected_list, prefs.GetList(kStringListPref));
EXPECT_EQ(expected_vector, string_list.GetValue());
EXPECT_EQ(expected_vector, *string_list);
EXPECT_FALSE(string_list.IsDefaultValue());
}
TEST_F(PrefMemberTest, InvalidList) {
// Set the vector to an initial good value.
std::vector<std::string> expected_vector;
expected_vector.push_back("foo");
// Try to add a valid list first.
base::Value list(base::Value::Type::LIST);
list.GetList().Append("foo");
std::vector<std::string> vector;
EXPECT_TRUE(subtle::PrefMemberVectorStringUpdate(list, &vector));
EXPECT_EQ(expected_vector, vector);
// Now try to add an invalid list. |vector| should not be changed.
list.GetList().Append(0);
EXPECT_FALSE(subtle::PrefMemberVectorStringUpdate(list, &vector));
EXPECT_EQ(expected_vector, vector);
}
TEST_F(PrefMemberTest, TwoPrefs) {
// Make sure two DoublePrefMembers stay in sync.
TestingPrefServiceSimple prefs;
RegisterTestPrefs(prefs.registry());
DoublePrefMember pref1;
pref1.Init(kDoublePref, &prefs);
DoublePrefMember pref2;
pref2.Init(kDoublePref, &prefs);
pref1.SetValue(2.3);
EXPECT_EQ(2.3, *pref2);
pref2.SetValue(3.5);
EXPECT_EQ(3.5, *pref1);
prefs.SetDouble(kDoublePref, 4.2);
EXPECT_EQ(4.2, *pref1);
EXPECT_EQ(4.2, *pref2);
}
TEST_F(PrefMemberTest, Observer) {
TestingPrefServiceSimple prefs;
RegisterTestPrefs(prefs.registry());
PrefMemberTestClass test_obj(&prefs);
EXPECT_EQ("default", *test_obj.str_);
EXPECT_TRUE(test_obj.str_.IsDefaultValue());
// Changing the pref from the default value to an explicitly-set version of
// the same value fires the observer. The caller may be sensitive to
// IsDefaultValue().
prefs.SetString(kStringPref, "default");
EXPECT_EQ("default", *test_obj.str_);
EXPECT_EQ(1, test_obj.observe_cnt_);
EXPECT_FALSE(test_obj.str_.IsDefaultValue());
// Calling SetValue should not fire the observer.
test_obj.str_.SetValue("hello");
EXPECT_EQ(1, test_obj.observe_cnt_);
EXPECT_EQ("hello", prefs.GetString(kStringPref));
// Changing the pref does fire the observer.
prefs.SetString(kStringPref, "world");
EXPECT_EQ(2, test_obj.observe_cnt_);
EXPECT_EQ("world", *(test_obj.str_));
// Not changing the value should not fire the observer.
prefs.SetString(kStringPref, "world");
EXPECT_EQ(2, test_obj.observe_cnt_);
EXPECT_EQ("world", *(test_obj.str_));
prefs.SetString(kStringPref, "hello");
EXPECT_EQ(3, test_obj.observe_cnt_);
EXPECT_EQ("hello", prefs.GetString(kStringPref));
}
TEST_F(PrefMemberTest, NoInit) {
// Make sure not calling Init on a PrefMember doesn't cause problems.
IntegerPrefMember pref;
}
TEST_F(PrefMemberTest, MoveToSequence) {
TestingPrefServiceSimple prefs;
scoped_refptr<GetPrefValueHelper> helper(new GetPrefValueHelper());
RegisterTestPrefs(prefs.registry());
helper->Init(kBoolPref, &prefs);
helper->FetchValue();
EXPECT_FALSE(helper->value());
prefs.SetBoolean(kBoolPref, true);
helper->FetchValue();
EXPECT_TRUE(helper->value());
helper->Destroy();
helper->FetchValue();
EXPECT_TRUE(helper->value());
}
|