1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664
|
// Copyright 2011 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/url_formatter/url_fixer.h"
#include <stddef.h>
#include <stdlib.h>
#include <string>
#include "base/base_paths.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "net/base/filename_util.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
#include "url/third_party/mozilla/url_parse.h"
struct SegmentCase {
const std::string input;
const std::string result;
const url::Component scheme;
const url::Component username;
const url::Component password;
const url::Component host;
const url::Component port;
const url::Component path;
const url::Component query;
const url::Component ref;
};
static const SegmentCase segment_cases[] = {
{
"http://www.google.com/", "http", url::Component(0, 4), // scheme
url::Component(), // username
url::Component(), // password
url::Component(7, 14), // host
url::Component(), // port
url::Component(21, 1), // path
url::Component(), // query
url::Component(), // ref
},
{
"aBoUt:vErSiOn", "about", url::Component(0, 5), // scheme
url::Component(), // username
url::Component(), // password
url::Component(6, 7), // host
url::Component(), // port
url::Component(), // path
url::Component(), // query
url::Component(), // ref
},
{
"about:host/path?query#ref", "about", url::Component(0, 5), // scheme
url::Component(), // username
url::Component(), // password
url::Component(6, 4), // host
url::Component(), // port
url::Component(10, 5), // path
url::Component(16, 5), // query
url::Component(22, 3), // ref
},
{
"about://host/path?query#ref", "about", url::Component(0, 5), // scheme
url::Component(), // username
url::Component(), // password
url::Component(8, 4), // host
url::Component(), // port
url::Component(12, 5), // path
url::Component(18, 5), // query
url::Component(24, 3), // ref
},
{
"chrome:host/path?query#ref", "chrome", url::Component(0, 6), // scheme
url::Component(), // username
url::Component(), // password
url::Component(7, 4), // host
url::Component(), // port
url::Component(11, 5), // path
url::Component(17, 5), // query
url::Component(23, 3), // ref
},
{
"chrome://host/path?query#ref", "chrome",
url::Component(0, 6), // scheme
url::Component(), // username
url::Component(), // password
url::Component(9, 4), // host
url::Component(), // port
url::Component(13, 5), // path
url::Component(19, 5), // query
url::Component(25, 3), // ref
},
{
" www.google.com:124?foo#", "http",
url::Component(), // scheme
url::Component(), // username
url::Component(), // password
url::Component(4, 14), // host
url::Component(19, 3), // port
url::Component(), // path
url::Component(23, 3), // query
url::Component(27, 0), // ref
},
{
" \u00A0 www.google.com", "http",
url::Component(), // scheme
url::Component(), // username
url::Component(), // password
url::Component(4, 14), // host
url::Component(), // port
url::Component(), // path
url::Component(), // query
url::Component(), // ref
},
{
"user@www.google.com", "http",
url::Component(), // scheme
url::Component(0, 4), // username
url::Component(), // password
url::Component(5, 14), // host
url::Component(), // port
url::Component(), // path
url::Component(), // query
url::Component(), // ref
},
{
"ftp:/user:P:a$$Wd@..ftp.google.com...::23///pub?foo#bar", "ftp",
url::Component(0, 3), // scheme
url::Component(5, 4), // username
url::Component(10, 7), // password
url::Component(18, 20), // host
url::Component(39, 2), // port
url::Component(41, 6), // path
url::Component(48, 3), // query
url::Component(52, 3), // ref
},
{
"[2001:db8::1]/path", "http",
url::Component(), // scheme
url::Component(), // username
url::Component(), // password
url::Component(0, 13), // host
url::Component(), // port
url::Component(13, 5), // path
url::Component(), // query
url::Component(), // ref
},
{
"[::1]", "http",
url::Component(), // scheme
url::Component(), // username
url::Component(), // password
url::Component(0, 5), // host
url::Component(), // port
url::Component(), // path
url::Component(), // query
url::Component(), // ref
},
// Incomplete IPv6 addresses (will not canonicalize).
{
"[2001:4860:", "http",
url::Component(), // scheme
url::Component(), // username
url::Component(), // password
url::Component(0, 11), // host
url::Component(), // port
url::Component(), // path
url::Component(), // query
url::Component(), // ref
},
{
"[2001:4860:/foo", "http",
url::Component(), // scheme
url::Component(), // username
url::Component(), // password
url::Component(0, 11), // host
url::Component(), // port
url::Component(11, 4), // path
url::Component(), // query
url::Component(), // ref
},
{
"http://:b005::68]", "http", url::Component(0, 4), // scheme
url::Component(), // username
url::Component(), // password
url::Component(7, 10), // host
url::Component(), // port
url::Component(), // path
url::Component(), // query
url::Component(), // ref
},
{
":b005::68]", "http",
url::Component(), // scheme
url::Component(), // username
url::Component(), // password
url::Component(1, 9), // host
url::Component(), // port
url::Component(), // path
url::Component(), // query
url::Component(), // ref
},
{
"file://host/path/file#ref", "file", url::Component(0, 4), // scheme
url::Component(), // username
url::Component(), // password
url::Component(7, 4), // host
url::Component(), // port
url::Component(11, 10), // path
url::Component(), // query
url::Component(22, 3), // ref
},
{
"file:///notahost/path/file#ref", "file",
url::Component(0, 4), // scheme
url::Component(), // username
url::Component(), // password
url::Component(), // host
url::Component(), // port
url::Component(7, 19), // path
url::Component(), // query
url::Component(27, 3), // ref
},
#if BUILDFLAG(IS_WIN)
{
"c:/notahost/path/file#ref", "file",
url::Component(), // scheme
url::Component(), // username
url::Component(), // password
url::Component(), // host
url::Component(), // port
url::Component(0, 21), // path
url::Component(), // query
url::Component(22, 3), // ref
},
#elif BUILDFLAG(IS_POSIX)
{
"~/notahost/path/file#ref", "file",
url::Component(), // scheme
url::Component(), // username
url::Component(), // password
url::Component(), // host
url::Component(), // port
url::Component(0, 20), // path
url::Component(), // query
url::Component(21, 3), // ref
},
#endif
{
"devtools://bundled/devtools/inspector.html?ws=localhost:9221",
"devtools", url::Component(0, 8), // scheme
url::Component(), // username
url::Component(), // password
url::Component(11, 7), // host
url::Component(), // port
url::Component(18, 24), // path
url::Component(43, 17), // query
url::Component(), // ref
},
};
typedef testing::Test URLFixerTest;
TEST(URLFixerTest, SegmentURL) {
std::string result;
url::Parsed parts;
for (size_t i = 0; i < std::size(segment_cases); ++i) {
SegmentCase value = segment_cases[i];
SCOPED_TRACE(testing::Message() << "test #" << i << ": " << value.input);
result = url_formatter::SegmentURL(value.input, &parts);
EXPECT_EQ(value.result, result);
EXPECT_EQ(value.scheme, parts.scheme);
EXPECT_EQ(value.username, parts.username);
EXPECT_EQ(value.password, parts.password);
EXPECT_EQ(value.host, parts.host);
EXPECT_EQ(value.port, parts.port);
EXPECT_EQ(value.path, parts.path);
EXPECT_EQ(value.query, parts.query);
EXPECT_EQ(value.ref, parts.ref);
}
}
// Creates a file and returns its full name as well as the decomposed
// version. Example:
// full_path = "c:\foo\bar.txt"
// dir = "c:\foo"
// file_name = "bar.txt"
static bool MakeTempFile(const base::FilePath& dir,
const base::FilePath& file_name,
base::FilePath* full_path) {
*full_path = dir.Append(file_name);
return base::WriteFile(*full_path, "");
}
// Returns true if the given URL is a file: URL that matches the given file
static bool IsMatchingFileURL(const std::string& url,
const base::FilePath& full_file_path) {
if (url.length() <= 8)
return false;
if (std::string("file:///") != url.substr(0, 8))
return false; // no file:/// prefix
if (url.find('\\') != std::string::npos)
return false; // contains backslashes
base::FilePath derived_path;
net::FileURLToFilePath(GURL(url), &derived_path);
return base::FilePath::CompareEqualIgnoreCase(derived_path.value(),
full_file_path.value());
}
struct FixupCase {
const std::string input;
const std::string output;
} fixup_cases[] = {
{"www.google.com", "http://www.google.com/"},
{" www.google.com ", "http://www.google.com/"},
{" foo.com/asdf bar", "http://foo.com/asdf%20%20bar"},
{"..www.google.com..", "http://www.google.com./"},
{"http://......", "http://....../"},
{"http://host.com:ninety-two/", "http://host.com:ninety-two/"},
{"http://host.com:ninety-two?foo", "http://host.com:ninety-two/?foo"},
{"google.com:123", "http://google.com:123/"},
{"about:", "chrome://version/"},
{"about:foo", "chrome://foo/"},
{"about:version", "chrome://version/"},
{"about:blank", "about:blank"},
{"About:blaNk", "about:blank"},
{"about:blank#blah", "about:blank#blah"},
{"about:blank/#blah", "about:blank/#blah"},
{"about:srcdoc", "about:srcdoc"},
{"about:srcdoc#blah", "about:srcdoc#blah"},
{"about:srcdoc/#blah", "about:srcdoc/#blah"},
{"about:usr:pwd@hst:20/pth?qry#ref", "chrome://hst/pth?qry#ref"},
{"about://usr:pwd@hst/pth?qry#ref", "chrome://hst/pth?qry#ref"},
{"chrome:usr:pwd@hst/pth?qry#ref", "chrome://hst/pth?qry#ref"},
{"chrome://usr:pwd@hst/pth?qry#ref", "chrome://hst/pth?qry#ref"},
{"www:123", "http://www:123/"},
{" www:123", "http://www:123/"},
{"www.google.com?foo", "http://www.google.com/?foo"},
{"www.google.com#foo", "http://www.google.com/#foo"},
{"www.google.com?", "http://www.google.com/?"},
{"www.google.com#", "http://www.google.com/#"},
{"www.google.com:123?foo#bar", "http://www.google.com:123/?foo#bar"},
{"user@www.google.com", "http://user@www.google.com/"},
{"\xE6\xB0\xB4.com", "http://xn--1rw.com/"},
// It would be better if this next case got treated as http, but I don't see
// a clean way to guess this isn't the new-and-exciting "user" scheme.
{"user:passwd@www.google.com:8080/", "user:passwd@www.google.com:8080/"},
// {"file:///c:/foo/bar%20baz.txt", "file:///C:/foo/bar%20baz.txt"},
// URLs which end with 0x85 (NEL in ISO-8859).
{"http://example.com/s?q=\xD0\x85", "http://example.com/s?q=%D0%85"},
{"http://example.com/s?q=\xEC\x97\x85", "http://example.com/s?q=%EC%97%85"},
{"http://example.com/s?q=\xF0\x90\x80\x85",
"http://example.com/s?q=%F0%90%80%85"},
// URLs which end with 0xA0 (non-break space in ISO-8859).
{"http://example.com/s?q=\xD0\xA0", "http://example.com/s?q=%D0%A0"},
{"http://example.com/s?q=\xEC\x97\xA0", "http://example.com/s?q=%EC%97%A0"},
{"http://example.com/s?q=\xF0\x90\x80\xA0",
"http://example.com/s?q=%F0%90%80%A0"},
// URLs containing Unicode non-characters.
{"http://example.com/s?q=\xEF\xB7\x90", // U+FDD0
"http://example.com/s?q=%EF%B7%90"},
{"http://example.com/s?q=\xEF\xBF\xBE", // U+FFFE
"http://example.com/s?q=%EF%BF%BE"},
{"http://example.com/s?q=\xEF\xBF\xBF", // U+FFFF
"http://example.com/s?q=%EF%BF%BF"},
{"http://example.com/s?q=\xF4\x8F\xBF\xBE", // U+10FFFE
"http://example.com/s?q=%F4%8F%BF%BE"},
{"http://example.com/s?q=\xF4\x8F\xBF\xBF", // U+10FFFF
"http://example.com/s?q=%F4%8F%BF%BF"},
// URLs containing IPv6 literals.
{"[2001:db8::2]", "http://[2001:db8::2]/"},
{"[::]:80", "http://[::]/"},
{"[::]:80/path", "http://[::]/path"},
{"[::]:180/path", "http://[::]:180/path"},
// TODO(pmarks): Maybe we should parse bare IPv6 literals someday. Currently
// the first colon is treated as a scheme separator, and we default
// unspecified schemes to "http".
{"::1", "http://:1/"},
// Semicolon as scheme separator for standard schemes.
{"http;//www.google.com/", "http://www.google.com/"},
{"about;help", "chrome://help/"},
// Semicolon in non-standard schemes is not replaced by colon.
{"whatsup;//fool", "http://whatsup;//fool"},
// Semicolon left as-is in URL itself.
{"http://host/port?query;moar", "http://host/port?query;moar"},
// Fewer slashes than expected.
{"http;www.google.com/", "http://www.google.com/"},
{"http;/www.google.com/", "http://www.google.com/"},
// Semicolon at start.
{";http://www.google.com/", "http://;http//www.google.com/"},
// DevTools scheme.
{"devtools://bundled/devtools/node.html",
"devtools://bundled/devtools/node.html"},
// DevTools scheme with websocket query.
{"devtools://bundled/devtools/inspector.html?ws=ws://localhost:9222/guid",
"devtools://bundled/devtools/inspector.html?ws=ws://localhost:9222/guid"},
// host:123 should be rewritten to http://host:123/, but only if the port
// number is valid - in particular telephone numbers are not port numbers
// (see also SendTabToSelfUtilTest.ShouldNotOfferFeatureForTelephoneLink).
{"host:123", "http://host:123/"},
{"host:80", "http://host/"}, // default port is removed
{"host:9999", "http://host:9999/"},
{"host:00009999", "http://host:9999/"}, // leading zeros are removed
{"host:0", "http://host:0/"}, // min valid port
{"host:65535", "http://host:65535/"}, // max valid port
{"host:-1", "host:-1"},
{"host:65536", "host:65536"},
{"host:18446744073709551619", "host:18446744073709551619"}, // > uint64.max
{"host:", "host:"},
{"host: 123", "host: 123"},
{"host:+123", "host:+123"},
{"host:1.23", "host:1.23"},
{"host:x", "host:x"},
{"host:᠐", "host:%E1%A0%90"}, // non-ASCII digit (U+1810)
{"host:𝟨", "host:%F0%9D%9F%A8"}, // non-ASCII digit (U+1D7E8)
{"tel:12345678901", "tel:12345678901"},
{"tel:123-456-78901", "tel:123-456-78901"},
// Double colon after host should not convert to an empty port.
{"foo.com::/server-redirect?http%3A%2F%2Fbar.com%2Ftitle2.html",
"http://foo.com/server-redirect?http%3A%2F%2Fbar.com%2Ftitle2.html"},
};
TEST(URLFixerTest, FixupURL) {
for (const auto& value : fixup_cases) {
GURL actual_output = url_formatter::FixupURL(value.input, std::string());
EXPECT_EQ(value.output, actual_output.possibly_invalid_spec())
<< "input: " << value.input;
// Fixup URL should never translate a valid GURL into an invalid one.
if (GURL(value.input).is_valid())
EXPECT_TRUE(actual_output.is_valid());
}
// Check the TLD-appending functionality.
FixupCase tld_cases[] = {
{"somedomainthatwillnotbeagtld",
"http://www.somedomainthatwillnotbeagtld.com/"},
{"somedomainthatwillnotbeagtld.",
"http://www.somedomainthatwillnotbeagtld.com/"},
{"somedomainthatwillnotbeagtld..",
"http://www.somedomainthatwillnotbeagtld.com/"},
{".somedomainthatwillnotbeagtld",
"http://www.somedomainthatwillnotbeagtld.com/"},
{"www.somedomainthatwillnotbeagtld",
"http://www.somedomainthatwillnotbeagtld.com/"},
{"somedomainthatwillnotbeagtld.com",
"http://somedomainthatwillnotbeagtld.com/"},
{"http://somedomainthatwillnotbeagtld",
"http://www.somedomainthatwillnotbeagtld.com/"},
{"..somedomainthatwillnotbeagtld..",
"http://www.somedomainthatwillnotbeagtld.com/"},
{"http://www.somedomainthatwillnotbeagtld",
"http://www.somedomainthatwillnotbeagtld.com/"},
{"9999999999999999", "http://www.9999999999999999.com/"},
{"somedomainthatwillnotbeagtld/foo",
"http://www.somedomainthatwillnotbeagtld.com/foo"},
{"somedomainthatwillnotbeagtld.com/foo",
"http://somedomainthatwillnotbeagtld.com/foo"},
{"somedomainthatwillnotbeagtld/?foo=.com",
"http://www.somedomainthatwillnotbeagtld.com/?foo=.com"},
{"www.somedomainthatwillnotbeagtld/?foo=www.",
"http://www.somedomainthatwillnotbeagtld.com/?foo=www."},
{"somedomainthatwillnotbeagtld.com/?foo=.com",
"http://somedomainthatwillnotbeagtld.com/?foo=.com"},
{"http://www.somedomainthatwillnotbeagtld.com",
"http://www.somedomainthatwillnotbeagtld.com/"},
{"somedomainthatwillnotbeagtld:123",
"http://www.somedomainthatwillnotbeagtld.com:123/"},
{"http://somedomainthatwillnotbeagtld:123",
"http://www.somedomainthatwillnotbeagtld.com:123/"},
};
for (const auto& value : tld_cases) {
EXPECT_EQ(
value.output,
url_formatter::FixupURL(value.input, "com").possibly_invalid_spec());
}
}
// Test different types of file inputs to URIFixerUpper::FixupURL. This
// doesn't go into the nice array of fixups above since the file input
// has to exist.
TEST(URLFixerTest, FixupFile) {
// this "original" filename is the one we tweak to get all the variations
base::ScopedTempDir temp_dir_;
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
base::FilePath original;
ASSERT_TRUE(MakeTempFile(
temp_dir_.GetPath(),
base::FilePath(FILE_PATH_LITERAL("url fixer upper existing file.txt")),
&original));
// reference path
GURL golden(net::FilePathToFileURL(original));
// c:\foo\bar.txt -> file:///c:/foo/bar.txt (basic)
GURL fixedup(url_formatter::FixupURL(original.AsUTF8Unsafe(), std::string()));
EXPECT_EQ(golden, fixedup);
// TODO(port): Make some equivalent tests for posix.
#if BUILDFLAG(IS_WIN)
// c|/foo\bar.txt -> file:///c:/foo/bar.txt (pipe allowed instead of colon)
std::string cur(base::WideToUTF8(original.value()));
EXPECT_EQ(':', cur[1]);
cur[1] = '|';
EXPECT_EQ(golden, url_formatter::FixupURL(cur, std::string()));
FixupCase cases[] = {
{"c:\\Non-existent%20file.txt", "file:///C:/Non-existent%2520file.txt"},
// \\foo\bar.txt -> file://foo/bar.txt
// UNC paths, this file won't exist, but since there are no escapes, it
// should be returned just converted to a file: URL.
{"\\\\NonexistentHost\\foo\\bar.txt", "file://nonexistenthost/foo/bar.txt"},
// We do this strictly, like IE8, which only accepts this form using
// backslashes and not forward ones. Turning "//foo" into "http" matches
// Firefox and IE, silly though it may seem (it falls out of adding "http"
// as the default protocol if you haven't entered one).
{"//NonexistentHost\\foo/bar.txt", "http://nonexistenthost/foo/bar.txt"},
{"file:///C:/foo/bar", "file:///C:/foo/bar"},
// Much of the work here comes from GURL's canonicalization stage.
{"file://C:/foo/bar", "file:///C:/foo/bar"},
{"file:c:", "file:///C:"},
{"file:c:WINDOWS", "file:///C:/WINDOWS"},
{"file:c|Program Files", "file:///C:/Program%20Files"},
{"file:/file", "file://file/"},
{"file:////////c:\\foo", "file:///C:/foo"},
{"file://server/folder/file", "file://server/folder/file"},
// These are fixups we don't do, but could consider:
// {"file:///foo:/bar", "file://foo/bar"},
// {"file:/\\/server\\folder/file", "file://server/folder/file"},
};
#elif BUILDFLAG(IS_POSIX) || BUILDFLAG(IS_FUCHSIA)
#if BUILDFLAG(IS_APPLE)
#define HOME "/Users/"
#else
#define HOME "/home/"
#endif
url_formatter::home_directory_override = "/foo";
FixupCase cases[] = {
// File URLs go through GURL, which tries to escape intelligently.
{"/A%20non-existent file.txt", "file:///A%2520non-existent%20file.txt"},
// A plain "/" refers to the root.
{"/", "file:///"},
// These rely on the above home_directory_override.
{"~", "file:///foo"},
{"~/bar", "file:///foo/bar"},
// References to other users' homedirs.
{"~foo", "file://" HOME "foo"},
{"~x/blah", "file://" HOME "x/blah"},
};
#endif
for (const auto& value : cases) {
EXPECT_EQ(value.output, url_formatter::FixupURL(value.input, std::string())
.possibly_invalid_spec());
}
EXPECT_TRUE(base::DeleteFile(original));
}
TEST(URLFixerTest, FixupRelativeFile) {
base::FilePath full_path;
base::FilePath file_part(
FILE_PATH_LITERAL("url_fixer_upper_existing_file.txt"));
base::ScopedTempDir temp_dir_;
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
ASSERT_TRUE(MakeTempFile(temp_dir_.GetPath(), file_part, &full_path));
full_path = base::MakeAbsoluteFilePath(full_path);
ASSERT_FALSE(full_path.empty());
// make sure we pass through good URLs
for (const auto& value : fixup_cases) {
base::FilePath input = base::FilePath::FromUTF8Unsafe(value.input);
EXPECT_EQ(value.output,
url_formatter::FixupRelativeFile(temp_dir_.GetPath(), input)
.possibly_invalid_spec())
<< "input: " << value.input;
}
// make sure the existing file got fixed-up to a file URL, and that there
// are no backslashes
EXPECT_TRUE(IsMatchingFileURL(
url_formatter::FixupRelativeFile(temp_dir_.GetPath(), file_part)
.possibly_invalid_spec(),
full_path));
EXPECT_TRUE(base::DeleteFile(full_path));
// create a filename we know doesn't exist and make sure it doesn't get
// fixed up to a file URL
base::FilePath nonexistent_file(
FILE_PATH_LITERAL("url_fixer_upper_nonexistent_file.txt"));
std::string fixedup(
url_formatter::FixupRelativeFile(temp_dir_.GetPath(), nonexistent_file)
.possibly_invalid_spec());
EXPECT_NE(std::string("file:///"), fixedup.substr(0, 8));
EXPECT_FALSE(IsMatchingFileURL(fixedup, nonexistent_file));
// make a subdir to make sure relative paths with directories work, also
// test spaces:
// "app_dir\url fixer-upper dir\url fixer-upper existing file.txt"
base::FilePath sub_dir(FILE_PATH_LITERAL("url fixer-upper dir"));
base::FilePath sub_file(
FILE_PATH_LITERAL("url fixer-upper existing file.txt"));
base::FilePath new_dir = temp_dir_.GetPath().Append(sub_dir);
base::CreateDirectory(new_dir);
ASSERT_TRUE(MakeTempFile(new_dir, sub_file, &full_path));
full_path = base::MakeAbsoluteFilePath(full_path);
ASSERT_FALSE(full_path.empty());
// test file in the subdir
base::FilePath relative_file = sub_dir.Append(sub_file);
EXPECT_TRUE(IsMatchingFileURL(
url_formatter::FixupRelativeFile(temp_dir_.GetPath(), relative_file)
.possibly_invalid_spec(),
full_path));
// test file in the subdir with different slashes and escaping.
base::FilePath::StringType relative_file_str = sub_dir.value() +
FILE_PATH_LITERAL("/") + sub_file.value();
base::ReplaceSubstringsAfterOffset(&relative_file_str, 0,
FILE_PATH_LITERAL(" "), FILE_PATH_LITERAL("%20"));
EXPECT_TRUE(IsMatchingFileURL(
url_formatter::FixupRelativeFile(temp_dir_.GetPath(),
base::FilePath(relative_file_str))
.possibly_invalid_spec(),
full_path));
// test relative directories and duplicate slashes
// (should resolve to the same file as above)
relative_file_str = sub_dir.value() + FILE_PATH_LITERAL("/../") +
sub_dir.value() + FILE_PATH_LITERAL("///./") + sub_file.value();
EXPECT_TRUE(IsMatchingFileURL(
url_formatter::FixupRelativeFile(temp_dir_.GetPath(),
base::FilePath(relative_file_str))
.possibly_invalid_spec(),
full_path));
// done with the subdir
EXPECT_TRUE(base::DeleteFile(full_path));
EXPECT_TRUE(base::DeletePathRecursively(new_dir));
// Test that an obvious HTTP URL isn't accidentally treated as an absolute
// file path (on account of system-specific craziness).
base::FilePath empty_path;
base::FilePath http_url_path(FILE_PATH_LITERAL("http://../"));
EXPECT_TRUE(url_formatter::FixupRelativeFile(empty_path, http_url_path)
.SchemeIs("http"));
}
|