1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "net/dns/dns_config_service_android.h"
#include <memory>
#include <string>
#include <utility>
#include <vector>
#include "base/android/build_info.h"
#include "base/functional/bind.h"
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_refptr.h"
#include "base/test/task_environment.h"
#include "net/android/network_library.h"
#include "net/base/ip_endpoint.h"
#include "net/base/mock_network_change_notifier.h"
#include "net/base/network_change_notifier.h"
#include "net/dns/dns_config.h"
#include "net/test/test_with_task_environment.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace net::internal {
namespace {
const IPEndPoint kNameserver1(IPAddress(1, 2, 3, 4), 53);
const IPEndPoint kNameserver2(IPAddress(1, 2, 3, 8), 53);
// DnsConfigServiceAndroid uses a simplified implementation for Android versions
// before relevant APIs were added in Android M. Most of these tests are
// targeting the logic used in M and beyond.
#define SKIP_ANDROID_VERSIONS_BEFORE_M() \
{ \
if (base::android::BuildInfo::GetInstance()->sdk_int() < \
base::android::SDK_VERSION_MARSHMALLOW) { \
GTEST_SKIP() << "Test not necessary or compatible with pre-M."; \
} \
}
// RefCountedThreadSafe to allow safe usage and reference storage in
// DnsConfigServiceAndroid's off-sequence utility classes.
class MockDnsServerGetter
: public base::RefCountedThreadSafe<MockDnsServerGetter> {
public:
void set_retval(bool retval) { retval_ = retval; }
void set_dns_servers(std::vector<IPEndPoint> dns_servers) {
dns_servers_ = std::move(dns_servers);
}
void set_dns_over_tls_active(bool dns_over_tls_active) {
dns_over_tls_active_ = dns_over_tls_active;
}
void set_dns_over_tls_hostname(std::string dns_over_tls_hostname) {
dns_over_tls_hostname_ = std::move(dns_over_tls_hostname);
}
void set_search_suffixes(std::vector<std::string> search_suffixes) {
search_suffixes_ = std::move(search_suffixes);
}
android::DnsServerGetter ConstructGetter() {
return base::BindRepeating(&MockDnsServerGetter::GetDnsServers, this);
}
private:
friend base::RefCountedThreadSafe<MockDnsServerGetter>;
~MockDnsServerGetter() = default;
bool GetDnsServers(std::vector<IPEndPoint>* dns_servers,
bool* dns_over_tls_active,
std::string* dns_over_tls_hostname,
std::vector<std::string>* search_suffixes) {
if (retval_) {
*dns_servers = dns_servers_;
*dns_over_tls_active = dns_over_tls_active_;
*dns_over_tls_hostname = dns_over_tls_hostname_;
*search_suffixes = search_suffixes_;
}
return retval_;
}
bool retval_ = false;
std::vector<IPEndPoint> dns_servers_;
bool dns_over_tls_active_ = false;
std::string dns_over_tls_hostname_;
std::vector<std::string> search_suffixes_;
};
class DnsConfigServiceAndroidTest : public testing::Test,
public WithTaskEnvironment {
public:
DnsConfigServiceAndroidTest()
: WithTaskEnvironment(
base::test::TaskEnvironment::TimeSource::MOCK_TIME) {
service_->set_dns_server_getter_for_testing(
mock_dns_server_getter_->ConstructGetter());
}
~DnsConfigServiceAndroidTest() override = default;
void OnConfigChanged(const DnsConfig& config) {
EXPECT_TRUE(config.IsValid());
seen_config_ = true;
real_config_ = config;
}
protected:
bool seen_config_ = false;
std::unique_ptr<DnsConfigServiceAndroid> service_ =
std::make_unique<DnsConfigServiceAndroid>();
DnsConfig real_config_;
scoped_refptr<MockDnsServerGetter> mock_dns_server_getter_ =
base::MakeRefCounted<MockDnsServerGetter>();
test::ScopedMockNetworkChangeNotifier mock_notifier_;
};
TEST_F(DnsConfigServiceAndroidTest, HandlesNetworkChangeNotifications) {
service_->WatchConfig(base::BindRepeating(
&DnsConfigServiceAndroidTest::OnConfigChanged, base::Unretained(this)));
FastForwardBy(DnsConfigServiceAndroid::kConfigChangeDelay);
RunUntilIdle();
// Cannot validate any behavior other than not crashing because this test runs
// on Android versions with unmocked behavior.
}
TEST_F(DnsConfigServiceAndroidTest, NewConfigReadOnNetworkChange) {
SKIP_ANDROID_VERSIONS_BEFORE_M();
mock_dns_server_getter_->set_retval(true);
mock_dns_server_getter_->set_dns_servers({kNameserver1});
service_->WatchConfig(base::BindRepeating(
&DnsConfigServiceAndroidTest::OnConfigChanged, base::Unretained(this)));
FastForwardBy(DnsConfigServiceAndroid::kConfigChangeDelay);
RunUntilIdle();
ASSERT_TRUE(seen_config_);
EXPECT_THAT(real_config_.nameservers, testing::ElementsAre(kNameserver1));
mock_dns_server_getter_->set_dns_servers({kNameserver2});
seen_config_ = false;
NetworkChangeNotifier::NotifyObserversOfConnectionTypeChangeForTests(
NetworkChangeNotifier::CONNECTION_WIFI);
FastForwardBy(DnsConfigServiceAndroid::kConfigChangeDelay);
RunUntilIdle();
ASSERT_TRUE(seen_config_);
EXPECT_THAT(real_config_.nameservers, testing::ElementsAre(kNameserver2));
}
TEST_F(DnsConfigServiceAndroidTest, NoConfigNotificationWhenUnchanged) {
SKIP_ANDROID_VERSIONS_BEFORE_M();
mock_dns_server_getter_->set_retval(true);
mock_dns_server_getter_->set_dns_servers({kNameserver1});
service_->WatchConfig(base::BindRepeating(
&DnsConfigServiceAndroidTest::OnConfigChanged, base::Unretained(this)));
FastForwardBy(DnsConfigServiceAndroid::kConfigChangeDelay);
RunUntilIdle();
ASSERT_TRUE(seen_config_);
EXPECT_THAT(real_config_.nameservers, testing::ElementsAre(kNameserver1));
seen_config_ = false;
NetworkChangeNotifier::NotifyObserversOfConnectionTypeChangeForTests(
NetworkChangeNotifier::CONNECTION_WIFI);
FastForwardBy(DnsConfigServiceAndroid::kConfigChangeDelay);
RunUntilIdle();
// Because the DNS config hasn't changed, no new config should be seen.
EXPECT_FALSE(seen_config_);
}
TEST_F(DnsConfigServiceAndroidTest, IgnoresConnectionNoneChangeNotifications) {
SKIP_ANDROID_VERSIONS_BEFORE_M();
mock_dns_server_getter_->set_retval(true);
mock_dns_server_getter_->set_dns_servers({kNameserver1});
service_->WatchConfig(base::BindRepeating(
&DnsConfigServiceAndroidTest::OnConfigChanged, base::Unretained(this)));
FastForwardBy(DnsConfigServiceAndroid::kConfigChangeDelay);
RunUntilIdle();
ASSERT_TRUE(seen_config_);
EXPECT_THAT(real_config_.nameservers, testing::ElementsAre(kNameserver1));
// Change the DNS config to ensure the lack of notification is due to not
// being checked for.
mock_dns_server_getter_->set_dns_servers({kNameserver2});
seen_config_ = false;
NetworkChangeNotifier::NotifyObserversOfConnectionTypeChangeForTests(
NetworkChangeNotifier::CONNECTION_NONE);
FastForwardBy(DnsConfigServiceAndroid::kConfigChangeDelay);
RunUntilIdle();
// Expect no new config read for network change to NONE.
EXPECT_FALSE(seen_config_);
}
// Regression test for https://crbug.com/704662.
TEST_F(DnsConfigServiceAndroidTest, ChangeConfigMultipleTimes) {
SKIP_ANDROID_VERSIONS_BEFORE_M();
mock_dns_server_getter_->set_retval(true);
mock_dns_server_getter_->set_dns_servers({kNameserver1});
service_->WatchConfig(base::BindRepeating(
&DnsConfigServiceAndroidTest::OnConfigChanged, base::Unretained(this)));
FastForwardBy(DnsConfigServiceAndroid::kConfigChangeDelay);
RunUntilIdle();
ASSERT_TRUE(seen_config_);
EXPECT_THAT(real_config_.nameservers, testing::ElementsAre(kNameserver1));
for (int i = 0; i < 5; i++) {
mock_dns_server_getter_->set_dns_servers({kNameserver2});
seen_config_ = false;
NetworkChangeNotifier::NotifyObserversOfConnectionTypeChangeForTests(
NetworkChangeNotifier::CONNECTION_WIFI);
FastForwardBy(DnsConfigServiceAndroid::kConfigChangeDelay);
RunUntilIdle();
ASSERT_TRUE(seen_config_);
EXPECT_THAT(real_config_.nameservers, testing::ElementsAre(kNameserver2));
mock_dns_server_getter_->set_dns_servers({kNameserver1});
seen_config_ = false;
NetworkChangeNotifier::NotifyObserversOfConnectionTypeChangeForTests(
NetworkChangeNotifier::CONNECTION_WIFI);
FastForwardBy(DnsConfigServiceAndroid::kConfigChangeDelay);
RunUntilIdle();
ASSERT_TRUE(seen_config_);
EXPECT_THAT(real_config_.nameservers, testing::ElementsAre(kNameserver1));
}
}
TEST_F(DnsConfigServiceAndroidTest, ReadsSearchSuffixes) {
SKIP_ANDROID_VERSIONS_BEFORE_M();
const std::vector<std::string> kSuffixes{"name1.test", "name2.test"};
mock_dns_server_getter_->set_retval(true);
mock_dns_server_getter_->set_dns_servers({kNameserver1});
mock_dns_server_getter_->set_search_suffixes(kSuffixes);
service_->ReadConfig(base::BindRepeating(
&DnsConfigServiceAndroidTest::OnConfigChanged, base::Unretained(this)));
FastForwardBy(DnsConfigServiceAndroid::kConfigChangeDelay);
RunUntilIdle();
ASSERT_TRUE(seen_config_);
EXPECT_EQ(real_config_.search, kSuffixes);
}
TEST_F(DnsConfigServiceAndroidTest, ReadsEmptySearchSuffixes) {
SKIP_ANDROID_VERSIONS_BEFORE_M();
mock_dns_server_getter_->set_retval(true);
mock_dns_server_getter_->set_dns_servers({kNameserver1});
service_->ReadConfig(base::BindRepeating(
&DnsConfigServiceAndroidTest::OnConfigChanged, base::Unretained(this)));
FastForwardBy(DnsConfigServiceAndroid::kConfigChangeDelay);
RunUntilIdle();
ASSERT_TRUE(seen_config_);
EXPECT_TRUE(real_config_.search.empty());
}
} // namespace
} // namespace net::internal
|