1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449
|
#!/usr/bin/env python3
# Copyright 2014 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Compare the artifacts from two builds."""
import ast
import binascii
import difflib
import glob
import json
import optparse
import os
import re
import shutil
import struct
import subprocess
import sys
import time
import zipfile
BASE_DIR = os.path.dirname(os.path.abspath(__file__))
def get_files_to_compare(build_dir, recursive=False):
"""Get the list of files to compare."""
allowed = frozenset((
'.aab',
'.apk',
'.apks',
'.app',
'.bin', # V8 snapshot file snapshot_blob.bin
'.dll',
'.dylib',
'.exe',
'.isolated',
'.nexe',
'.pdb',
'.so',
'.zip',
))
def check(f):
if not os.path.isfile(f):
return False
if os.path.basename(f).startswith('.'):
return False
ext = os.path.splitext(f)[1]
if ext in allowed:
return True
# Special case for file without an extension that has the executable bit
# set.
return ext == '' and os.access(f, os.X_OK)
ret_files = set()
for root, dirs, files in os.walk(build_dir):
if not recursive:
dirs[:] = [d for d in dirs if d.endswith('_apk')]
for f in (f for f in files if check(os.path.join(root, f))):
ret_files.add(os.path.relpath(os.path.join(root, f), build_dir))
return ret_files
def get_files_to_compare_using_isolate(build_dir):
# First, find all .runtime_deps files in build_dir.
# TODO(crbug.com/1066213): This misses some files.
runtime_deps_files = glob.glob(os.path.join(build_dir, '*.runtime_deps'))
# Then, extract their contents.
ret_files = set()
for runtime_deps_file in runtime_deps_files:
with open(runtime_deps_file) as f:
for runtime_dep in f:
runtime_dep = runtime_dep.rstrip()
normalized_path = os.path.normpath(os.path.join(build_dir, runtime_dep))
# Ignore runtime dep files that are not in the build dir ... for now.
# If we ever move to comparing determinism of artifacts built from two
# repositories, we'll want to get rid of this check.
if os.path.commonprefix((normalized_path, build_dir)) != build_dir:
continue
# Theoretically, directories should end in '/' and files should not, but
# this doesn't hold true because some GN build files are incorrectly
# configured. We explicitly check whether the path is a directory or
# file.
if not os.path.isdir(normalized_path):
ret_files.add(normalized_path)
continue
for root, dirs, files in os.walk(normalized_path):
for inner_file in files:
ret_files.add(os.path.join(root, inner_file))
# Convert back to a relpath since that's what the caller is expecting.
return set(os.path.relpath(f, build_dir) for f in ret_files)
def diff_binary(first_filepath, second_filepath, file_len):
"""Returns a compact binary diff if the diff is small enough."""
BLOCK_SIZE = 8192
CHUNK_SIZE = 32
NUM_CHUNKS_IN_BLOCK = BLOCK_SIZE // CHUNK_SIZE
MAX_STREAMS = 10
num_diffs = 0
streams = []
offset = 0
with open(first_filepath, 'rb') as lhs, open(second_filepath, 'rb') as rhs:
while True:
lhs_data = lhs.read(BLOCK_SIZE)
rhs_data = rhs.read(BLOCK_SIZE)
if not lhs_data or not rhs_data:
break
if lhs_data != rhs_data:
for i in range(min(len(lhs_data), len(rhs_data))):
if lhs_data[i] != rhs_data[i]:
num_diffs += 1
if len(streams) < MAX_STREAMS:
for idx in range(NUM_CHUNKS_IN_BLOCK):
lhs_chunk = lhs_data[idx * CHUNK_SIZE:(idx + 1) * CHUNK_SIZE]
rhs_chunk = rhs_data[idx * CHUNK_SIZE:(idx + 1) * CHUNK_SIZE]
if lhs_chunk != rhs_chunk:
if len(streams) < MAX_STREAMS:
streams.append((offset + CHUNK_SIZE * idx,
lhs_chunk, rhs_chunk))
else:
break
offset += len(lhs_data)
del lhs_data
del rhs_data
if not num_diffs:
return None
result = '%d out of %d bytes are different (%.2f%%)' % (
num_diffs, file_len, 100.0 * num_diffs / file_len)
if streams:
encode = lambda text: ''.join(chr(i) if 31 < i < 127 else '.' for i in text)
for offset, lhs_data, rhs_data in streams:
lhs_line = '%s \'%s\'' % (lhs_data.hex(), encode(lhs_data))
rhs_line = '%s \'%s\'' % (rhs_data.hex(), encode(rhs_data))
diff = list(difflib.Differ().compare([lhs_line], [rhs_line]))[-1][2:-1]
result += '\n 0x%-8x: %s\n %s\n %s' % (
offset, lhs_line, rhs_line, diff)
return result
def diff_zips(first_filepath, second_filepath):
with zipfile.ZipFile(first_filepath) as z1, \
zipfile.ZipFile(second_filepath) as z2:
names1 = z1.namelist()
names2 = z2.namelist()
# This kind of difference is rare, so don't put effort into printing the
# exact difference.
if names1 != names2:
diff = sorted(set(names1).symmetric_difference(names2))
if diff:
return ' Zip file lists differ:\n' + '\n'.join(
' ' + f for f in diff)
else:
return ' Zips contain same files, but in different orders.'
diffs = []
for info1 in z1.infolist():
info2 = z2.getinfo(info1.filename)
# Check for the two most common errors. The binary diff will still run
# to check the rest.
if info1.CRC != info2.CRC:
diffs.append(' {}: CRCs differ'.format(info1.filename))
if info1.date_time != info2.date_time:
diffs.append(' {}: Timestamps differ'.format(info1.filename))
# Don't be too spammy.
if len(diffs) > 5:
diffs[5:] = [' ...']
return '\n'.join(diffs)
def memoize(f):
memo = {}
def helper(*args):
if args not in memo:
memo[args] = f(*args)
return memo[args]
return helper
# compare_deps() can be called with different targets that all depend on
# "all" targets, so memoize the results of this function to make sure we
# don't compare "all" files more than once.
@memoize
def compare_files(first_filepath, second_filepath):
"""Compares two binaries and return the number of differences between them.
Returns None if the files are equal, a string otherwise.
"""
if not os.path.exists(first_filepath):
return 'file does not exist %s' % first_filepath
if not os.path.exists(second_filepath):
return 'file does not exist %s' % second_filepath
ret = None
file_len = os.stat(first_filepath).st_size
if file_len != os.stat(second_filepath).st_size:
ret = 'different size: %d != %d' % (file_len,
os.stat(second_filepath).st_size)
else:
ret = diff_binary(first_filepath, second_filepath, file_len)
if ret and zipfile.is_zipfile(first_filepath) and zipfile.is_zipfile(
second_filepath):
try:
ret += '\n' + diff_zips(first_filepath, second_filepath)
except OSError:
print("https://crbug.com/1427203: error from diff_zips(%s, %s)?" %
(first_filepath, second_filepath))
raise
return ret
def get_deps(ninja_path, build_dir, target):
"""Returns list of object files needed to build target."""
NODE_PATTERN = re.compile(r'label="([a-zA-Z0-9_\\/.-]+)"')
CHECK_EXTS = ('.o', '.obj')
# Rename to possibly original directory name if possible.
fixed_build_dir = build_dir
if build_dir.endswith('.1') or build_dir.endswith('.2'):
fixed_build_dir = build_dir[:-2]
if os.path.exists(fixed_build_dir):
print(
'fixed_build_dir %s exists.'
' will try to use orig dir.' % fixed_build_dir,
file=sys.stderr)
fixed_build_dir = build_dir
else:
shutil.move(build_dir, fixed_build_dir)
try:
out = subprocess.check_output(
[ninja_path, '-C', fixed_build_dir, '-t', 'graph', target],
universal_newlines=True)
except subprocess.CalledProcessError as e:
print('error to get graph for %s: %s' % (target, e), file=sys.stderr)
return []
finally:
# Rename again if we renamed before.
if fixed_build_dir != build_dir:
shutil.move(fixed_build_dir, build_dir)
files = []
for line in out.splitlines():
matched = NODE_PATTERN.search(line)
if matched:
path = matched.group(1)
if not os.path.splitext(path)[1] in CHECK_EXTS:
continue
if os.path.isabs(path):
print(
'not support abs path %s used for target %s' % (path, target),
file=sys.stderr)
continue
files.append(path)
return files
def compare_deps(first_dir, second_dir, ninja_path, targets):
"""Print difference of dependent files."""
diffs = set()
print('Differences split by build targets:')
for target in targets:
first_deps = get_deps(ninja_path, first_dir, target)
second_deps = get_deps(ninja_path, second_dir, target)
print('Checking %s difference: (%s deps)' % (target, len(first_deps)))
if set(first_deps) != set(second_deps):
# Since we do not thiks this case occur, we do not do anything special
# for this case.
print('deps on %s are different: %s' %
(target, set(first_deps).symmetric_difference(set(second_deps))))
continue
max_filepath_len = max([0] + [len(n) for n in first_deps])
for d in first_deps:
first_file = os.path.join(first_dir, d)
second_file = os.path.join(second_dir, d)
result = compare_files(first_file, second_file)
if result:
print(' %-*s: %s' % (max_filepath_len, d, result))
diffs.add(d)
return list(diffs)
def compare_build_artifacts(first_dir, second_dir, ninja_path, target_platform,
json_output, recursive, use_isolate_files):
"""Compares the artifacts from two distinct builds."""
if not os.path.isdir(first_dir):
print('%s isn\'t a valid directory.' % first_dir, file=sys.stderr)
return 1
if not os.path.isdir(second_dir):
print('%s isn\'t a valid directory.' % second_dir, file=sys.stderr)
return 1
epoch_hex = binascii.hexlify(struct.pack('<I', int(time.time()))).decode()
print('Epoch: %s' % ' '.join(epoch_hex[i:i + 2]
for i in range(0, len(epoch_hex), 2)))
with open(os.path.join(BASE_DIR, 'deterministic_build_ignorelist.pyl')) as f:
raw_ignorelist = ast.literal_eval(f.read())
ignorelist_list = raw_ignorelist[target_platform]
if re.search(r'\bis_component_build\s*=\s*true\b',
open(os.path.join(first_dir, 'args.gn')).read()):
ignorelist_list += raw_ignorelist.get(target_platform + '_component', [])
ignorelist = frozenset(ignorelist_list)
if use_isolate_files:
first_list = get_files_to_compare_using_isolate(first_dir)
second_list = get_files_to_compare_using_isolate(second_dir)
else:
first_list = get_files_to_compare(first_dir, recursive)
second_list = get_files_to_compare(second_dir, recursive)
# Always check that the main ninja files are deterministic.
# Ideally we'd compare all of them, but that requires walking
# the clobbered build dir to find them. This is less code
# and gives most of the benefit.
# TODO(thakis): Add build.ninja once comments 9/11 on crbug.com/1278777 are figured out.
# TODO(thakis): Run this on non-win32 once we have some plan for handling differences
# in goma/non-goma (crbug.com/1278777 comments 14/15) -- maybe have the recipe run
# `gn gen` in two additional build dirs with goma off and compare ninja files there?
if sys.platform == 'win32':
first_list.update(['toolchain.ninja'])
second_list.update(['toolchain.ninja'])
print('See https://chromium.googlesource.com/chromium/src/+/HEAD/docs/deterministic_builds.md')
print('for debugging non-determinisitic builds. Skip to "Unexpected diffs:" below')
print('and search for "DIFFERENT (unexpected)" for clues about problems.')
print()
print('Differences of files in build directories:')
equals = []
expected_diffs = []
unexpected_diffs = []
unexpected_equals = []
all_files = sorted(first_list & second_list)
missing_files = sorted(first_list.symmetric_difference(second_list))
if missing_files:
print('Different list of files in both directories:', file=sys.stderr)
print('\n'.join(' ' + i for i in missing_files), file=sys.stderr)
unexpected_diffs.extend(missing_files)
max_filepath_len = 0
if all_files:
max_filepath_len = max(len(n) for n in all_files)
for f in all_files:
first_file = os.path.join(first_dir, f)
second_file = os.path.join(second_dir, f)
result = compare_files(first_file, second_file)
if not result:
tag = 'equal'
equals.append(f)
if f in ignorelist:
unexpected_equals.append(f)
else:
if f in ignorelist:
expected_diffs.append(f)
tag = 'expected'
else:
unexpected_diffs.append(f)
tag = 'unexpected'
result = 'DIFFERENT (%s): %s' % (tag, result)
print('%-*s: %s' % (max_filepath_len, f, result))
unexpected_diffs.sort()
print('Equals: %d' % len(equals))
print('Expected diffs: %d' % len(expected_diffs))
print('Unexpected diffs: %d' % len(unexpected_diffs))
if unexpected_diffs:
print('Unexpected files with diffs:')
for u in unexpected_diffs:
print(' %s' % u)
if unexpected_equals:
print('Unexpected files with no diffs:')
for u in unexpected_equals:
print(' %s' % u)
print()
all_diffs = expected_diffs + unexpected_diffs
diffs_to_investigate = sorted(set(all_diffs).difference(missing_files))
deps_diff = compare_deps(first_dir, second_dir,
ninja_path, diffs_to_investigate)
if json_output:
try:
out = {
'expected_diffs': expected_diffs,
'unexpected_diffs': unexpected_diffs,
'deps_diff': deps_diff,
}
with open(json_output, 'w') as f:
json.dump(out, f)
except Exception as e:
print('failed to write json output: %s' % e)
return int(bool(unexpected_diffs))
def main():
parser = optparse.OptionParser(usage='%prog [options]')
parser.add_option(
'-f', '--first-build-dir', help='The first build directory.')
parser.add_option(
'-s', '--second-build-dir', help='The second build directory.')
parser.add_option('-r', '--recursive', action='store_true', default=False,
help='Indicates if the comparison should be recursive.')
parser.add_option(
'--use-isolate-files',
action='store_true',
default=False,
help='Use .runtime_deps files in each directory to determine which '
'artifacts to compare.')
parser.add_option('--json-output', help='JSON file to output differences')
parser.add_option('--ninja-path', help='path to ninja command.',
default='ninja')
target = {
'darwin': 'mac', 'linux2': 'linux', 'win32': 'win'
}.get(sys.platform, sys.platform)
parser.add_option(
'-t', '--target-platform', help='The target platform.',
default=target, choices=('android', 'fuchsia', 'mac', 'linux', 'win'))
options, _ = parser.parse_args()
if not options.first_build_dir:
parser.error('--first-build-dir is required')
if not options.second_build_dir:
parser.error('--second-build-dir is required')
if not options.target_platform:
parser.error('--target-platform is required')
return compare_build_artifacts(os.path.abspath(options.first_build_dir),
os.path.abspath(options.second_build_dir),
options.ninja_path,
options.target_platform,
options.json_output,
options.recursive,
options.use_isolate_files)
if __name__ == '__main__':
sys.exit(main())
|