1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
|
# Copyright 2020 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
from parameterized import parameterized
import unittest
import xml.dom.minidom
import actions_model
PRETTY_XML = """
<actions>
<action name="Action1">
<owner>owner@chromium.org</owner>
<description>Description1</description>
</action>
<action name="Action2" not_user_triggered="true">
<obsolete>Obsolete text</obsolete>
<owner>owner@chromium.org</owner>
<description>Description2</description>
</action>
<action name="Action3">
<obsolete>Obsolete text</obsolete>
<owner>owner@chromium.org</owner>
<owner>owner2@chromium.org</owner>
<description>Description3</description>
</action>
<action-suffix separator="." ordering="suffix">
<suffix name="AppMenu" label="Users opened a new incognito tab by app menu"/>
<suffix name="LongTapMenu"
label="Users opened a new incognito tab by long tap menu"/>
</action-suffix>
<action-suffix separator="." ordering="suffix">
<suffix name="LongTapMenu" label="Users closed a tab by long tap menu"/>
<affected-action name="AnAction"/>
<affected-action name="MobileMenuCloseTab"/>
</action-suffix>
</actions>
""".strip()
XML_WITH_WRONG_INDENT = """
<actions>
<action name="Action1">
<owner>owner@chromium.org</owner>
<description>Description1</description>
</action>
<action name="Action2" not_user_triggered="true">
<obsolete>Obsolete text</obsolete>
<owner>owner@chromium.org</owner>
<description>Description2</description>
</action>
<action name="Action3">
<obsolete>Obsolete text</obsolete>
<owner>owner@chromium.org</owner>
<owner>owner2@chromium.org</owner>
<description>Description3</description>
</action>
<action-suffix separator="." ordering="suffix">
<suffix name="AppMenu" label="Users opened a new incognito tab by app menu"/>
<suffix name="LongTapMenu"
label="Users opened a new incognito tab by long tap menu"/>
</action-suffix>
<action-suffix separator="." ordering="suffix">
<suffix name="LongTapMenu" label="Users closed a tab by long tap menu"/>
<affected-action name="AnAction"/>
<affected-action name="MobileMenuCloseTab"/>
</action-suffix>
</actions>
""".strip()
XML_WITH_WRONG_SINGLELINE = """
<actions>
<action name="Action1">
<owner>
owner@chromium.org
</owner>
<description>Description1</description>
</action>
<action name="Action2" not_user_triggered="true">
<obsolete>
Obsolete text
</obsolete>
<owner>owner@chromium.org</owner>
<description>Description2</description>
</action>
<action name="Action3">
<obsolete>Obsolete text</obsolete>
<owner>owner@chromium.org</owner>
<owner>owner2@chromium.org</owner>
<description>
Description3
</description>
</action>
<action-suffix separator="." ordering="suffix">
<suffix name="AppMenu" label="Users opened a new incognito tab by app menu"/>
<suffix name="LongTapMenu"
label="Users opened a new incognito tab by long tap menu"/>
</action-suffix>
<action-suffix separator="." ordering="suffix">
<suffix name="LongTapMenu" label="Users closed a tab by long tap menu"/>
<affected-action name="AnAction"/>
<affected-action name="MobileMenuCloseTab"/>
</action-suffix>
</actions>
""".strip()
XML_WITH_WRONG_LINE_BREAK = """
<actions>
<action name="Action1">
<owner>owner@chromium.org</owner>
<description>Description1</description>
</action>
<action name="Action2" not_user_triggered="true">
<obsolete>Obsolete text</obsolete>
<owner>owner@chromium.org</owner>
<description>Description2</description>
</action>
<action name="Action3">
<obsolete>Obsolete text</obsolete>
<owner>owner@chromium.org</owner>
<owner>owner2@chromium.org</owner>
<description>Description3</description>
</action>
<action-suffix separator="." ordering="suffix">
<suffix name="AppMenu" label="Users opened a new incognito tab by app menu"/>
<suffix name="LongTapMenu"
label="Users opened a new incognito tab by long tap menu"/>
</action-suffix>
<action-suffix separator="." ordering="suffix">
<suffix name="LongTapMenu"
label="Users closed a tab by long tap menu"/>
<affected-action name="AnAction"/>
<affected-action name="MobileMenuCloseTab"/>
</action-suffix>
</actions>
""".strip()
XML_WITH_WRONG_ORDER = """
<actions>
<action name="Action2" not_user_triggered="true">
<obsolete>Obsolete text</obsolete>
<owner>owner@chromium.org</owner>
<description>Description2</description>
</action>
<action name="Action1">
<owner>owner@chromium.org</owner>
<description>Description1</description>
</action>
<action name="Action3">
<obsolete>Obsolete text</obsolete>
<owner>owner@chromium.org</owner>
<owner>owner2@chromium.org</owner>
<description>Description3</description>
</action>
<action-suffix separator="." ordering="suffix">
<suffix name="LongTapMenu"
label="Users opened a new incognito tab by long tap menu"/>
<suffix name="AppMenu" label="Users opened a new incognito tab by app menu"/>
</action-suffix>
<action-suffix separator="." ordering="suffix">
<suffix name="LongTapMenu" label="Users closed a tab by long tap menu"/>
<affected-action name="MobileMenuCloseTab"/>
<affected-action name="AnAction"/>
</action-suffix>
</actions>
""".strip()
XML_WITH_WRONG_CHILDREN_ORDER = """
<actions>
<action name="Action1">
<description>Description1</description>
<owner>owner@chromium.org</owner>
</action>
<action name="Action2" not_user_triggered="true">
<owner>owner@chromium.org</owner>
<obsolete>Obsolete text</obsolete>
<description>Description2</description>
</action>
<action name="Action3">
<obsolete>Obsolete text</obsolete>
<owner>owner@chromium.org</owner>
<description>Description3</description>
<owner>owner2@chromium.org</owner>
</action>
<action-suffix separator="." ordering="suffix">
<suffix name="AppMenu" label="Users opened a new incognito tab by app menu"/>
<suffix name="LongTapMenu"
label="Users opened a new incognito tab by long tap menu"/>
</action-suffix>
<action-suffix separator="." ordering="suffix">
<affected-action name="AnAction"/>
<affected-action name="MobileMenuCloseTab"/>
<suffix name="LongTapMenu" label="Users closed a tab by long tap menu"/>
</action-suffix>
</actions>
""".strip()
XML_WITH_WRONG_ATTRIBUTE_ORDER = """
<actions>
<action name="Action1">
<owner>owner@chromium.org</owner>
<description>Description1</description>
</action>
<action not_user_triggered="true" name="Action2">
<obsolete>Obsolete text</obsolete>
<owner>owner@chromium.org</owner>
<description>Description2</description>
</action>
<action name="Action3">
<obsolete>Obsolete text</obsolete>
<owner>owner@chromium.org</owner>
<owner>owner2@chromium.org</owner>
<description>Description3</description>
</action>
<action-suffix ordering="suffix" separator=".">
<suffix name="AppMenu" label="Users opened a new incognito tab by app menu"/>
<suffix name="LongTapMenu"
label="Users opened a new incognito tab by long tap menu"/>
</action-suffix>
<action-suffix separator="." ordering="suffix">
<suffix label="Users closed a tab by long tap menu" name="LongTapMenu"/>
<affected-action name="AnAction"/>
<affected-action name="MobileMenuCloseTab"/>
</action-suffix>
</actions>
""".strip()
class ActionXmlTest(unittest.TestCase):
def __init__(self, *args, **kwargs):
super(ActionXmlTest, self).__init__(*args, **kwargs)
self.maxDiff = None
@parameterized.expand([
# Test prettify already pretty XML to verify the pretty-printed version
# is the same.
('AlreadyPrettyXml', PRETTY_XML, PRETTY_XML),
('Indent', XML_WITH_WRONG_INDENT, PRETTY_XML),
('SingleLine', XML_WITH_WRONG_SINGLELINE, PRETTY_XML),
('LineBreak', XML_WITH_WRONG_LINE_BREAK, PRETTY_XML),
('Order', XML_WITH_WRONG_ORDER, PRETTY_XML),
# The children of <action> should be sorted in the order of <obsolete>,
# <owner> and <description>
('ChildrenOrder', XML_WITH_WRONG_CHILDREN_ORDER, PRETTY_XML),
])
def testPrettify(self, _, input_xml, expected_xml):
result = actions_model.PrettifyTree(xml.dom.minidom.parseString(input_xml))
self.assertMultiLineEqual(result.strip(), expected_xml)
@parameterized.expand([
('BadAttributeBoolean', PRETTY_XML, 'true', 'hello', 'hello'),
('BadSuffixNameWithSpace', PRETTY_XML, 'AppMenu', 'App Menu', 'App Menu'),
('BadAffectedActionNameWithSpace', PRETTY_XML, 'AnAction', 'An Action',
'An Action'),
('SuffixWithBadSeparator', PRETTY_XML, '.', '-', '-'),
('BadOrdering_IllegalWord', PRETTY_XML, 'ordering="suffix"',
'ordering="hello"', 'hello'),
])
def testRegex(self, _, pretty_input_xml, original_string, bad_string,
error_string):
BAD_XML = pretty_input_xml.replace(original_string, bad_string)
with self.assertRaises(ValueError) as context:
actions_model.PrettifyTree(xml.dom.minidom.parseString(BAD_XML))
self.assertIn(error_string, str(context.exception))
self.assertIn('does not match regex', str(context.exception))
if __name__ == '__main__':
unittest.main()
|
