1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
|
#!/usr/bin/env python3
# Copyright 2013 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Verifies that the histograms XML file is well-formatted."""
import logging
import sys
import xml.dom.minidom
import extract_histograms
import histogram_paths
import merge_xml
import xml_utils
# The allowlist of namespaces (histogram prefixes, case insensitive) that are
# split across multiple files.
_NAMESPACES_IN_MULTIPLE_FILES = [
'ash', 'autocomplete', 'chromeos', 'fcminvalidations', 'graphics', 'launch'
]
def CheckNamespaces():
namespaces = {}
has_errors = False
for path in histogram_paths.ALL_XMLS:
tree = xml.dom.minidom.parse(path)
def _GetNamespace(node):
return node.getAttribute('name').lower().split('.')[0]
namespaces_in_file = set(
_GetNamespace(node)
for node in xml_utils.IterElementsWithTag(tree, 'histogram', depth=3))
for namespace in namespaces_in_file:
if (namespace in namespaces
and namespace not in _NAMESPACES_IN_MULTIPLE_FILES):
logging.error(
'Namespace %s has already been used in %s. it\'s recommended to '
'put histograms with the same namespace in the same file. If you '
'intentionally want to split a namespace across multiple files, '
'please add the namespace to the |_NAMESPACES_IN_MULTIPLE_FILES| '
'in the validate_format.py.' % (namespace, namespaces[namespace]))
has_errors = True
namespaces[namespace] = path
return has_errors
def main():
doc = merge_xml.MergeFiles(histogram_paths.ALL_XMLS,
should_expand_owners=True)
_, errors = extract_histograms.ExtractHistogramsFromDom(doc)
errors = errors or CheckNamespaces()
sys.exit(errors)
if __name__ == '__main__':
main()
|
