1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
|
// Copyright 2015 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stdint.h>
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/test/test_mock_time_task_runner.h"
#include "cc/trees/layer_tree_host.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/compositor/compositor_lock.h"
using testing::Mock;
using testing::_;
namespace ui {
namespace {
// For tests that control time.
class CompositorLockTest : public testing::Test {
protected:
CompositorLockTest() {}
~CompositorLockTest() override {}
void SetUp() override {
task_runner_ = new base::TestMockTimeTaskRunner;
lock_manager_ = std::make_unique<CompositorLockManager>(task_runner_);
}
base::TestMockTimeTaskRunner* task_runner() { return task_runner_.get(); }
CompositorLockManager* lock_manager() { return lock_manager_.get(); }
void DestroyLockManager() { lock_manager_.reset(); }
base::OnceClosure CreateReleaseCallback() {
return base::BindOnce(
[](CompositorLockTest* self) { self->num_releases_++; },
base::Unretained(this));
}
protected:
scoped_refptr<base::TestMockTimeTaskRunner> task_runner_;
std::unique_ptr<CompositorLockManager> lock_manager_;
bool is_locked_ = false;
uint32_t num_releases_ = 0u;
};
class MockCompositorLockClient : public ui::CompositorLockClient {
public:
MOCK_METHOD0(CompositorLockTimedOut, void());
};
} // namespace
TEST_F(CompositorLockTest, LocksTimeOut) {
base::TimeDelta timeout = base::Milliseconds(100);
{
testing::StrictMock<MockCompositorLockClient> lock_client;
// This lock has a timeout.
std::unique_ptr<CompositorLock> lock = lock_manager()->GetCompositorLock(
&lock_client, timeout, CreateReleaseCallback());
EXPECT_TRUE(lock_manager()->IsLocked());
EXPECT_CALL(lock_client, CompositorLockTimedOut()).Times(1);
task_runner()->FastForwardBy(timeout);
task_runner()->RunUntilIdle();
EXPECT_FALSE(lock_manager()->IsLocked());
EXPECT_EQ(1u, num_releases_);
}
{
testing::StrictMock<MockCompositorLockClient> lock_client;
// This lock has no timeout.
std::unique_ptr<CompositorLock> lock = lock_manager()->GetCompositorLock(
&lock_client, base::TimeDelta(), CreateReleaseCallback());
EXPECT_TRUE(lock_manager()->IsLocked());
EXPECT_CALL(lock_client, CompositorLockTimedOut()).Times(0);
task_runner()->FastForwardBy(timeout);
task_runner()->RunUntilIdle();
EXPECT_TRUE(lock_manager()->IsLocked());
EXPECT_EQ(1u, num_releases_);
}
}
TEST_F(CompositorLockTest, MultipleLockClients) {
testing::StrictMock<MockCompositorLockClient> lock_client1;
std::unique_ptr<CompositorLock> lock1;
testing::StrictMock<MockCompositorLockClient> lock_client2;
std::unique_ptr<CompositorLock> lock2;
base::TimeDelta timeout = base::Milliseconds(1);
// Both locks are grabbed from the Compositor with a separate client.
lock1 = lock_manager()->GetCompositorLock(&lock_client1, timeout,
CreateReleaseCallback());
lock2 = lock_manager()->GetCompositorLock(&lock_client2, timeout,
CreateReleaseCallback());
EXPECT_TRUE(lock_manager()->IsLocked());
// Both clients get notified of timeout.
EXPECT_CALL(lock_client1, CompositorLockTimedOut()).Times(1);
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(1);
task_runner()->FastForwardBy(timeout);
task_runner()->RunUntilIdle();
EXPECT_FALSE(lock_manager()->IsLocked());
EXPECT_EQ(2u, num_releases_);
}
TEST_F(CompositorLockTest, ExtendingLifeOfLockDoesntUseDeadClient) {
testing::StrictMock<MockCompositorLockClient> lock_client1;
std::unique_ptr<CompositorLock> lock1;
testing::StrictMock<MockCompositorLockClient> lock_client2;
std::unique_ptr<CompositorLock> lock2;
base::TimeDelta timeout = base::Milliseconds(1);
// One lock is grabbed from the compositor with a client. The other
// extends its lifetime past that of the first.
lock1 = lock_manager()->GetCompositorLock(&lock_client1, timeout,
CreateReleaseCallback());
EXPECT_TRUE(lock_manager()->IsLocked());
// This also locks the compositor and will do so past |lock1| ending.
lock2 = lock_manager()->GetCompositorLock(&lock_client2, timeout,
CreateReleaseCallback());
// |lock1| is destroyed, so it won't timeout but |lock2| will.
lock1 = nullptr;
EXPECT_EQ(1u, num_releases_);
EXPECT_CALL(lock_client1, CompositorLockTimedOut()).Times(0);
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(1);
task_runner()->FastForwardBy(timeout);
task_runner()->RunUntilIdle();
EXPECT_FALSE(lock_manager()->IsLocked());
EXPECT_EQ(2u, num_releases_);
}
TEST_F(CompositorLockTest, AddingLocksDoesNotExtendTimeout) {
testing::StrictMock<MockCompositorLockClient> lock_client1;
std::unique_ptr<CompositorLock> lock1;
testing::StrictMock<MockCompositorLockClient> lock_client2;
std::unique_ptr<CompositorLock> lock2;
base::TimeDelta timeout1 = base::Milliseconds(1);
base::TimeDelta timeout2 = base::Milliseconds(10);
// The first lock has a short timeout.
lock1 = lock_manager()->GetCompositorLock(&lock_client1, timeout1,
CreateReleaseCallback());
EXPECT_TRUE(lock_manager()->IsLocked());
// The second lock has a longer timeout, but since a lock is active,
// the first one is used for both.
lock2 = lock_manager()->GetCompositorLock(&lock_client2, timeout2,
CreateReleaseCallback());
EXPECT_CALL(lock_client1, CompositorLockTimedOut()).Times(1);
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(1);
task_runner()->FastForwardBy(timeout1);
task_runner()->RunUntilIdle();
EXPECT_FALSE(lock_manager()->IsLocked());
EXPECT_EQ(2u, num_releases_);
}
TEST_F(CompositorLockTest, AllowAndExtendTimeout) {
testing::StrictMock<MockCompositorLockClient> lock_client1;
std::unique_ptr<CompositorLock> lock1;
testing::StrictMock<MockCompositorLockClient> lock_client2;
std::unique_ptr<CompositorLock> lock2;
base::TimeDelta timeout1 = base::Milliseconds(1);
base::TimeDelta timeout2 = base::Milliseconds(10);
// The first lock has a short timeout.
lock1 = lock_manager()->GetCompositorLock(&lock_client1, timeout1,
CreateReleaseCallback());
EXPECT_TRUE(lock_manager()->IsLocked());
// Allow locks to extend timeout.
lock_manager()->set_allow_locks_to_extend_timeout(true);
// The second lock has a longer timeout, so the second one is used for both.
lock2 = lock_manager()->GetCompositorLock(&lock_client2, timeout2,
CreateReleaseCallback());
lock_manager()->set_allow_locks_to_extend_timeout(false);
EXPECT_CALL(lock_client1, CompositorLockTimedOut()).Times(0);
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(0);
task_runner()->FastForwardBy(timeout1);
task_runner()->RunUntilIdle();
EXPECT_TRUE(lock_manager()->IsLocked());
EXPECT_EQ(0u, num_releases_);
EXPECT_CALL(lock_client1, CompositorLockTimedOut()).Times(1);
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(1);
task_runner()->FastForwardBy(timeout2 - timeout1);
task_runner()->RunUntilIdle();
EXPECT_FALSE(lock_manager()->IsLocked());
EXPECT_EQ(2u, num_releases_);
}
TEST_F(CompositorLockTest, ExtendingTimeoutStartingCreatedTime) {
testing::StrictMock<MockCompositorLockClient> lock_client1;
std::unique_ptr<CompositorLock> lock1;
testing::StrictMock<MockCompositorLockClient> lock_client2;
std::unique_ptr<CompositorLock> lock2;
base::TimeDelta timeout1 = base::Milliseconds(5);
base::TimeDelta timeout2 = base::Milliseconds(10);
// The first lock has a short timeout.
lock1 = lock_manager()->GetCompositorLock(&lock_client1, timeout1,
CreateReleaseCallback());
EXPECT_TRUE(lock_manager()->IsLocked());
base::TimeDelta time_elapse = base::Milliseconds(1);
task_runner()->FastForwardBy(time_elapse);
task_runner()->RunUntilIdle();
// Allow locks to extend timeout.
lock_manager()->set_allow_locks_to_extend_timeout(true);
// The second lock has a longer timeout, so the second one is used for both
// and start from the time second lock created.
lock2 = lock_manager()->GetCompositorLock(&lock_client2, timeout2,
CreateReleaseCallback());
lock_manager()->set_allow_locks_to_extend_timeout(false);
EXPECT_CALL(lock_client1, CompositorLockTimedOut()).Times(0);
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(0);
task_runner()->FastForwardBy(timeout1 - time_elapse);
task_runner()->RunUntilIdle();
EXPECT_TRUE(lock_manager()->IsLocked());
EXPECT_EQ(0u, num_releases_);
EXPECT_CALL(lock_client1, CompositorLockTimedOut()).Times(1);
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(1);
task_runner()->FastForwardBy(timeout2 - (timeout1 - time_elapse));
task_runner()->RunUntilIdle();
EXPECT_FALSE(lock_manager()->IsLocked());
EXPECT_EQ(2u, num_releases_);
}
TEST_F(CompositorLockTest, AllowButNotExtendTimeout) {
testing::StrictMock<MockCompositorLockClient> lock_client1;
std::unique_ptr<CompositorLock> lock1;
testing::StrictMock<MockCompositorLockClient> lock_client2;
std::unique_ptr<CompositorLock> lock2;
base::TimeDelta timeout1 = base::Milliseconds(10);
base::TimeDelta timeout2 = base::Milliseconds(1);
// The first lock has a longer timeout.
lock1 = lock_manager()->GetCompositorLock(&lock_client1, timeout1,
CreateReleaseCallback());
EXPECT_TRUE(lock_manager()->IsLocked());
// Allow locks to extend timeout.
lock_manager()->set_allow_locks_to_extend_timeout(true);
// The second lock has a short timeout, so the first one is used for both.
lock2 = lock_manager()->GetCompositorLock(&lock_client2, timeout2,
CreateReleaseCallback());
lock_manager()->set_allow_locks_to_extend_timeout(false);
EXPECT_CALL(lock_client1, CompositorLockTimedOut()).Times(0);
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(0);
task_runner()->FastForwardBy(timeout2);
task_runner()->RunUntilIdle();
EXPECT_TRUE(lock_manager()->IsLocked());
EXPECT_EQ(0u, num_releases_);
EXPECT_CALL(lock_client1, CompositorLockTimedOut()).Times(1);
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(1);
task_runner()->FastForwardBy(timeout1 - timeout2);
task_runner()->RunUntilIdle();
EXPECT_FALSE(lock_manager()->IsLocked());
EXPECT_EQ(2u, num_releases_);
}
TEST_F(CompositorLockTest, AllowingExtendDoesNotUseDeadClient) {
testing::StrictMock<MockCompositorLockClient> lock_client1;
std::unique_ptr<CompositorLock> lock1;
testing::StrictMock<MockCompositorLockClient> lock_client2;
std::unique_ptr<CompositorLock> lock2;
base::TimeDelta timeout1 = base::Milliseconds(1);
base::TimeDelta timeout2 = base::Milliseconds(10);
lock1 = lock_manager()->GetCompositorLock(&lock_client1, timeout1,
CreateReleaseCallback());
EXPECT_TRUE(lock_manager()->IsLocked());
EXPECT_CALL(lock_client1, CompositorLockTimedOut()).Times(1);
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(0);
task_runner()->FastForwardBy(timeout1);
task_runner()->RunUntilIdle();
EXPECT_FALSE(lock_manager()->IsLocked());
EXPECT_EQ(1u, num_releases_);
// Allow locks to extend timeout.
lock_manager()->set_allow_locks_to_extend_timeout(true);
// |lock1| is timed out already. The second lock can timeout on its own.
lock2 = lock_manager()->GetCompositorLock(&lock_client2, timeout2,
CreateReleaseCallback());
lock_manager()->set_allow_locks_to_extend_timeout(false);
EXPECT_TRUE(lock_manager()->IsLocked());
EXPECT_CALL(lock_client1, CompositorLockTimedOut()).Times(0);
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(1);
task_runner()->FastForwardBy(timeout2);
task_runner()->RunUntilIdle();
EXPECT_FALSE(lock_manager()->IsLocked());
EXPECT_EQ(2u, num_releases_);
}
TEST_F(CompositorLockTest, LockIsDestroyedDoesntTimeout) {
base::TimeDelta timeout = base::Milliseconds(1);
testing::StrictMock<MockCompositorLockClient> lock_client1;
std::unique_ptr<CompositorLock> lock1;
lock1 = lock_manager()->GetCompositorLock(&lock_client1, timeout,
CreateReleaseCallback());
EXPECT_TRUE(lock_manager()->IsLocked());
// The CompositorLockClient is destroyed when |lock1| is released.
lock1 = nullptr;
EXPECT_EQ(1u, num_releases_);
// The client isn't called as a result.
EXPECT_CALL(lock_client1, CompositorLockTimedOut()).Times(0);
task_runner()->FastForwardBy(timeout);
task_runner()->RunUntilIdle();
EXPECT_FALSE(lock_manager()->IsLocked());
}
TEST_F(CompositorLockTest, TimeoutEndsWhenLockEnds) {
testing::StrictMock<MockCompositorLockClient> lock_client1;
std::unique_ptr<CompositorLock> lock1;
testing::StrictMock<MockCompositorLockClient> lock_client2;
std::unique_ptr<CompositorLock> lock2;
base::TimeDelta timeout1 = base::Milliseconds(1);
base::TimeDelta timeout2 = base::Milliseconds(10);
// The first lock has a short timeout.
lock1 = lock_manager()->GetCompositorLock(&lock_client1, timeout1,
CreateReleaseCallback());
EXPECT_TRUE(lock_manager()->IsLocked());
// But the first lock is ended before timeout.
lock1 = nullptr;
EXPECT_FALSE(lock_manager()->IsLocked());
EXPECT_EQ(1u, num_releases_);
// The second lock has a longer timeout, and it should use that timeout,
// since the first lock is done.
lock2 = lock_manager()->GetCompositorLock(&lock_client2, timeout2,
CreateReleaseCallback());
EXPECT_TRUE(lock_manager()->IsLocked());
{
// The second lock doesn't timeout from the first lock which has ended.
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(0);
task_runner()->FastForwardBy(timeout1);
task_runner()->RunUntilIdle();
}
{
// The second lock can still timeout on its own though.
EXPECT_CALL(lock_client2, CompositorLockTimedOut()).Times(1);
task_runner()->FastForwardBy(timeout2 - timeout1);
task_runner()->RunUntilIdle();
}
EXPECT_FALSE(lock_manager()->IsLocked());
EXPECT_EQ(2u, num_releases_);
}
TEST_F(CompositorLockTest, CompositorLockOutlivesManager) {
testing::StrictMock<MockCompositorLockClient> lock_client1;
std::unique_ptr<CompositorLock> lock1;
lock1 = lock_manager()->GetCompositorLock(&lock_client1, base::TimeDelta(),
CreateReleaseCallback());
// The compositor is destroyed before the lock.
DestroyLockManager();
// This doesn't crash.
lock1 = nullptr;
EXPECT_EQ(1u, num_releases_);
}
} // namespace ui
|
