1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "sql/statement.h"
#include <cstdint>
#include <limits>
#include <string>
#include <string_view>
#include <vector>
#include "base/containers/contains.h"
#include "base/files/scoped_temp_dir.h"
#include "base/test/bind.h"
#include "base/test/metrics/histogram_tester.h"
#include "sql/database.h"
#include "sql/test/scoped_error_expecter.h"
#include "sql/test/test_helpers.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/sqlite/sqlite3.h"
namespace sql {
namespace {
class StatementTest : public testing::Test {
public:
void SetUp() override {
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
ASSERT_TRUE(
db_.Open(temp_dir_.GetPath().AppendASCII("statement_test.sqlite")));
}
protected:
base::ScopedTempDir temp_dir_;
Database db_{test::kTestTag};
};
TEST_F(StatementTest, Assign) {
Statement create;
EXPECT_FALSE(create.is_valid());
create.Assign(db_.GetUniqueStatement(
"CREATE TABLE rows(a INTEGER PRIMARY KEY NOT NULL, b INTEGER NOT NULL)"));
EXPECT_TRUE(create.is_valid());
}
TEST_F(StatementTest, Run) {
ASSERT_TRUE(db_.Execute(
"CREATE TABLE rows(a INTEGER PRIMARY KEY NOT NULL, b INTEGER NOT NULL)"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows(a, b) VALUES(3, 12)"));
Statement select(db_.GetUniqueStatement("SELECT b FROM rows WHERE a=?"));
EXPECT_FALSE(select.Succeeded());
// Stepping it won't work since we haven't bound the value.
EXPECT_FALSE(select.Step());
// Run should fail since this produces output, and we should use Step(). This
// gets a bit wonky since sqlite says this is OK so succeeded is set.
select.Reset(/*clear_bound_vars=*/true);
select.BindInt64(0, 3);
EXPECT_FALSE(select.Run());
EXPECT_EQ(SQLITE_ROW, db_.GetErrorCode());
EXPECT_TRUE(select.Succeeded());
// Resetting it should put it back to the previous state (not runnable).
select.Reset(/*clear_bound_vars=*/true);
EXPECT_FALSE(select.Succeeded());
// Binding and stepping should produce one row.
select.BindInt64(0, 3);
EXPECT_TRUE(select.Step());
EXPECT_TRUE(select.Succeeded());
EXPECT_EQ(12, select.ColumnInt64(0));
EXPECT_FALSE(select.Step());
EXPECT_TRUE(select.Succeeded());
}
// Error callback called for error running a statement.
TEST_F(StatementTest, DatabaseErrorCallbackCalledOnError) {
ASSERT_TRUE(db_.Execute(
"CREATE TABLE rows(a INTEGER PRIMARY KEY NOT NULL, b INTEGER NOT NULL)"));
bool error_callback_called = false;
int error = SQLITE_OK;
db_.set_error_callback(base::BindLambdaForTesting(
[&](int sqlite_error, sql::Statement* statement) {
error_callback_called = true;
error = sqlite_error;
}));
// `rows` is a table with ROWID. https://www.sqlite.org/rowidtable.html
// Since `a` is declared as INTEGER PRIMARY KEY, it is an alias for SQLITE's
// rowid. This means `a` can only take on integer values. Attempting to insert
// anything else causes the error callback handler to be called with
// SQLITE_MISMATCH as error code.
Statement insert(db_.GetUniqueStatement("INSERT INTO rows(a) VALUES(?)"));
ASSERT_TRUE(insert.is_valid());
insert.BindString(0, "not an integer, not suitable as primary key value");
EXPECT_FALSE(insert.Run())
<< "Invalid statement should not Run() successfully";
EXPECT_TRUE(error_callback_called)
<< "Statement::Run() should report errors to the database error callback";
EXPECT_EQ(SQLITE_MISMATCH, error)
<< "Statement::Run() should report errors to the database error callback";
}
// Error expecter works for error running a statement.
TEST_F(StatementTest, ScopedIgnoreError) {
ASSERT_TRUE(db_.Execute(
"CREATE TABLE rows(a INTEGER PRIMARY KEY NOT NULL, b INTEGER NOT NULL)"));
Statement insert(db_.GetUniqueStatement("INSERT INTO rows(a) VALUES(?)"));
EXPECT_TRUE(insert.is_valid());
insert.BindString(0, "not an integer, not suitable as primary key value");
{
sql::test::ScopedErrorExpecter expecter;
expecter.ExpectError(SQLITE_MISMATCH);
EXPECT_FALSE(insert.Run());
EXPECT_TRUE(expecter.SawExpectedErrors());
}
}
TEST_F(StatementTest, Reset) {
ASSERT_TRUE(db_.Execute(
"CREATE TABLE rows(a INTEGER PRIMARY KEY NOT NULL, b INTEGER NOT NULL)"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows(a, b) VALUES(3, 12)"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows(a, b) VALUES(4, 13)"));
Statement insert(db_.GetUniqueStatement("SELECT b FROM rows WHERE a=?"));
insert.BindInt64(0, 3);
ASSERT_TRUE(insert.Step());
EXPECT_EQ(12, insert.ColumnInt64(0));
ASSERT_FALSE(insert.Step());
insert.Reset(/*clear_bound_vars=*/false);
// Verify that we can get all rows again.
ASSERT_TRUE(insert.Step());
EXPECT_EQ(12, insert.ColumnInt64(0));
EXPECT_FALSE(insert.Step());
insert.Reset(/*clear_bound_vars=*/true);
ASSERT_FALSE(insert.Step());
}
TEST_F(StatementTest, BindInt64) {
// `id` makes SQLite's rowid mechanism explicit. We rely on it to retrieve
// the rows in the same order that they were inserted.
ASSERT_TRUE(db_.Execute(
"CREATE TABLE ints(id INTEGER PRIMARY KEY, i INTEGER NOT NULL)"));
const std::vector<int64_t> values = {
// Small positive values.
0,
1,
2,
10,
101,
1002,
// Small negative values.
-1,
-2,
-3,
-10,
-101,
-1002,
// Large values.
std::numeric_limits<int64_t>::max(),
std::numeric_limits<int64_t>::min(),
};
Statement insert(db_.GetUniqueStatement("INSERT INTO ints(i) VALUES(?)"));
for (int64_t value : values) {
insert.BindInt64(0, value);
ASSERT_TRUE(insert.Run());
insert.Reset(/*clear_bound_vars=*/true);
}
Statement select(db_.GetUniqueStatement("SELECT i FROM ints ORDER BY id"));
for (int64_t value : values) {
ASSERT_TRUE(select.Step());
int64_t column_value = select.ColumnInt64(0);
EXPECT_EQ(value, column_value);
}
}
// Chrome features rely on being able to use uint64_t with ColumnInt64().
// This is supported, because (starting in C++20) casting between signed and
// unsigned integers is well-defined in both directions. This test ensures that
// the casting works as expected.
TEST_F(StatementTest, BindInt64_FromUint64t) {
// `id` makes SQLite's rowid mechanism explicit. We rely on it to retrieve
// the rows in the same order that they were inserted.
static constexpr char kSql[] =
"CREATE TABLE ints(id INTEGER PRIMARY KEY NOT NULL, i INTEGER NOT NULL)";
ASSERT_TRUE(db_.Execute(kSql));
const std::vector<uint64_t> values = {
// Small positive values.
0,
1,
2,
10,
101,
1002,
// Large values.
std::numeric_limits<int64_t>::max() - 1,
std::numeric_limits<int64_t>::max(),
std::numeric_limits<uint64_t>::max() - 1,
std::numeric_limits<uint64_t>::max(),
};
Statement insert(db_.GetUniqueStatement("INSERT INTO ints(i) VALUES(?)"));
for (uint64_t value : values) {
insert.BindInt64(0, static_cast<int64_t>(value));
ASSERT_TRUE(insert.Run());
insert.Reset(/*clear_bound_vars=*/true);
}
Statement select(db_.GetUniqueStatement("SELECT i FROM ints ORDER BY id"));
for (uint64_t value : values) {
ASSERT_TRUE(select.Step());
int64_t column_value = select.ColumnInt64(0);
uint64_t cast_column_value = static_cast<uint64_t>(column_value);
EXPECT_EQ(value, cast_column_value) << " column_value: " << column_value;
}
}
TEST_F(StatementTest, BindBlob) {
// `id` makes SQLite's rowid mechanism explicit. We rely on it to retrieve
// the rows in the same order that they were inserted.
ASSERT_TRUE(db_.Execute(
"CREATE TABLE blobs(id INTEGER PRIMARY KEY NOT NULL, b BLOB NOT NULL)"));
const std::vector<std::vector<uint8_t>> values = {
{},
{0x01},
{0x41, 0x42, 0x43, 0x44},
};
Statement insert(db_.GetUniqueStatement("INSERT INTO blobs(b) VALUES(?)"));
for (const std::vector<uint8_t>& value : values) {
insert.BindBlob(0, value);
ASSERT_TRUE(insert.Run());
insert.Reset(/*clear_bound_vars=*/true);
}
Statement select(db_.GetUniqueStatement("SELECT b FROM blobs ORDER BY id"));
for (const std::vector<uint8_t>& value : values) {
ASSERT_TRUE(select.Step());
std::vector<uint8_t> column_value;
EXPECT_TRUE(select.ColumnBlobAsVector(0, &column_value));
EXPECT_EQ(value, column_value);
}
EXPECT_FALSE(select.Step());
}
TEST_F(StatementTest, BindBlob_String16Overload) {
// `id` makes SQLite's rowid mechanism explicit. We rely on it to retrieve
// the rows in the same order that they were inserted.
ASSERT_TRUE(db_.Execute(
"CREATE TABLE blobs(id INTEGER PRIMARY KEY NOT NULL, b BLOB NOT NULL)"));
const std::vector<std::u16string> values = {
std::u16string(), std::u16string(u"hello\n"), std::u16string(u"😀🍩🎉"),
std::u16string(u"\xd800\xdc00text"), // surrogate pair with text
std::u16string(u"\xd8ff"), // unpaired high surrogate
std::u16string(u"\xdddd"), // unpaired low surrogate
std::u16string(u"\xdc00\xd800text"), // lone low followed by lone high
// surrogate and text
std::u16string(1024, 0xdb23), // long invalid UTF-16
};
Statement insert(db_.GetUniqueStatement("INSERT INTO blobs(b) VALUES(?)"));
for (const std::u16string& value : values) {
insert.BindBlob(0, value);
ASSERT_TRUE(insert.Run());
insert.Reset(/*clear_bound_vars=*/true);
}
Statement select(db_.GetUniqueStatement("SELECT b FROM blobs ORDER BY id"));
for (const std::u16string& value : values) {
ASSERT_TRUE(select.Step());
std::u16string column_value;
EXPECT_TRUE(select.ColumnBlobAsString16(0, &column_value));
EXPECT_EQ(value, column_value);
}
EXPECT_FALSE(select.Step());
}
TEST_F(StatementTest, BindString) {
// `id` makes SQLite's rowid mechanism explicit. We rely on it to retrieve
// the rows in the same order that they were inserted.
ASSERT_TRUE(db_.Execute(
"CREATE TABLE texts(id INTEGER PRIMARY KEY NOT NULL, t TEXT NOT NULL)"));
const std::vector<std::string> values = {
"",
"a",
"\x01",
std::string("\x00", 1),
"abcd",
"\x01\x02\x03\x04",
std::string("\x01Test", 5),
std::string("\x00Test", 5),
};
Statement insert(db_.GetUniqueStatement("INSERT INTO texts(t) VALUES(?)"));
for (const std::string& value : values) {
insert.BindString(0, value);
ASSERT_TRUE(insert.Run());
insert.Reset(/*clear_bound_vars=*/true);
}
{
Statement select(db_.GetUniqueStatement("SELECT t FROM texts ORDER BY id"));
for (const std::string& value : values) {
ASSERT_TRUE(select.Step());
EXPECT_EQ(value, select.ColumnString(0));
}
EXPECT_FALSE(select.Step());
}
{
Statement select(db_.GetUniqueStatement("SELECT t FROM texts ORDER BY id"));
for (const std::string& value : values) {
ASSERT_TRUE(select.Step());
EXPECT_EQ(value, select.ColumnStringView(0));
}
EXPECT_FALSE(select.Step());
}
}
TEST_F(StatementTest, BindString_NullData) {
// `id` makes SQLite's rowid mechanism explicit. We rely on it to retrieve
// the rows in the same order that they were inserted.
ASSERT_TRUE(db_.Execute(
"CREATE TABLE texts(id INTEGER PRIMARY KEY NOT NULL, t TEXT NOT NULL)"));
Statement insert(db_.GetUniqueStatement("INSERT INTO texts(t) VALUES(?)"));
insert.BindString(0, std::string_view(nullptr, 0));
ASSERT_TRUE(insert.Run());
Statement select(db_.GetUniqueStatement("SELECT t FROM texts ORDER BY id"));
ASSERT_TRUE(select.Step());
EXPECT_EQ(std::string(), select.ColumnString(0));
EXPECT_FALSE(select.Step());
}
TEST_F(StatementTest, GetSQLStatementExcludesBoundValues) {
ASSERT_TRUE(db_.Execute(
"CREATE TABLE texts(id INTEGER PRIMARY KEY NOT NULL, t TEXT NOT NULL)"));
Statement insert(db_.GetUniqueStatement("INSERT INTO texts(t) VALUES(?)"));
insert.BindString(0, "John Doe");
ASSERT_TRUE(insert.Run());
// Verify that GetSQLStatement doesn't leak any bound values that may be PII.
std::string sql_statement = insert.GetSQLStatement();
EXPECT_TRUE(base::Contains(sql_statement, "INSERT INTO texts(t) VALUES(?)"));
EXPECT_TRUE(base::Contains(sql_statement, "VALUES"));
EXPECT_FALSE(base::Contains(sql_statement, "Doe"));
// Sanity check that the name was actually committed.
Statement select(db_.GetUniqueStatement("SELECT t FROM texts ORDER BY id"));
ASSERT_TRUE(select.Step());
EXPECT_EQ(select.ColumnString(0), "John Doe");
}
TEST_F(StatementTest, RunReportsPerformanceMetrics) {
base::HistogramTester histogram_tester;
ASSERT_TRUE(db_.Execute(
"CREATE TABLE rows(a INTEGER PRIMARY KEY NOT NULL, b INTEGER NOT NULL)"));
ASSERT_TRUE(db_.Execute("INSERT INTO rows(a, b) VALUES(12, 42)"));
histogram_tester.ExpectTotalCount("Sql.Statement.Test.VMSteps", 0);
{
Statement select(db_.GetUniqueStatement("SELECT b FROM rows WHERE a=?"));
select.BindInt64(0, 12);
ASSERT_TRUE(select.Step());
EXPECT_EQ(select.ColumnInt64(0), 42);
}
histogram_tester.ExpectTotalCount("Sql.Statement.Test.VMSteps", 1);
}
} // namespace
} // namespace sql
|