1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
|
#!/usr/bin/env python
# Copyright 2019 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import os.path
import sys
import unittest
import PRESUBMIT
file_dir_path = os.path.dirname(os.path.abspath(__file__))
sys.path.insert(0, os.path.join(file_dir_path, '..', '..'))
from PRESUBMIT_test_mocks import MockAffectedFile
from PRESUBMIT_test_mocks import MockInputApi, MockOutputApi
_VALID_DEP = "+third_party/blink/public/platform/web_something.h,"
_INVALID_DEP = "+third_party/blink/public/web/web_something.h,"
_INVALID_DEP2 = "+third_party/blink/public/web/web_nothing.h,"
class BlinkPublicWebUnwantedDependenciesTest(unittest.TestCase):
def makeInputApi(self, files):
input_api = MockInputApi()
input_api.InitFiles(files)
return input_api
INVALID_DEPS_MESSAGE = ('chrome/browser cannot depend on '
'blink/public/web interfaces. Use'
' blink/public/common instead.')
def testAdditionOfUnwantedDependency(self):
input_api = self.makeInputApi([
MockAffectedFile('DEPS', [_INVALID_DEP], [], action='M')])
warnings = PRESUBMIT._CheckUnwantedDependencies(input_api, MockOutputApi())
self.assertEqual(1, len(warnings))
self.assertEqual(self.INVALID_DEPS_MESSAGE, warnings[0].message)
self.assertEqual(1, len(warnings[0].items))
def testAdditionOfUnwantedDependencyInComment(self):
input_api = self.makeInputApi([
MockAffectedFile('DEPS', ["#" + _INVALID_DEP], [], action='M')])
warnings = PRESUBMIT._CheckUnwantedDependencies(input_api, MockOutputApi())
self.assertEqual([], warnings)
def testAdditionOfValidDependency(self):
input_api = self.makeInputApi([
MockAffectedFile('DEPS', [_VALID_DEP], [], action='M')])
warnings = PRESUBMIT._CheckUnwantedDependencies(input_api, MockOutputApi())
self.assertEqual([], warnings)
def testAdditionOfMultipleUnwantedDependency(self):
input_api = self.makeInputApi([
MockAffectedFile('DEPS', [_INVALID_DEP, _INVALID_DEP2], action='M')])
warnings = PRESUBMIT._CheckUnwantedDependencies(input_api, MockOutputApi())
self.assertEqual(1, len(warnings))
self.assertEqual(self.INVALID_DEPS_MESSAGE, warnings[0].message)
self.assertEqual(2, len(warnings[0].items))
input_api = self.makeInputApi([
MockAffectedFile('DEPS', [_INVALID_DEP, _VALID_DEP], [], action='M')])
warnings = PRESUBMIT._CheckUnwantedDependencies(input_api, MockOutputApi())
self.assertEqual(1, len(warnings))
self.assertEqual(self.INVALID_DEPS_MESSAGE, warnings[0].message)
self.assertEqual(1, len(warnings[0].items))
def testRemovalOfUnwantedDependency(self):
input_api = self.makeInputApi([
MockAffectedFile('DEPS', [], [_INVALID_DEP], action='M')])
warnings = PRESUBMIT._CheckUnwantedDependencies(input_api, MockOutputApi())
self.assertEqual([], warnings)
def testRemovalOfValidDependency(self):
input_api = self.makeInputApi([
MockAffectedFile('DEPS', [], [_VALID_DEP], action='M')])
warnings = PRESUBMIT._CheckUnwantedDependencies(input_api, MockOutputApi())
self.assertEqual([], warnings)
class InteractiveUiTestLibIncludeTest(unittest.TestCase):
def testAdditionOfUnwantedDependency(self):
lines = ['#include "ui/base/test/ui_controls.h"',
'#include "ui/base/test/foo.h"',
'#include "chrome/test/base/interactive_test_utils.h"']
mock_input_api = MockInputApi()
mock_input_api.files = [
MockAffectedFile('foo_interactive_uitest.cc', lines),
MockAffectedFile('foo_browsertest.cc', lines),
MockAffectedFile('foo_interactive_browsertest.cc', lines),
MockAffectedFile('foo_unittest.cc', lines) ]
mock_output_api = MockOutputApi()
errors = PRESUBMIT._CheckNoInteractiveUiTestLibInNonInteractiveUiTest(
mock_input_api, mock_output_api)
self.assertEqual(1, len(errors))
# 2 lines from 2 files.
self.assertEqual(4, len(errors[0].items))
class CheckBuildFilesForIndirectAshSourcesTest(unittest.TestCase):
MESSAGE = "Indirect sources detected."
def testScope(self):
"""We only complain for changes to BUILD.gn under certain directories."""
new_contents = [
'source_set("foo") {',
' sources = [ "a/b.cc" ]',
'}',
]
mock_output_api = MockOutputApi()
mock_input_api = MockInputApi()
mock_input_api.files = [
MockAffectedFile('BUILD.gn', new_contents),
MockAffectedFile('chrome/browser/BUILD.gn', new_contents),
MockAffectedFile('chrome/browser/ash/build.cc', new_contents),
MockAffectedFile('chrome/browser/ash/BUILD.gn', new_contents),
MockAffectedFile('chrome/browser/ashley/BUILD.gn', new_contents),
MockAffectedFile('chrome/browser/chromeos/a/b/BUILD.gn', new_contents),
MockAffectedFile('chrome/browser/resources/ash/BUILD.gn', new_contents),
MockAffectedFile('chrome/browser/ui/BUILD.gn', new_contents),
MockAffectedFile('chrome/browser/ui/ash/foo/BUILD.gn', new_contents),
MockAffectedFile('chrome/browser/ui/chromeos/BUILD.gn', new_contents),
MockAffectedFile('chrome/browser/ui/webui/ash/BUILD.gn', new_contents),
]
results = PRESUBMIT._CheckBuildFilesForIndirectAshSources(mock_input_api,
mock_output_api)
for result in results:
self.assertEqual(result.message, self.MESSAGE)
self.assertCountEqual(
[r.items for r in results],
[["chrome/browser/ash/BUILD.gn"],
["chrome/browser/chromeos/a/b/BUILD.gn"],
["chrome/browser/ui/ash/foo/BUILD.gn"],
["chrome/browser/ui/chromeos/BUILD.gn"],
["chrome/browser/ui/webui/ash/BUILD.gn"]])
def testComplexFormatting(self):
new_contents = [
'source_set("foo") {',
' sources = [ "../0", "a/1",]',
'\tsources += ["a/2" ]',
'sources += [ # bla',
' "a/3",',
' ]',
' # sources = ["a/b"]',
'sources += # bla',
' ["a/4"]#bla',
'}',
'static_library("bar"){',
' deps = []',
' sources = []',
' if (something) {',
' sources += [',
'',
' "a/5", "ab", "a/6","a/7",# "a/b"',
' "a/8"]',
' sources',
' += [ "a/9" ]}',
'}',
]
mock_output_api = MockOutputApi()
mock_input_api = MockInputApi()
mock_input_api.files = [
MockAffectedFile('chrome/browser/ash/BUILD.gn', new_contents),
]
results = PRESUBMIT._CheckBuildFilesForIndirectAshSources(mock_input_api,
mock_output_api)
self.assertEqual(len(results), 1)
self.assertEqual(results[0].message, self.MESSAGE)
self.assertEqual(results[0].items, ["chrome/browser/ash/BUILD.gn"])
self.assertEqual(
[s.lstrip() for s in results[0].long_text.splitlines()[1:]],
['../0', 'a/1', 'a/2', 'a/3', 'a/4', 'a/5', 'a/6', 'a/7', 'a/8', 'a/9'])
def testModifications(self):
old_contents = [
'source_set("foo") {',
' sources = ["x/y", "a/b"]',
'}',
]
new_contents_good = [
'source_set("foo") {',
' sources = ["x/y", "ab"]',
'}',
]
new_contents_bad = [
'source_set("foo") {',
' sources = ["x/y", "a/b", "a/c"]',
'}',
]
mock_output_api = MockOutputApi()
mock_input_api = MockInputApi()
mock_input_api.files = [
MockAffectedFile('chrome/browser/ash/BUILD.gn',
new_contents_bad, old_contents),
MockAffectedFile('chrome/browser/chromeos/BUILD.gn',
new_contents_good, old_contents),
]
results = PRESUBMIT._CheckBuildFilesForIndirectAshSources(mock_input_api,
mock_output_api)
self.assertEqual(len(results), 1)
self.assertEqual(results[0].message, self.MESSAGE)
self.assertEqual(results[0].items, ["chrome/browser/ash/BUILD.gn"])
self.assertEqual(
[s.lstrip() for s in results[0].long_text.splitlines()[1:]],
['a/c'])
if __name__ == '__main__':
unittest.main()
|
