1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#import "chrome/browser/app_controller_mac.h"
#import <Cocoa/Cocoa.h>
#import <Foundation/Foundation.h>
#import <objc/runtime.h>
#include <stddef.h>
#include <string>
#include "base/apple/foundation_util.h"
#include "base/apple/scoped_objc_class_swizzler.h"
#include "base/command_line.h"
#include "base/files/scoped_temp_dir.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "base/path_service.h"
#include "base/run_loop.h"
#include "base/scoped_observation.h"
#include "base/strings/string_util.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/threading/thread_restrictions.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/apps/platform_apps/app_browsertest_util.h"
#include "chrome/browser/bookmarks/bookmark_merged_surface_service.h"
#include "chrome/browser/bookmarks/bookmark_merged_surface_service_factory.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/bookmarks/bookmark_test_helpers.h"
#include "chrome/browser/browser_features.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/first_run/first_run.h"
#include "chrome/browser/history/history_service_factory.h"
#include "chrome/browser/lifetime/application_lifetime.h"
#include "chrome/browser/lifetime/application_lifetime_desktop.h"
#include "chrome/browser/prefs/incognito_mode_prefs.h"
#include "chrome/browser/profiles/delete_profile_helper.h"
#include "chrome/browser/profiles/keep_alive/profile_keep_alive_types.h"
#include "chrome/browser/profiles/profile_attributes_entry.h"
#include "chrome/browser/profiles/profile_attributes_init_params.h"
#include "chrome/browser/profiles/profile_attributes_storage.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/profiles/profile_metrics.h"
#include "chrome/browser/profiles/profile_observer.h"
#include "chrome/browser/profiles/profile_test_util.h"
#include "chrome/browser/shortcuts/chrome_webloc_file.h"
#include "chrome/browser/signin/signin_util.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_finder.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/browser_navigator_params.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.h"
#include "chrome/browser/ui/cocoa/history_menu_bridge.h"
#include "chrome/browser/ui/cocoa/test/run_loop_testing.h"
#include "chrome/browser/ui/profiles/profile_picker.h"
#include "chrome/browser/ui/profiles/profile_ui_test_utils.h"
#include "chrome/browser/ui/search/ntp_test_utils.h"
#include "chrome/browser/ui/startup/first_run_service.h"
#include "chrome/browser/ui/tabs/tab_enums.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/ui_features.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/account_id/account_id.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/policy/core/common/policy_pref_names.h"
#include "components/prefs/pref_service.h"
#include "components/signin/public/base/signin_switches.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/prerender_test_util.h"
#include "content/public/test/test_navigation_observer.h"
#include "extensions/browser/app_window/app_window_registry.h"
#include "extensions/browser/extension_dialog_auto_confirm.h"
#include "extensions/common/extension.h"
#include "extensions/test/extension_test_message_listener.h"
#include "net/base/apple/url_conversions.h"
#include "net/base/filename_util.h"
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "third_party/blink/public/common/features.h"
#import "ui/events/test/cocoa_test_event_utils.h"
#include "ui/views/test/dialog_test.h"
#include "ui/views/widget/any_widget_observer.h"
#include "ui/views/widget/widget.h"
namespace {
GURL g_open_shortcut_url;
// Instructs the NSApp's delegate to open |url|.
void SendOpenUrlToAppController(const GURL& url) {
[NSApp.delegate application:NSApp openURLs:@[ net::NSURLWithGURL(url) ]];
}
Profile& CreateAndWaitForProfile(const base::FilePath& profile_dir) {
Profile& profile = profiles::testing::CreateProfileSync(
g_browser_process->profile_manager(), profile_dir);
return profile;
}
void CreateAndWaitForSystemProfile() {
CreateAndWaitForProfile(ProfileManager::GetSystemProfilePath());
}
Profile& CreateAndWaitForGuestProfile() {
return CreateAndWaitForProfile(ProfileManager::GetGuestProfilePath());
}
void SetGuestProfileAsLastProfile() {
AppController* app_controller = AppController.sharedController;
// Create the guest profile, and set it as the last used profile.
Profile& guest_profile = CreateAndWaitForGuestProfile();
[app_controller setLastProfile:&guest_profile];
Profile* profile = [app_controller lastProfileIfLoaded];
ASSERT_TRUE(profile);
EXPECT_EQ(guest_profile.GetPath(), profile->GetPath());
EXPECT_TRUE(profile->IsGuestSession());
// Also set the last used profile path preference. If the profile does need to
// be read from disk for some reason this acts as a backstop.
g_browser_process->local_state()->SetString(
prefs::kProfileLastUsed, guest_profile.GetPath().BaseName().value());
}
// Key for ProfileDestroyedData user data.
const char kProfileDestructionWaiterUserDataKey = 0;
// Waits until the Profile instance is destroyed.
class ProfileDestructionWaiter {
public:
explicit ProfileDestructionWaiter(Profile* profile) {
profile->SetUserData(
&kProfileDestructionWaiterUserDataKey,
std::make_unique<ProfileDestroyedData>(run_loop_.QuitClosure()));
}
void Wait() { run_loop_.Run(); }
private:
// Simple user data that calls a callback at destruction.
class ProfileDestroyedData : public base::SupportsUserData::Data {
public:
explicit ProfileDestroyedData(base::OnceClosure callback)
: scoped_closure_runner_(std::move(callback)) {}
private:
base::ScopedClosureRunner scoped_closure_runner_;
};
base::RunLoop run_loop_;
};
} // namespace
@interface TestOpenShortcutOnStartup : NSObject
- (void)applicationWillFinishLaunching:(NSNotification*)notification;
@end
@implementation TestOpenShortcutOnStartup
- (void)applicationWillFinishLaunching:(NSNotification*)notification {
if (!g_open_shortcut_url.is_valid())
return;
SendOpenUrlToAppController(g_open_shortcut_url);
}
@end
namespace {
using AppControllerBrowserTest = InProcessBrowserTest;
// Returns whether a window's pixels are actually on the screen, which is the
// case when it and all of its parents are marked visible.
bool IsReallyVisible(NSWindow* window) {
while (window) {
if (!window.visible)
return false;
window = [window parentWindow];
}
return true;
}
size_t CountVisibleWindows() {
size_t count = 0;
for (NSWindow* w in [NSApp windows])
count = count + (IsReallyVisible(w) ? 1 : 0);
return count;
}
// Returns how many visible NSWindows are expected for a given count of browser
// windows.
size_t ExpectedWindowCountForBrowserCount(size_t browsers) {
return browsers;
}
// Test browser shutdown with a command in the message queue.
IN_PROC_BROWSER_TEST_F(AppControllerBrowserTest, CommandDuringShutdown) {
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
EXPECT_EQ(ExpectedWindowCountForBrowserCount(1), CountVisibleWindows());
chrome::AttemptExit(); // Set chrome::IsTryingToQuit and close all windows.
// Opening a new window here is fine (unload handlers can also interrupt
// exit). But closing the window posts an autorelease on
// BrowserWindowController, which calls ~Browser() and, if that was the last
// Browser, it invokes applicationWillTerminate: (because IsTryingToQuit is
// set). So, verify assumptions then process that autorelease.
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
EXPECT_EQ(ExpectedWindowCountForBrowserCount(0), CountVisibleWindows());
base::RunLoop().RunUntilIdle();
EXPECT_EQ(0u, chrome::GetTotalBrowserCount());
EXPECT_EQ(ExpectedWindowCountForBrowserCount(0), CountVisibleWindows());
NSEvent* cmd_n = cocoa_test_event_utils::KeyEventWithKeyCode(
'n', 'n', NSEventTypeKeyDown, NSEventModifierFlagCommand);
[[NSApp mainMenu] performSelector:@selector(performKeyEquivalent:)
withObject:cmd_n
afterDelay:0];
// Let the run loop get flushed, during process cleanup and try not to crash.
}
class AppControllerKeepAliveBrowserTest : public InProcessBrowserTest {
protected:
AppControllerKeepAliveBrowserTest() {
features_.InitAndEnableFeature(features::kDestroyProfileOnBrowserClose);
}
base::test::ScopedFeatureList features_;
};
class AppControllerPlatformAppBrowserTest
: public extensions::PlatformAppBrowserTest {
protected:
AppControllerPlatformAppBrowserTest()
: active_browser_list_(BrowserList::GetInstance()) {}
void SetUpCommandLine(base::CommandLine* command_line) override {
PlatformAppBrowserTest::SetUpCommandLine(command_line);
command_line->AppendSwitchASCII(switches::kAppId,
"1234");
}
raw_ptr<const BrowserList> active_browser_list_;
};
// Test that if only a platform app window is open and no browser windows are
// open then a reopen event does nothing.
IN_PROC_BROWSER_TEST_F(AppControllerPlatformAppBrowserTest,
DISABLED_PlatformAppReopenWithWindows) {
NSUInteger old_window_count = NSApp.windows.count;
EXPECT_EQ(1u, active_browser_list_->size());
[AppController.sharedController applicationShouldHandleReopen:NSApp
hasVisibleWindows:YES];
// We do not EXPECT_TRUE the result here because the method
// deminiaturizes windows manually rather than return YES and have
// AppKit do it.
EXPECT_EQ(old_window_count, NSApp.windows.count);
EXPECT_EQ(1u, active_browser_list_->size());
}
IN_PROC_BROWSER_TEST_F(AppControllerPlatformAppBrowserTest,
DISABLED_ActivationFocusesBrowserWindow) {
ExtensionTestMessageListener listener("Launched");
const extensions::Extension* app =
InstallAndLaunchPlatformApp("minimal");
ASSERT_TRUE(listener.WaitUntilSatisfied());
NSWindow* app_window = extensions::AppWindowRegistry::Get(profile())
->GetAppWindowsForApp(app->id())
.front()
->GetNativeWindow()
.GetNativeNSWindow();
NSWindow* browser_window =
browser()->window()->GetNativeWindow().GetNativeNSWindow();
chrome::testing::NSRunLoopRunAllPending();
EXPECT_LE([NSApp.orderedWindows indexOfObject:app_window],
[NSApp.orderedWindows indexOfObject:browser_window]);
[AppController.sharedController applicationShouldHandleReopen:NSApp
hasVisibleWindows:YES];
chrome::testing::NSRunLoopRunAllPending();
EXPECT_LE([NSApp.orderedWindows indexOfObject:browser_window],
[NSApp.orderedWindows indexOfObject:app_window]);
}
class AppControllerWebAppBrowserTest : public InProcessBrowserTest {
protected:
AppControllerWebAppBrowserTest()
: active_browser_list_(BrowserList::GetInstance()) {}
void SetUpCommandLine(base::CommandLine* command_line) override {
command_line->AppendSwitchASCII(switches::kApp, GetAppURL());
}
std::string GetAppURL() const {
return "https://example.com/";
}
raw_ptr<const BrowserList> active_browser_list_;
};
// Test that in web app mode a reopen event opens the app URL.
IN_PROC_BROWSER_TEST_F(AppControllerWebAppBrowserTest,
WebAppReopenWithNoWindows) {
EXPECT_EQ(1u, active_browser_list_->size());
BOOL result =
[AppController.sharedController applicationShouldHandleReopen:NSApp
hasVisibleWindows:NO];
EXPECT_FALSE(result);
EXPECT_EQ(2u, active_browser_list_->size());
Browser* browser = active_browser_list_->get(0);
GURL current_url =
browser->tab_strip_model()->GetActiveWebContents()->GetURL();
EXPECT_EQ(GetAppURL(), current_url.spec());
}
class AppControllerProfilePickerBrowserTest : public InProcessBrowserTest {
public:
AppControllerProfilePickerBrowserTest()
: active_browser_list_(BrowserList::GetInstance()) {}
~AppControllerProfilePickerBrowserTest() override = default;
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
// Flag the profile picker as already shown in the past, to avoid additional
// feature onboarding logic.
g_browser_process->local_state()->SetBoolean(
prefs::kBrowserProfilePickerShown, true);
}
const BrowserList* active_browser_list() const {
return active_browser_list_;
}
// Brings the ProfilerPicker onscreen and returns its NSWindow.
NSWindow* ActivateProfilePicker() {
NSArray<NSWindow*>* startingWindows = [NSApp windows];
// ProfilePicker::Show() calls ProfilePicker::Display(), which, for tests,
// creates the profile asynchronously. Only after the profile gets created
// is the profile picker initialized and brought onscreen. Therefore, we
// need to wait for the picker to appear before proceeding with the test.
ProfilePicker::Show(ProfilePicker::Params::FromEntryPoint(
ProfilePicker::EntryPoint::kProfileMenuManageProfiles));
int counter = 5;
while (!ProfilePicker::IsActive() && counter--) {
base::TimeDelta delay = base::Seconds(1);
base::RunLoop run_loop;
base::SingleThreadTaskRunner::GetCurrentDefault()->PostDelayedTask(
FROM_HERE, run_loop.QuitClosure(), delay);
run_loop.Run();
}
EXPECT_TRUE(ProfilePicker::IsActive());
// The ProfilePicker is the new window in the list.
for (NSWindow* window in [NSApp windows]) {
if (![startingWindows containsObject:window]) {
return window;
}
}
return nil;
}
private:
raw_ptr<const BrowserList> active_browser_list_;
};
// Test that for a guest last profile, commandDispatch should open UserManager
// if guest mode is disabled. Note that this test might be flaky under ASAN
// due to https://crbug.com/674475. Please disable this test under ASAN
// as the tests below if that happened.
IN_PROC_BROWSER_TEST_F(AppControllerProfilePickerBrowserTest,
OpenGuestProfileOnlyIfGuestModeIsEnabled) {
SetGuestProfileAsLastProfile();
PrefService* local_state = g_browser_process->local_state();
local_state->SetBoolean(prefs::kBrowserGuestModeEnabled, false);
AppController* app_controller = AppController.sharedController;
NSMenu* menu = [app_controller applicationDockMenu:NSApp];
ASSERT_TRUE(menu);
NSMenuItem* item = [menu itemWithTag:IDC_NEW_WINDOW];
ASSERT_TRUE(item);
EXPECT_EQ(1u, active_browser_list()->size());
[app_controller commandDispatch:item];
base::RunLoop().RunUntilIdle();
EXPECT_EQ(1u, active_browser_list()->size());
EXPECT_TRUE(ProfilePicker::IsOpen());
ProfilePicker::Hide();
local_state->SetBoolean(prefs::kBrowserGuestModeEnabled, true);
[app_controller commandDispatch:item];
base::RunLoop().RunUntilIdle();
EXPECT_EQ(2u, active_browser_list()->size());
EXPECT_FALSE(ProfilePicker::IsOpen());
}
IN_PROC_BROWSER_TEST_F(AppControllerProfilePickerBrowserTest,
AboutChromeGuestDisallowed) {
SetGuestProfileAsLastProfile();
// Disallow guest by policy and make sure "About Chrome" is not available
// in the menu.
PrefService* local_state = g_browser_process->local_state();
local_state->SetBoolean(prefs::kBrowserGuestModeEnabled, false);
NSMenuItem* about_menu_item = [[[NSApp.mainMenu itemWithTag:IDC_CHROME_MENU]
submenu] itemWithTag:IDC_ABOUT];
EXPECT_FALSE([AppController.sharedController
validateUserInterfaceItem:about_menu_item]);
}
// Test that for a regular last profile, a reopen event opens a browser.
IN_PROC_BROWSER_TEST_F(AppControllerProfilePickerBrowserTest,
RegularProfileReopenWithNoWindows) {
EXPECT_EQ(1u, active_browser_list()->size());
BOOL result =
[AppController.sharedController applicationShouldHandleReopen:NSApp
hasVisibleWindows:NO];
EXPECT_FALSE(result);
EXPECT_EQ(2u, active_browser_list()->size());
EXPECT_FALSE(ProfilePicker::IsOpen());
}
// Test that for a locked last profile, a reopen event opens the ProfilePicker.
IN_PROC_BROWSER_TEST_F(AppControllerProfilePickerBrowserTest,
LockedProfileReopenWithNoWindows) {
signin_util::ScopedForceSigninSetterForTesting signin_setter(true);
// The User Manager uses the system profile as its underlying profile. To
// minimize flakiness due to the scheduling/descheduling of tasks on the
// different threads, pre-initialize the guest profile before it is needed.
CreateAndWaitForSystemProfile();
AppController* app_controller = AppController.sharedController;
// Lock the active profile.
Profile* profile = [app_controller lastProfileIfLoaded];
ProfileAttributesEntry* entry =
g_browser_process->profile_manager()
->GetProfileAttributesStorage()
.GetProfileAttributesWithPath(profile->GetPath());
ASSERT_NE(entry, nullptr);
entry->LockForceSigninProfile(true);
EXPECT_TRUE(entry->IsSigninRequired());
EXPECT_EQ(1u, active_browser_list()->size());
BOOL result = [app_controller applicationShouldHandleReopen:NSApp
hasVisibleWindows:NO];
EXPECT_FALSE(result);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(1u, active_browser_list()->size());
EXPECT_TRUE(ProfilePicker::IsOpen());
ProfilePicker::Hide();
}
// "About Chrome" does not unlock the profile (regression test for
// https://crbug.com/1226844).
IN_PROC_BROWSER_TEST_F(AppControllerProfilePickerBrowserTest,
AboutPanelDoesNotUnlockProfile) {
signin_util::ScopedForceSigninSetterForTesting signin_setter(true);
// The User Manager uses the system profile as its underlying profile. To
// minimize flakiness due to the scheduling/descheduling of tasks on the
// different threads, pre-initialize the guest profile before it is needed.
CreateAndWaitForSystemProfile();
AppController* app_controller = AppController.sharedController;
// Lock the active profile.
Profile* profile = [app_controller lastProfileIfLoaded];
ProfileAttributesEntry* entry =
g_browser_process->profile_manager()
->GetProfileAttributesStorage()
.GetProfileAttributesWithPath(profile->GetPath());
ASSERT_NE(entry, nullptr);
entry->LockForceSigninProfile(true);
EXPECT_TRUE(entry->IsSigninRequired());
EXPECT_EQ(1u, active_browser_list()->size());
Browser* browser = active_browser_list()->get(0);
EXPECT_FALSE(browser->profile()->IsGuestSession());
// "About Chrome" is not available in the menu.
NSMenu* chrome_submenu =
[[NSApp.mainMenu itemWithTag:IDC_CHROME_MENU] submenu];
NSMenuItem* about_menu_item = [chrome_submenu itemWithTag:IDC_ABOUT];
EXPECT_FALSE([app_controller validateUserInterfaceItem:about_menu_item]);
[chrome_submenu update];
EXPECT_FALSE([about_menu_item isEnabled]);
}
// Test that for a guest last profile, a reopen event opens the ProfilePicker.
IN_PROC_BROWSER_TEST_F(AppControllerProfilePickerBrowserTest,
GuestProfileReopenWithNoWindows) {
SetGuestProfileAsLastProfile();
EXPECT_EQ(1u, active_browser_list()->size());
BOOL result =
[AppController.sharedController applicationShouldHandleReopen:NSApp
hasVisibleWindows:NO];
EXPECT_FALSE(result);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(1u, active_browser_list()->size());
EXPECT_TRUE(ProfilePicker::IsOpen());
ProfilePicker::Hide();
}
// Test that the ProfilePicker is shown when there are multiple profiles.
IN_PROC_BROWSER_TEST_F(AppControllerProfilePickerBrowserTest,
MultiProfilePickerShown) {
CreateAndWaitForSystemProfile();
// Add a profile in the cache (simulate another profile on disk).
ProfileManager* profile_manager = g_browser_process->profile_manager();
ProfileAttributesStorage* profile_storage =
&profile_manager->GetProfileAttributesStorage();
const base::FilePath profile_path =
profile_manager->GenerateNextProfileDirectoryPath();
ProfileAttributesInitParams params;
params.profile_path = profile_path;
params.profile_name = u"name_1";
profile_storage->AddProfile(std::move(params));
EXPECT_EQ(1u, active_browser_list()->size());
BOOL result =
[AppController.sharedController applicationShouldHandleReopen:NSApp
hasVisibleWindows:NO];
EXPECT_FALSE(result);
base::RunLoop().RunUntilIdle();
EXPECT_EQ(1u, active_browser_list()->size());
EXPECT_TRUE(ProfilePicker::IsOpen());
ProfilePicker::Hide();
}
// Checks that menu items and commands work when the profile picker is open.
IN_PROC_BROWSER_TEST_F(AppControllerProfilePickerBrowserTest, MenuCommands) {
AppController* app_controller = AppController.sharedController;
// Bring the ProfilePicker onscreen. In normal browser operation, it would
// be the mainWindow, but with Ventura, the test harness can't activate
// Chrome, and -mainWindow can return nil. Use a workaround to make it the
// main window.
NSWindow* profileWindow = ActivateProfilePicker();
[app_controller setMainWindowForTesting:profileWindow];
// Menus are updated before they are brought onscreen. This includes a call
// to -menuNeedsUpdate: to update the menu's items.
NSMenu* file_submenu = [[NSApp.mainMenu itemWithTag:IDC_FILE_MENU] submenu];
[app_controller menuNeedsUpdate:file_submenu];
// The Profiler Picker has no tabs, so Close Tab should not be present.
NSMenuItem* close_tab_menu_item = [file_submenu itemWithTag:IDC_CLOSE_TAB];
EXPECT_EQ(nil, close_tab_menu_item);
// Close Window should be available.
NSMenuItem* close_window_menu_item =
[file_submenu itemWithTag:IDC_CLOSE_WINDOW];
EXPECT_FALSE([close_window_menu_item isHidden]);
EXPECT_TRUE([NSApp validateMenuItem:close_window_menu_item]);
// Make sure New Window works.
NSMenuItem* new_window_menu_item = [file_submenu itemWithTag:IDC_NEW_WINDOW];
EXPECT_TRUE([new_window_menu_item isEnabled]);
EXPECT_TRUE([app_controller validateUserInterfaceItem:new_window_menu_item]);
// Activate the item and check that a new browser is opened.
ui_test_utils::BrowserChangeObserver browser_added_observer(
nullptr, ui_test_utils::BrowserChangeObserver::ChangeType::kAdded);
[file_submenu
performActionForItemAtIndex:[file_submenu
indexOfItem:new_window_menu_item]];
EXPECT_TRUE(browser_added_observer.Wait());
}
class AppControllerFirstRunBrowserTest : public AppControllerBrowserTest {
public:
void SetUpDefaultCommandLine(base::CommandLine* command_line) override {
InProcessBrowserTest::SetUpDefaultCommandLine(command_line);
command_line->RemoveSwitch(switches::kNoFirstRun);
}
};
IN_PROC_BROWSER_TEST_F(AppControllerFirstRunBrowserTest,
OpenNewWindowWhileFreIsRunning) {
EXPECT_TRUE(ProfilePicker::IsFirstRunOpen());
EXPECT_EQ(BrowserList::GetInstance()->size(), 0u);
AppController* app_controller = AppController.sharedController;
NSMenu* menu = [app_controller applicationDockMenu:NSApp];
ASSERT_TRUE(menu);
NSMenuItem* item = [menu itemWithTag:IDC_NEW_WINDOW];
ASSERT_TRUE(item);
[app_controller commandDispatch:item];
profiles::testing::WaitForPickerClosed();
EXPECT_FALSE(ProfilePicker::IsFirstRunOpen());
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
}
IN_PROC_BROWSER_TEST_F(AppControllerFirstRunBrowserTest,
ClickingChromeDockIconDoesNotOpenBrowser) {
EXPECT_TRUE(ProfilePicker::IsFirstRunOpen());
EXPECT_EQ(BrowserList::GetInstance()->size(), 0u);
[AppController.sharedController applicationShouldHandleReopen:NSApp
hasVisibleWindows:NO];
EXPECT_EQ(BrowserList::GetInstance()->size(), 0u);
ProfilePicker::Hide();
}
class AppControllerOpenShortcutBrowserTest : public InProcessBrowserTest {
protected:
AppControllerOpenShortcutBrowserTest() = default;
void SetUpInProcessBrowserTestFixture() override {
// In order to mimic opening shortcut during browser startup, we need to
// send the event before -applicationDidFinishLaunching is called, but
// after AppController is loaded.
//
// Since -applicationWillFinishLaunching does nothing now, we swizzle it to
// our function to send the event. We need to do this early before running
// the main message loop.
//
// NSApp does not exist yet. We need to get the AppController using
// reflection.
Class appControllerClass = NSClassFromString(@"AppController");
Class openShortcutClass = NSClassFromString(@"TestOpenShortcutOnStartup");
ASSERT_TRUE(appControllerClass != nil);
ASSERT_TRUE(openShortcutClass != nil);
SEL targetMethod = @selector(applicationWillFinishLaunching:);
Method original = class_getInstanceMethod(appControllerClass,
targetMethod);
Method destination = class_getInstanceMethod(openShortcutClass,
targetMethod);
ASSERT_TRUE(original);
ASSERT_TRUE(destination);
method_exchangeImplementations(original, destination);
ASSERT_TRUE(embedded_test_server()->Start());
g_open_shortcut_url = embedded_test_server()->GetURL("/simple.html");
}
void SetUpCommandLine(base::CommandLine* command_line) override {
// If the arg is empty, PrepareTestCommandLine() after this function will
// append about:blank as default url.
command_line->AppendArg(chrome::kChromeUINewTabURL);
}
};
IN_PROC_BROWSER_TEST_F(AppControllerOpenShortcutBrowserTest,
OpenShortcutOnStartup) {
EXPECT_EQ(1, browser()->tab_strip_model()->count());
EXPECT_EQ(g_open_shortcut_url,
browser()->tab_strip_model()->GetActiveWebContents()
->GetLastCommittedURL());
}
class AppControllerReplaceNTPBrowserTest : public InProcessBrowserTest {
protected:
AppControllerReplaceNTPBrowserTest() = default;
void SetUpInProcessBrowserTestFixture() override {
ASSERT_TRUE(embedded_test_server()->Start());
}
void SetUpCommandLine(base::CommandLine* command_line) override {
// If the arg is empty, PrepareTestCommandLine() after this function will
// append about:blank as default url.
command_line->AppendArg(chrome::kChromeUINewTabURL);
}
};
// Tests that when a GURL is opened after startup, it replaces the NTP.
// Flaky. See crbug.com/1234765.
IN_PROC_BROWSER_TEST_F(AppControllerReplaceNTPBrowserTest,
DISABLED_ReplaceNTPAfterStartup) {
// Depending on network connectivity, the NTP URL can either be
// chrome://newtab/ or chrome://new-tab-page-third-party. See
// ntp_test_utils::GetFinalNtpUrl for more details.
std::string expected_url =
ntp_test_utils::GetFinalNtpUrl(browser()->profile()).spec();
// Ensure that there is exactly 1 tab showing, and the tab is the NTP.
GURL ntp(expected_url);
EXPECT_EQ(1, browser()->tab_strip_model()->count());
browser()->tab_strip_model()->GetActiveWebContents()->GetController().LoadURL(
GURL(expected_url), content::Referrer(),
ui::PageTransition::PAGE_TRANSITION_LINK, std::string());
// Wait for one navigation on the active web contents.
content::TestNavigationObserver ntp_navigation_observer(
browser()->tab_strip_model()->GetActiveWebContents());
ntp_navigation_observer.Wait();
EXPECT_EQ(ntp,
browser()
->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL());
GURL simple(embedded_test_server()->GetURL("/simple.html"));
SendOpenUrlToAppController(simple);
EXPECT_EQ(1, browser()->tab_strip_model()->count());
content::TestNavigationObserver event_navigation_observer(
browser()->tab_strip_model()->GetActiveWebContents());
event_navigation_observer.Wait();
EXPECT_EQ(simple,
browser()
->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL());
}
// Tests that, even if an incognito browser is the last active browser, a GURL
// is opened in a regular (non-incognito) browser.
// Regression test for https://crbug.com/757253, https://crbug.com/1444747
IN_PROC_BROWSER_TEST_F(AppControllerBrowserTest, OpenInRegularBrowser) {
ASSERT_TRUE(embedded_test_server()->Start());
AppController* ac =
base::apple::ObjCCastStrict<AppController>([NSApp delegate]);
ASSERT_TRUE(ac);
// Create an incognito browser and make it the last active browser.
Browser* incognito_browser = CreateIncognitoBrowser(browser()->profile());
EXPECT_EQ(1, browser()->tab_strip_model()->count());
EXPECT_EQ(1, incognito_browser->tab_strip_model()->count());
EXPECT_TRUE(incognito_browser->profile()->IsIncognitoProfile());
EXPECT_EQ(incognito_browser, chrome::FindLastActive());
// Assure that `windowDidBecomeMain` is called even if this browser process
// lost focus because of other browser processes in other shards taking
// focus. It prevents flakiness.
// See: https://crrev.com/c/4530255/comments/2aadb9cf_9a39d4bf
[[NSNotificationCenter defaultCenter]
postNotificationName:NSWindowDidBecomeMainNotification
object:incognito_browser->window()
->GetNativeWindow()
.GetNativeNSWindow()];
// Open a url.
GURL simple(embedded_test_server()->GetURL("/simple.html"));
content::TestNavigationObserver event_navigation_observer(simple);
event_navigation_observer.StartWatchingNewWebContents();
SendOpenUrlToAppController(simple);
event_navigation_observer.Wait();
// It should be opened in the regular browser.
EXPECT_EQ(2, browser()->tab_strip_model()->count());
EXPECT_EQ(1, incognito_browser->tab_strip_model()->count());
EXPECT_EQ(simple, browser()
->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL());
}
// Tests that, even if only an incognito browser is currently opened, a GURL
// is opened in a regular (non-incognito) browser.
// Regression test for https://crbug.com/757253, https://crbug.com/1444747
IN_PROC_BROWSER_TEST_F(AppControllerBrowserTest,
OpenInRegularBrowserWhenOnlyIncognitoBrowserIsOpened) {
ASSERT_TRUE(embedded_test_server()->Start());
AppController* ac =
base::apple::ObjCCastStrict<AppController>([NSApp delegate]);
ASSERT_TRUE(ac);
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
// Close the current browser.
Profile* profile = browser()->profile();
chrome::CloseAllBrowsers();
ui_test_utils::WaitForBrowserToClose();
EXPECT_TRUE(BrowserList::GetInstance()->empty());
// Create an incognito browser and check that it is the last active browser.
Browser* incognito_browser = CreateIncognitoBrowser(profile);
EXPECT_TRUE(incognito_browser->profile()->IsIncognitoProfile());
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
EXPECT_EQ(incognito_browser, chrome::FindLastActive());
// Assure that `windowDidBecomeMain` is called even if this browser process
// lost focus because of other browser processes in other shards taking
// focus. It prevents flakiness.
// See: https://crrev.com/c/4530255/comments/2aadb9cf_9a39d4bf
[[NSNotificationCenter defaultCenter]
postNotificationName:NSWindowDidBecomeMainNotification
object:incognito_browser->window()
->GetNativeWindow()
.GetNativeNSWindow()];
// Open a url.
GURL simple(embedded_test_server()->GetURL("/simple.html"));
content::TestNavigationObserver event_navigation_observer(simple);
event_navigation_observer.StartWatchingNewWebContents();
SendOpenUrlToAppController(simple);
event_navigation_observer.Wait();
// Check that a new regular browser is opened
// and the url is opened in the regular browser.
Browser* new_browser = chrome::FindLastActive();
EXPECT_EQ(BrowserList::GetInstance()->size(), 2u);
EXPECT_TRUE(new_browser->profile()->IsRegularProfile());
EXPECT_EQ(profile, new_browser->profile());
EXPECT_EQ(simple, new_browser->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL());
}
// Tests that, if a guest browser is the last active browser, a GURL is opened
// in the guest browser.
IN_PROC_BROWSER_TEST_F(AppControllerBrowserTest, OpenUrlInGuestBrowser) {
ASSERT_TRUE(embedded_test_server()->Start());
AppController* ac =
base::apple::ObjCCastStrict<AppController>([NSApp delegate]);
ASSERT_TRUE(ac);
// Create a guest browser and make it the last active browser.
Browser* guest_browser = CreateGuestBrowser();
EXPECT_EQ(1, browser()->tab_strip_model()->count());
EXPECT_EQ(1, guest_browser->tab_strip_model()->count());
EXPECT_TRUE(guest_browser->profile()->IsGuestSession());
guest_browser->window()->Show();
EXPECT_EQ(guest_browser, chrome::FindLastActive());
// Assure that `windowDidBecomeMain` is called even if this browser process
// lost focus because of other browser processes in other shards taking
// focus. It prevents flakiness.
// See: https://crrev.com/c/4530255/comments/2aadb9cf_9a39d4bf
[[NSNotificationCenter defaultCenter]
postNotificationName:NSWindowDidBecomeMainNotification
object:guest_browser->window()
->GetNativeWindow()
.GetNativeNSWindow()];
// Open a url.
GURL simple(embedded_test_server()->GetURL("/simple.html"));
content::TestNavigationObserver event_navigation_observer(simple);
event_navigation_observer.StartWatchingNewWebContents();
SendOpenUrlToAppController(simple);
event_navigation_observer.Wait();
// It should be opened in the guest browser.
EXPECT_EQ(1, browser()->tab_strip_model()->count());
EXPECT_EQ(2, guest_browser->tab_strip_model()->count());
EXPECT_EQ(simple, guest_browser->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL());
}
// Tests that when a GURL is opened while incognito forced and there is no
// browser opened, it is opened in a new incognito browser.
// Test for https://crbug.com/1444747#c8
IN_PROC_BROWSER_TEST_F(AppControllerBrowserTest, OpenUrlWhenForcedIncognito) {
ASSERT_TRUE(embedded_test_server()->Start());
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
// Close the current non-incognito browser.
Profile* profile = browser()->profile();
chrome::CloseAllBrowsers();
ui_test_utils::WaitForBrowserToClose();
EXPECT_TRUE(BrowserList::GetInstance()->empty());
// Force incognito mode.
IncognitoModePrefs::SetAvailability(
profile->GetPrefs(), policy::IncognitoModeAvailability::kForced);
// Open a url.
GURL simple(embedded_test_server()->GetURL("/simple.html"));
content::TestNavigationObserver event_navigation_observer(simple);
event_navigation_observer.StartWatchingNewWebContents();
SendOpenUrlToAppController(simple);
event_navigation_observer.Wait();
// Check that a new incognito browser is opened
// and the url is opened in the incognito browser.
Browser* new_browser = chrome::FindLastActive();
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
EXPECT_TRUE(new_browser->profile()->IsIncognitoProfile());
EXPECT_TRUE(new_browser->profile()->IsPrimaryOTRProfile());
EXPECT_EQ(profile, new_browser->profile()->GetOriginalProfile());
EXPECT_EQ(simple, new_browser->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL());
}
// Tests that when a GURL is opened while incognito forced and an incognito
// browser is opened, it is opened in the already opened incognito browser.
// Test for https://crbug.com/1444747#c8
IN_PROC_BROWSER_TEST_F(AppControllerBrowserTest,
OpenUrlWhenForcedIncognitoAndIncognitoBrowserIsOpened) {
ASSERT_TRUE(embedded_test_server()->Start());
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
// Close the current non-incognito browser.
Profile* profile = browser()->profile();
chrome::CloseAllBrowsers();
ui_test_utils::WaitForBrowserToClose();
EXPECT_TRUE(BrowserList::GetInstance()->empty());
// Force incognito mode.
IncognitoModePrefs::SetAvailability(
profile->GetPrefs(), policy::IncognitoModeAvailability::kForced);
// Create an incognito browser.
Browser* incognito_browser = CreateIncognitoBrowser(profile);
EXPECT_TRUE(incognito_browser->profile()->IsIncognitoProfile());
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
EXPECT_EQ(1, incognito_browser->tab_strip_model()->count());
EXPECT_EQ(incognito_browser, chrome::FindLastActive());
// Assure that `windowDidBecomeMain` is called even if this browser process
// lost focus because of other browser processes in other shards taking
// focus. It prevents flakiness.
// See: https://crrev.com/c/4530255/comments/2aadb9cf_9a39d4bf
[[NSNotificationCenter defaultCenter]
postNotificationName:NSWindowDidBecomeMainNotification
object:incognito_browser->window()
->GetNativeWindow()
.GetNativeNSWindow()];
// Open a url.
GURL simple(embedded_test_server()->GetURL("/simple.html"));
content::TestNavigationObserver event_navigation_observer(simple);
event_navigation_observer.StartWatchingNewWebContents();
SendOpenUrlToAppController(simple);
event_navigation_observer.Wait();
// Check the url is opened in the already opened incognito browser.
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
EXPECT_EQ(2, incognito_browser->tab_strip_model()->count());
EXPECT_EQ(simple, incognito_browser->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL());
}
using AppControllerShortcutsNotAppsBrowserTest = InProcessBrowserTest;
IN_PROC_BROWSER_TEST_F(AppControllerShortcutsNotAppsBrowserTest,
OpenChromeWeblocFile) {
ASSERT_TRUE(embedded_test_server()->Start());
AppController* ac =
base::apple::ObjCCastStrict<AppController>([NSApp delegate]);
ASSERT_TRUE(ac);
// Create and open a .crwebloc file
GURL simple(embedded_test_server()->GetURL("/simple.html"));
base::ScopedTempDir temp_dir;
base::FilePath crwebloc_file;
{
base::ScopedAllowBlockingForTesting allow_blocking;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
crwebloc_file = temp_dir.GetPath().AppendASCII("test shortcut.crwebloc");
ASSERT_TRUE(shortcuts::ChromeWeblocFile(
simple, *base::SafeBaseName::Create(
browser()->profile()->GetPath()))
.SaveToFile(crwebloc_file));
}
content::TestNavigationObserver event_navigation_observer(simple);
event_navigation_observer.StartWatchingNewWebContents();
SendOpenUrlToAppController(net::FilePathToFileURL(crwebloc_file));
event_navigation_observer.Wait();
// It should be opened in the regular browser.
EXPECT_EQ(2, browser()->tab_strip_model()->count());
EXPECT_EQ(simple, browser()
->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL());
{
base::ScopedAllowBlockingForTesting allow_blocking;
EXPECT_TRUE(temp_dir.Delete());
}
}
IN_PROC_BROWSER_TEST_F(AppControllerShortcutsNotAppsBrowserTest,
OpenChromeWeblocFileInSecondProfile) {
ASSERT_TRUE(embedded_test_server()->Start());
AppController* ac =
base::apple::ObjCCastStrict<AppController>([NSApp delegate]);
ASSERT_TRUE(ac);
// Create profile 2.
Profile* profile2_ptr = nullptr;
{
base::ScopedAllowBlockingForTesting allow_blocking;
ProfileManager* profile_manager = g_browser_process->profile_manager();
profile2_ptr = profile_manager->GetProfile(
profile_manager->GenerateNextProfileDirectoryPath());
}
// Create and open a .crwebloc file
GURL simple(embedded_test_server()->GetURL("/simple.html"));
base::ScopedTempDir temp_dir;
base::FilePath crwebloc_file;
{
base::ScopedAllowBlockingForTesting allow_blocking;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
crwebloc_file = temp_dir.GetPath().AppendASCII("test shortcut.crwebloc");
ASSERT_TRUE(
shortcuts::ChromeWeblocFile(
simple, *base::SafeBaseName::Create(profile2_ptr->GetPath()))
.SaveToFile(crwebloc_file));
}
content::TestNavigationObserver event_navigation_observer(simple);
event_navigation_observer.StartWatchingNewWebContents();
SendOpenUrlToAppController(net::FilePathToFileURL(crwebloc_file));
event_navigation_observer.Wait();
// It should be opened in a new browser in the second profile.
EXPECT_EQ(1, browser()->tab_strip_model()->count());
Browser* new_browser = chrome::FindLastActive();
EXPECT_EQ(profile2_ptr, new_browser->profile());
EXPECT_EQ(1, new_browser->tab_strip_model()->count());
EXPECT_EQ(simple, new_browser->tab_strip_model()
->GetActiveWebContents()
->GetLastCommittedURL());
{
base::ScopedAllowBlockingForTesting allow_blocking;
EXPECT_TRUE(temp_dir.Delete());
}
}
IN_PROC_BROWSER_TEST_F(AppControllerShortcutsNotAppsBrowserTest,
LockedProfileOpensProfilePicker) {
// Flag the profile picker as already shown in the past, to avoid additional
// feature onboarding logic.
g_browser_process->local_state()->SetBoolean(
prefs::kBrowserProfilePickerShown, true);
signin_util::ScopedForceSigninSetterForTesting signin_setter(true);
// The User Manager uses the system profile as its underlying profile. To
// minimize flakiness due to the scheduling/descheduling of tasks on the
// different threads, pre-initialize the guest profile before it is needed.
CreateAndWaitForSystemProfile();
AppController* app_controller = AppController.sharedController;
// Lock the active profile.
Profile* profile = [app_controller lastProfileIfLoaded];
ProfileAttributesEntry* entry =
g_browser_process->profile_manager()
->GetProfileAttributesStorage()
.GetProfileAttributesWithPath(profile->GetPath());
ASSERT_NE(entry, nullptr);
entry->LockForceSigninProfile(true);
EXPECT_TRUE(entry->IsSigninRequired());
// Create and open a .crwebloc file
GURL simple("https://simple.invalid/");
base::ScopedTempDir temp_dir;
base::FilePath crwebloc_file;
{
base::ScopedAllowBlockingForTesting allow_blocking;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
crwebloc_file = temp_dir.GetPath().AppendASCII("test shortcut.crwebloc");
ASSERT_TRUE(shortcuts::ChromeWeblocFile(
simple, *base::SafeBaseName::Create(profile->GetPath()))
.SaveToFile(crwebloc_file));
}
SendOpenUrlToAppController(net::FilePathToFileURL(crwebloc_file));
auto* active_browser_list = BrowserList::GetInstance();
base::RunLoop().RunUntilIdle();
EXPECT_EQ(1u, active_browser_list->size());
EXPECT_TRUE(ProfilePicker::IsOpen());
ProfilePicker::Hide();
{
base::ScopedAllowBlockingForTesting allow_blocking;
EXPECT_TRUE(temp_dir.Delete());
}
}
class AppControllerMainMenuBrowserTest : public InProcessBrowserTest {
protected:
AppControllerMainMenuBrowserTest() = default;
};
IN_PROC_BROWSER_TEST_F(AppControllerMainMenuBrowserTest,
HistoryMenuResetAfterProfileDeletion) {
ProfileManager* profile_manager = g_browser_process->profile_manager();
AppController* app_controller = AppController.sharedController;
// Use the existing profile as profile 1.
Profile* profile1 = browser()->profile();
// Create profile 2.
base::FilePath profile2_path =
profile_manager->GenerateNextProfileDirectoryPath();
Profile& profile2 =
profiles::testing::CreateProfileSync(profile_manager, profile2_path);
// Load profile1's History Service backend so it will be assigned to the
// HistoryMenuBridge when setLastProfile is called, or else this test will
// fail flaky.
ui_test_utils::WaitForHistoryToLoad(HistoryServiceFactory::GetForProfile(
profile1, ServiceAccessType::EXPLICIT_ACCESS));
// Switch the controller to profile1.
[app_controller setLastProfile:profile1];
base::RunLoop().RunUntilIdle();
// Verify the controller's History Menu corresponds to profile1.
EXPECT_TRUE([app_controller historyMenuBridge]->service());
EXPECT_EQ([app_controller historyMenuBridge]->service(),
HistoryServiceFactory::GetForProfile(
profile1, ServiceAccessType::EXPLICIT_ACCESS));
// Load profile2's History Service backend so it will be assigned to the
// HistoryMenuBridge when setLastProfile is called, or else this test will
// fail flaky.
ui_test_utils::WaitForHistoryToLoad(HistoryServiceFactory::GetForProfile(
&profile2, ServiceAccessType::EXPLICIT_ACCESS));
// Switch the controller to profile2.
[app_controller setLastProfile:&profile2];
base::RunLoop().RunUntilIdle();
// Verify the controller's History Menu has changed.
EXPECT_TRUE([app_controller historyMenuBridge]->service());
EXPECT_EQ([app_controller historyMenuBridge]->service(),
HistoryServiceFactory::GetForProfile(
&profile2, ServiceAccessType::EXPLICIT_ACCESS));
EXPECT_NE(HistoryServiceFactory::GetForProfile(
profile1, ServiceAccessType::EXPLICIT_ACCESS),
HistoryServiceFactory::GetForProfile(
&profile2, ServiceAccessType::EXPLICIT_ACCESS));
// Delete profile2.
profile_manager->GetDeleteProfileHelper().MaybeScheduleProfileForDeletion(
profile2.GetPath(), base::DoNothing(),
ProfileMetrics::DELETE_PROFILE_USER_MANAGER);
content::RunAllTasksUntilIdle();
// Verify the controller's history is back to profile1.
EXPECT_EQ([app_controller historyMenuBridge]->service(),
HistoryServiceFactory::GetForProfile(
profile1, ServiceAccessType::EXPLICIT_ACCESS));
}
// Disabled because of flakiness. See crbug.com/1278031.
IN_PROC_BROWSER_TEST_F(AppControllerMainMenuBrowserTest,
DISABLED_ReloadingDestroyedProfileDoesNotCrash) {
ProfileManager* profile_manager = g_browser_process->profile_manager();
AppController* app_controller = AppController.sharedController;
Profile* profile = browser()->profile();
base::FilePath profile_path = profile->GetPath();
// Switch the controller to |profile|.
[app_controller setLastProfile:profile];
base::RunLoop().RunUntilIdle();
EXPECT_EQ(profile, [app_controller lastProfileIfLoaded]);
// Trigger Profile* destruction. Note that this event (destruction from
// memory) is a separate event from profile deletion (from disk).
chrome::CloseAllBrowsers();
ProfileDestructionWaiter(profile).Wait();
EXPECT_EQ(nullptr, [app_controller lastProfileIfLoaded]);
// Re-open the profile. Since the Profile* is destroyed, this involves loading
// it from disk.
base::ScopedAllowBlockingForTesting allow_blocking;
profile = profile_manager->GetProfile(profile_path);
[app_controller setLastProfile:profile];
base::RunLoop().RunUntilIdle();
// We mostly want to make sure re-loading the same profile didn't cause a
// crash. This means we didn't have e.g. a dangling ProfilePrefRegistrar, or
// observers pointing to the old (now dead) Profile.
EXPECT_EQ(profile, [app_controller lastProfileIfLoaded]);
}
IN_PROC_BROWSER_TEST_F(AppControllerMainMenuBrowserTest,
BookmarksMenuIsRestoredAfterProfileSwitch) {
ProfileManager* profile_manager = g_browser_process->profile_manager();
AppController* app_controller = AppController.sharedController;
[app_controller mainMenuCreated];
// Constants for bookmarks that we will create later.
const std::u16string title1(u"Dinosaur Comics");
const GURL url1("http://qwantz.com//");
const std::u16string title2(u"XKCD");
const GURL url2("https://www.xkcd.com/");
// Use the existing profile as profile 1.
Profile* profile1 = browser()->profile();
WaitForBookmarkMergedSurfaceServiceToLoad(
BookmarkMergedSurfaceServiceFactory::GetForProfile(profile1));
// Create profile 2.
base::ScopedAllowBlockingForTesting allow_blocking;
base::FilePath path2 = profile_manager->GenerateNextProfileDirectoryPath();
std::unique_ptr<Profile> profile2 =
Profile::CreateProfile(path2, nullptr, Profile::CreateMode::kSynchronous);
Profile* profile2_ptr = profile2.get();
profile_manager->RegisterTestingProfile(std::move(profile2), false);
WaitForBookmarkMergedSurfaceServiceToLoad(
BookmarkMergedSurfaceServiceFactory::GetForProfile(profile2_ptr));
// Switch to profile 1, create bookmark 1 and force the menu to build.
[app_controller setLastProfile:profile1];
[app_controller bookmarkMenuBridge]->GetBookmarkModelForTesting()
-> AddURL([app_controller bookmarkMenuBridge]
->GetBookmarkModelForTesting() -> bookmark_bar_node(),
0, title1, url1);
NSMenu* profile1_submenu =
[app_controller bookmarkMenuBridge]->BookmarkMenu();
[[profile1_submenu delegate] menuNeedsUpdate:profile1_submenu];
// Switch to profile 2, create bookmark 2 and force the menu to build.
[app_controller setLastProfile:profile2_ptr];
[app_controller bookmarkMenuBridge]->GetBookmarkModelForTesting()
-> AddURL([app_controller bookmarkMenuBridge]
->GetBookmarkModelForTesting() -> bookmark_bar_node(),
0, title2, url2);
NSMenu* profile2_submenu =
[app_controller bookmarkMenuBridge]->BookmarkMenu();
[[profile2_submenu delegate] menuNeedsUpdate:profile2_submenu];
EXPECT_NE(profile1_submenu, profile2_submenu);
// Test that only bookmark 2 is shown.
EXPECT_FALSE([[app_controller bookmarkMenuBridge]->BookmarkMenu()
itemWithTitle:base::SysUTF16ToNSString(title1)]);
EXPECT_TRUE([[app_controller bookmarkMenuBridge]->BookmarkMenu()
itemWithTitle:base::SysUTF16ToNSString(title2)]);
// Switch *back* to profile 1 and *don't* force the menu to build.
[app_controller setLastProfile:profile1];
// Test that only bookmark 1 is shown in the restored menu.
EXPECT_TRUE([[app_controller bookmarkMenuBridge]->BookmarkMenu()
itemWithTitle:base::SysUTF16ToNSString(title1)]);
EXPECT_FALSE([[app_controller bookmarkMenuBridge]->BookmarkMenu()
itemWithTitle:base::SysUTF16ToNSString(title2)]);
// Ensure a cached menu was used.
EXPECT_EQ(profile1_submenu,
[app_controller bookmarkMenuBridge]->BookmarkMenu());
}
// Tests opening a new window from a browser command while incognito is forced.
// Regression test for https://crbug.com/1206726
IN_PROC_BROWSER_TEST_F(AppControllerMainMenuBrowserTest,
ForcedIncognito_NewWindow) {
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
// Close the current non-incognito browser.
Profile* profile = browser()->profile();
chrome::CloseAllBrowsers();
ui_test_utils::WaitForBrowserToClose();
EXPECT_TRUE(BrowserList::GetInstance()->empty());
// Force incognito mode.
IncognitoModePrefs::SetAvailability(
profile->GetPrefs(), policy::IncognitoModeAvailability::kForced);
// Simulate click on "New window".
ui_test_utils::BrowserChangeObserver browser_added_observer(
nullptr, ui_test_utils::BrowserChangeObserver::ChangeType::kAdded);
AppController* app_controller = AppController.sharedController;
NSMenu* menu = [app_controller applicationDockMenu:NSApp];
ASSERT_TRUE(menu);
NSMenuItem* item = [menu itemWithTag:IDC_NEW_WINDOW];
ASSERT_TRUE(item);
[app_controller commandDispatch:item];
// Check that a new incognito browser is opened.
Browser* new_browser = browser_added_observer.Wait();
EXPECT_EQ(BrowserList::GetInstance()->size(), 1u);
EXPECT_TRUE(new_browser->profile()->IsPrimaryOTRProfile());
EXPECT_EQ(profile, new_browser->profile()->GetOriginalProfile());
}
} // namespace
//--------------------------AppControllerHandoffBrowserTest---------------------
static GURL g_handoff_url;
static std::u16string g_handoff_title;
@interface AppController (BrowserTest)
- (void)new_updateHandoffManagerWithURL:(const GURL&)handoffURL
title:(const std::u16string&)handoffTitle;
@end
@implementation AppController (BrowserTest)
- (void)new_updateHandoffManagerWithURL:(const GURL&)handoffURL
title:(const std::u16string&)handoffTitle {
g_handoff_url = handoffURL;
g_handoff_title = handoffTitle;
}
@end
namespace {
class AppControllerHandoffBrowserTest : public InProcessBrowserTest {
protected:
// Swizzle Handoff related implementations.
void SetUpInProcessBrowserTestFixture() override {
// This swizzle intercepts the URL that would be sent to the Handoff
// Manager, and instead puts it into a variable accessible to this test.
swizzler_ = std::make_unique<base::apple::ScopedObjCClassSwizzler>(
[AppController class], @selector(updateHandoffManagerWithURL:title:),
@selector(new_updateHandoffManagerWithURL:title:));
}
void TearDownInProcessBrowserTestFixture() override { swizzler_.reset(); }
// Closes the tab, and waits for the close to finish.
void CloseTab(Browser* browser, int index) {
content::WebContentsDestroyedWatcher destroyed_watcher(
browser->tab_strip_model()->GetWebContentsAt(index));
browser->tab_strip_model()->CloseWebContentsAt(
index, TabCloseTypes::CLOSE_CREATE_HISTORICAL_TAB);
destroyed_watcher.Wait();
}
private:
std::unique_ptr<base::apple::ScopedObjCClassSwizzler> swizzler_;
};
// Tests that as a user switches between tabs, navigates within a tab, and
// switches between browser windows, the correct URL is being passed to the
// Handoff.
IN_PROC_BROWSER_TEST_F(AppControllerHandoffBrowserTest, TestHandoffURLs) {
ASSERT_TRUE(embedded_test_server()->Start());
EXPECT_EQ(g_handoff_url, GURL(url::kAboutBlankURL));
EXPECT_EQ(g_handoff_title, u"about:blank");
// Test that navigating to a URL updates the handoff manager.
GURL test_url1 = embedded_test_server()->GetURL("/title1.html");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), test_url1));
EXPECT_EQ(g_handoff_url, test_url1);
EXPECT_TRUE(base::EndsWith(g_handoff_title, u"title1.html"));
// Test that opening a new tab updates the handoff URL.
GURL test_url2 = embedded_test_server()->GetURL("/title2.html");
NavigateParams params(browser(), test_url2, ui::PAGE_TRANSITION_LINK);
params.disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
ui_test_utils::NavigateToURL(¶ms);
EXPECT_EQ(g_handoff_url, test_url2);
// Test that switching tabs updates the handoff URL.
browser()->tab_strip_model()->ActivateTabAt(
0, TabStripUserGestureDetails(
TabStripUserGestureDetails::GestureType::kOther));
EXPECT_EQ(g_handoff_url, test_url1);
EXPECT_TRUE(base::EndsWith(g_handoff_title, u"title1.html"));
// Test that closing the current tab updates the handoff URL.
CloseTab(browser(), 0);
EXPECT_EQ(g_handoff_url, test_url2);
EXPECT_EQ(g_handoff_title, u"Title Of Awesomeness");
// Test that opening a new browser window updates the handoff URL.
GURL test_url3 = embedded_test_server()->GetURL("/title3.html");
ui_test_utils::NavigateToURLWithDisposition(
browser(), GURL(test_url3), WindowOpenDisposition::NEW_WINDOW,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP);
EXPECT_EQ(g_handoff_url, test_url3);
EXPECT_EQ(g_handoff_title, u"Title Of More Awesomeness");
// Check that there are exactly 2 browsers.
BrowserList* active_browser_list = BrowserList::GetInstance();
EXPECT_EQ(2u, active_browser_list->size());
// Close the second browser window (which only has 1 tab left).
Browser* browser2 = active_browser_list->get(1);
CloseBrowserSynchronously(browser2);
EXPECT_EQ(g_handoff_url, test_url2);
EXPECT_EQ(g_handoff_title, u"Title Of Awesomeness");
// The URLs of incognito windows should not be passed to Handoff.
GURL test_url4 = embedded_test_server()->GetURL("/simple.html");
ui_test_utils::NavigateToURLWithDisposition(
browser(), GURL(test_url4), WindowOpenDisposition::OFF_THE_RECORD,
ui_test_utils::BROWSER_TEST_WAIT_FOR_BROWSER);
EXPECT_EQ(g_handoff_url, GURL());
EXPECT_EQ(g_handoff_title, u"");
// Open a new tab in the incognito window.
EXPECT_EQ(2u, active_browser_list->size());
Browser* browser3 = active_browser_list->get(1);
ui_test_utils::NavigateToURLWithDisposition(
browser3, test_url4, WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_TAB);
EXPECT_EQ(g_handoff_url, GURL());
EXPECT_EQ(g_handoff_title, u"");
// Navigate the current tab in the incognito window.
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser3, test_url1));
EXPECT_EQ(g_handoff_url, GURL());
EXPECT_EQ(g_handoff_title, u"");
// Activate the original browser window.
Browser* browser1 = active_browser_list->get(0);
browser1->window()->Show();
EXPECT_EQ(g_handoff_url, test_url2);
EXPECT_EQ(g_handoff_title, u"Title Of Awesomeness");
}
class AppControllerHandoffPrerenderBrowserTest
: public AppControllerHandoffBrowserTest {
public:
void SetUpOnMainThread() override {
prerender_helper_.RegisterServerRequestMonitor(embedded_test_server());
host_resolver()->AddRule("*", "127.0.0.1");
embedded_test_server()->ServeFilesFromDirectory(
base::PathService::CheckedGet(chrome::DIR_TEST_DATA));
ASSERT_TRUE(embedded_test_server()->Start());
}
content::WebContents* GetActiveWebContents() {
return browser()->tab_strip_model()->GetActiveWebContents();
}
content::test::PrerenderTestHelper& prerender_helper() {
return prerender_helper_;
}
protected:
AppControllerHandoffPrerenderBrowserTest()
: prerender_helper_(base::BindRepeating(
&AppControllerHandoffPrerenderBrowserTest::GetActiveWebContents,
// Unretained is safe here, as this class owns PrerenderTestHelper
// object, which holds the callback being constructed here, so the
// callback will be destructed before this class.
base::Unretained(this))) {}
private:
content::test::PrerenderTestHelper prerender_helper_;
};
// Tests that as a user switches from main page to prerendered page, the correct
// URL is being passed to the Handoff.
IN_PROC_BROWSER_TEST_F(AppControllerHandoffPrerenderBrowserTest,
TestHandoffURLs) {
// Navigate to an initial page.
GURL url = embedded_test_server()->GetURL("/empty.html");
ASSERT_TRUE(content::NavigateToURL(GetActiveWebContents(), url));
// Start a prerender.
GURL prerender_url = embedded_test_server()->GetURL("/simple.html");
prerender_helper().AddPrerender(prerender_url);
EXPECT_EQ(g_handoff_url, url);
// Activate.
content::TestActivationManager navigation_manager(GetActiveWebContents(),
prerender_url);
ASSERT_TRUE(
content::ExecJs(GetActiveWebContents()->GetPrimaryMainFrame(),
content::JsReplace("location = $1", prerender_url)));
navigation_manager.WaitForNavigationFinished();
EXPECT_TRUE(navigation_manager.was_activated());
EXPECT_TRUE(navigation_manager.was_successful());
EXPECT_EQ(g_handoff_url, prerender_url);
}
} // namespace
|