1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
|
// Copyright 2015 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/browsing_data/core/counters/passwords_counter.h"
#include <memory>
#include "base/functional/bind.h"
#include "base/location.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "base/time/time.h"
#include "chrome/browser/password_manager/account_password_store_factory.h"
#include "chrome/browser/password_manager/profile_password_store_factory.h"
#include "chrome/browser/sync/sync_service_factory.h"
#include "chrome/browser/sync/test/integration/passwords_helper.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "components/browsing_data/core/browsing_data_utils.h"
#include "components/browsing_data/core/pref_names.h"
#include "components/password_manager/core/browser/password_form.h"
#include "components/password_manager/core/browser/password_store/password_store_interface.h"
#include "components/prefs/pref_service.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/test/browser_test.h"
namespace {
using browsing_data::BrowsingDataCounter;
using password_manager::PasswordForm;
class PasswordsCounterTest : public InProcessBrowserTest {
public:
void SetUpOnMainThread() override {
finished_ = false;
time_ = base::Time::Now();
times_used_in_html_form_ = 0;
store_ = ProfilePasswordStoreFactory::GetForProfile(
browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS)
.get();
SetPasswordsDeletionPref(true);
SetDeletionPeriodPref(browsing_data::TimePeriod::ALL_TIME);
}
void TearDownOnMainThread() override { store_ = nullptr; }
void AddLogin(const std::string& origin,
const std::string& username,
bool blocked_by_user) {
// Add login and wait until the password store actually changes.
// on the database thread.
store_->AddLogin(CreateCredentials(origin, username, blocked_by_user));
// GetLogins() blocks until reading on the background thread is finished.
passwords_helper::GetLogins(store_);
}
void RemoveLogin(const std::string& origin,
const std::string& username,
bool blocked_by_user) {
// Remove login and wait until the password store actually changes
// on the database thread.
store_->RemoveLogin(FROM_HERE,
CreateCredentials(origin, username, blocked_by_user));
// GetLogins() blocks until reading on the background thread is finished.
passwords_helper::GetLogins(store_);
}
void SetPasswordsDeletionPref(bool value) {
browser()->profile()->GetPrefs()->SetBoolean(
browsing_data::prefs::kDeletePasswords, value);
}
void SetDeletionPeriodPref(browsing_data::TimePeriod period) {
browser()->profile()->GetPrefs()->SetInteger(
browsing_data::prefs::kDeleteTimePeriod, static_cast<int>(period));
}
void RevertTimeInDays(int days) { time_ -= base::Days(days); }
void SetTimesUsed(int occurrences) { times_used_in_html_form_ = occurrences; }
void WaitForCounting() {
// The counting takes place on the background thread. Wait until it
// finishes. GetLogins() blocks until reading on the background thread is
// finished
passwords_helper::GetLogins(store_);
// At this point, the calculation on DB thread should have finished, and
// a callback should be scheduled on the UI thread. Process the tasks until
// we get a finished result.
if (finished_) {
return;
}
run_loop_ = std::make_unique<base::RunLoop>();
run_loop_->Run();
}
// Once the GetResult() or GetDomainExamples() is called, it can be called
// again until the next result is available.
BrowsingDataCounter::ResultInt GetResult() {
DCHECK(finished_);
// Some tests call WaitForCounting() multiple times. Set `finished_` to
// false such that next call of WaitForCounting() will indeed block until
// counting is done.
finished_ = false;
return result_;
}
// Once the GetResult() or GetDomainExamples() is called, it can be called
// again until the next result is available.
std::vector<std::string> GetDomainExamples() {
DCHECK(finished_);
// Some tests call WaitForCounting() multiple times. Set `finished_` to
// false such that next call of WaitForCounting() will indeed block until
// counting is done.
finished_ = false;
return domain_examples_;
}
void Callback(std::unique_ptr<BrowsingDataCounter::Result> result) {
DCHECK(result);
finished_ = result->Finished();
if (finished_) {
auto* password_result =
static_cast<browsing_data::PasswordsCounter::PasswordsResult*>(
result.get());
result_ = password_result->Value();
domain_examples_ = password_result->domain_examples();
}
if (run_loop_ && finished_) {
run_loop_->Quit();
}
}
private:
PasswordForm CreateCredentials(const std::string& origin,
const std::string& username,
bool blocked_by_user) {
PasswordForm result;
result.signon_realm = origin;
result.url = GURL(origin);
if (!blocked_by_user) {
result.username_value = base::ASCIIToUTF16(username);
result.password_value = u"hunter2";
}
result.blocked_by_user = blocked_by_user;
result.date_created = time_;
result.times_used_in_html_form = times_used_in_html_form_;
return result;
}
raw_ptr<password_manager::PasswordStoreInterface> store_ = nullptr;
std::unique_ptr<base::RunLoop> run_loop_;
base::Time time_;
int times_used_in_html_form_;
bool finished_;
BrowsingDataCounter::ResultInt result_;
std::vector<std::string> domain_examples_;
};
// Tests that the counter correctly counts each individual credential on
// the same domain.
IN_PROC_BROWSER_TEST_F(PasswordsCounterTest, SameDomain) {
AddLogin("https://www.google.com", "user1", false);
AddLogin("https://www.google.com", "user2", false);
AddLogin("https://www.google.com", "user3", false);
AddLogin("https://www.chrome.com", "user1", false);
AddLogin("https://www.chrome.com", "user2", false);
Profile* profile = browser()->profile();
browsing_data::PasswordsCounter counter(
ProfilePasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
AccountPasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
profile->GetPrefs(), SyncServiceFactory::GetForProfile(profile));
counter.Init(profile->GetPrefs(),
browsing_data::ClearBrowsingDataTab::ADVANCED,
base::BindRepeating(&PasswordsCounterTest::Callback,
base::Unretained(this)));
counter.Restart();
WaitForCounting();
EXPECT_EQ(5u, GetResult());
}
// Tests that the counter doesn't count blocklisted entries.
IN_PROC_BROWSER_TEST_F(PasswordsCounterTest, blocklisted) {
AddLogin("https://www.google.com", "user1", false);
AddLogin("https://www.google.com", "", true);
AddLogin("https://www.chrome.com", "", true);
Profile* profile = browser()->profile();
browsing_data::PasswordsCounter counter(
ProfilePasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
AccountPasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
profile->GetPrefs(), SyncServiceFactory::GetForProfile(profile));
counter.Init(profile->GetPrefs(),
browsing_data::ClearBrowsingDataTab::ADVANCED,
base::BindRepeating(&PasswordsCounterTest::Callback,
base::Unretained(this)));
counter.Restart();
WaitForCounting();
EXPECT_EQ(1u, GetResult());
}
// Tests that the counter starts counting automatically when the deletion
// pref changes to true.
IN_PROC_BROWSER_TEST_F(PasswordsCounterTest, PrefChanged) {
SetPasswordsDeletionPref(false);
AddLogin("https://www.google.com", "user", false);
AddLogin("https://www.chrome.com", "user", false);
Profile* profile = browser()->profile();
browsing_data::PasswordsCounter counter(
ProfilePasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
AccountPasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
profile->GetPrefs(), SyncServiceFactory::GetForProfile(profile));
counter.Init(profile->GetPrefs(),
browsing_data::ClearBrowsingDataTab::ADVANCED,
base::BindRepeating(&PasswordsCounterTest::Callback,
base::Unretained(this)));
SetPasswordsDeletionPref(true);
WaitForCounting();
EXPECT_EQ(2u, GetResult());
}
// Tests that the counter starts counting automatically when
// the password store changes.
IN_PROC_BROWSER_TEST_F(PasswordsCounterTest, StoreChanged) {
AddLogin("https://www.google.com", "user", false);
Profile* profile = browser()->profile();
browsing_data::PasswordsCounter counter(
ProfilePasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
AccountPasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
profile->GetPrefs(), SyncServiceFactory::GetForProfile(profile));
counter.Init(profile->GetPrefs(),
browsing_data::ClearBrowsingDataTab::ADVANCED,
base::BindRepeating(&PasswordsCounterTest::Callback,
base::Unretained(this)));
counter.Restart();
WaitForCounting();
EXPECT_EQ(1u, GetResult());
AddLogin("https://www.chrome.com", "user", false);
WaitForCounting();
EXPECT_EQ(2u, GetResult());
RemoveLogin("https://www.chrome.com", "user", false);
WaitForCounting();
EXPECT_EQ(1u, GetResult());
}
// Tests that changing the deletion period restarts the counting, and that
// the result takes login creation dates into account.
IN_PROC_BROWSER_TEST_F(PasswordsCounterTest, PeriodChanged) {
AddLogin("https://www.google.com", "user", false);
RevertTimeInDays(2);
AddLogin("https://example.com", "user1", false);
RevertTimeInDays(3);
AddLogin("https://example.com", "user2", false);
RevertTimeInDays(30);
AddLogin("https://www.chrome.com", "user", false);
Profile* profile = browser()->profile();
browsing_data::PasswordsCounter counter(
ProfilePasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
AccountPasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
profile->GetPrefs(), SyncServiceFactory::GetForProfile(profile));
counter.Init(profile->GetPrefs(),
browsing_data::ClearBrowsingDataTab::ADVANCED,
base::BindRepeating(&PasswordsCounterTest::Callback,
base::Unretained(this)));
SetDeletionPeriodPref(browsing_data::TimePeriod::LAST_HOUR);
WaitForCounting();
EXPECT_EQ(1u, GetResult());
SetDeletionPeriodPref(browsing_data::TimePeriod::LAST_DAY);
WaitForCounting();
EXPECT_EQ(1u, GetResult());
SetDeletionPeriodPref(browsing_data::TimePeriod::LAST_WEEK);
WaitForCounting();
EXPECT_EQ(3u, GetResult());
SetDeletionPeriodPref(browsing_data::TimePeriod::FOUR_WEEKS);
WaitForCounting();
EXPECT_EQ(3u, GetResult());
SetDeletionPeriodPref(browsing_data::TimePeriod::OLDER_THAN_30_DAYS);
WaitForCounting();
EXPECT_EQ(1u, GetResult());
SetDeletionPeriodPref(browsing_data::TimePeriod::ALL_TIME);
WaitForCounting();
EXPECT_EQ(4u, GetResult());
}
// Tests that the two most commonly used domains are chosen as the listed domain
// examples.
IN_PROC_BROWSER_TEST_F(PasswordsCounterTest, MostCommonDomains) {
SetTimesUsed(3);
AddLogin("https://www.google.com", "user", false);
SetTimesUsed(4);
AddLogin("https://wwww.maps.google.com", "user", false);
SetTimesUsed(1);
AddLogin("https://www.example.com", "user", false);
SetTimesUsed(2);
AddLogin("https://www.chrome.com", "user", false);
Profile* profile = browser()->profile();
browsing_data::PasswordsCounter counter(
ProfilePasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
AccountPasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
profile->GetPrefs(), SyncServiceFactory::GetForProfile(profile));
counter.Init(profile->GetPrefs(),
browsing_data::ClearBrowsingDataTab::ADVANCED,
base::BindRepeating(&PasswordsCounterTest::Callback,
base::Unretained(this)));
counter.Restart();
WaitForCounting();
std::vector<std::string> domain_examples = {"google.com", "chrome.com"};
EXPECT_EQ(domain_examples, GetDomainExamples());
}
// Tests that the counter doesn't crash if restarted in a quick succession.
// TODO(crbug.com/40918960): Upgrade this test to use SigninDataCounter.
IN_PROC_BROWSER_TEST_F(PasswordsCounterTest, MultipleRestarts) {
Profile* profile = browser()->profile();
browsing_data::PasswordsCounter counter(
ProfilePasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
AccountPasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::EXPLICIT_ACCESS),
profile->GetPrefs(), SyncServiceFactory::GetForProfile(profile));
counter.Init(profile->GetPrefs(),
browsing_data::ClearBrowsingDataTab::ADVANCED,
base::BindRepeating(&PasswordsCounterTest::Callback,
base::Unretained(this)));
counter.Restart();
counter.Restart();
counter.Restart();
// Previous restarts should be invalidated, so we only need to wait for
// counting once.
WaitForCounting();
}
} // namespace
|
