1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "base/strings/stringprintf.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/subresource_filter/subresource_filter_browser_test_harness.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/page_load_metrics/browser/observers/use_counter_page_load_metrics_observer.h"
#include "components/page_load_metrics/browser/page_load_metrics_test_waiter.h"
#include "components/subresource_filter/content/shared/browser/ruleset_service.h"
#include "components/subresource_filter/core/browser/subresource_filter_features.h"
#include "components/subresource_filter/core/common/activation_scope.h"
#include "components/subresource_filter/core/common/common_features.h"
#include "components/subresource_filter/core/common/test_ruleset_utils.h"
#include "components/subresource_filter/core/mojom/subresource_filter.mojom.h"
#include "content/public/common/content_switches.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/download_test_observer.h"
#include "content/public/test/test_navigation_observer.h"
#include "media/base/media_switches.h"
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/controllable_http_response.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/blink/public/common/features.h"
#include "url/gurl.h"
#include "url/url_constants.h"
namespace {
enum class OtherFrameNavigationType {
kUnrestrictedTopFrameNavigatesRestrictedSubframe,
kRestrictedSubframeNavigatesUnrestrictedTopFrame,
};
std::ostream& operator<<(std::ostream& os, OtherFrameNavigationType type) {
switch (type) {
case OtherFrameNavigationType::
kUnrestrictedTopFrameNavigatesRestrictedSubframe:
return os << "UnrestrictedTopFrameNavigatesRestrictedSubframe";
case OtherFrameNavigationType::
kRestrictedSubframeNavigatesUnrestrictedTopFrame:
return os << "RestrictedSubframeNavigatesUnrestrictedTopFrame";
}
}
enum class DownloadSource {
kNavigation,
kAnchorAttribute,
};
std::ostream& operator<<(std::ostream& os, DownloadSource source) {
switch (source) {
case DownloadSource::kNavigation:
return os << "Navigation";
case DownloadSource::kAnchorAttribute:
return os << "AnchorAttribute";
}
}
enum class SandboxOption {
kNotSandboxed,
kDisallowDownloads,
kAllowDownloads,
};
std::ostream& operator<<(std::ostream& os, SandboxOption sandbox_option) {
switch (sandbox_option) {
case SandboxOption::kNotSandboxed:
return os << "NotSandboxed";
case SandboxOption::kDisallowDownloads:
return os << "DisallowDownloads";
case SandboxOption::kAllowDownloads:
return os << "AllowDownloads";
}
}
const char kSandboxTokensDisallowDownloads[] =
"allow-scripts allow-same-origin allow-top-navigation allow-popups";
const char kSandboxTokensAllowDownloads[] =
"allow-scripts allow-same-origin allow-top-navigation allow-popups "
"allow-downloads";
// Allow PageLoadMetricsTestWaiter to be initialized for a new web content
// before the first commit.
class PopupPageLoadMetricsWaiterInitializer : public TabStripModelObserver {
public:
PopupPageLoadMetricsWaiterInitializer(
TabStripModel* tab_strip_model,
std::unique_ptr<page_load_metrics::PageLoadMetricsTestWaiter>* waiter)
: waiter_(waiter) {
tab_strip_model->AddObserver(this);
}
PopupPageLoadMetricsWaiterInitializer(
const PopupPageLoadMetricsWaiterInitializer&) = delete;
PopupPageLoadMetricsWaiterInitializer& operator=(
const PopupPageLoadMetricsWaiterInitializer&) = delete;
void OnTabStripModelChanged(
TabStripModel* tab_strip_model,
const TabStripModelChange& change,
const TabStripSelectionChange& selection) override {
if (change.type() == TabStripModelChange::kInserted &&
selection.active_tab_changed()) {
DCHECK(waiter_ && !(*waiter_));
*waiter_ = std::make_unique<page_load_metrics::PageLoadMetricsTestWaiter>(
tab_strip_model->GetActiveWebContents());
}
}
private:
raw_ptr<std::unique_ptr<page_load_metrics::PageLoadMetricsTestWaiter>>
waiter_;
};
} // namespace
class DownloadFramePolicyBrowserTest
: public subresource_filter::SubresourceFilterBrowserTest {
public:
~DownloadFramePolicyBrowserTest() override = default;
// Override embedded_test_server() with a variant that uses HTTPS to avoid
// insecure download warnings.
net::EmbeddedTestServer* embedded_test_server() {
return https_test_server_.get();
}
void SetUpOnMainThread() override {
host_resolver()->AddRule("*", "127.0.0.1");
SetRulesetWithRules(
{subresource_filter::testing::CreateSuffixRule("ad_script.js"),
subresource_filter::testing::CreateSuffixRule("disallow.zip")});
https_test_server_ = std::make_unique<net::EmbeddedTestServer>(
net::EmbeddedTestServer::TYPE_HTTPS);
embedded_test_server()->SetSSLConfig(
net::EmbeddedTestServer::CERT_TEST_NAMES);
embedded_test_server()->ServeFilesFromSourceDirectory(
"components/test/data/ad_tagging");
content::SetupCrossSiteRedirector(embedded_test_server());
ASSERT_TRUE(embedded_test_server()->Start());
}
// Trigger a download that is initiated and occurs in the same frame.
void TriggerDownloadSameFrame(const content::ToRenderFrameHost& adapter,
DownloadSource source,
bool initiate_with_gesture,
std::string file_name = "allow.zip") {
static constexpr char kADownloadScript[] = R"(
var a = document.createElement('a');
a.setAttribute('href', '%s');
a.download = '';
document.body.appendChild(a);
a.click();
)";
static constexpr char kNavDownloadScript[] = "window.location = '%s'";
std::string script =
source == DownloadSource::kAnchorAttribute
? base::StringPrintf(kADownloadScript, file_name.c_str())
: base::StringPrintf(kNavDownloadScript, file_name.c_str());
if (initiate_with_gesture) {
EXPECT_TRUE(ExecJs(adapter, script));
} else {
EXPECT_TRUE(
ExecJs(adapter, script, content::EXECUTE_SCRIPT_NO_USER_GESTURE));
}
}
// This method creates a top frame with a subframe inside it. The subframe
// can be configured with various frame attributes.
void InitializeOneSubframeSetup(SandboxOption sandbox_option,
bool is_ad_frame,
bool is_cross_origin) {
std::string host_name = "a.test";
GURL top_frame_url =
embedded_test_server()->GetURL(host_name, "/frame_factory.html");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), top_frame_url));
const char* method = is_ad_frame ? "createAdFrame" : "createFrame";
GURL subframe_url = embedded_test_server()->GetURL(
is_cross_origin ? "b.test" : host_name, "/frame_factory.html");
std::string script;
if (sandbox_option == SandboxOption::kNotSandboxed) {
script = content::JsReplace("window[$1]($2, $3)", method, subframe_url,
GetSubframeId());
} else {
const char* sandbox_token =
(sandbox_option == SandboxOption::kDisallowDownloads)
? kSandboxTokensDisallowDownloads
: kSandboxTokensAllowDownloads;
script = content::JsReplace("window[$1]($2, $3, $4)", method,
subframe_url, GetSubframeId(), sandbox_token);
}
content::TestNavigationObserver navigation_observer(web_contents());
EXPECT_TRUE(content::ExecJs(web_contents()->GetPrimaryMainFrame(), script,
content::EXECUTE_SCRIPT_NO_USER_GESTURE));
navigation_observer.Wait();
subframe_rfh_ = content::FrameMatchingPredicate(
web_contents()->GetPrimaryPage(),
base::BindRepeating(&content::FrameMatchesName, GetSubframeId()));
DCHECK(subframe_rfh_);
}
// This method creates a top frame with sandbox options through popups from a
// sandboxed subframe, and re-initialize |web_feature_waiter_| to watch for
// features in the new page.
void InitializeOneTopFrameSetup(SandboxOption sandbox_option) {
InitializeOneSubframeSetup(sandbox_option, false /* is_ad_frame */,
false /* is_cross_origin */);
std::string host_name = "a.test";
GURL main_url =
embedded_test_server()->GetURL(host_name, "/frame_factory.html");
web_feature_waiter_.reset();
auto waiter_initializer =
std::make_unique<PopupPageLoadMetricsWaiterInitializer>(
browser()->tab_strip_model(), &web_feature_waiter_);
content::TestNavigationObserver popup_observer(main_url);
popup_observer.StartWatchingNewWebContents();
EXPECT_TRUE(
ExecJs(GetSubframeRfh(), "window.open(\"" + main_url.spec() + "\");"));
popup_observer.Wait();
ASSERT_EQ(2, browser()->tab_strip_model()->count());
ASSERT_TRUE(browser()->tab_strip_model()->IsTabSelected(1));
subframe_rfh_ = nullptr;
}
void SetNumDownloadsExpectation(size_t num_downloads) {
if (num_downloads > 0) {
download_observer_ =
std::make_unique<content::DownloadTestObserverTerminal>(
browser()->profile()->GetDownloadManager(),
num_downloads /* wait_count */,
content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL);
}
expected_num_downloads_ = num_downloads;
}
void CheckNumDownloadsExpectation() {
if (download_observer_)
download_observer_->WaitForFinished();
std::vector<raw_ptr<download::DownloadItem, VectorExperimental>>
download_items;
content::DownloadManager* manager =
browser()->profile()->GetDownloadManager();
manager->GetAllDownloads(&download_items);
EXPECT_EQ(expected_num_downloads_, download_items.size());
}
void InitializeHistogramTesterAndWebFeatureWaiter() {
histogram_tester_ = std::make_unique<base::HistogramTester>();
web_feature_waiter_ =
std::make_unique<page_load_metrics::PageLoadMetricsTestWaiter>(
web_contents());
}
base::HistogramTester* GetHistogramTester() {
return histogram_tester_.get();
}
page_load_metrics::PageLoadMetricsTestWaiter* GetWebFeatureWaiter() {
return web_feature_waiter_.get();
}
content::RenderFrameHost* GetSubframeRfh() { return subframe_rfh_; }
std::string GetSubframeId() { return "test"; }
private:
std::unique_ptr<base::HistogramTester> histogram_tester_;
std::unique_ptr<content::DownloadTestObserver> download_observer_;
std::unique_ptr<page_load_metrics::PageLoadMetricsTestWaiter>
web_feature_waiter_;
raw_ptr<content::RenderFrameHost, AcrossTasksDanglingUntriaged>
subframe_rfh_ = nullptr;
size_t expected_num_downloads_ = 0;
// By default, the embedded test server uses HTTP. Keep an HTTPS server
// instead so that we don't encounter unexpected insecure download warnings.
std::unique_ptr<net::EmbeddedTestServer> https_test_server_;
};
class SubframeSameFrameDownloadBrowserTest_Sandbox
: public DownloadFramePolicyBrowserTest,
public ::testing::WithParamInterface<
std::tuple<DownloadSource,
SandboxOption,
bool /* is_cross_origin */>> {};
// Download that's initiated from / occurs in the same subframe are handled
// correctly. This test specifically tests sandbox related behaviors.
IN_PROC_BROWSER_TEST_P(SubframeSameFrameDownloadBrowserTest_Sandbox, Download) {
auto [source, sandbox_option, is_cross_origin] = GetParam();
SCOPED_TRACE(::testing::Message()
<< "source = " << source << ", "
<< "sandbox_option = " << sandbox_option << ", "
<< "is_cross_origin = " << is_cross_origin);
bool expect_download = sandbox_option != SandboxOption::kDisallowDownloads;
bool sandboxed = sandbox_option == SandboxOption::kDisallowDownloads;
InitializeHistogramTesterAndWebFeatureWaiter();
SetNumDownloadsExpectation(expect_download);
InitializeOneSubframeSetup(sandbox_option, false /* is_ad_frame */,
is_cross_origin);
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadPrePolicyCheck);
if (expect_download) {
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadPostPolicyCheck);
}
if (sandboxed) {
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadInSandbox);
}
TriggerDownloadSameFrame(GetSubframeRfh(), source,
true /* initiate_with_gesture */);
GetWebFeatureWaiter()->Wait();
CheckNumDownloadsExpectation();
}
INSTANTIATE_TEST_SUITE_P(
All,
SubframeSameFrameDownloadBrowserTest_Sandbox,
::testing::Combine(::testing::Values(DownloadSource::kNavigation,
DownloadSource::kAnchorAttribute),
::testing::Values(SandboxOption::kNotSandboxed,
SandboxOption::kDisallowDownloads,
SandboxOption::kAllowDownloads),
::testing::Bool()));
class SubframeSameFrameDownloadBrowserTest_AdFrame
: public DownloadFramePolicyBrowserTest,
public ::testing::WithParamInterface<std::tuple<
DownloadSource,
bool /* is_ad_frame */,
bool /* is_cross_origin */,
bool /* initiate_with_gesture */>> {
public:
SubframeSameFrameDownloadBrowserTest_AdFrame() = default;
};
// Download that's initiated from / occurs in the same subframe are handled
// correctly. This test specifically tests ad related behaviors.
IN_PROC_BROWSER_TEST_P(SubframeSameFrameDownloadBrowserTest_AdFrame, Download) {
auto [source, is_ad_frame, is_cross_origin, initiate_with_gesture] =
GetParam();
SCOPED_TRACE(::testing::Message()
<< "source = " << source << ", "
<< "is_ad_frame = " << is_ad_frame << ", "
<< "is_cross_origin = " << is_cross_origin << ", "
<< "initiate_with_gesture = " << initiate_with_gesture);
bool expect_download = initiate_with_gesture || !is_ad_frame;
bool expect_download_in_ad_frame_without_user_activation =
is_ad_frame && !initiate_with_gesture;
InitializeHistogramTesterAndWebFeatureWaiter();
SetNumDownloadsExpectation(expect_download);
InitializeOneSubframeSetup(SandboxOption::kNotSandboxed, is_ad_frame,
is_cross_origin);
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadPrePolicyCheck);
if (expect_download) {
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadPostPolicyCheck);
}
if (is_ad_frame) {
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadInAdFrame);
}
if (expect_download_in_ad_frame_without_user_activation) {
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadInAdFrameWithoutUserGesture);
}
TriggerDownloadSameFrame(GetSubframeRfh(), source, initiate_with_gesture);
GetWebFeatureWaiter()->Wait();
CheckNumDownloadsExpectation();
}
INSTANTIATE_TEST_SUITE_P(
All,
SubframeSameFrameDownloadBrowserTest_AdFrame,
::testing::Combine(::testing::Values(DownloadSource::kNavigation,
DownloadSource::kAnchorAttribute),
::testing::Bool(),
::testing::Bool(),
::testing::Bool()));
class OtherFrameNavigationDownloadBrowserTest_Sandbox
: public DownloadFramePolicyBrowserTest,
public ::testing::WithParamInterface<
std::tuple<bool /* is_cross_origin */, OtherFrameNavigationType>> {};
// Tests navigation download that's initiated from a different frame with
// only one frame being sandboxed. Also covers the remote frame navigation path.
IN_PROC_BROWSER_TEST_P(OtherFrameNavigationDownloadBrowserTest_Sandbox,
Download) {
auto [is_cross_origin, other_frame_navigation_type] = GetParam();
SCOPED_TRACE(::testing::Message()
<< "is_cross_origin = " << is_cross_origin << ", "
<< "other_frame_navigation_type = "
<< other_frame_navigation_type);
InitializeHistogramTesterAndWebFeatureWaiter();
SetNumDownloadsExpectation(0);
InitializeOneSubframeSetup(SandboxOption::kDisallowDownloads,
false /* is_ad_frame */,
is_cross_origin /* is_cross_origin */);
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadPrePolicyCheck);
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadInSandbox);
if (other_frame_navigation_type ==
OtherFrameNavigationType::
kRestrictedSubframeNavigatesUnrestrictedTopFrame) {
std::string script = "top.location = 'allow.zip';";
EXPECT_TRUE(ExecJs(GetSubframeRfh(), script));
} else {
std::string script =
"document.getElementById('" + GetSubframeId() + "').src = 'allow.zip';";
EXPECT_TRUE(ExecJs(web_contents(), script));
}
GetWebFeatureWaiter()->Wait();
CheckNumDownloadsExpectation();
}
INSTANTIATE_TEST_SUITE_P(
All,
OtherFrameNavigationDownloadBrowserTest_Sandbox,
::testing::Combine(
::testing::Bool(),
::testing::Values(
OtherFrameNavigationType::
kRestrictedSubframeNavigatesUnrestrictedTopFrame,
OtherFrameNavigationType::
kUnrestrictedTopFrameNavigatesRestrictedSubframe)));
class OtherFrameNavigationDownloadBrowserTest_AdFrame
: public DownloadFramePolicyBrowserTest,
public ::testing::WithParamInterface<std::tuple<
bool /* is_cross_origin */,
bool /* initiate_with_gesture */,
OtherFrameNavigationType>> {
public:
OtherFrameNavigationDownloadBrowserTest_AdFrame() = default;
};
// Tests navigation download that's initiated from a different frame with
// only one frame being ad. Also covers the remote frame navigation path.
IN_PROC_BROWSER_TEST_P(OtherFrameNavigationDownloadBrowserTest_AdFrame,
Download) {
auto [is_cross_origin, initiate_with_gesture, other_frame_navigation_type] =
GetParam();
SCOPED_TRACE(::testing::Message()
<< "is_cross_origin = " << is_cross_origin << ", "
<< "initiate_with_gesture = " << initiate_with_gesture << ", "
<< "other_frame_navigation_type = "
<< other_frame_navigation_type);
bool prevent_frame_busting =
other_frame_navigation_type ==
OtherFrameNavigationType::
kRestrictedSubframeNavigatesUnrestrictedTopFrame &&
is_cross_origin && !initiate_with_gesture;
InitializeHistogramTesterAndWebFeatureWaiter();
InitializeOneSubframeSetup(SandboxOption::kNotSandboxed,
true /* is_ad_frame */,
is_cross_origin /* is_cross_origin */);
if (!prevent_frame_busting) {
bool expect_download = initiate_with_gesture;
SetNumDownloadsExpectation(expect_download);
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadPrePolicyCheck);
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadInAdFrame);
if (!initiate_with_gesture) {
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadInAdFrameWithoutUserGesture);
}
if (expect_download) {
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadPostPolicyCheck);
}
}
if (other_frame_navigation_type ==
OtherFrameNavigationType::
kRestrictedSubframeNavigatesUnrestrictedTopFrame) {
std::string script = "top.location = 'allow.zip';";
if (initiate_with_gesture) {
EXPECT_TRUE(ExecJs(GetSubframeRfh(), script));
} else {
EXPECT_TRUE(prevent_frame_busting ^
ExecJs(GetSubframeRfh(), script,
content::EXECUTE_SCRIPT_NO_USER_GESTURE));
}
} else {
std::string script =
"document.getElementById('" + GetSubframeId() + "').src = 'allow.zip';";
if (initiate_with_gesture) {
EXPECT_TRUE(ExecJs(web_contents(), script));
} else {
EXPECT_TRUE(ExecJs(web_contents(), script,
content::EXECUTE_SCRIPT_NO_USER_GESTURE));
}
}
GetWebFeatureWaiter()->Wait();
CheckNumDownloadsExpectation();
}
INSTANTIATE_TEST_SUITE_P(
All,
OtherFrameNavigationDownloadBrowserTest_AdFrame,
::testing::Combine(
::testing::Bool(),
::testing::Bool(),
::testing::Values(
OtherFrameNavigationType::
kRestrictedSubframeNavigatesUnrestrictedTopFrame,
OtherFrameNavigationType::
kUnrestrictedTopFrameNavigatesRestrictedSubframe)));
class TopFrameSameFrameDownloadBrowserTest
: public DownloadFramePolicyBrowserTest,
public ::testing::WithParamInterface<
std::tuple<DownloadSource, SandboxOption>> {};
// Download that's initiated from / occurs in the same top frame are handled
// correctly.
IN_PROC_BROWSER_TEST_P(TopFrameSameFrameDownloadBrowserTest, Download) {
auto [source, sandbox_option] = GetParam();
SCOPED_TRACE(::testing::Message()
<< "source = " << source << ", "
<< "sandbox_option = " << sandbox_option);
bool expect_download = sandbox_option != SandboxOption::kDisallowDownloads;
bool sandboxed = sandbox_option == SandboxOption::kDisallowDownloads;
InitializeHistogramTesterAndWebFeatureWaiter();
SetNumDownloadsExpectation(expect_download);
InitializeOneTopFrameSetup(sandbox_option);
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadPrePolicyCheck);
if (expect_download) {
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadPostPolicyCheck);
}
if (sandboxed) {
GetWebFeatureWaiter()->AddWebFeatureExpectation(
blink::mojom::WebFeature::kDownloadInSandbox);
}
TriggerDownloadSameFrame(web_contents(), source,
true /* initiate_with_gesture */);
GetWebFeatureWaiter()->Wait();
CheckNumDownloadsExpectation();
}
INSTANTIATE_TEST_SUITE_P(
All,
TopFrameSameFrameDownloadBrowserTest,
::testing::Combine(::testing::Values(DownloadSource::kNavigation,
DownloadSource::kAnchorAttribute),
::testing::Values(SandboxOption::kNotSandboxed,
SandboxOption::kDisallowDownloads,
SandboxOption::kAllowDownloads)));
class DownloadFramePolicyBrowserTest_UpdateIframeSandboxFlags
: public DownloadFramePolicyBrowserTest,
public ::testing::WithParamInterface<
std::tuple<bool /* is_cross_origin */,
bool /* from_allow_to_disallow */>> {};
// Test that when the iframe sandbox attribute is updated before navigation,
// the updated flag will be controlling the navigation-instantiating frame's
// policy for the download intervention.
IN_PROC_BROWSER_TEST_P(
DownloadFramePolicyBrowserTest_UpdateIframeSandboxFlags,
PendingSandboxPolicyUsedForNavigationInstantiatingFrame) {
auto [is_cross_origin, from_allow_to_disallow] = GetParam();
size_t number_of_downloads = from_allow_to_disallow ? 0u : 1u;
SandboxOption initial_sandbox_option =
from_allow_to_disallow ? SandboxOption::kAllowDownloads
: SandboxOption::kDisallowDownloads;
const char* update_to_token = from_allow_to_disallow
? kSandboxTokensDisallowDownloads
: kSandboxTokensAllowDownloads;
InitializeHistogramTesterAndWebFeatureWaiter();
SetNumDownloadsExpectation(number_of_downloads);
InitializeOneSubframeSetup(initial_sandbox_option, false /* is_ad_frame */,
is_cross_origin);
EXPECT_TRUE(
ExecJs(web_contents()->GetPrimaryMainFrame(),
content::JsReplace("document.querySelector('iframe').sandbox = $1",
update_to_token)));
GURL download_url = embedded_test_server()->GetURL("b.test", "/allow.zip");
content::TestNavigationManager navigation_observer(web_contents(),
download_url);
EXPECT_TRUE(
ExecJs(web_contents()->GetPrimaryMainFrame(),
content::JsReplace("document.querySelector('iframe').src = $1",
download_url)));
ASSERT_TRUE(navigation_observer.WaitForNavigationFinished());
EXPECT_FALSE(navigation_observer.was_successful());
GetHistogramTester()->ExpectBucketCount(
"Blink.UseCounter.Features", blink::mojom::WebFeature::kDownloadInSandbox,
from_allow_to_disallow);
CheckNumDownloadsExpectation();
}
// Test that when the iframe sandbox attribute is updated before navigation,
// the updated flag will NOT be controlling the navigation-initiator frame's
// policy for the download intervention.
IN_PROC_BROWSER_TEST_P(DownloadFramePolicyBrowserTest_UpdateIframeSandboxFlags,
EffectiveSandboxPolicyUsedForNavigationInitiatorFrame) {
auto [is_cross_origin, from_allow_to_disallow] = GetParam();
size_t number_of_downloads = from_allow_to_disallow ? 1u : 0u;
SandboxOption initial_sandbox_option =
from_allow_to_disallow ? SandboxOption::kAllowDownloads
: SandboxOption::kDisallowDownloads;
const char* update_to_token = from_allow_to_disallow
? kSandboxTokensDisallowDownloads
: kSandboxTokensAllowDownloads;
InitializeHistogramTesterAndWebFeatureWaiter();
SetNumDownloadsExpectation(number_of_downloads);
InitializeOneSubframeSetup(initial_sandbox_option, false /* is_ad_frame */,
is_cross_origin);
EXPECT_TRUE(
ExecJs(web_contents()->GetPrimaryMainFrame(),
content::JsReplace("document.querySelector('iframe').sandbox = $1",
update_to_token)));
GURL download_url = embedded_test_server()->GetURL("b.test", "/allow.zip");
content::TestNavigationManager navigation_observer(web_contents(),
download_url);
EXPECT_TRUE(ExecJs(GetSubframeRfh(),
content::JsReplace("top.location = $1", download_url)));
ASSERT_TRUE(navigation_observer.WaitForNavigationFinished());
EXPECT_FALSE(navigation_observer.was_successful());
GetHistogramTester()->ExpectBucketCount(
"Blink.UseCounter.Features", blink::mojom::WebFeature::kDownloadInSandbox,
!from_allow_to_disallow);
CheckNumDownloadsExpectation();
}
INSTANTIATE_TEST_SUITE_P(
All,
DownloadFramePolicyBrowserTest_UpdateIframeSandboxFlags,
::testing::Combine(::testing::Bool(), ::testing::Bool()));
// Download gets blocked when LoadPolicy is DISALLOW for the navigation to
// download. This test is technically unrelated to policy on frame, but stays
// here for convenience.
IN_PROC_BROWSER_TEST_F(DownloadFramePolicyBrowserTest,
SubframeNavigationDownloadBlockedByLoadPolicy) {
ResetConfiguration(subresource_filter::Configuration(
subresource_filter::mojom::ActivationLevel::kEnabled,
subresource_filter::ActivationScope::ALL_SITES));
InitializeHistogramTesterAndWebFeatureWaiter();
SetNumDownloadsExpectation(0);
InitializeOneSubframeSetup(SandboxOption::kNotSandboxed,
false /* is_ad_frame */,
false /* is_cross_origin */);
content::TestNavigationObserver navigation_observer(web_contents());
TriggerDownloadSameFrame(GetSubframeRfh(), DownloadSource::kNavigation,
false /* initiate_with_gesture */, "disallow.zip");
navigation_observer.Wait();
GetHistogramTester()->ExpectBucketCount(
"Blink.UseCounter.Features",
blink::mojom::WebFeature::kDownloadPrePolicyCheck, 0);
CheckNumDownloadsExpectation();
}
|