1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <stddef.h>
#include <memory>
#include "base/memory/raw_ptr.h"
#include "base/memory/weak_ptr.h"
#include "base/run_loop.h"
#include "base/strings/stringprintf.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/browser_features.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/download/chrome_download_manager_delegate.h"
#include "chrome/browser/download/download_core_service.h"
#include "chrome/browser/download/download_core_service_factory.h"
#include "chrome/browser/download/download_core_service_impl.h"
#include "chrome/browser/download/download_prefs.h"
#include "chrome/browser/download/download_status_updater.h"
#include "chrome/browser/profiles/keep_alive/profile_keep_alive_types.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile.h"
#include "chrome/test/base/testing_profile_manager.h"
#include "components/download/public/common/mock_download_item.h"
#include "content/public/test/browser_task_environment.h"
#include "content/public/test/mock_download_manager.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
using testing::AtLeast;
using testing::Invoke;
using testing::Mock;
using testing::Return;
using testing::SetArgPointee;
using testing::StrictMock;
using testing::WithArg;
using testing::_;
class TestDownloadStatusUpdater : public DownloadStatusUpdater {
public:
TestDownloadStatusUpdater()
: notification_count_(0), acceptable_notification_item_(nullptr) {}
void SetAcceptableNotificationItem(download::DownloadItem* item) {
acceptable_notification_item_ = item;
}
size_t NotificationCount() {
return notification_count_;
}
protected:
void UpdateAppIconDownloadProgress(
download::DownloadItem* download) override {
++notification_count_;
if (acceptable_notification_item_)
EXPECT_EQ(acceptable_notification_item_, download);
}
private:
size_t notification_count_;
raw_ptr<download::DownloadItem> acceptable_notification_item_;
};
class DownloadStatusUpdaterTest : public testing::Test {
public:
DownloadStatusUpdaterTest()
: updater_(new TestDownloadStatusUpdater()),
profile_manager_(TestingBrowserProcess::GetGlobal()) {}
~DownloadStatusUpdaterTest() override {
for (size_t mgr_idx = 0; mgr_idx < managers_.size(); ++mgr_idx) {
EXPECT_CALL(*Manager(mgr_idx), RemoveObserver(_));
}
delete updater_;
updater_ = nullptr;
VerifyAndClearExpectations();
managers_.clear();
manager_items_.clear();
all_owned_items_.clear();
base::RunLoop().RunUntilIdle(); // Allow DownloadManager destruction.
}
void SetUp() override { ASSERT_TRUE(profile_manager_.SetUp()); }
protected:
// Attach some number of DownloadManagers to the updater.
void SetupManagers(int manager_count) {
DCHECK_EQ(0U, managers_.size());
for (int i = 0; i < manager_count; ++i) {
managers_.push_back(
std::make_unique<StrictMock<content::MockDownloadManager>>());
}
}
void SetObserver(content::DownloadManager::Observer* observer) {
manager_observers_[manager_observer_index_] = observer;
}
// Hook the specified manager into the updater.
void LinkManager(int i) {
content::MockDownloadManager* mgr = managers_[i].get();
manager_observer_index_ = i;
while (manager_observers_.size() <= static_cast<size_t>(i)) {
manager_observers_.push_back(nullptr);
}
EXPECT_CALL(*mgr, IsManagerInitialized());
EXPECT_CALL(*mgr, AddObserver(_))
.WillOnce(WithArg<0>(Invoke(
this, &DownloadStatusUpdaterTest::SetObserver)));
TestingProfile* profile = profile_manager_.CreateTestingProfile(
base::StringPrintf("Profile %d", i + 1));
testing_profiles_.push_back(profile);
EXPECT_CALL(*mgr, GetBrowserContext()).WillRepeatedly(Return(profile));
auto delegate = std::make_unique<ChromeDownloadManagerDelegate>(profile);
DownloadCoreServiceFactory::GetForBrowserContext(profile)
->SetDownloadManagerDelegateForTesting(std::move(delegate));
updater_->AddManager(mgr);
}
// Add some number of Download items to a particular manager.
void AddItems(int manager_index, int item_count, int in_progress_count) {
DCHECK_GT(managers_.size(), static_cast<size_t>(manager_index));
content::MockDownloadManager* manager = managers_[manager_index].get();
if (manager_items_.size() <= static_cast<size_t>(manager_index))
manager_items_.resize(manager_index+1);
std::vector<download::DownloadItem*> item_list;
for (int i = 0; i < item_count; ++i) {
std::unique_ptr<download::MockDownloadItem> item =
std::make_unique<StrictMock<download::MockDownloadItem>>();
download::DownloadItem::DownloadState state =
i < in_progress_count ? download::DownloadItem::IN_PROGRESS
: download::DownloadItem::CANCELLED;
EXPECT_CALL(*item, IsTransient()).WillRepeatedly(Return(false));
EXPECT_CALL(*item, GetState()).WillRepeatedly(Return(state));
manager_items_[manager_index].push_back(item.get());
all_owned_items_.push_back(std::move(item));
}
EXPECT_CALL(*manager, GetAllDownloads(_))
.WillRepeatedly(SetArgPointee<0>(manager_items_[manager_index]));
}
// Return the specified manager.
content::MockDownloadManager* Manager(int manager_index) {
DCHECK_GT(managers_.size(), static_cast<size_t>(manager_index));
return managers_[manager_index].get();
}
// Return the specified item.
download::MockDownloadItem* Item(int manager_index, int item_index) {
DCHECK_GT(manager_items_.size(), static_cast<size_t>(manager_index));
DCHECK_GT(manager_items_[manager_index].size(),
static_cast<size_t>(item_index));
// All DownloadItems in manager_items_ are MockDownloadItems.
return static_cast<download::MockDownloadItem*>(
manager_items_[manager_index][item_index]);
}
// Set return values relevant to |DownloadStatusUpdater::GetProgress()|
// for the specified item.
void SetItemValues(int manager_index, int item_index,
int received_bytes, int total_bytes, bool notify) {
download::MockDownloadItem* item(Item(manager_index, item_index));
EXPECT_CALL(*item, GetReceivedBytes())
.WillRepeatedly(Return(received_bytes));
EXPECT_CALL(*item, GetTotalBytes())
.WillRepeatedly(Return(total_bytes));
if (notify)
updater_->OnDownloadUpdated(managers_[manager_index].get(), item);
}
// Transition specified item to completed.
void CompleteItem(int manager_index, int item_index) {
download::MockDownloadItem* item(Item(manager_index, item_index));
EXPECT_CALL(*item, GetState())
.WillRepeatedly(Return(download::DownloadItem::COMPLETE));
updater_->OnDownloadUpdated(managers_[manager_index].get(), item);
}
// Verify and clear all mocks expectations.
void VerifyAndClearExpectations() {
for (const auto& manager : managers_)
Mock::VerifyAndClearExpectations(manager.get());
for (auto it = manager_items_.begin(); it != manager_items_.end(); ++it)
for (auto sit = it->begin(); sit != it->end(); ++sit)
Mock::VerifyAndClearExpectations(*sit);
}
// The mocked download managers.
std::vector<std::unique_ptr<content::MockDownloadManager>> managers_;
// The download items being downloaded by those managers in |managers_|. The
// top-level vector is the manager index, and the inner vector is the list of
// items of that manager. The inner vector is a vector<DownloadItem*> for
// compatibility with the return value of DownloadManager::GetAllDownloads().
std::vector<std::vector<raw_ptr<download::DownloadItem, VectorExperimental>>>
manager_items_;
// An owning container for items in |manager_items_|.
std::vector<std::unique_ptr<download::DownloadItem>> all_owned_items_;
int manager_observer_index_;
std::vector<raw_ptr<content::DownloadManager::Observer, VectorExperimental>>
manager_observers_;
// Pointer so we can verify that destruction triggers appropriate
// changes.
raw_ptr<TestDownloadStatusUpdater, DanglingUntriaged> updater_;
// Thread so that the DownloadManager (which is a DeleteOnUIThread
// object) can be deleted.
content::BrowserTaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
// To test ScopedProfileKeepAlive behavior.
TestingProfileManager profile_manager_;
std::vector<raw_ptr<TestingProfile, VectorExperimental>> testing_profiles_;
};
// Test null updater.
TEST_F(DownloadStatusUpdaterTest, Basic) {
float progress = -1;
int download_count = -1;
EXPECT_TRUE(updater_->GetProgress(&progress, &download_count));
EXPECT_FLOAT_EQ(0.0f, progress);
EXPECT_EQ(0, download_count);
}
// Test updater with null manager.
TEST_F(DownloadStatusUpdaterTest, OneManagerNoItems) {
SetupManagers(1);
AddItems(0, 0, 0);
LinkManager(0);
VerifyAndClearExpectations();
float progress = -1;
int download_count = -1;
EXPECT_CALL(*managers_[0], GetAllDownloads(_))
.WillRepeatedly(SetArgPointee<0>(manager_items_[0]));
EXPECT_TRUE(updater_->GetProgress(&progress, &download_count));
EXPECT_FLOAT_EQ(0.0f, progress);
EXPECT_EQ(0, download_count);
}
// Test updater with non-null manager, including transition an item to
// |download::DownloadItem::COMPLETE| and adding a new item.
TEST_F(DownloadStatusUpdaterTest, OneManagerManyItems) {
SetupManagers(1);
AddItems(0, 3, 2);
LinkManager(0);
// Prime items
SetItemValues(0, 0, 10, 20, false);
SetItemValues(0, 1, 50, 60, false);
SetItemValues(0, 2, 90, 90, false);
float progress = -1;
int download_count = -1;
EXPECT_TRUE(updater_->GetProgress(&progress, &download_count));
EXPECT_FLOAT_EQ((10+50)/(20.0f+60), progress);
EXPECT_EQ(2, download_count);
// Transition one item to completed and confirm progress is updated
// properly.
CompleteItem(0, 0);
EXPECT_TRUE(updater_->GetProgress(&progress, &download_count));
EXPECT_FLOAT_EQ(50/60.0f, progress);
EXPECT_EQ(1, download_count);
// Add a new item to manager and confirm progress is updated properly.
AddItems(0, 1, 1);
SetItemValues(0, 3, 150, 200, false);
manager_observers_[0]->OnDownloadCreated(
managers_[0].get(), manager_items_[0][manager_items_[0].size() - 1]);
EXPECT_TRUE(updater_->GetProgress(&progress, &download_count));
EXPECT_FLOAT_EQ((50+150)/(60+200.0f), progress);
EXPECT_EQ(2, download_count);
}
// Test to ensure that the download progress notification is called correctly.
TEST_F(DownloadStatusUpdaterTest, ProgressNotification) {
size_t expected_notifications = updater_->NotificationCount();
SetupManagers(1);
AddItems(0, 2, 2);
LinkManager(0);
// Expect two notifications, one for each item; which item will come first
// isn't defined so it cannot be tested.
expected_notifications += 2;
ASSERT_EQ(expected_notifications, updater_->NotificationCount());
// Make progress on the first item.
updater_->SetAcceptableNotificationItem(Item(0, 0));
SetItemValues(0, 0, 10, 20, true);
++expected_notifications;
ASSERT_EQ(expected_notifications, updater_->NotificationCount());
// Second item completes!
updater_->SetAcceptableNotificationItem(Item(0, 1));
CompleteItem(0, 1);
++expected_notifications;
ASSERT_EQ(expected_notifications, updater_->NotificationCount());
// First item completes.
updater_->SetAcceptableNotificationItem(Item(0, 0));
CompleteItem(0, 0);
++expected_notifications;
ASSERT_EQ(expected_notifications, updater_->NotificationCount());
updater_->SetAcceptableNotificationItem(nullptr);
}
// Confirm we recognize the situation where we have an unknown size.
TEST_F(DownloadStatusUpdaterTest, UnknownSize) {
SetupManagers(1);
AddItems(0, 2, 2);
LinkManager(0);
// Prime items
SetItemValues(0, 0, 10, 20, false);
SetItemValues(0, 1, 50, -1, false);
float progress = -1;
int download_count = -1;
EXPECT_FALSE(updater_->GetProgress(&progress, &download_count));
}
// Test many null managers.
TEST_F(DownloadStatusUpdaterTest, ManyManagersNoItems) {
SetupManagers(1);
AddItems(0, 0, 0);
LinkManager(0);
float progress = -1;
int download_count = -1;
EXPECT_TRUE(updater_->GetProgress(&progress, &download_count));
EXPECT_FLOAT_EQ(0.0f, progress);
EXPECT_EQ(0, download_count);
}
// Test many managers with all items complete.
TEST_F(DownloadStatusUpdaterTest, ManyManagersEmptyItems) {
SetupManagers(2);
AddItems(0, 3, 0);
LinkManager(0);
AddItems(1, 3, 0);
LinkManager(1);
float progress = -1;
int download_count = -1;
EXPECT_TRUE(updater_->GetProgress(&progress, &download_count));
EXPECT_FLOAT_EQ(0.0f, progress);
EXPECT_EQ(0, download_count);
}
// Test many managers with some non-complete items.
TEST_F(DownloadStatusUpdaterTest, ManyManagersMixedItems) {
SetupManagers(2);
AddItems(0, 3, 2);
LinkManager(0);
AddItems(1, 3, 1);
LinkManager(1);
SetItemValues(0, 0, 10, 20, false);
SetItemValues(0, 1, 50, 60, false);
SetItemValues(1, 0, 80, 90, false);
float progress = -1;
int download_count = -1;
EXPECT_TRUE(updater_->GetProgress(&progress, &download_count));
EXPECT_FLOAT_EQ((10+50+80)/(20.0f+60+90), progress);
EXPECT_EQ(3, download_count);
}
// Test that it prevents Profile deletion.
TEST_F(DownloadStatusUpdaterTest, HoldsKeepAlive) {
base::test::ScopedFeatureList feature_list;
feature_list.InitAndEnableFeature(features::kDestroyProfileOnBrowserClose);
ProfileManager* profile_manager = g_browser_process->profile_manager();
ASSERT_NE(nullptr, profile_manager);
SetupManagers(2);
AddItems(0, 2, 1);
LinkManager(0);
AddItems(1, 2, 0);
LinkManager(1);
// Profile 1 has a download in progress.
Profile* profile1 = testing_profiles_[0];
SetItemValues(0, 0, 10, 20, true);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(profile_manager->HasKeepAliveForTesting(
profile1, ProfileKeepAliveOrigin::kDownloadInProgress));
// Profile 2 doesn't have a download in progress.
Profile* profile2 = testing_profiles_[1];
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(profile_manager->HasKeepAliveForTesting(
profile2, ProfileKeepAliveOrigin::kDownloadInProgress));
// Complete Profile 1's download. It should release its keepalive.
CompleteItem(0, 0);
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(profile_manager->HasKeepAliveForTesting(
profile1, ProfileKeepAliveOrigin::kDownloadInProgress));
}
// Tests that transient download will not trigger any updates.
TEST_F(DownloadStatusUpdaterTest, TransientDownload) {
SetupManagers(/*manager_count=*/1);
AddItems(/*manager_index=*/0, /*item_count=*/2, /*in_progress_count=*/0);
LinkManager(0);
std::unique_ptr<download::MockDownloadItem> item =
std::make_unique<StrictMock<download::MockDownloadItem>>();
EXPECT_CALL(*item, GetState())
.WillRepeatedly(Return(download::DownloadItem::IN_PROGRESS));
EXPECT_CALL(*item, IsTransient()).WillRepeatedly(Return(true));
manager_items_[0].push_back(item.get());
all_owned_items_.push_back(std::move(item));
manager_observers_[0]->OnDownloadCreated(
managers_[0].get(), manager_items_[0][manager_items_[0].size() - 1]);
float progress = -1;
int download_count = -1;
EXPECT_TRUE(updater_->GetProgress(&progress, &download_count));
EXPECT_FLOAT_EQ(0.0f, progress);
EXPECT_EQ(0, download_count);
}
|