1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/browser/blocklist_extension_prefs.h"
#include "base/memory/raw_ptr.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/browser/profiles/profile.h"
#include "extensions/browser/blocklist_state.h"
#include "extensions/browser/extension_prefs.h"
namespace extensions {
namespace {
// Extension ids used during testing.
constexpr char kExtensionId[] = "behllobkkfkfnphdnhnkndlbkcpglgmj";
} // namespace
// Test suite to test blocklist extension prefs.
class BlocklistExtensionPrefsUnitTest : public ExtensionServiceTestBase {
public:
void SetUp() override {
InitializeEmptyExtensionService();
extension_prefs_ = ExtensionPrefs::Get(profile());
}
ExtensionPrefs* extension_prefs() { return extension_prefs_; }
private:
raw_ptr<ExtensionPrefs> extension_prefs_;
};
TEST_F(BlocklistExtensionPrefsUnitTest, OmahaBlocklistState) {
BitMapBlocklistState state1 =
BitMapBlocklistState::BLOCKLISTED_POTENTIALLY_UNWANTED;
BitMapBlocklistState state2 =
BitMapBlocklistState::BLOCKLISTED_SECURITY_VULNERABILITY;
BitMapBlocklistState state3 =
BitMapBlocklistState::BLOCKLISTED_CWS_POLICY_VIOLATION;
EXPECT_FALSE(blocklist_prefs::HasOmahaBlocklistState(kExtensionId, state1,
extension_prefs()));
EXPECT_FALSE(blocklist_prefs::HasAnyOmahaGreylistState(kExtensionId,
extension_prefs()));
blocklist_prefs::AddOmahaBlocklistState(kExtensionId, state1,
extension_prefs());
EXPECT_TRUE(blocklist_prefs::HasOmahaBlocklistState(kExtensionId, state1,
extension_prefs()));
EXPECT_TRUE(blocklist_prefs::HasAnyOmahaGreylistState(kExtensionId,
extension_prefs()));
blocklist_prefs::AddOmahaBlocklistState(kExtensionId, state2,
extension_prefs());
EXPECT_TRUE(blocklist_prefs::HasOmahaBlocklistState(kExtensionId, state2,
extension_prefs()));
// Doesn't clear the other blocklist state.
EXPECT_TRUE(blocklist_prefs::HasOmahaBlocklistState(kExtensionId, state1,
extension_prefs()));
EXPECT_TRUE(blocklist_prefs::HasAnyOmahaGreylistState(kExtensionId,
extension_prefs()));
blocklist_prefs::RemoveOmahaBlocklistState(kExtensionId, state1,
extension_prefs());
EXPECT_FALSE(blocklist_prefs::HasOmahaBlocklistState(kExtensionId, state1,
extension_prefs()));
// Doesn't remove the other blocklist state.
EXPECT_TRUE(blocklist_prefs::HasOmahaBlocklistState(kExtensionId, state2,
extension_prefs()));
EXPECT_TRUE(blocklist_prefs::HasAnyOmahaGreylistState(kExtensionId,
extension_prefs()));
blocklist_prefs::AddOmahaBlocklistState(kExtensionId, state3,
extension_prefs());
blocklist_prefs::RemoveOmahaBlocklistState(kExtensionId, state2,
extension_prefs());
EXPECT_TRUE(blocklist_prefs::HasAnyOmahaGreylistState(kExtensionId,
extension_prefs()));
blocklist_prefs::RemoveOmahaBlocklistState(kExtensionId, state3,
extension_prefs());
EXPECT_FALSE(blocklist_prefs::HasAnyOmahaGreylistState(kExtensionId,
extension_prefs()));
}
TEST_F(BlocklistExtensionPrefsUnitTest, AcknowledgedBlocklistState) {
BitMapBlocklistState state1 =
BitMapBlocklistState::BLOCKLISTED_POTENTIALLY_UNWANTED;
BitMapBlocklistState state2 =
BitMapBlocklistState::BLOCKLISTED_SECURITY_VULNERABILITY;
EXPECT_FALSE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, state1, extension_prefs()));
blocklist_prefs::AddAcknowledgedBlocklistState(kExtensionId, state1,
extension_prefs());
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, state1, extension_prefs()));
blocklist_prefs::AddAcknowledgedBlocklistState(kExtensionId, state2,
extension_prefs());
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, state2, extension_prefs()));
// Doesn't clear the other blocklist state.
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, state1, extension_prefs()));
blocklist_prefs::AddAcknowledgedBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs());
blocklist_prefs::ClearAcknowledgedGreylistStates(kExtensionId,
extension_prefs());
EXPECT_FALSE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, state1, extension_prefs()));
EXPECT_FALSE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, state2, extension_prefs()));
// The malware acknowledged state should not be cleared.
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs()));
}
TEST_F(BlocklistExtensionPrefsUnitTest,
UpdateCurrentGreylistStatesAsAcknowledged) {
blocklist_prefs::AddAcknowledgedBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs());
blocklist_prefs::AddAcknowledgedBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_SECURITY_VULNERABILITY,
extension_prefs());
blocklist_prefs::SetSafeBrowsingExtensionBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_POTENTIALLY_UNWANTED,
extension_prefs());
blocklist_prefs::AddOmahaBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_CWS_POLICY_VIOLATION,
extension_prefs());
blocklist_prefs::UpdateCurrentGreylistStatesAsAcknowledged(kExtensionId,
extension_prefs());
// The BLOCKLISTED_SECURITY_VULNERABILITY should be cleared because it is not
// in any greylist state.
EXPECT_FALSE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_SECURITY_VULNERABILITY,
extension_prefs()));
// BLOCKLISTED_POTENTIALLY_UNWANTED should be acknowledged because it is in
// the Safe Browsing greylist state.
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_POTENTIALLY_UNWANTED,
extension_prefs()));
// BLOCKLISTED_CWS_POLICY_VIOLATION should be acknowledged because it is in
// the Omaha greylist state.
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_CWS_POLICY_VIOLATION,
extension_prefs()));
// BLOCKLISTED_MALWARE should not be cleared because it is not a greylist
// state.
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs()));
blocklist_prefs::SetSafeBrowsingExtensionBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_SECURITY_VULNERABILITY,
extension_prefs());
blocklist_prefs::UpdateCurrentGreylistStatesAsAcknowledged(kExtensionId,
extension_prefs());
// The BLOCKLISTED_SECURITY_VULNERABILITY should be acknowledged because it is
// in the Safe Browsing greylist state.
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_SECURITY_VULNERABILITY,
extension_prefs()));
// BLOCKLISTED_POTENTIALLY_UNWANTED should be cleared because it is not in any
// greylist state.
EXPECT_FALSE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_POTENTIALLY_UNWANTED,
extension_prefs()));
// BLOCKLISTED_CWS_POLICY_VIOLATION should be acknowledged because it is in
// the Omaha greylist state.
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_CWS_POLICY_VIOLATION,
extension_prefs()));
}
TEST_F(BlocklistExtensionPrefsUnitTest, GetExtensionBlocklistState) {
EXPECT_EQ(BitMapBlocklistState::NOT_BLOCKLISTED,
blocklist_prefs::GetExtensionBlocklistState(kExtensionId,
extension_prefs()));
blocklist_prefs::SetSafeBrowsingExtensionBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_POTENTIALLY_UNWANTED,
extension_prefs());
blocklist_prefs::AddOmahaBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_SECURITY_VULNERABILITY,
extension_prefs());
// BLOCKLISTED_POTENTIALLY_UNWANTED has a higher precedence than
// BLOCKLISTED_SECURITY_VULNERABILITY.
EXPECT_EQ(BitMapBlocklistState::BLOCKLISTED_POTENTIALLY_UNWANTED,
blocklist_prefs::GetExtensionBlocklistState(kExtensionId,
extension_prefs()));
blocklist_prefs::AddOmahaBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_CWS_POLICY_VIOLATION,
extension_prefs());
// BLOCKLISTED_CWS_POLICY_VIOLATION has a higher precedence than
// BLOCKLISTED_POTENTIALLY_UNWANTED.
EXPECT_EQ(BitMapBlocklistState::BLOCKLISTED_CWS_POLICY_VIOLATION,
blocklist_prefs::GetExtensionBlocklistState(kExtensionId,
extension_prefs()));
blocklist_prefs::SetSafeBrowsingExtensionBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs());
// BLOCKLISTED_MALWARE has the highest precedence.
EXPECT_EQ(BitMapBlocklistState::BLOCKLISTED_MALWARE,
blocklist_prefs::GetExtensionBlocklistState(kExtensionId,
extension_prefs()));
}
TEST_F(BlocklistExtensionPrefsUnitTest, SafeBrowsingExtensionBlocklistState) {
blocklist_prefs::SetSafeBrowsingExtensionBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs());
EXPECT_EQ(BitMapBlocklistState::BLOCKLISTED_MALWARE,
blocklist_prefs::GetSafeBrowsingExtensionBlocklistState(
kExtensionId, extension_prefs()));
blocklist_prefs::SetSafeBrowsingExtensionBlocklistState(
kExtensionId, BitMapBlocklistState::NOT_BLOCKLISTED, extension_prefs());
EXPECT_EQ(BitMapBlocklistState::NOT_BLOCKLISTED,
blocklist_prefs::GetSafeBrowsingExtensionBlocklistState(
kExtensionId, extension_prefs()));
}
TEST_F(BlocklistExtensionPrefsUnitTest, IsExtensionBlocklisted) {
blocklist_prefs::SetSafeBrowsingExtensionBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs());
EXPECT_TRUE(
blocklist_prefs::IsExtensionBlocklisted(kExtensionId, extension_prefs()));
blocklist_prefs::SetSafeBrowsingExtensionBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_POTENTIALLY_UNWANTED,
extension_prefs());
EXPECT_FALSE(
blocklist_prefs::IsExtensionBlocklisted(kExtensionId, extension_prefs()));
blocklist_prefs::SetSafeBrowsingExtensionBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs());
EXPECT_TRUE(
blocklist_prefs::IsExtensionBlocklisted(kExtensionId, extension_prefs()));
blocklist_prefs::SetSafeBrowsingExtensionBlocklistState(
kExtensionId, BitMapBlocklistState::NOT_BLOCKLISTED, extension_prefs());
EXPECT_FALSE(
blocklist_prefs::IsExtensionBlocklisted(kExtensionId, extension_prefs()));
}
TEST_F(BlocklistExtensionPrefsUnitTest,
ExtensionTelemetryServiceBlocklistState) {
blocklist_prefs::SetExtensionTelemetryServiceBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs());
EXPECT_EQ(BitMapBlocklistState::BLOCKLISTED_MALWARE,
blocklist_prefs::GetExtensionTelemetryServiceBlocklistState(
kExtensionId, extension_prefs()));
blocklist_prefs::SetExtensionTelemetryServiceBlocklistState(
kExtensionId, BitMapBlocklistState::NOT_BLOCKLISTED, extension_prefs());
EXPECT_EQ(BitMapBlocklistState::NOT_BLOCKLISTED,
blocklist_prefs::GetExtensionTelemetryServiceBlocklistState(
kExtensionId, extension_prefs()));
}
TEST_F(BlocklistExtensionPrefsUnitTest,
IsExtensionBlocklisted_ExtensionTelemetryService) {
blocklist_prefs::SetExtensionTelemetryServiceBlocklistState(
kExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs());
EXPECT_TRUE(
blocklist_prefs::IsExtensionBlocklisted(kExtensionId, extension_prefs()));
blocklist_prefs::SetExtensionTelemetryServiceBlocklistState(
kExtensionId, BitMapBlocklistState::NOT_BLOCKLISTED, extension_prefs());
EXPECT_FALSE(
blocklist_prefs::IsExtensionBlocklisted(kExtensionId, extension_prefs()));
}
} // namespace extensions
|
