1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/memory/raw_ptr.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/browser/extensions/test_blocklist.h"
#include "chrome/browser/profiles/profile.h"
#include "components/safe_browsing/buildflags.h"
#include "extensions/browser/blocklist_extension_prefs.h"
#include "extensions/browser/blocklist_state.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/common/extension_id.h"
#include "extensions/test/extension_state_tester.h"
#include "testing/gtest/include/gtest/gtest.h"
// The interaction tests rely on the safe-browsing database.
#if BUILDFLAG(SAFE_BROWSING_DB_LOCAL)
namespace extensions {
namespace {
// Extension ids used during testing.
constexpr char kTestExtensionId[] = "behllobkkfkfnphdnhnkndlbkcpglgmj";
} // namespace
// Test suite to test the interaction between Safe Browsing blocklist, Omaha
// attributes blocklist and user action. These tests verify that the extension
// is in the correct extension set under different circumstances.
class BlocklistStatesInteractionUnitTest : public ExtensionServiceTestBase {
public:
BlocklistStatesInteractionUnitTest() {
// Set this flag to true so the acknowledged bit is not automatically set
// by the extension error controller on the first run.
ExtensionPrefs::SetRunAlertsInFirstRunForTest();
}
void SetUp() override {
ExtensionServiceTestBase::SetUp();
InitializeGoodInstalledExtensionService();
test_blocklist_.Attach(service()->blocklist_);
service()->Init();
extension_prefs_ = ExtensionPrefs::Get(profile());
}
protected:
void SetSafeBrowsingBlocklistStateForExtension(
const ExtensionId& extension_id,
BlocklistState state) {
// Reset cache in blocklist to make sure the latest blocklist state is
// fetched.
service()->blocklist_->ResetBlocklistStateCacheForTest();
test_blocklist_.SetBlocklistState(extension_id, state, true);
task_environment()->RunUntilIdle();
}
void SetOmahaBlocklistStateForExtension(const ExtensionId& extension_id,
const std::string& omaha_attribute,
bool value) {
auto attributes = base::Value::Dict().Set(omaha_attribute, value);
service()->PerformActionBasedOnOmahaAttributes(extension_id, attributes);
}
ExtensionPrefs* extension_prefs() { return extension_prefs_; }
private:
TestBlocklist test_blocklist_;
raw_ptr<ExtensionPrefs> extension_prefs_;
};
// 1. The extension is added to the Safe Browsing blocklist with
// BLOCKLISTED_MALWARE state.
// 2. The extension is added to the Omaha attribute blocklist with _malware
// attribute.
// 3. The extension is removed from the Safe Browsing blocklist.
// 4. The extension is removed from the Omaha attribute blocklist.
TEST_F(BlocklistStatesInteractionUnitTest,
SafeBrowsingMalwareThenOmahaAttributeMalware) {
ExtensionStateTester state_tester(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId,
BLOCKLISTED_MALWARE);
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_malware", true);
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId, NOT_BLOCKLISTED);
// kTestExtensionId should be kept in `blocklisted_extensions` because it is
// still in the Omaha attribute blocklist.
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_malware", false);
// kTestExtensionId should be removed from the `blocklisted_extensions` and is
// re-enabled.
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
}
// 1. The extension is added to the Safe Browsing blocklist with
// BLOCKLISTED_MALWARE state.
// 2. The user has acknowledged the blocklist state.
// 3. The extension is added to the Omaha attribute blocklist with _malware
// attribute.
// 4. The extension is removed from the Safe Browsing blocklist.
// 5. The extension is removed from the Omaha attribute blocklist.
TEST_F(BlocklistStatesInteractionUnitTest,
SafeBrowsingMalwareAcknowledgedThenOmahaAttributeMalware) {
ExtensionStateTester state_tester(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId,
BLOCKLISTED_MALWARE);
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
EXPECT_FALSE(blocklist_prefs::HasAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs()));
blocklist_prefs::AddAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs());
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs()));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_malware", true);
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
// The acknowledged state should not be cleared because the user has already
// acknowledged.
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs()));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId, NOT_BLOCKLISTED);
// kTestExtensionId should be kept in `blocklisted_extensions` because it is
// still in the Omaha attribute blocklist.
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
// The acknowledged state should not be cleared because it is still in the
// Omaha attribute blocklist.
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs()));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_malware", false);
// kTestExtensionId should be removed from the `blocklisted_extensions` and is
// re-enabled.
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
// The acknowledged state should be cleared because it is removed from the
// blocklist.
EXPECT_FALSE(blocklist_prefs::HasAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_MALWARE,
extension_prefs()));
}
// 1. The extension is added to the Omaha attribute blocklist with _malware
// attribute.
// 2. The extension is added to the Safe Browsing blocklist with
// BLOCKLISTED_MALWARE state.
// 3. The extension is removed from the Omaha attribute blocklist.
// 4. The extension is removed from the Safe Browsing blocklist.
TEST_F(BlocklistStatesInteractionUnitTest,
OmahaAttributeMalwareThenSafeBrowsingMalware) {
ExtensionStateTester state_tester(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_malware", true);
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId,
BLOCKLISTED_MALWARE);
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_malware", false);
// This extension is still blocklisted because the extension is still in the
// Safe Browsing blocklist.
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId, NOT_BLOCKLISTED);
// kTestExtensionId should be removed from `blocklisted_extensions` and is
// re-enabled.
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
}
// 1. The extension is added to the Safe Browsing greylist with
// BLOCKLISTED_POTENTIALLY_UNWANTED state.
// 2. The extension is added to the Omaha attribute blocklist with _malware
// attribute.
// 3. The extension is removed from the Omaha attribute blocklist.
// 4. The extension is removed from the Safe Browsing greylist.
TEST_F(BlocklistStatesInteractionUnitTest,
SafeBrowsingUwSThenOmahaAttributeMalware) {
ExtensionStateTester state_tester(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId,
BLOCKLISTED_POTENTIALLY_UNWANTED);
EXPECT_TRUE(state_tester.ExpectDisabledWithSingleReason(
kTestExtensionId, disable_reason::DISABLE_GREYLIST));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_malware", true);
EXPECT_EQ(BitMapBlocklistState::BLOCKLISTED_MALWARE,
blocklist_prefs::GetExtensionBlocklistState(kTestExtensionId,
extension_prefs()));
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
EXPECT_TRUE(extension_prefs()->HasDisableReason(
kTestExtensionId, disable_reason::DISABLE_GREYLIST));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_malware", false);
// The extension should be kept disabled because it's still in the Safe
// Browsing greylist.
EXPECT_EQ(BitMapBlocklistState::BLOCKLISTED_POTENTIALLY_UNWANTED,
blocklist_prefs::GetExtensionBlocklistState(kTestExtensionId,
extension_prefs()));
EXPECT_TRUE(state_tester.ExpectDisabledWithSingleReason(
kTestExtensionId, disable_reason::DISABLE_GREYLIST));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId, NOT_BLOCKLISTED);
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
}
// 1. The extension is added to the Safe Browsing blocklist with
// BLOCKLISTED_MALWARE state.
// 2. The extension is added to the Omaha attribute greylist with
// _policy_violation attribute.
// 3. The extension is removed from the Safe Browsing blocklist.
// 4. The extension is removed from the Omaha attribute greylist.
TEST_F(BlocklistStatesInteractionUnitTest,
SafeBrowsingMalwareThenOmahaAttributePolicyViolation) {
ExtensionStateTester state_tester(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId,
BLOCKLISTED_MALWARE);
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
EXPECT_EQ(BitMapBlocklistState::BLOCKLISTED_MALWARE,
blocklist_prefs::GetSafeBrowsingExtensionBlocklistState(
kTestExtensionId, extension_prefs()));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_policy_violation",
true);
EXPECT_TRUE(state_tester.ExpectBlocklisted(kTestExtensionId));
EXPECT_TRUE(blocklist_prefs::HasOmahaBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_CWS_POLICY_VIOLATION,
extension_prefs()));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId, NOT_BLOCKLISTED);
// The extension should be kept disabled because it's still in the Omaha
// attribute greylist.
EXPECT_TRUE(state_tester.ExpectDisabledWithSingleReason(
kTestExtensionId, disable_reason::DISABLE_GREYLIST));
EXPECT_EQ(BitMapBlocklistState::NOT_BLOCKLISTED,
blocklist_prefs::GetSafeBrowsingExtensionBlocklistState(
kTestExtensionId, extension_prefs()));
EXPECT_TRUE(blocklist_prefs::HasOmahaBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_CWS_POLICY_VIOLATION,
extension_prefs()));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_policy_violation",
false);
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
}
// 1. The extension is added to the Safe Browsing greylist with
// BLOCKLISTED_CWS_POLICY_VIOLATION state.
// 2. The extension is added to the Omaha attribute greylist with
// _policy_violation attribute.
// 3. The extension is removed from the Safe Browsing greylist.
// 4. The extension is removed from the Omaha attribute greylist.
TEST_F(BlocklistStatesInteractionUnitTest,
SafeBrowsingPolicyViolationThenOmahaAttributePolicyViolation) {
ExtensionStateTester state_tester(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId,
BLOCKLISTED_CWS_POLICY_VIOLATION);
EXPECT_TRUE(state_tester.ExpectDisabledWithSingleReason(
kTestExtensionId, disable_reason::DISABLE_GREYLIST));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_policy_violation",
true);
EXPECT_TRUE(state_tester.ExpectDisabledWithSingleReason(
kTestExtensionId, disable_reason::DISABLE_GREYLIST));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId, NOT_BLOCKLISTED);
// The extension should be kept disabled because it's still in the Omaha
// attribute greylist.
EXPECT_TRUE(state_tester.ExpectDisabledWithSingleReason(
kTestExtensionId, disable_reason::DISABLE_GREYLIST));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_policy_violation",
false);
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
}
// 1. The extension is added to the Omaha attribute greylist with
// BLOCKLISTED_CWS_POLICY_VIOLATION state.
// 2. The extension is added to the Safe Browsing greylist with
// _policy_violation attribute.
// 3. The extension is removed from the Omaha attribute greylist.
// 4. The extension is removed from the Safe Browsing greylist.
TEST_F(BlocklistStatesInteractionUnitTest,
OmahaAttributePolicyViolationThenSafeBrowsingPolicyViolation) {
ExtensionStateTester state_tester(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_policy_violation",
true);
EXPECT_TRUE(state_tester.ExpectDisabledWithSingleReason(
kTestExtensionId, disable_reason::DISABLE_GREYLIST));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId,
BLOCKLISTED_CWS_POLICY_VIOLATION);
EXPECT_TRUE(state_tester.ExpectDisabledWithSingleReason(
kTestExtensionId, disable_reason::DISABLE_GREYLIST));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_policy_violation",
false);
// The extension should be kept disabled because it's still in the Safe
// Browsing greylist.
EXPECT_TRUE(state_tester.ExpectDisabledWithSingleReason(
kTestExtensionId, disable_reason::DISABLE_GREYLIST));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId, NOT_BLOCKLISTED);
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
}
// 1. The extension is added to the Safe Browsing greylist with
// BLOCKLISTED_CWS_POLICY_VIOLATION state.
// 2. User re-enabled the extension.
// 3. The extension is added to the Omaha attribute greylist with
// _policy_violation attribute.
// 4. The extension is removed from the Safe Browsing greylist.
// 5. The extension is removed from the Omaha attribute greylist.
TEST_F(
BlocklistStatesInteractionUnitTest,
SafeBrowsingPolicyViolationThenOmahaAttributePolicyViolationWithUserAction) {
ExtensionStateTester state_tester(profile());
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId,
BLOCKLISTED_CWS_POLICY_VIOLATION);
EXPECT_TRUE(state_tester.ExpectDisabledWithSingleReason(
kTestExtensionId, disable_reason::DISABLE_GREYLIST));
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_CWS_POLICY_VIOLATION,
extension_prefs()));
// The extension is manually re-enabled.
registrar()->EnableExtension(kTestExtensionId);
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_policy_violation",
true);
// The extension is not disabled again, because it was previously manually
// re-enabled.
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
SetSafeBrowsingBlocklistStateForExtension(kTestExtensionId, NOT_BLOCKLISTED);
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
// The acknowledged state should not be cleared yet, because it is still in
// the Omaha attribute greylist.
EXPECT_TRUE(blocklist_prefs::HasAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_CWS_POLICY_VIOLATION,
extension_prefs()));
SetOmahaBlocklistStateForExtension(kTestExtensionId, "_policy_violation",
false);
EXPECT_TRUE(state_tester.ExpectEnabled(kTestExtensionId));
// The acknowledged state should be removed now.
EXPECT_FALSE(blocklist_prefs::HasAcknowledgedBlocklistState(
kTestExtensionId, BitMapBlocklistState::BLOCKLISTED_CWS_POLICY_VIOLATION,
extension_prefs()));
}
} // namespace extensions
#endif
|
