1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/component_loader.h"
#include <stddef.h>
#include <memory>
#include <optional>
#include <string>
#include "base/command_line.h"
#include "base/files/file_util.h"
#include "base/memory/raw_ptr.h"
#include "base/one_shot_event.h"
#include "base/path_service.h"
#include "base/scoped_observation.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/values.h"
#include "build/build_config.h"
#include "chrome/browser/extensions/chrome_extension_registrar_delegate.h"
#include "chrome/browser/extensions/extension_service_user_test_base.h"
#include "chrome/browser/extensions/test_extension_system.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile.h"
#include "chrome/test/base/testing_profile_manager.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
#include "content/public/test/browser_task_environment.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_registry_observer.h"
#include "extensions/browser/extension_system.h"
#include "extensions/browser/unloaded_extension_reason.h"
#include "extensions/buildflags/buildflags.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_set.h"
#include "extensions/common/manifest_handlers/background_info.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/display/test/test_screen.h"
static_assert(BUILDFLAG(ENABLE_EXTENSIONS_CORE));
namespace extensions {
class ExtensionUnloadedObserver : public ExtensionRegistryObserver {
public:
explicit ExtensionUnloadedObserver(ExtensionRegistry* registry) {
observation_.Observe(registry);
}
ExtensionUnloadedObserver(const ExtensionUnloadedObserver&) = delete;
ExtensionUnloadedObserver& operator=(const ExtensionUnloadedObserver&) =
delete;
size_t unloaded_count() const { return unloaded_count_; }
protected:
void OnExtensionUnloaded(content::BrowserContext* browser_context,
const Extension* extension,
UnloadedExtensionReason reason) override {
ASSERT_TRUE(Manifest::IsComponentLocation(extension->location()));
++unloaded_count_;
}
private:
size_t unloaded_count_ = 0;
base::ScopedObservation<ExtensionRegistry, ExtensionRegistryObserver>
observation_{this};
};
// TODO(crbug.com/408458901): Use an extensions test base class once we have
// one that works on desktop Android.
class ComponentLoaderTest : public testing::Test {
public:
ComponentLoaderTest() = default;
void SetUp() override {
profile_manager_ = std::make_unique<TestingProfileManager>(
TestingBrowserProcess::GetGlobal());
ASSERT_TRUE(profile_manager_->SetUp());
profile_ = profile_manager_->CreateTestingProfile(
TestingProfile::kDefaultProfileUserName, /*prefs=*/nullptr,
/*user_name=*/std::u16string(),
/*avatar_id=*/0, /*testing_factories=*/{});
extension_system_ =
static_cast<TestExtensionSystem*>(ExtensionSystem::Get(profile()));
extension_path_ =
GetBasePath().AppendASCII("good")
.AppendASCII("Extensions")
.AppendASCII("behllobkkfkfnphdnhnkndlbkcpglgmj")
.AppendASCII("1.0.0.0");
// Read in the extension manifest.
ASSERT_TRUE(base::ReadFileToString(
extension_path_.Append(kManifestFilename),
&manifest_contents_));
component_loader_ = ComponentLoader::Get(profile());
component_loader_->set_ignore_allowlist_for_testing(true);
// Set up ExtensionRegistrar with a delegate.
extension_registrar_delegate_ =
std::make_unique<ChromeExtensionRegistrarDelegate>(profile_.get());
extension_registrar_ = ExtensionRegistrar::Get(profile_.get());
extension_registrar_->Init(extension_registrar_delegate_.get(), true,
base::CommandLine::ForCurrentProcess(),
base::FilePath(), base::FilePath());
extension_registrar_delegate_->Init(extension_registrar_);
}
void TearDown() override {
extension_registrar_delegate_->Shutdown();
extension_registrar_ = nullptr;
component_loader_ = nullptr;
extension_system_ = nullptr;
profile_ = nullptr;
profile_manager_.reset();
}
base::FilePath GetBasePath() {
base::FilePath test_data_dir;
base::PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir);
return test_data_dir.AppendASCII("extensions");
}
void UninstallAllExtensions() {
auto* registry = ExtensionRegistry::Get(profile());
ExtensionSet extensions = registry->GenerateInstalledExtensionsSet();
for (const auto& extension : extensions) {
extension_registrar_->RemoveExtension(extension->id(),
UnloadedExtensionReason::UNINSTALL);
}
}
TestingProfile* profile() { return profile_; }
protected:
content::BrowserTaskEnvironment task_environment_{
base::test::TaskEnvironment::TimeSource::MOCK_TIME};
std::unique_ptr<TestingProfileManager> profile_manager_;
raw_ptr<TestingProfile> profile_ = nullptr;
std::unique_ptr<ChromeExtensionRegistrarDelegate>
extension_registrar_delegate_;
raw_ptr<ExtensionRegistrar> extension_registrar_ = nullptr;
raw_ptr<TestExtensionSystem> extension_system_ = nullptr;
raw_ptr<ComponentLoader> component_loader_ = nullptr;
// The root directory of the text extension.
base::FilePath extension_path_;
// The contents of the text extension's manifest file.
std::string manifest_contents_;
#if BUILDFLAG(IS_ANDROID)
// WebContentImpl requires a Screen instance on Android.
display::test::TestScreen screen_{/*create_display=*/true,
/*register_screen=*/true};
#endif
};
TEST_F(ComponentLoaderTest, ParseManifest) {
std::optional<base::Value::Dict> manifest;
// Test invalid JSON.
manifest = component_loader_->ParseManifest("{ 'test': 3 } invalid");
EXPECT_FALSE(manifest);
// Test manifests that are valid JSON, but don't have an object literal
// at the root. ParseManifest() should always return NULL.
manifest = component_loader_->ParseManifest(std::string());
EXPECT_FALSE(manifest);
manifest = component_loader_->ParseManifest("[{ \"foo\": 3 }]");
EXPECT_FALSE(manifest);
manifest = component_loader_->ParseManifest("\"Test\"");
EXPECT_FALSE(manifest);
manifest = component_loader_->ParseManifest("42");
EXPECT_FALSE(manifest);
manifest = component_loader_->ParseManifest("true");
EXPECT_FALSE(manifest);
manifest = component_loader_->ParseManifest("false");
EXPECT_FALSE(manifest);
manifest = component_loader_->ParseManifest("null");
EXPECT_FALSE(manifest);
// Test parsing valid JSON.
manifest = component_loader_->ParseManifest(
"{ \"test\": { \"one\": 1 }, \"two\": 2 }");
ASSERT_TRUE(manifest);
EXPECT_EQ(1, manifest->FindIntByDottedPath("test.one"));
EXPECT_EQ(2, manifest->FindInt("two"));
manifest = component_loader_->ParseManifest(manifest_contents_);
const std::string* string_value =
manifest->FindStringByDottedPath("background.page");
ASSERT_TRUE(string_value);
EXPECT_EQ("backgroundpage.html", *string_value);
}
// Test that the extension isn't loaded if the extension service isn't ready.
TEST_F(ComponentLoaderTest, AddWhenNotReady) {
std::string extension_id =
component_loader_->Add(manifest_contents_, extension_path_);
EXPECT_NE("", extension_id);
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
EXPECT_EQ(0u, registry->enabled_extensions().size());
}
// Test that it *is* loaded when the extension service *is* ready.
TEST_F(ComponentLoaderTest, AddWhenReady) {
extension_system_->SetReady();
std::string extension_id =
component_loader_->Add(manifest_contents_, extension_path_);
EXPECT_NE("", extension_id);
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
EXPECT_EQ(1u, registry->enabled_extensions().size());
EXPECT_TRUE(registry->enabled_extensions().GetByID(extension_id));
}
TEST_F(ComponentLoaderTest, Remove) {
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
// Removing an extension that was never added should be ok.
component_loader_->Remove(extension_path_);
EXPECT_EQ(0u, registry->enabled_extensions().size());
// Try adding and removing before LoadAll() is called.
component_loader_->Add(manifest_contents_, extension_path_);
component_loader_->Remove(extension_path_);
component_loader_->LoadAll();
EXPECT_EQ(0u, registry->enabled_extensions().size());
// Load an extension, and check that it's unloaded when Remove() is called.
extension_system_->SetReady();
std::string extension_id =
component_loader_->Add(manifest_contents_, extension_path_);
EXPECT_EQ(1u, registry->enabled_extensions().size());
component_loader_->Remove(extension_path_);
EXPECT_EQ(0u, registry->enabled_extensions().size());
// And after calling LoadAll(), it shouldn't get loaded.
component_loader_->LoadAll();
EXPECT_EQ(0u, registry->enabled_extensions().size());
}
TEST_F(ComponentLoaderTest, LoadAll) {
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
// No extensions should be loaded if none were added.
component_loader_->LoadAll();
EXPECT_EQ(0u, registry->enabled_extensions().size());
// Use LoadAll() to load the default extensions.
component_loader_->AddDefaultComponentExtensions(false);
component_loader_->LoadAll();
unsigned int default_count = registry->enabled_extensions().size();
// Clear the list of loaded extensions, and reload with one more.
UninstallAllExtensions();
component_loader_->Add(manifest_contents_, extension_path_);
component_loader_->LoadAll();
EXPECT_EQ(default_count + 1, registry->enabled_extensions().size());
}
class ComponentLoaderExtensionServiceTest
: public ExtensionServiceUserTestBase {
public:
// testing::Test:
void SetUp() override {
ExtensionServiceUserTestBase::InitializeEmptyExtensionService();
ExtensionServiceUserTestBase::SetUp();
}
// Test that certain histograms are emitted for user and non-user profiles
// (users for ChromeOS Ash).
void RunEmitUserHistogramsTest(int nonuser_expected_total_count,
int user_expected_total_count) {
auto* component_loader = ComponentLoader::Get(profile());
component_loader->set_profile_for_testing(profile());
base::HistogramTester histograms;
component_loader->LoadAll();
histograms.ExpectTotalCount("Extensions.LoadAllComponentTime", 1);
histograms.ExpectTotalCount("Extensions.LoadAllComponentTime.NonUser",
nonuser_expected_total_count);
histograms.ExpectTotalCount("Extensions.LoadAllComponentTime.User",
user_expected_total_count);
}
};
TEST_F(ComponentLoaderExtensionServiceTest, LoadAll_EmitUserHistograms) {
ASSERT_NO_FATAL_FAILURE(MaybeSetUpTestUser(/*is_guest=*/false));
RunEmitUserHistogramsTest(/*nonuser_expected_total_count=*/0,
/*user_expected_total_count=*/1);
}
TEST_F(ComponentLoaderExtensionServiceTest, LoadAll_NonUserEmitHistograms) {
ASSERT_NO_FATAL_FAILURE(MaybeSetUpTestUser(/*is_guest=*/true));
RunEmitUserHistogramsTest(/*nonuser_expected_total_count=*/1,
/*user_expected_total_count=*/0);
}
// Test is flaky. https://crbug.com/1306983
TEST_F(ComponentLoaderTest, DISABLED_AddOrReplace) {
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
ExtensionUnloadedObserver unload_observer(registry);
EXPECT_EQ(0u, component_loader_->registered_extensions_count());
// Allow the Feedback extension, which has a background page, to be loaded.
component_loader_->EnableBackgroundExtensionsForTesting();
component_loader_->AddDefaultComponentExtensions(false);
size_t const default_count = component_loader_->registered_extensions_count();
base::FilePath known_extension = GetBasePath()
.AppendASCII("override_component_extension");
base::FilePath unknown_extension = extension_path_;
base::FilePath invalid_extension = GetBasePath()
.AppendASCII("this_path_does_not_exist");
// Replace a default component extension.
component_loader_->AddOrReplace(known_extension);
EXPECT_EQ(default_count, component_loader_->registered_extensions_count());
// Add a new component extension.
component_loader_->AddOrReplace(unknown_extension);
EXPECT_EQ(default_count + 1,
component_loader_->registered_extensions_count());
extension_system_->SetReady();
component_loader_->LoadAll();
EXPECT_EQ(default_count + 1, registry->enabled_extensions().size());
EXPECT_EQ(0u, unload_observer.unloaded_count());
// replace loaded component extension.
component_loader_->AddOrReplace(known_extension);
EXPECT_EQ(default_count + 1, registry->enabled_extensions().size());
EXPECT_EQ(1u, unload_observer.unloaded_count());
// Add an invalid component extension.
std::string extension_id = component_loader_->AddOrReplace(invalid_extension);
EXPECT_TRUE(extension_id.empty());
}
} // namespace extensions
|