1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115
|
// Copyright 2017 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/corrupted_extension_reinstaller.h"
#include <utility>
#include "base/functional/bind.h"
#include "base/functional/callback.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/test/browser_task_environment.h"
#include "extensions/common/mojom/manifest.mojom-shared.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
namespace {
const char kDummyExtensionId[] = "whatever";
}
class TestReinstallerTracker {
public:
TestReinstallerTracker()
: action_(base::BindRepeating(&TestReinstallerTracker::ReinstallAction,
base::Unretained(this))) {
CorruptedExtensionReinstaller::set_reinstall_action_for_test(&action_);
}
TestReinstallerTracker(const TestReinstallerTracker&) = delete;
TestReinstallerTracker& operator=(const TestReinstallerTracker&) = delete;
~TestReinstallerTracker() {
CorruptedExtensionReinstaller::set_reinstall_action_for_test(nullptr);
}
void ReinstallAction(base::OnceClosure callback,
base::TimeDelta reinstall_delay) {
++call_count_;
saved_callback_ = std::move(callback);
}
void Proceed() {
DCHECK(saved_callback_);
DCHECK(!saved_callback_->is_null());
// Run() will set |saved_callback_| again, so use a temporary.
base::OnceClosure callback = std::move(saved_callback_.value());
saved_callback_.reset();
std::move(callback).Run();
}
int call_count() { return call_count_; }
private:
int call_count_ = 0;
std::optional<base::OnceClosure> saved_callback_;
CorruptedExtensionReinstaller::ReinstallCallback action_;
};
class CorruptedExtensionReinstallerUnittest : public testing::Test {
public:
CorruptedExtensionReinstallerUnittest() = default;
CorruptedExtensionReinstallerUnittest(
const CorruptedExtensionReinstallerUnittest&) = delete;
CorruptedExtensionReinstallerUnittest& operator=(
const CorruptedExtensionReinstallerUnittest&) = delete;
~CorruptedExtensionReinstallerUnittest() override = default;
private:
content::BrowserTaskEnvironment task_environment_;
};
// Tests that a single extension corruption will keep retrying reinstallation.
TEST_F(CorruptedExtensionReinstallerUnittest, Retry) {
TestingProfile profile;
auto* reinstaller = CorruptedExtensionReinstaller::Get(&profile);
reinstaller->ExpectReinstallForCorruption(
kDummyExtensionId,
CorruptedExtensionReinstaller::PolicyReinstallReason::
CORRUPTION_DETECTED_WEBSTORE,
mojom::ManifestLocation::kInternal);
TestReinstallerTracker tracker;
reinstaller->NotifyExtensionDisabledDueToCorruption();
EXPECT_EQ(1, tracker.call_count());
tracker.Proceed();
EXPECT_EQ(2, tracker.call_count());
tracker.Proceed();
EXPECT_EQ(3, tracker.call_count());
}
// Tests that CorruptedExtensionReinstaller doesn't schedule a
// CheckForExternalUpdates() when one is already in-flight through PostTask.
TEST_F(CorruptedExtensionReinstallerUnittest,
DoNotScheduleWhenAlreadyInflight) {
TestingProfile profile;
auto* reinstaller = CorruptedExtensionReinstaller::Get(&profile);
reinstaller->ExpectReinstallForCorruption(
kDummyExtensionId,
CorruptedExtensionReinstaller::PolicyReinstallReason::
CORRUPTION_DETECTED_WEBSTORE,
mojom::ManifestLocation::kInternal);
TestReinstallerTracker tracker;
reinstaller->NotifyExtensionDisabledDueToCorruption();
EXPECT_EQ(1, tracker.call_count());
reinstaller->NotifyExtensionDisabledDueToCorruption();
// Resolve the reinstall attempt.
tracker.Proceed();
EXPECT_EQ(2, tracker.call_count());
reinstaller->NotifyExtensionDisabledDueToCorruption();
// Not resolving the pending attempt will not produce further calls.
EXPECT_EQ(2, tracker.call_count());
}
} // namespace extensions
|