1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002
|
// Copyright 2010 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/strings/stringprintf.h"
#include "build/build_config.h"
#include "chrome/browser/extensions/api/permissions/permissions_api.h"
#include "chrome/browser/extensions/chrome_extension_test_notification_observer.h"
#include "chrome/browser/extensions/chrome_extensions_browser_client.h"
#include "chrome/browser/extensions/chrome_test_extension_loader.h"
#include "chrome/browser/extensions/extension_apitest.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/profiles/profile_observer.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/common/extensions/api/tabs.h"
#include "chrome/common/extensions/api/web_navigation.h"
#include "chrome/test/base/profile_destruction_waiter.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/result_codes.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "content/public/test/service_worker_test_helpers.h"
#include "extensions/browser/background_script_executor.h"
#include "extensions/browser/event_router.h"
#include "extensions/browser/extension_event_histogram_value.h"
#include "extensions/browser/extension_host.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/process_manager.h"
#include "extensions/browser/process_manager_observer.h"
#include "extensions/test/extension_background_page_waiter.h"
#include "extensions/test/extension_test_message_listener.h"
#include "extensions/test/result_catcher.h"
#include "extensions/test/test_extension_dir.h"
#include "net/dns/mock_host_resolver.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace extensions {
namespace {
using ContextType = extensions::browser_test_util::ContextType;
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, Events) {
ASSERT_TRUE(RunExtensionTest("events")) << message_;
}
// Tests that events are unregistered when an extension page shuts down.
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, EventsAreUnregistered) {
// In this test, page1.html registers for a number of events, then navigates
// to page2.html, which should unregister those events. page2.html notifies
// pass, by which point the event should have been unregistered.
EventRouter* event_router = EventRouter::Get(profile());
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
static constexpr char test_extension_name[] = "events_are_unregistered";
ASSERT_TRUE(
RunExtensionTest(test_extension_name, {.extension_url = "page1.html"}))
<< message_;
// Find the extension we just installed by looking for the path.
base::FilePath extension_path =
test_data_dir_.AppendASCII(test_extension_name);
const Extension* extension =
GetExtensionByPath(registry->enabled_extensions(), extension_path);
ASSERT_TRUE(extension) << "No extension found at \"" << extension_path.value()
<< "\" (absolute path \""
<< base::MakeAbsoluteFilePath(extension_path).value()
<< "\")";
const std::string& id = extension->id();
// The page has closed, so no matter what all events are no longer listened
// to. Assertions for normal events:
EXPECT_FALSE(
event_router->ExtensionHasEventListener(id, "browserAction.onClicked"));
EXPECT_FALSE(
event_router->ExtensionHasEventListener(id, "runtime.onStartup"));
EXPECT_FALSE(
event_router->ExtensionHasEventListener(id, "runtime.onSuspend"));
EXPECT_FALSE(
event_router->ExtensionHasEventListener(id, "runtime.onInstalled"));
// Assertions for filtered events:
EXPECT_FALSE(event_router->ExtensionHasEventListener(
id, "webNavigation.onBeforeNavigate"));
EXPECT_FALSE(
event_router->ExtensionHasEventListener(id, "webNavigation.onCommitted"));
EXPECT_FALSE(event_router->ExtensionHasEventListener(
id, "webNavigation.onDOMContentLoaded"));
EXPECT_FALSE(
event_router->ExtensionHasEventListener(id, "webNavigation.onCompleted"));
}
// Test that listeners for webview-related events are not stored (even for lazy
// contexts). See crbug.com/736381.
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebViewEventRegistration) {
ASSERT_TRUE(RunExtensionTest("events/webview_events",
{.launch_as_platform_app = true}))
<< message_;
EventRouter* event_router = EventRouter::Get(profile());
// We should not register lazy listeners for any webview-related events.
EXPECT_FALSE(
event_router->HasLazyEventListenerForTesting("webViewInternal.onClose"));
EXPECT_FALSE(event_router->HasLazyEventListenerForTesting("webview.close"));
EXPECT_FALSE(event_router->HasLazyEventListenerForTesting(
"chromeWebViewInternal.onContextMenuShow"));
EXPECT_FALSE(event_router->HasLazyEventListenerForTesting(
"chromeWebViewInternal.onClicked"));
EXPECT_FALSE(event_router->HasLazyEventListenerForTesting(
"webViewInternal.contextMenus"));
// Chrome webview context menu events also use a "subevent" pattern, so we
// need to look for suffixed events. These seem to always be suffixed with
// "3" and "4", but look for the first 10 to be a bit safer.
for (int i = 0; i < 10; ++i) {
EXPECT_FALSE(event_router->HasLazyEventListenerForTesting(
base::StringPrintf("chromeWebViewInternal.onClicked/%d", i)));
EXPECT_FALSE(event_router->HasLazyEventListenerForTesting(
base::StringPrintf("chromeWebViewInternal.onContextMenuShow/%d", i)));
EXPECT_FALSE(
event_router->HasLazyEventListenerForTesting(base::StringPrintf(
"webViewInternal.declarativeWebRequest.onMessage/%d", i)));
}
// Sanity check: app.runtime.onLaunched should have a lazy listener.
EXPECT_TRUE(
event_router->HasLazyEventListenerForTesting("app.runtime.onLaunched"));
}
// Tests that registering a listener for an event that requires a permission and
// then removing that permission using the permissions API does not lead to a
// crash. Regression test for crbug.com/1402642.
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, EventAfterPermissionRemoved) {
// Add an extension which registers an event on a permission which it has
// declared as optional.
constexpr char kManifest[] = R"({
"name": "Test",
"manifest_version": 3,
"version": "1.0",
"background": {"service_worker": "worker.js"},
"optional_permissions": ["webNavigation"]
})";
constexpr char kWorker[] = R"(
var restrictedListenerCallCount = 0;
var unrestrictedListenerCallCount = 0;
function queryRestrictedListenerCallCount() {
chrome.test.sendScriptResult(restrictedListenerCallCount);
}
function queryUnrestrictedListenerCallCount() {
chrome.test.sendScriptResult(unrestrictedListenerCallCount);
}
function restrictedListener() {
restrictedListenerCallCount++;
}
function unrestrictedListener() {
unrestrictedListenerCallCount++;
chrome.test.sendMessage('onActivated called');
}
chrome.tabs.onActivated.addListener(unrestrictedListener);
async function requestPermission() {
let result = await chrome.permissions.request(
{permissions: ['webNavigation']});
chrome.webNavigation.onCommitted.addListener(restrictedListener);
chrome.test.sendScriptResult(result);
}
async function removePermission() {
let result = await chrome.permissions.remove(
{permissions: ['webNavigation']});
chrome.test.sendScriptResult(result);
};
)";
auto dialog_action_reset =
PermissionsRequestFunction::SetDialogActionForTests(
PermissionsRequestFunction::DialogAction::kAutoConfirm);
PermissionsRequestFunction::SetIgnoreUserGestureForTests(true);
TestExtensionDir test_dir;
test_dir.WriteManifest(kManifest);
test_dir.WriteFile(FILE_PATH_LITERAL("worker.js"), kWorker);
scoped_refptr<const Extension> extension =
LoadExtension(test_dir.UnpackedPath());
ASSERT_TRUE(extension);
// A helper function to run the script in the worker context.
auto run_script_in_worker = [this, extension](const std::string& script) {
return BackgroundScriptExecutor::ExecuteScript(
profile(), extension->id(), script,
BackgroundScriptExecutor::ResultCapture::kSendScriptResult);
};
// A helper function to broadcast two events, one which requires a permission
// and one that does not. Note: We rely on the FIFO nature of events here so
// we can be sure that the restricted event will be processed before the
// unrestricted one reports back that it has arrived.
auto send_events = [this]() {
EventRouter* event_router = EventRouter::Get(profile());
// The webNavigation.onCommitted event requires the webNavigation permission
// to listen to. Send that one out first.
{
auto event_details = api::web_navigation::OnCommitted::Details();
event_details.document_lifecycle =
api::extension_types::DocumentLifecycle::kPrerender;
event_details.frame_type =
api::extension_types::FrameType::kOutermostFrame;
event_details.transition_type =
api::web_navigation::TransitionType::kLink;
event_router->BroadcastEvent(std::make_unique<Event>(
events::FOR_TEST, "webNavigation.onCommitted",
api::web_navigation::OnCommitted::Create(event_details)));
}
// The tabs.onActivated event listener in the extension will send a message
// after it receives it, so we wait for that to come back.
{
auto event_details = api::tabs::OnActivated::ActiveInfo();
ExtensionTestMessageListener listener_listener("onActivated called");
event_router->BroadcastEvent(std::make_unique<Event>(
events::FOR_TEST, "tabs.onActivated",
api::tabs::OnActivated::Create(event_details)));
ASSERT_TRUE(listener_listener.WaitUntilSatisfied());
}
};
// Initially the listeners should not have been called yet.
ASSERT_EQ(base::Value(0),
run_script_in_worker("queryRestrictedListenerCallCount()"));
ASSERT_EQ(base::Value(0),
run_script_in_worker("queryUnrestrictedListenerCallCount()"));
// Trigger the event, which should only increase the unrestricted count as the
// restricted event hasn't been registered.
send_events();
ASSERT_EQ(base::Value(0),
run_script_in_worker("queryRestrictedListenerCallCount()"));
ASSERT_EQ(base::Value(1),
run_script_in_worker("queryUnrestrictedListenerCallCount()"));
// Next have the extension request the permission and add the restricted
// listener, then trigger the event again which should increase both call
// counts.
ASSERT_EQ(base::Value(true), run_script_in_worker("requestPermission()"));
send_events();
ASSERT_EQ(base::Value(1),
run_script_in_worker("queryRestrictedListenerCallCount()"));
ASSERT_EQ(base::Value(2),
run_script_in_worker("queryUnrestrictedListenerCallCount()"));
// Now have the extension remove the permission and trigger the event, which
// should not trigger the restricted listener.
ASSERT_EQ(base::Value(true), run_script_in_worker("removePermission()"));
send_events();
ASSERT_EQ(base::Value(1),
run_script_in_worker("queryRestrictedListenerCallCount()"));
ASSERT_EQ(base::Value(3),
run_script_in_worker("queryUnrestrictedListenerCallCount()"));
// Finally add the permission again and trigger the event. The listeners
// should both be called.
ASSERT_EQ(base::Value(true), run_script_in_worker("requestPermission()"));
send_events();
ASSERT_EQ(base::Value(2),
run_script_in_worker("queryRestrictedListenerCallCount()"));
ASSERT_EQ(base::Value(4),
run_script_in_worker("queryUnrestrictedListenerCallCount()"));
}
// Tests that events broadcast right after a profile has started to be destroyed
// do not cause a crash. Regression test for crbug.com/1335837.
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DispatchEventDuringShutdown) {
// Minimize background page expiration time for testing purposes.
ProcessManager::SetEventPageIdleTimeForTesting(1);
ProcessManager::SetEventPageSuspendingTimeForTesting(1);
// Load extension.
constexpr char kManifest[] = R"({
"name": "Test",
"manifest_version": 2,
"version": "1.0",
"background": {"scripts": ["background.js"], "persistent": false}
})";
constexpr char kBackground[] = R"(
chrome.tabs.onActivated.addListener(activeInfo => {});
chrome.test.notifyPass();
)";
TestExtensionDir test_dir;
test_dir.WriteManifest(kManifest);
test_dir.WriteFile(FILE_PATH_LITERAL("background.js"), kBackground);
ChromeTestExtensionLoader loader(profile());
loader.set_pack_extension(true);
ResultCatcher catcher;
auto extension = loader.LoadExtension(test_dir.UnpackedPath());
ASSERT_TRUE(extension);
EXPECT_TRUE(catcher.GetNextResult());
// Verify that an event was registered.
EventRouter* event_router = EventRouter::Get(profile());
EXPECT_TRUE(event_router->ExtensionHasEventListener(extension->id(),
"tabs.onActivated"));
ExtensionBackgroundPageWaiter(profile(), *extension)
.WaitForBackgroundClosed();
// Dispatch event after starting profile destruction.
ProfileDestructionWaiter waiter(profile());
profile()->MaybeSendDestroyedNotification();
waiter.Wait();
ASSERT_TRUE(waiter.destroyed());
// Broadcast an event to the event router. Since a shutdown is occurring, it
// should be ignored and cause no problems.
event_router->BroadcastEvent(std::make_unique<Event>(
events::FOR_TEST, "tabs.onActivated", base::Value::List()));
}
class EventsApiTest : public ExtensionApiTest {
public:
EventsApiTest() = default;
EventsApiTest(const EventsApiTest&) = delete;
EventsApiTest& operator=(const EventsApiTest&) = delete;
protected:
void SetUpOnMainThread() override {
ExtensionApiTest::SetUpOnMainThread();
host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_TRUE(embedded_test_server()->Start());
EXPECT_TRUE(scoped_temp_dir_.CreateUniqueTempDir());
}
struct ExtensionCRXData {
std::string unpacked_relative_path;
base::FilePath crx_path;
explicit ExtensionCRXData(const std::string& unpacked_relative_path)
: unpacked_relative_path(unpacked_relative_path) {}
};
void SetUpCRX(const std::string& root_dir,
const std::string& pem_filename,
std::vector<ExtensionCRXData>* crx_data_list) {
const base::FilePath test_dir = test_data_dir_.AppendASCII(root_dir);
const base::FilePath pem_path = test_dir.AppendASCII(pem_filename);
for (ExtensionCRXData& crx_data : *crx_data_list) {
crx_data.crx_path = PackExtensionWithOptions(
test_dir.AppendASCII(crx_data.unpacked_relative_path),
scoped_temp_dir_.GetPath().AppendASCII(
crx_data.unpacked_relative_path + ".crx"),
pem_path, base::FilePath());
}
}
private:
base::ScopedTempDir scoped_temp_dir_;
};
// Tests that updating an extension sends runtime.onInstalled event to the
// updated extension.
IN_PROC_BROWSER_TEST_F(EventsApiTest, ExtensionUpdateSendsOnInstalledEvent) {
std::vector<ExtensionCRXData> data;
data.emplace_back("v1");
data.emplace_back("v2");
SetUpCRX("lazy_events/on_installed", "pem.pem", &data);
ExtensionId extension_id;
{
// Install version 1 of the extension and expect runtime.onInstalled.
ResultCatcher catcher;
const int expected_change = 1;
const Extension* extension_v1 =
InstallExtension(data[0].crx_path, expected_change);
extension_id = extension_v1->id();
ASSERT_TRUE(extension_v1);
EXPECT_TRUE(catcher.GetNextResult());
}
{
// Update to version 2, also expect runtime.onInstalled.
ResultCatcher catcher;
const int expected_change = 0;
const Extension* extension_v2 =
UpdateExtension(extension_id, data[1].crx_path, expected_change);
ASSERT_TRUE(extension_v2);
EXPECT_TRUE(catcher.GetNextResult());
}
}
// Tests that if updating an extension makes the extension disabled (due to
// permissions increase), then enabling the extension fires runtime.onInstalled
// correctly to the updated extension.
IN_PROC_BROWSER_TEST_F(EventsApiTest,
UpdateDispatchesOnInstalledAfterEnablement) {
std::vector<ExtensionCRXData> data;
data.emplace_back("v1");
data.emplace_back("v2");
SetUpCRX("lazy_events/on_installed_permissions_increase", "pem.pem", &data);
ExtensionRegistry* registry = ExtensionRegistry::Get(profile());
ExtensionId extension_id;
{
// Install version 1 of the extension and expect runtime.onInstalled.
ResultCatcher catcher;
const int expected_change = 1;
const Extension* extension_v1 =
InstallExtension(data[0].crx_path, expected_change);
extension_id = extension_v1->id();
ASSERT_TRUE(extension_v1);
EXPECT_TRUE(catcher.GetNextResult());
}
{
// Update to version 2, which will be disabled due to permissions increase.
ResultCatcher catcher;
const int expected_change = -1; // Expect extension to be disabled.
ASSERT_FALSE(
UpdateExtension(extension_id, data[1].crx_path, expected_change));
const Extension* extension_v2 =
registry->disabled_extensions().GetByID(extension_id);
ASSERT_TRUE(extension_v2);
// Enable the extension.
ExtensionRegistrar::Get(profile())->GrantPermissionsAndEnableExtension(
*extension_v2);
EXPECT_TRUE(catcher.GetNextResult());
}
}
// This test is OK on Windows, but times out on other platforms.
// https://crbug.com/833854
#if BUILDFLAG(IS_WIN)
#define MAYBE_NewlyIntroducedListener NewlyIntroducedListener
#else
#define MAYBE_NewlyIntroducedListener DISABLED_NewlyIntroducedListener
#endif
// Tests that if an extension's updated version has a new lazy listener, it
// fires properly after the update.
IN_PROC_BROWSER_TEST_F(EventsApiTest, MAYBE_NewlyIntroducedListener) {
std::vector<ExtensionCRXData> data;
data.emplace_back("v1");
data.emplace_back("v2");
SetUpCRX("lazy_events/new_event_in_new_version", "pem.pem", &data);
ExtensionId extension_id;
{
// Install version 1 of the extension.
ResultCatcher catcher;
const int expected_change = 1;
const Extension* extension_v1 =
InstallExtension(data[0].crx_path, expected_change);
EXPECT_TRUE(extension_v1);
extension_id = extension_v1->id();
ASSERT_TRUE(extension_v1);
EXPECT_TRUE(catcher.GetNextResult());
}
{
// Update to version 2, that has tabs.onCreated event listener.
ResultCatcher catcher;
const int expected_change = 0;
const Extension* extension_v2 =
UpdateExtension(extension_id, data[1].crx_path, expected_change);
ASSERT_TRUE(extension_v2);
ui_test_utils::NavigateToURLWithDisposition(
browser(), GURL(url::kAboutBlankURL),
WindowOpenDisposition::NEW_BACKGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP);
// Expect tabs.onCreated to fire.
EXPECT_TRUE(catcher.GetNextResult());
}
}
// Tests that, if an extension registers multiple listeners for a filtered
// event where the listeners overlap, but are not identical, each listener is
// only triggered once for a given event.
// TODO(crbug.com/40365717): This test is currently (intentionally)
// testing improper behavior and will be fixed as part of the linked bug.
IN_PROC_BROWSER_TEST_F(
EventsApiTest,
MultipleFilteredListenersWithOverlappingFiltersShouldOnlyTriggerOnce) {
// Load an extension that registers two listeners for a webNavigation event
// (which supports filters). The first filter is for any event with a host
// that matches 'example' (such as 'example.com') and the second filter is
// for any that has a path that matches 'simple'. Thus, the URL
// http://example.com/simple.html matches both filters.
// Note that we use a page here (instead of a service worker) because we
// separately (and purely coincidentally) de-dupe messages to lazy contexts.
static constexpr char kManifest[] =
R"({
"name": "Events test",
"manifest_version": 3,
"version": "0.1",
"permissions": ["webNavigation"]
})";
static constexpr char kPageHtml[] =
R"(<html><script src="page.js"></script></html>)";
static constexpr char kPageJs[] =
R"(self.receivedEvents = 0;
chrome.webNavigation.onCommitted.addListener(() => {
++receivedEvents;
}, {url: [{hostContains: 'example'}]});
chrome.webNavigation.onCommitted.addListener(() => {
++receivedEvents;
}, {url: [{pathContains: 'simple'}]});)";
TestExtensionDir test_dir;
test_dir.WriteManifest(kManifest);
test_dir.WriteFile(FILE_PATH_LITERAL("page.html"), kPageHtml);
test_dir.WriteFile(FILE_PATH_LITERAL("page.js"), kPageJs);
const Extension* extension = LoadExtension(test_dir.UnpackedPath());
ASSERT_TRUE(extension);
// Navigate to the extension page that registers the events.
ASSERT_TRUE(ui_test_utils::NavigateToURL(
browser(), extension->GetResourceURL("page.html")));
content::WebContents* extension_contents =
browser()->tab_strip_model()->GetActiveWebContents();
// So far, no events should have been received.
EXPECT_EQ(0, content::EvalJs(extension_contents, "self.receivedEvents;"));
// Navigate to http://example.com/simple.html.
const GURL url =
embedded_test_server()->GetURL("example.com", "/simple.html");
ASSERT_TRUE(ui_test_utils::NavigateToURLWithDisposition(
browser(), url, WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP));
// TODO(crbug.com/40365717): This should be:
// EXPECT_EQ(2, content::EvalJs(extension_contents, "self.receivedEvents;"));
// because each listener should fire exactly once (we only visited one new
// page).
// However, currently we'll dispatch the event to the same process twice
// (once for each listener), and each dispatch will match both listeners,
// resulting in each listener being triggered twice (for a total of four
// received events).
EXPECT_EQ(4, content::EvalJs(extension_contents, "self.receivedEvents;"));
}
class ChromeUpdatesEventsApiTest : public EventsApiTest,
public ProcessManagerObserver {
public:
ChromeUpdatesEventsApiTest() {
// We set this in the constructor (rather than in a SetUp() method) because
// it needs to be done before any of the extensions system is created.
ChromeExtensionsBrowserClient::set_did_chrome_update_for_testing(true);
}
ChromeUpdatesEventsApiTest(const ChromeUpdatesEventsApiTest&) = delete;
ChromeUpdatesEventsApiTest& operator=(const ChromeUpdatesEventsApiTest&) =
delete;
void SetUpOnMainThread() override {
EventsApiTest::SetUpOnMainThread();
ProcessManager* process_manager = ProcessManager::Get(profile());
ProcessManager::Get(profile())->AddObserver(this);
for (ExtensionHost* host : process_manager->background_hosts()) {
observed_extension_names_.insert(host->extension()->name());
}
}
void TearDownOnMainThread() override {
ProcessManager::Get(profile())->RemoveObserver(this);
ChromeExtensionsBrowserClient::set_did_chrome_update_for_testing(false);
EventsApiTest::TearDownOnMainThread();
}
void OnBackgroundHostCreated(ExtensionHost* host) override {
// Use name since it's more deterministic than ID.
observed_extension_names_.insert(host->extension()->name());
}
const std::set<std::string> observed_extension_names() const {
return observed_extension_names_;
}
private:
std::set<std::string> observed_extension_names_;
};
IN_PROC_BROWSER_TEST_F(ChromeUpdatesEventsApiTest, PRE_ChromeUpdates) {
{
ChromeTestExtensionLoader loader(profile());
loader.set_pack_extension(true);
ResultCatcher catcher;
ASSERT_TRUE(loader.LoadExtension(
test_data_dir_.AppendASCII("lazy_events/chrome_updates/listener")));
EXPECT_TRUE(catcher.GetNextResult());
}
{
ChromeTestExtensionLoader loader(profile());
loader.set_pack_extension(true);
ResultCatcher catcher;
ASSERT_TRUE(loader.LoadExtension(
test_data_dir_.AppendASCII("lazy_events/chrome_updates/non_listener")));
EXPECT_TRUE(catcher.GetNextResult());
}
}
// Test that we only dispatch the onInstalled event triggered by a chrome update
// to extensions that have a registered onInstalled listener.
IN_PROC_BROWSER_TEST_F(ChromeUpdatesEventsApiTest, ChromeUpdates) {
ChromeExtensionTestNotificationObserver(browser())
.WaitForExtensionViewsToLoad();
content::RunAllPendingInMessageLoop();
content::RunAllTasksUntilIdle();
// "chrome updates listener" registered a listener for the onInstalled event,
// whereas "chrome updates non listener" did not. Only the
// "chrome updates listener" extension should have been woken up for the
// chrome update event.
EXPECT_TRUE(observed_extension_names().count("chrome updates listener"));
EXPECT_FALSE(observed_extension_names().count("chrome updates non listener"));
}
// TODO(crbug.com/41493334): Also test extensions with service workers and their
// equivalent to ExtensionHost (EventAckData) for these scenarios:
// 1. Dispatch to background context acks (duplicate of
// DispatchToBackgroundPage_Acks)
// 2. Dispatch to content script doesn't ack (duplicate of
// DispatchToContentScript_DoesNotRecordMessageForAcking)
// 2. Dispatch guest view event (EventRouter::DispatchEventToSender()) acks
// (similar to DispatchToPage_Acks)
class EventDispatchingApiTest
: public ExtensionApiTest,
public testing::WithParamInterface<ContextType> {
public:
EventDispatchingApiTest() = default;
EventDispatchingApiTest(const EventDispatchingApiTest&) = delete;
EventDispatchingApiTest& operator=(const EventDispatchingApiTest&) = delete;
};
// Tests that background pages will receive an event message (routed through the
// EventRouter::DispatchToProcess() flow) and properly track and remove the
// unacked event message in ExtensionHost. Rather than send generate webRequest
// events this uses storage events to use this flow.
IN_PROC_BROWSER_TEST_P(EventDispatchingApiTest, DispatchToBackgroundPage_Acks) {
// Load either a persistent background page or a event page script.
static constexpr char kManifestPersistentBackgroundScript[] =
R"("persistent": true)";
static constexpr char kManifestEventPageBackgroundScript[] =
R"("persistent": false)";
// Load an extension with a chrome.storage.onChanged
// (EventRouter::DispatchToProcess()) listener and wait for the
// chrome.runtime.onInstalled listener to fire.
static constexpr char kManifest[] =
R"({
"name": "Background page",
"version": "0.1",
"manifest_version": 2,
"background": {
"scripts": ["background.js"],
%s
},
"permissions": ["storage"]
})";
bool persistent_background_extension =
GetParam() == ContextType::kPersistentBackground;
const char* background_script = persistent_background_extension
? kManifestPersistentBackgroundScript
: kManifestEventPageBackgroundScript;
std::string manifest = base::StringPrintf(kManifest, background_script);
TestExtensionDir test_dir;
test_dir.WriteManifest(manifest);
constexpr char kBackgroundJs[] =
R"(
chrome.runtime.onInstalled.addListener((details) => {
// Asynchronously send the message that the listener fired so that the
// event is considered ack'd in the browser C++ code.
setTimeout(() => {
chrome.test.sendMessage('installed listener fired');
}, 0);
});
chrome.storage.onChanged.addListener((details) => {
// Asynchronously send the message that the listener fired so that the
// event is considered ack'd in the browser C++ code.
setTimeout(() => {
chrome.test.sendMessage('listener fired');
}, 0);
});
)";
test_dir.WriteFile(FILE_PATH_LITERAL("background.js"), kBackgroundJs);
ExtensionTestMessageListener extension_oninstall_listener_fired(
"installed listener fired");
const Extension* extension = LoadExtension(test_dir.UnpackedPath());
ASSERT_TRUE(extension);
// This ensures that we wait until the the browser receives the ack from the
// renderer. This prevents unexpected event state later when we check it.
ASSERT_TRUE(extension_oninstall_listener_fired.WaitUntilSatisfied());
// Confirm there are no unacked messages before we send the test event.
ProcessManager* process_manager = ProcessManager::Get(profile());
ExtensionHost* extension_host =
process_manager->GetBackgroundHostForExtension(extension->id());
ASSERT_EQ(extension_host->GetUnackedMessagesSizeForTesting(), 0UL);
// Set storage value which should fire chrome.storage.onChanged listener.
ExtensionTestMessageListener extension_event_listener_fired("listener fired");
static constexpr char kScript[] =
R"(chrome.storage.local.set({"key" : "value"});)";
BackgroundScriptExecutor::ExecuteScriptAsync(profile(), extension->id(),
kScript);
// Confirm that the listener in the event page background script was fired.
EXPECT_TRUE(extension_event_listener_fired.WaitUntilSatisfied());
// TODO(crbug.com/40286706): Can we add an observer so that we know that an
// unacked message was added and then removed?
EXPECT_EQ(extension_host->GetUnackedMessagesSizeForTesting(), 0UL);
}
INSTANTIATE_TEST_SUITE_P(PersistentBackground,
EventDispatchingApiTest,
::testing::Values(ContextType::kPersistentBackground));
INSTANTIATE_TEST_SUITE_P(EventPage,
EventDispatchingApiTest,
::testing::Values(ContextType::kEventPage));
// This allows tests to perform web navigations that trigger webRequest API
// events to be sent.
class NavigatingEventDispatchingApiTest : public EventDispatchingApiTest {
public:
NavigatingEventDispatchingApiTest() = default;
NavigatingEventDispatchingApiTest(const NavigatingEventDispatchingApiTest&) =
delete;
NavigatingEventDispatchingApiTest& operator=(
const NavigatingEventDispatchingApiTest&) = delete;
void SetUpOnMainThread() override {
ExtensionApiTest::SetUpOnMainThread();
host_resolver()->AddRule("*", "127.0.0.1");
ASSERT_TRUE(StartEmbeddedTestServer());
}
content::WebContents* web_contents() {
return browser()->tab_strip_model()->GetActiveWebContents();
}
};
using PersistentBackgroundPageDispatchEventToSenderEventApiTest =
NavigatingEventDispatchingApiTest;
// Tests that persistent background pages will receive an event message (routed
// through the EventRouter::DispatchEventToSender() flow) and properly track and
// remove the unacked event message in ExtensionHost. Only persistent background
// pages can use the webRequest API so event pages are not tested.
IN_PROC_BROWSER_TEST_F(
PersistentBackgroundPageDispatchEventToSenderEventApiTest,
DispatchToPage_Acks) {
// Load an extension with a chrome.webRequest.onBeforeRequest
// (EventRouter::DispatchEventToSender()) listener and wait for the
// chrome.runtime.onInstalled listener to fire.
static constexpr char kManifest[] =
R"({
"name": "Persistent background page",
"version": "0.1",
"manifest_version": 2,
"background": {
"scripts": ["background.js"],
"persistent": true
},
"permissions": ["webRequest", "http://example.com/*"]
})";
TestExtensionDir test_dir;
test_dir.WriteManifest(kManifest);
constexpr char kBackgroundJs[] =
R"({
chrome.runtime.onInstalled.addListener((details) => {
// Asynchronously send the message that the listener fired so that the
// event is considered ack'd in the browser C++ code.
setTimeout(() => {
chrome.test.sendMessage('installed listener fired');
}, 0);
});
chrome.webRequest.onBeforeRequest.addListener(
(details) => {
setTimeout(() => {
chrome.test.sendMessage('listener fired');
}, 0);
},
{urls: ['<all_urls>'], types: ['main_frame']},
[]
);
})";
test_dir.WriteFile(FILE_PATH_LITERAL("background.js"), kBackgroundJs);
ExtensionTestMessageListener extension_oninstall_listener_fired(
"installed listener fired");
const Extension* extension = LoadExtension(test_dir.UnpackedPath());
ASSERT_TRUE(extension);
// This ensures that we wait until the the browser receives the ack from the
// renderer. This prevents unexpected event state later when we check it.
ASSERT_TRUE(extension_oninstall_listener_fired.WaitUntilSatisfied());
// Confirm there are no unacked messages before we send the test event.
ProcessManager* process_manager = ProcessManager::Get(profile());
ExtensionHost* extension_host =
process_manager->GetBackgroundHostForExtension(extension->id());
ASSERT_EQ(extension_host->GetUnackedMessagesSizeForTesting(), 0UL);
ExtensionTestMessageListener extension_event_listener_fired("listener fired");
// Navigate somewhere to trigger webRequest.onBeforeRequest event to the
// extension listener.
ASSERT_TRUE(ui_test_utils::NavigateToURL(
browser(),
embedded_test_server()->GetURL("example.com", "/simple.html")));
// Confirm that the listener in the persistent background page script fired.
EXPECT_TRUE(extension_event_listener_fired.WaitUntilSatisfied());
// TODO(crbug.com/40286706): Can we add an observer so that we know that an
// unacked message was added and then removed?
EXPECT_EQ(extension_host->GetUnackedMessagesSizeForTesting(), 0UL);
}
// Tests that an event targeted to a content script listener is not recorded in
// unacked event messages in ExtensionHost (for event pages and persistent
// background pages). EventRouter::DispatchEventToSender() flow is not tested
// since content scripts cannot listen to webRequest events.
IN_PROC_BROWSER_TEST_P(NavigatingEventDispatchingApiTest,
DispatchToContentScript_DoesNotRecordMessageForAcking) {
// Load either a persistent background page or a event page script.
static constexpr char kManifestPersistentBackgroundScript[] =
R"("persistent": true)";
static constexpr char kManifestEventPageBackgroundScript[] =
R"("persistent": false)";
// Load an extension with a content script that has the only
// chrome.storage.onChanged listener.
static constexpr char kManifest[] =
R"({
"name": "Background page",
"version": "0.1",
"manifest_version": 2,
"background": {
"scripts": ["background.js"],
%s
},
"content_scripts": [{
"matches": ["https://*/*", "http://*/*"],
"js": ["content_script.js"]
}],
"permissions": ["storage"]
})";
bool persistent_background_extension =
GetParam() == ContextType::kPersistentBackground;
const char* background_script = persistent_background_extension
? kManifestPersistentBackgroundScript
: kManifestEventPageBackgroundScript;
std::string manifest = base::StringPrintf(kManifest, background_script);
TestExtensionDir test_dir;
test_dir.WriteManifest(manifest);
constexpr char kContentScriptJs[] =
R"(
chrome.storage.onChanged.addListener((details) => {
// Asynchronously send the message that the listener fired so that the
// event is considered ack'd in the browser C++ code.
setTimeout(() => {
chrome.test.sendMessage('listener fired');
}, 0);
});
chrome.test.sendMessage('content script loaded');
)";
test_dir.WriteFile(FILE_PATH_LITERAL("content_script.js"), kContentScriptJs);
constexpr char kBackgroundJs[] =
R"(
chrome.runtime.onInstalled.addListener((details) => {
// Asynchronously send the message that the listener fired so that the
// event is considered ack'd in the browser C++ code.
setTimeout(() => {
chrome.test.sendMessage('installed listener fired');
}, 0);
});
)";
test_dir.WriteFile(FILE_PATH_LITERAL("background.js"), kBackgroundJs);
ExtensionTestMessageListener extension_oninstall_listener_fired(
"installed listener fired");
const Extension* extension = LoadExtension(test_dir.UnpackedPath());
ASSERT_TRUE(extension);
// This ensures that we wait until the the browser receives the ack from the
// renderer. This prevents inconsistent unacked event messages state later
// when we check it.
ASSERT_TRUE(extension_oninstall_listener_fired.WaitUntilSatisfied());
// Confirm there are no unacked messages before we send the test event.
ProcessManager* process_manager = ProcessManager::Get(profile());
ExtensionHost* extension_host =
process_manager->GetBackgroundHostForExtension(extension->id());
ASSERT_EQ(extension_host->GetUnackedMessagesSizeForTesting(), 0UL);
ExtensionTestMessageListener content_script_loaded("content script loaded");
// Navigate to example.com to get the content_script to load.
ASSERT_TRUE(ui_test_utils::NavigateToURL(
browser(),
embedded_test_server()->GetURL("example.com", "/simple.html")));
ASSERT_TRUE(content::WaitForLoadStop(web_contents()));
ASSERT_TRUE(content_script_loaded.WaitUntilSatisfied());
// Set storage value which should fire chrome.storage.onChanged listeners.
ExtensionTestMessageListener content_script_event_listener_fired(
"listener fired");
static constexpr char kScript[] =
R"(chrome.storage.local.set({"key" : "value"});)";
BackgroundScriptExecutor::ExecuteScriptAsync(profile(), extension->id(),
kScript);
// Confirm that the listener in the content script was fired and no unacked
// messages remain.
EXPECT_TRUE(content_script_event_listener_fired.WaitUntilSatisfied());
// TODO(crbug.com/40286706): Can we add an observer so that we know that an
// unacked message was not added to the map at all?
EXPECT_EQ(extension_host->GetUnackedMessagesSizeForTesting(), 0UL);
}
INSTANTIATE_TEST_SUITE_P(PersistentBackground,
NavigatingEventDispatchingApiTest,
::testing::Values(ContextType::kPersistentBackground));
INSTANTIATE_TEST_SUITE_P(EventPage,
NavigatingEventDispatchingApiTest,
::testing::Values(ContextType::kEventPage));
using ServiceWorkerEventAckBrowserTest = EventDispatchingApiTest;
// TODO(crbug.com/383086263): Flaky on Mac and Windows.
#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_WIN)
#define MAYBE_RendererProcessGoesAway_ClearsUnackedEventData \
DISABLED_RendererProcessGoesAway_ClearsUnackedEventData
#else
#define MAYBE_RendererProcessGoesAway_ClearsUnackedEventData \
RendererProcessGoesAway_ClearsUnackedEventData
#endif
// Tests that when a renderer process is no longer available that we clear any
// unacked events from EventAckData for that render process. Otherwise we would
// leak these unacked events and never remove them.
IN_PROC_BROWSER_TEST_F(ServiceWorkerEventAckBrowserTest,
MAYBE_RendererProcessGoesAway_ClearsUnackedEventData) {
// TODO(crbug.com/331358155): This currently tests
// EventRouter::RenderProcessExited(), but it does not test the case of
// EventRouter::RenderProcessHostDestroyed(). It can be simulated with a
// worker that is delayed in terminating.
// Load an extension and wait until the service worker is running.
ASSERT_TRUE(embedded_test_server()->Start());
ExtensionTestMessageListener extension_oninstall_listener_fired(
"installed listener fired");
const Extension* extension = LoadExtension(
test_data_dir_.AppendASCII("events/listener_spins_forever"));
ASSERT_TRUE(extension);
ASSERT_TRUE(extension_oninstall_listener_fired.WaitUntilSatisfied());
ASSERT_TRUE(content::CheckServiceWorkerIsRunning(
// The first SW version ID is always 0.
GetServiceWorkerContext(), /*service_worker_version_id=*/0));
// Dispatch an event that the renderer will never ack (that the event was
// executed), therefore simulating that the render process has gone away
// before it could ack. This should keep the unacked event info in
// `EventAckData`.
ASSERT_TRUE(ui_test_utils::NavigateToURL(
browser(),
embedded_test_server()->GetURL("example.com", "/simple.html")));
// Confirm the `EventInfo` for the above event is still unacked.
EventRouter* event_router = EventRouter::Get(profile());
// 1 is inferred since the extension has two listeners and the above
// navigation should be the second event encountered.
EXPECT_TRUE(event_router->event_ack_data()->HasUnackedEventForTesting(
/*event_id=*/1));
// Terminate worker's RenderProcessHost which triggers the cleanup logic.
std::vector<WorkerId> service_workers =
ProcessManager::Get(profile())->GetServiceWorkersForExtension(
extension->id());
ASSERT_EQ(1u, service_workers.size());
content::RenderProcessHost* extension_process =
content::RenderProcessHost::FromID(service_workers[0].render_process_id);
ASSERT_TRUE(extension_process);
content::RenderProcessHostWatcher process_exit_observer(
extension_process,
content::RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);
extension_process->Shutdown(content::RESULT_CODE_KILLED);
process_exit_observer.Wait();
// Confirm we no longer have the `EventInfo` for the unacked event.
EXPECT_FALSE(event_router->event_ack_data()->HasUnackedEventForTesting(
/*event_id=*/1));
}
} // namespace
} // namespace extensions
|