1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/extension_garbage_collector.h"
#include <stddef.h>
#include "base/files/file_enumerator.h"
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/values.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/browser/extensions/install_tracker.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/test/base/testing_profile.h"
#include "components/prefs/scoped_user_pref_update.h"
#include "content/public/test/browser_task_environment.h"
#include "content/public/test/test_utils.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/pref_names.h"
#include "extensions/common/extension_features.h"
#include "extensions/common/extension_id.h"
#include "ppapi/buildflags/buildflags.h"
#if BUILDFLAG(ENABLE_PLUGINS)
#include "content/public/browser/plugin_service.h"
#endif
static_assert(BUILDFLAG(ENABLE_EXTENSIONS_CORE));
namespace extensions {
class ExtensionGarbageCollectorUnitTest : public ExtensionServiceTestBase {
protected:
void InitPluginService() {
#if BUILDFLAG(ENABLE_PLUGINS)
content::PluginService::GetInstance()->Init();
#endif
}
// A delayed task to call GarbageCollectExtensions is posted by
// ExtensionGarbageCollector's constructor. But, as the test won't wait for
// the delayed task to be called, we have to call it manually instead.
void GarbageCollectExtensions() {
ExtensionGarbageCollector::Get(profile_.get())
->GarbageCollectExtensionsForTest();
// Wait for GarbageCollectExtensions task to complete.
content::RunAllTasksUntilIdle();
}
};
// TODO(crbug.com/40875193): The test extension good_juKvIh seems to error on
// install with "Manifest file is missing or unreadable" despite the manifest
// being valid. This test case is still valid because we're only checking if the
// files get deleted. The files get copied to the install directory by the test
// infra despite the installation failure. So we should probably fix this in the
// future so that this test extension can be used in other tests.
// Test that partially deleted unpacked extensions (e.g. from .zips) are cleaned
// up during startup.
TEST_F(ExtensionGarbageCollectorUnitTest,
CleanupUnpackedOnStartup_DeleteWhenNoLongerInstalled) {
const ExtensionId kExtensionId = "lckcjklfapeiadkadngidmocpbkemckm";
InitPluginService();
InitializeGoodInstalledExtensionService();
base::FilePath zipped_extension_dir =
unpacked_install_dir().AppendASCII("good_juKvIh");
ASSERT_TRUE(base::PathExists(zipped_extension_dir));
// Simulate that the extensions was partially deleted (no longer considered
// installed) by clearing its pref.
{
ScopedDictPrefUpdate update(profile_->GetPrefs(), pref_names::kExtensions);
update->Remove(kExtensionId);
}
service_->Init();
GarbageCollectExtensions();
base::FileEnumerator dirs(unpacked_install_dir(),
false, // not recursive
base::FileEnumerator::DIRECTORIES);
// We should have have zero extensions now.
EXPECT_TRUE(dirs.Next().empty());
// And unpacked extension dir should now be toast.
EXPECT_FALSE(base::PathExists(zipped_extension_dir));
}
TEST_F(ExtensionGarbageCollectorUnitTest,
CleanupUnpackedOnStartup_DoNotDeleteWhenStillInstalled) {
const ExtensionId kExtensionId = "lckcjklfapeiadkadngidmocpbkemckm";
InitPluginService();
InitializeGoodInstalledExtensionService();
base::FilePath zipped_extension_dir =
unpacked_install_dir().AppendASCII("good_juKvIh");
ASSERT_TRUE(base::PathExists(zipped_extension_dir));
// Update the path of the installed extension to be accurate for the test.
{
ScopedDictPrefUpdate update(profile_->GetPrefs(), pref_names::kExtensions);
base::Value::Dict& update_dict = update.Get();
// An unpacked extension installed in the profile dir in production usually
// has it's full install path written to the "path" key, but since we don't
// know what the path is during the test (due to variation of test directory
// location) we need to manually set it during the test. The garbage
// collection checks this path to determine whether to delete the
// installation directory.
base::Value::Dict* extension_entry = update_dict.FindDict(kExtensionId);
ASSERT_TRUE(extension_entry);
extension_entry->Set("path",
base::Value(zipped_extension_dir.MaybeAsASCII()));
}
service_->Init();
GarbageCollectExtensions();
// Unpacked extension dir should not be deleted.
EXPECT_TRUE(base::PathExists(zipped_extension_dir));
}
// Test that garbage collection doesn't delete anything while a crx is being
// installed.
TEST_F(ExtensionGarbageCollectorUnitTest, NoCleanupDuringInstall) {
const ExtensionId kExtensionId = "behllobkkfkfnphdnhnkndlbkcpglgmj";
InitPluginService();
InitializeGoodInstalledExtensionService();
// Simulate that one of them got partially deleted by clearing its pref.
{
ScopedDictPrefUpdate update(profile_->GetPrefs(), pref_names::kExtensions);
update->Remove(kExtensionId);
}
service_->Init();
// Simulate a CRX installation.
InstallTracker::Get(profile_.get())->OnBeginCrxInstall(kExtensionId);
GarbageCollectExtensions();
// extension1 dir should still exist.
base::FilePath extension_dir =
extensions_install_dir().AppendASCII(kExtensionId);
ASSERT_TRUE(base::PathExists(extension_dir));
// Finish CRX installation and re-run garbage collection.
InstallTracker::Get(profile_.get())
->OnFinishCrxInstall(base::FilePath(), kExtensionId, nullptr, false);
GarbageCollectExtensions();
// extension1 dir should be gone
ASSERT_FALSE(base::PathExists(extension_dir));
}
// Test that GarbageCollectExtensions deletes the right versions of an
// extension.
TEST_F(ExtensionGarbageCollectorUnitTest, GarbageCollectWithPendingUpdates) {
InitPluginService();
ExtensionServiceInitParams params;
ASSERT_TRUE(params.ConfigureByTestDataDirectory(
data_dir().AppendASCII("pending_updates")));
InitializeExtensionService(std::move(params));
// This is the directory that is going to be deleted, so make sure it actually
// is there before the garbage collection.
ASSERT_TRUE(base::PathExists(extensions_install_dir().AppendASCII(
"hpiknbiabeeppbpihjehijgoemciehgk/3")));
GarbageCollectExtensions();
// Verify that the pending update for the first extension didn't get
// deleted.
EXPECT_TRUE(base::PathExists(extensions_install_dir().AppendASCII(
"bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0")));
EXPECT_TRUE(base::PathExists(extensions_install_dir().AppendASCII(
"bjafgdebaacbbbecmhlhpofkepfkgcpa/2.0")));
EXPECT_TRUE(base::PathExists(extensions_install_dir().AppendASCII(
"hpiknbiabeeppbpihjehijgoemciehgk/2")));
EXPECT_FALSE(base::PathExists(extensions_install_dir().AppendASCII(
"hpiknbiabeeppbpihjehijgoemciehgk/3")));
}
// Test that pending updates are properly handled on startup.
TEST_F(ExtensionGarbageCollectorUnitTest, UpdateOnStartup) {
InitPluginService();
ExtensionServiceInitParams params;
ASSERT_TRUE(params.ConfigureByTestDataDirectory(
data_dir().AppendASCII("pending_updates")));
InitializeExtensionService(std::move(params));
// This is the directory that is going to be deleted, so make sure it actually
// is there before the garbage collection.
ASSERT_TRUE(base::PathExists(extensions_install_dir().AppendASCII(
"hpiknbiabeeppbpihjehijgoemciehgk/3")));
service_->Init();
GarbageCollectExtensions();
// Verify that the pending update for the first extension got installed.
EXPECT_FALSE(base::PathExists(extensions_install_dir().AppendASCII(
"bjafgdebaacbbbecmhlhpofkepfkgcpa/1.0")));
EXPECT_TRUE(base::PathExists(extensions_install_dir().AppendASCII(
"bjafgdebaacbbbecmhlhpofkepfkgcpa/2.0")));
EXPECT_TRUE(base::PathExists(extensions_install_dir().AppendASCII(
"hpiknbiabeeppbpihjehijgoemciehgk/2")));
EXPECT_FALSE(base::PathExists(extensions_install_dir().AppendASCII(
"hpiknbiabeeppbpihjehijgoemciehgk/3")));
// Make sure update information got deleted.
ExtensionPrefs* prefs = ExtensionPrefs::Get(profile_.get());
EXPECT_FALSE(
prefs->GetDelayedInstallInfo("bjafgdebaacbbbecmhlhpofkepfkgcpa"));
}
} // namespace extensions
|
