1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/extensions/navigation_extension_enabler.h"
#include "base/feature_list.h"
#include "base/functional/bind.h"
#include "base/functional/callback_helpers.h"
#include "base/memory/raw_ptr.h"
#include "base/run_loop.h"
#include "chrome/browser/extensions/chrome_test_extension_loader.h"
#include "chrome/browser/extensions/extension_browsertest.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/public/browser/site_isolation_policy.h"
#include "content/public/common/content_features.h"
#include "content/public/common/isolated_world_ids.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/no_renderer_crashes_assertion.h"
#include "content/public/test/test_navigation_observer.h"
#include "extensions/browser/disable_reason.h"
#include "extensions/browser/extension_dialog_auto_confirm.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/common/constants.h"
#include "extensions/common/extension.h"
namespace extensions {
// A class for testing various scenarios of disabled extensions.
class DisableExtensionBrowserTest : public ExtensionBrowserTest {
protected:
void SetUpOnMainThread() override {
ExtensionBrowserTest::SetUpOnMainThread();
extension_ = LoadExtension(test_data_dir_.AppendASCII("simple_with_file"));
extension_id_ = extension_->id();
extension_resource_url_ = extension_->GetResourceURL("file.html");
ASSERT_TRUE(extension_);
registry_ = ExtensionRegistry::Get(profile());
EXPECT_TRUE(registry_->enabled_extensions().Contains(extension_id_));
prefs_ = ExtensionPrefs::Get(profile());
}
void TearDownOnMainThread() override {
prefs_ = nullptr;
registry_ = nullptr;
ExtensionBrowserTest::TearDownOnMainThread();
}
// We always navigate in a new tab because when we disable the extension, it
// closes all tabs for that extension. If we only opened in the current tab,
// this would result in the only open tab being closed, and the test
// quitting.
void NavigateToUrlInNewTab(const GURL& url) {
ui_test_utils::NavigateToURLWithDisposition(
browser(), url, WindowOpenDisposition::NEW_FOREGROUND_TAB,
ui_test_utils::BROWSER_TEST_WAIT_FOR_LOAD_STOP);
}
scoped_refptr<const Extension> extension_;
ExtensionId extension_id_;
GURL extension_resource_url_;
raw_ptr<ExtensionRegistry> registry_;
raw_ptr<ExtensionPrefs> prefs_;
};
// Test that visiting an url associated with a disabled extension offers to
// re-enable it.
IN_PROC_BROWSER_TEST_F(
DisableExtensionBrowserTest,
PromptToReEnableExtensionsOnNavigation_PermissionsIncrease) {
// Disable the extension due to a permissions increase.
extension_registrar()->DisableExtension(
extension_id_, {disable_reason::DISABLE_PERMISSIONS_INCREASE});
EXPECT_TRUE(registry_->disabled_extensions().Contains(extension_id_));
EXPECT_THAT(prefs_->GetDisableReasons(extension_id_),
testing::UnorderedElementsAre(
disable_reason::DISABLE_PERMISSIONS_INCREASE));
{
// Visit an associated url and deny the prompt. The extension should remain
// disabled.
ScopedTestDialogAutoConfirm auto_deny(ScopedTestDialogAutoConfirm::CANCEL);
NavigateToUrlInNewTab(extension_resource_url_);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(registry_->disabled_extensions().Contains(extension_id_));
EXPECT_THAT(prefs_->GetDisableReasons(extension_id_),
testing::UnorderedElementsAre(
disable_reason::DISABLE_PERMISSIONS_INCREASE));
}
{
// Visit an associated url and accept the prompt. The extension should get
// re-enabled.
ScopedTestDialogAutoConfirm auto_accept(
ScopedTestDialogAutoConfirm::ACCEPT);
NavigateToUrlInNewTab(extension_resource_url_);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(registry_->enabled_extensions().Contains(extension_id_));
EXPECT_TRUE(prefs_->GetDisableReasons(extension_id_).empty());
}
}
// Test that visiting an url associated with a disabled extension offers to
// re-enable it.
IN_PROC_BROWSER_TEST_F(DisableExtensionBrowserTest,
PromptToReEnableExtensionsOnNavigation_UserAction) {
// Disable the extension for something other than a permissions increase.
extension_registrar()->DisableExtension(
extension_id_, {disable_reason::DISABLE_USER_ACTION});
EXPECT_TRUE(registry_->disabled_extensions().Contains(extension_id_));
EXPECT_THAT(
prefs_->GetDisableReasons(extension_id_),
testing::UnorderedElementsAre(disable_reason::DISABLE_USER_ACTION));
{
// We only prompt for permissions increases, not any other disable reason.
// As such, the extension should stay disabled.
ScopedTestDialogAutoConfirm auto_accept(
ScopedTestDialogAutoConfirm::ACCEPT);
NavigateToUrlInNewTab(extension_resource_url_);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(registry_->disabled_extensions().Contains(extension_id_));
EXPECT_THAT(
prefs_->GetDisableReasons(extension_id_),
testing::UnorderedElementsAre(disable_reason::DISABLE_USER_ACTION));
}
}
// Test that visiting an url associated with a disabled hosted app offers to
// re-enable it.
IN_PROC_BROWSER_TEST_F(DisableExtensionBrowserTest,
PromptToReEnableHostedAppOnNavigation) {
// Load a hosted app and disable it for a permissions increase.
scoped_refptr<const Extension> hosted_app =
LoadExtension(test_data_dir_.AppendASCII("hosted_app"));
ASSERT_TRUE(hosted_app);
const std::string kHostedAppId = hosted_app->id();
const GURL kHostedAppUrl("http://localhost/extensions/hosted_app/main.html");
EXPECT_EQ(hosted_app, registry_->enabled_extensions().GetExtensionOrAppByURL(
kHostedAppUrl));
extension_registrar()->DisableExtension(
kHostedAppId, {disable_reason::DISABLE_PERMISSIONS_INCREASE});
EXPECT_TRUE(registry_->disabled_extensions().Contains(kHostedAppId));
EXPECT_THAT(prefs_->GetDisableReasons(kHostedAppId),
testing::UnorderedElementsAre(
disable_reason::DISABLE_PERMISSIONS_INCREASE));
{
// When visiting a site that's associated with a hosted app, but not a
// chrome-extension url, we don't prompt to re-enable. This is to avoid
// prompting when visiting a regular website like calendar.google.com.
// See crbug.com/678631.
ScopedTestDialogAutoConfirm auto_accept(
ScopedTestDialogAutoConfirm::ACCEPT);
NavigateToUrlInNewTab(kHostedAppUrl);
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(registry_->disabled_extensions().Contains(kHostedAppId));
EXPECT_THAT(prefs_->GetDisableReasons(kHostedAppId),
testing::UnorderedElementsAre(
disable_reason::DISABLE_PERMISSIONS_INCREASE));
}
}
// Verify that navigating a subframe to an enabled -> disabled -> enabled
// extension URL doesn't result in a renderer process termination. See
// https://crbug.com/1197360.
IN_PROC_BROWSER_TEST_F(DisableExtensionBrowserTest,
VisitReenabledExtensionInSubframe) {
ASSERT_TRUE(embedded_test_server()->Start());
// Navigate to a page with a subframe.
GURL main_url = embedded_test_server()->GetURL("/iframe.html");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), main_url));
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
EXPECT_EQ(web_contents->GetPrimaryMainFrame()->GetLastCommittedURL(),
main_url);
// Emulate a user gesture so that the current entry won't be skipped due to
// the history manipulation intervention when we try to navigate back to it.
web_contents->GetPrimaryMainFrame()->ExecuteJavaScriptWithUserGestureForTests(
std::u16string(), base::NullCallback(),
content::ISOLATED_WORLD_ID_GLOBAL);
// Navigate subframe to an enabled extension URL.
scoped_refptr<const Extension> extension =
ChromeTestExtensionLoader(profile()).LoadExtension(
test_data_dir_.AppendASCII("web_accessible_resources/subframe"));
ASSERT_TRUE(extension);
GURL extension_url = extension->GetResourceURL("web_accessible_page.html");
EXPECT_TRUE(NavigateIframeToURL(web_contents, "test", extension_url));
content::RenderFrameHost* subframe =
ChildFrameAt(web_contents->GetPrimaryMainFrame(), 0);
EXPECT_EQ(subframe->GetLastCommittedURL(), extension_url);
EXPECT_EQ(web_contents->GetController().GetEntryCount(), 3);
scoped_refptr<content::SiteInstance> extension_site_instance =
subframe->GetSiteInstance();
// The extension process should be locked.
EXPECT_TRUE(subframe->GetProcess()->IsProcessLockedToSiteForTesting());
// Disable the extension.
extension_registrar()->DisableExtension(
extension->id(), {disable_reason::DISABLE_USER_ACTION});
EXPECT_TRUE(registry_->disabled_extensions().Contains(extension->id()));
// Go back and then forward. This should go back to the original URL in the
// iframe, then go forward to the now-disabled extension URL. Using a
// history navigation makes the latter navigation a browser-initiated one,
// which is important for reproducing https://crbug.com/1197360.
content::RenderFrameDeletedObserver observer(subframe);
web_contents->GetController().GoBack();
EXPECT_TRUE(content::WaitForLoadStop(web_contents));
// Ensure that the subframe's SiteInstance is deleted to prevent its reuse in
// the forward navigation.
observer.WaitUntilDeleted();
EXPECT_EQ(web_contents->GetController().GetLastCommittedEntryIndex(), 1);
web_contents->GetController().GoForward();
EXPECT_TRUE(content::WaitForLoadStop(web_contents));
EXPECT_EQ(web_contents->GetController().GetLastCommittedEntryIndex(), 2);
subframe = ChildFrameAt(web_contents->GetPrimaryMainFrame(), 0);
EXPECT_EQ(subframe->GetLastCommittedURL(), extension_url);
// The SiteInstance of the disabled extension frame should be different from
// the SiteInstance of the enabled extension subframe. It should reference the
// invalid extension ID or the error page URL.
// TODO(crbug.com/40192071): remove the exceptions for Mac and Windows below
// once renderer-process shutdown delay causing `extension_site_instance` to
// be reused is addressed (see
// RendererProcessHostImpl::ShouldDelayProcessShutdown() for details).
#if !BUILDFLAG(IS_MAC) && !BUILDFLAG(IS_WIN)
EXPECT_NE(subframe->GetSiteInstance(), extension_site_instance);
if (content::SiteIsolationPolicy::IsErrorPageIsolationEnabled(false)) {
EXPECT_EQ(subframe->GetSiteInstance()->GetSiteURL(),
GURL(content::kUnreachableWebDataURL));
} else {
EXPECT_EQ(subframe->GetSiteInstance()->GetSiteURL(),
GURL(kExtensionInvalidRequestURL));
// The disabled extension process should be locked.
EXPECT_TRUE(subframe->GetProcess()->IsProcessLockedToSiteForTesting());
}
#endif // !BUILDFLAG(IS_MAC) && !BUILDFLAG(IS_WIN)
// Re-enable the extension.
extension_registrar()->EnableExtension(extension->id());
EXPECT_TRUE(registry_->enabled_extensions().Contains(extension->id()));
// Navigate the subframe to the extension URL again. This shouldn't
// terminate the renderer and should go back to the original extension
// SiteInstance.
EXPECT_TRUE(NavigateIframeToURL(web_contents, "test", extension_url));
subframe = ChildFrameAt(web_contents->GetPrimaryMainFrame(), 0);
EXPECT_TRUE(subframe->IsRenderFrameLive());
EXPECT_EQ(subframe->GetSiteInstance(), extension_site_instance);
EXPECT_TRUE(subframe->GetProcess()->IsProcessLockedToSiteForTesting());
}
IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, NoExtensionsInRefererHeader) {
ASSERT_TRUE(embedded_test_server()->Start());
scoped_refptr<const Extension> extension =
ChromeTestExtensionLoader(profile()).LoadExtension(
test_data_dir_.AppendASCII("simple_with_file"));
ASSERT_TRUE(extension);
GURL page_url = extension->GetResourceURL("file.html");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), page_url));
// Click a link in the extension.
GURL target_url = embedded_test_server()->GetURL("/echoheader?referer");
const char kScriptTemplate[] = R"(
let a = document.createElement('a');
a.href = $1;
document.body.appendChild(a);
a.click();
)";
content::WebContents* web_contents =
browser()->tab_strip_model()->GetActiveWebContents();
content::TestNavigationObserver nav_observer(web_contents, 1);
ExecuteScriptAsync(web_contents,
content::JsReplace(kScriptTemplate, target_url));
// Wait for navigation to complete and verify it was successful.
nav_observer.WaitForNavigationFinished();
EXPECT_TRUE(nav_observer.last_navigation_succeeded());
EXPECT_EQ(target_url, nav_observer.last_navigation_url());
EXPECT_EQ(target_url, web_contents->GetLastCommittedURL());
// Verify that the Referrer header was not present (in particular, it should
// not reveal the identity of the extension).
EXPECT_TRUE(content::WaitForLoadStop(web_contents));
EXPECT_EQ("None", content::EvalJs(web_contents, "document.body.innerText"));
// Verify that the initiator_origin was present and set to the extension.
ASSERT_TRUE(nav_observer.last_initiator_origin().has_value());
EXPECT_EQ(url::Origin::Create(page_url),
nav_observer.last_initiator_origin());
}
} // namespace extensions
|