1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720
|
// Copyright 2015 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include <vector>
#include "base/functional/bind.h"
#include "base/location.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "base/task/single_thread_task_runner.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/run_until.h"
#include "build/build_config.h"
#include "chrome/browser/password_manager/chrome_password_manager_client.h"
#include "chrome/browser/password_manager/password_manager_interactive_test_base.h"
#include "chrome/browser/password_manager/passwords_navigation_observer.h"
#include "chrome/browser/password_manager/profile_password_store_factory.h"
#include "chrome/browser/ui/autofill/autofill_suggestion_controller.h"
#include "chrome/browser/ui/autofill/chrome_autofill_client.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/passwords/manage_passwords_ui_controller.h"
#include "components/autofill/core/common/autofill_features.h"
#include "components/autofill/core/common/form_data.h"
#include "components/password_manager/content/browser/content_password_manager_driver.h"
#include "components/password_manager/core/browser/password_form_manager.h"
#include "components/password_manager/core/browser/password_manager.h"
#include "components/password_manager/core/browser/password_store/test_password_store.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/signin/public/base/signin_buildflags.h"
#include "content/public/test/browser_test.h"
#include "content/public/test/browser_test_utils.h"
#include "third_party/blink/public/common/switches.h"
#if BUILDFLAG(ENABLE_DICE_SUPPORT)
#include "chrome/browser/password_manager/password_manager_signin_intercept_test_helper.h"
#include "chrome/browser/signin/dice_web_signin_interceptor.h"
#endif // BUILDFLAG(ENABLE_DICE_SUPPORT)
namespace {
constexpr autofill::FieldRendererId kElementId(1000);
} // namespace
namespace password_manager {
class PasswordManagerInteractiveTest
: public PasswordManagerInteractiveTestBase {
public:
PasswordManagerInteractiveTest() {
// Turn off waiting for server predictions before filing. It makes filling
// behaviour more deterministic. Filling with server predictions is tested
// in PasswordFormManager unit tests.
password_manager::PasswordFormManager::
set_wait_for_server_predictions_for_filling(false);
}
~PasswordManagerInteractiveTest() override = default;
void SetUpCommandLine(base::CommandLine* command_line) override {
PasswordManagerInteractiveTestBase::SetUpCommandLine(command_line);
// Some builders are flaky due to slower loading interacting with
// deferred commits.
command_line->AppendSwitch(blink::switches::kAllowPreCommitInput);
}
};
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest, UsernameChanged) {
// At first let us save a credential to the password store.
scoped_refptr<password_manager::TestPasswordStore> password_store =
static_cast<password_manager::TestPasswordStore*>(
ProfilePasswordStoreFactory::GetForProfile(
browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS)
.get());
password_manager::PasswordForm signin_form;
signin_form.signon_realm = embedded_test_server()->base_url().spec();
signin_form.url = embedded_test_server()->base_url();
signin_form.username_value = u"temp";
signin_form.password_value = u"random";
password_store->AddLogin(signin_form);
// Load the page to have the saved credentials autofilled.
NavigateToFile("/password/signup_form.html");
// Let the user interact with the page, so that DOM gets modification events,
// needed for autofilling fields.
content::SimulateMouseClickAt(
WebContents(), 0, blink::WebMouseEvent::Button::kLeft, gfx::Point(1, 1));
WaitForElementValue("username_field", "temp");
WaitForElementValue("password_field", "random");
// Change username and submit. This should add the characters "orary" to the
// already autofilled username.
FillElementWithValue("username_field", "orary", "temporary");
PasswordsNavigationObserver navigation_observer(WebContents());
BubbleObserver prompt_observer(WebContents());
std::string submit =
"document.getElementById('input_submit_button').click();";
ASSERT_TRUE(content::ExecJs(WebContents(), submit));
ASSERT_TRUE(navigation_observer.Wait());
prompt_observer.WaitForAutomaticSavePrompt();
prompt_observer.AcceptSavePrompt();
// Spin the message loop to make sure the password store had a chance to save
// the password.
WaitForPasswordStore();
EXPECT_FALSE(password_store->IsEmpty());
// Verify that there are two saved password, the old password and the new
// password.
password_manager::TestPasswordStore::PasswordMap stored_passwords =
password_store->stored_passwords();
EXPECT_EQ(1u, stored_passwords.size());
EXPECT_EQ(2u, stored_passwords.begin()->second.size());
EXPECT_EQ(u"temp", (stored_passwords.begin()->second)[0].username_value);
EXPECT_EQ(u"temporary", (stored_passwords.begin()->second)[1].username_value);
}
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
ManualFallbackForSaving) {
NavigateToFile("/password/password_form.html");
FillElementWithValue("password_field", "123");
BubbleObserver prompt_observer(WebContents());
prompt_observer.WaitForFallbackForSaving();
// The save prompt should be available but shouldn't pop up automatically.
EXPECT_TRUE(prompt_observer.IsSavePromptAvailable());
EXPECT_FALSE(prompt_observer.IsSavePromptShownAutomatically());
// Simulate several navigations.
NavigateToFile("/password/signup_form.html");
NavigateToFile("/password/failed.html");
NavigateToFile("/password/done.html");
// The save prompt should be still available.
EXPECT_TRUE(prompt_observer.IsSavePromptAvailable());
EXPECT_FALSE(prompt_observer.IsSavePromptShownAutomatically());
prompt_observer.AcceptSavePrompt();
WaitForPasswordStore();
CheckThatCredentialsStored("", "123");
}
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
ManualFallbackForSaving_HideAfterTimeout) {
NavigateToFile("/password/password_form.html");
ManagePasswordsUIController::set_save_fallback_timeout_in_seconds(0);
FillElementWithValue("password_field", "123");
BubbleObserver prompt_observer(WebContents());
// Since the timeout is changed to zero for testing, the save prompt should be
// hidden right after show. Potentially the manual fallback state is not
// caught by the test.
prompt_observer.WaitForInactiveState();
EXPECT_FALSE(prompt_observer.IsSavePromptAvailable());
}
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
ManualFallbackForSaving_HideIcon) {
NavigateToFile("/password/password_form.html");
FillElementWithValue("password_field", "123");
BubbleObserver prompt_observer(WebContents());
prompt_observer.WaitForFallbackForSaving();
// Delete typed content and verify that inactive state is reached.
SimulateUserDeletingFieldContent("password_field");
prompt_observer.WaitForInactiveState();
}
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
ManualFallbackForSaving_GoToManagedState) {
// At first let us save a credential to the password store.
scoped_refptr<password_manager::TestPasswordStore> password_store =
static_cast<password_manager::TestPasswordStore*>(
ProfilePasswordStoreFactory::GetForProfile(
browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS)
.get());
password_manager::PasswordForm signin_form;
signin_form.signon_realm = embedded_test_server()->base_url().spec();
signin_form.url = embedded_test_server()->base_url();
signin_form.username_value = u"temp";
signin_form.password_value = u"random";
password_store->AddLogin(signin_form);
NavigateToFile("/password/password_form.html");
SimulateUserDeletingFieldContent("username_field");
FillElementWithValue("username_field", "123");
BubbleObserver prompt_observer(WebContents());
prompt_observer.WaitForFallbackForSaving();
// Delete typed content and verify that management state is reached.
SimulateUserDeletingFieldContent("password_field");
prompt_observer.WaitForManagementState();
}
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
PromptForXHRWithoutOnSubmit) {
NavigateToFile("/password/password_xhr_submit.html");
// Verify that if XHR navigation occurs and the form is properly filled out,
// we try and save the password even though onsubmit hasn't been called.
FillElementWithValue("username_field", "user");
FillElementWithValue("password_field", "1234");
PasswordsNavigationObserver observer(WebContents());
ASSERT_TRUE(content::ExecJs(WebContents(), "send_xhr()"));
ASSERT_TRUE(observer.Wait());
BubbleObserver(WebContents()).WaitForAutomaticSavePrompt();
}
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
PromptForXHRWithNewPasswordsWithoutOnSubmit) {
NavigateToFile("/password/password_xhr_submit.html");
// Verify that if XHR navigation occurs and the form is properly filled out,
// we try and save the password even though onsubmit hasn't been called.
// Specifically verify that the password form saving new passwords is treated
// the same as a login form.
FillElementWithValue("signup_username_field", "user");
FillElementWithValue("signup_password_field", "1234");
FillElementWithValue("confirmation_password_field", "1234");
PasswordsNavigationObserver observer(WebContents());
ASSERT_TRUE(content::ExecJs(WebContents(), "send_xhr()"));
ASSERT_TRUE(observer.Wait());
BubbleObserver(WebContents()).WaitForAutomaticSavePrompt();
}
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
PromptForFetchWithoutOnSubmit) {
NavigateToFile("/password/password_fetch_submit.html");
// Verify that if Fetch navigation occurs and the form is properly filled out,
// we try and save the password even though onsubmit hasn't been called.
FillElementWithValue("username_field", "user");
FillElementWithValue("password_field", "1234");
PasswordsNavigationObserver observer(WebContents());
ASSERT_TRUE(content::ExecJs(WebContents(), "send_fetch()"));
ASSERT_TRUE(observer.Wait());
BubbleObserver(WebContents()).WaitForAutomaticSavePrompt();
}
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
PromptForFetchWithNewPasswordsWithoutOnSubmit) {
NavigateToFile("/password/password_fetch_submit.html");
// Verify that if Fetch navigation occurs and the form is properly filled out,
// we try and save the password even though onsubmit hasn't been called.
// Specifically verify that the password form saving new passwords is treated
// the same as a login form.
FillElementWithValue("signup_username_field", "user");
FillElementWithValue("signup_password_field", "1234");
FillElementWithValue("confirmation_password_field", "1234");
PasswordsNavigationObserver observer(WebContents());
ASSERT_TRUE(content::ExecJs(WebContents(), "send_fetch()"));
ASSERT_TRUE(observer.Wait());
BubbleObserver(WebContents()).WaitForAutomaticSavePrompt();
}
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
AutofillPasswordFormWithoutUsernameField) {
std::string submit = "document.getElementById('submit-button').click();";
VerifyPasswordIsSavedAndFilled("/password/form_with_only_password_field.html",
std::string(), "password", submit);
}
// Tests that if a site embeds the login and signup forms into one <form>, the
// login form still gets autofilled.
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
AutofillLoginSignupForm) {
std::string submit = "document.getElementById('submit').click();";
VerifyPasswordIsSavedAndFilled("/password/login_signup_form.html", "username",
"password", submit);
}
// Tests that password suggestions still work if the fields have the
// "autocomplete" attribute set to off.
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
AutofillPasswordFormWithAutocompleteOff) {
std::string submit = "document.getElementById('submit').click();";
VerifyPasswordIsSavedAndFilled(
"/password/password_autocomplete_off_test.html", "username", "password",
submit);
}
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
AutofillPasswordNoFormElement) {
VerifyPasswordIsSavedAndFilled("/password/no_form_element.html",
"username_field", "password_field",
"send_xhr();");
}
// Check that we can fill in cases where <base href> is set and the action of
// the form is not set. Regression test for https://crbug.com/360230.
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
AutofillBaseTagWithNoActionTest) {
std::string submit = "document.getElementById('submit_button').click();";
VerifyPasswordIsSavedAndFilled("/password/password_xhr_submit.html",
"username_field", "password_field", submit);
}
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
DeleteCredentialsUpdateDropdown) {
password_manager::PasswordStoreInterface* password_store =
ProfilePasswordStoreFactory::GetForProfile(
browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS)
.get();
// Start with two logins in the password store.
password_manager::PasswordForm admin_form;
admin_form.signon_realm = embedded_test_server()->base_url().spec();
admin_form.url = embedded_test_server()->base_url();
admin_form.username_value = u"admin";
admin_form.password_value = u"random_secret";
admin_form.date_last_used = base::Time::FromTimeT(1);
password_store->AddLogin(admin_form);
password_manager::PasswordForm user_form = admin_form;
user_form.username_value = u"user";
admin_form.date_last_used = base::Time::FromTimeT(0);
password_store->AddLogin(user_form);
NavigateToFile("/password/password_form.html");
autofill::ChromeAutofillClient* autofill_client =
autofill::ChromeAutofillClient::FromWebContentsForTesting(WebContents());
// The test page contains multiple password forms. All of them will be
// autofilled again every time the logins from the password store are changed.
// Updating every field takes time and triggers every time hiding the Autofill
// Popup with the reason `SuggestionHidingReason::kEndEditing` (because each
// field gains focus while it is autofilled). Therefore, we use
// `ChromeAutofillClient::SetKeepPopupOpenForTesting()` to keep the autofill
// popup open (and prevent the controller from being deleted).
// Note that `ChromeAutofillClient::SetKeepPopupOpenForTesting()` only ignores
// a specific very small set of hiding reasons, so the popup can still be
// hidden by almost all of the reasons (such as
// `SuggestionHidingReason::kStaleData`, which occurs only once when the test
// removes logins from the password store).
autofill_client->SetKeepPopupOpenForTesting(true);
autofill::mojom::PasswordManagerDriver* driver =
ContentPasswordManagerDriver::GetForRenderFrameHost(
WebContents()->GetPrimaryMainFrame());
// Just fake a position of the <input> element within the content_area_bounds.
// For this test it does not matter where the dropdown is rendered.
gfx::Rect content_area_bounds = WebContents()->GetContainerBounds();
gfx::RectF element_bounds(content_area_bounds.x(), content_area_bounds.y(),
content_area_bounds.width(),
content_area_bounds.height() * 0.1);
// Instruct Chrome to show the password dropdown.
autofill::FormData form;
driver->ShowPasswordSuggestions(autofill::PasswordSuggestionRequest(
autofill::TriggeringField(
kElementId,
autofill::AutofillSuggestionTriggerSource::kFormControlElementClicked,
base::i18n::LEFT_TO_RIGHT, std::u16string(),
/*show_webauthn_credentials=*/false,
/*show_identity_credentials=*/false, element_bounds),
form, 0, 0));
autofill::AutofillSuggestionController* controller = nullptr;
// Showing the Autofill Popup is an asynchronous task.
EXPECT_TRUE(base::test::RunUntil([&]() {
return controller =
autofill_client->suggestion_controller_for_testing().get();
})) << "Creating `AutofillPopupController` timed out.";
// Two credentials, a separator line and "Manage passwords" should be
// displayed.
EXPECT_EQ(4, controller->GetLineCount());
// Trigger user gesture so that autofill happens.
ASSERT_TRUE(content::ExecJs(
WebContents(), "document.getElementById('username_field').click();"));
WaitForElementValue("username_field", "admin");
// Delete one credential. It should not be in the dropdown.
password_store->RemoveLogin(FROM_HERE, admin_form);
WaitForPasswordStore();
// Wait for the refetch to finish.
EXPECT_FALSE(autofill_client->suggestion_controller_for_testing());
WaitForPasswordStore();
// Reshow the dropdown.
driver->ShowPasswordSuggestions(autofill::PasswordSuggestionRequest(
autofill::TriggeringField(
kElementId,
autofill::AutofillSuggestionTriggerSource::kFormControlElementClicked,
base::i18n::LEFT_TO_RIGHT, std::u16string(),
/*show_webauthn_credentials=*/false,
/*show_identity_credentials=*/false, element_bounds),
form, 0, 0));
// Showing the Autofill Popup is an asynchronous task.
EXPECT_TRUE(base::test::RunUntil([&]() {
return controller =
autofill_client->suggestion_controller_for_testing().get();
})) << "Creating `AutofillPopupController` timed out.";
EXPECT_EQ(3, controller->GetLineCount());
EXPECT_EQ(u"user", controller->GetSuggestionAt(0).main_text.value);
EXPECT_NE(u"admin", controller->GetSuggestionAt(1).main_text.value);
// The username_field should get re-filled with "user" instead of "admin".
WaitForElementValue("username_field", "user");
// Delete all the credentials.
password_store->RemoveLogin(FROM_HERE, user_form);
WaitForPasswordStore();
// Wait for the refetch to finish.
EXPECT_FALSE(autofill_client->suggestion_controller_for_testing());
WaitForPasswordStore();
// Reshow the dropdown won't work because there is nothing to suggest.
driver->ShowPasswordSuggestions(autofill::PasswordSuggestionRequest(
autofill::TriggeringField(
kElementId,
autofill::AutofillSuggestionTriggerSource::kFormControlElementClicked,
base::i18n::LEFT_TO_RIGHT, std::u16string(),
/*show_webauthn_credentials=*/false,
/*show_identity_credentials=*/false, element_bounds),
form, 0, 0));
// Showing the Autofill Popup is an asynchronous task.
base::RunLoop().RunUntilIdle();
EXPECT_FALSE(autofill_client->suggestion_controller_for_testing());
WaitForElementValue("username_field", "");
}
// Tests that submission is detected when change password form is reset.
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest, ChangePwdFormCleared) {
base::HistogramTester histogram_tester;
// At first let us save credentials to the PasswordManager.
scoped_refptr<password_manager::TestPasswordStore> password_store =
static_cast<password_manager::TestPasswordStore*>(
ProfilePasswordStoreFactory::GetForProfile(
browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS)
.get());
password_manager::PasswordForm signin_form;
signin_form.signon_realm = embedded_test_server()->base_url().spec();
signin_form.username_value = u"temp";
signin_form.password_value = u"old_pw";
password_store->AddLogin(signin_form);
NavigateToFile("/password/cleared_change_password_forms.html");
// Fill a form and submit through a <input type="submit"> button.
std::unique_ptr<BubbleObserver> prompt_observer(
new BubbleObserver(WebContents()));
FillElementWithValue("chg_new_password_1", "new_pw", "new_pw");
FillElementWithValue("chg_new_password_2", "new_pw", "new_pw");
std::string submit = "document.getElementById('chg_clear_button').click();";
ASSERT_TRUE(content::ExecJs(WebContents(), submit));
prompt_observer->WaitForAutomaticUpdatePrompt();
// We emulate that the user clicks "Update" button.
prompt_observer->AcceptUpdatePrompt();
// Check that credentials are stored.
WaitForPasswordStore();
CheckThatCredentialsStored("temp", "new_pw");
histogram_tester.ExpectUniqueSample(
"PasswordManager.SuccessfulSubmissionIndicatorEvent",
autofill::mojom::SubmissionIndicatorEvent::CHANGE_PASSWORD_FORM_CLEARED,
1);
}
// Tests that submission is detected when all password fields in a change
// password form are cleared and not detected when only some fields are cleared.
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
ChangePwdFormFieldsCleared) {
// At first let us save credentials to the PasswordManager.
scoped_refptr<password_manager::TestPasswordStore> password_store =
static_cast<password_manager::TestPasswordStore*>(
ProfilePasswordStoreFactory::GetForProfile(
browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS)
.get());
password_manager::PasswordForm signin_form;
signin_form.signon_realm = embedded_test_server()->base_url().spec();
signin_form.username_value = u"temp";
signin_form.password_value = u"old_pw";
password_store->AddLogin(signin_form);
for (bool all_fields_cleared : {false, true}) {
base::HistogramTester histogram_tester;
SCOPED_TRACE(testing::Message("#all_fields_cleared = ")
<< all_fields_cleared);
NavigateToFile("/password/cleared_change_password_forms.html");
// Fill a form and submit through a <input type="submit"> button.
std::unique_ptr<BubbleObserver> prompt_observer(
new BubbleObserver(WebContents()));
FillElementWithValue("chg_new_password_1", "new_pw", "new_pw");
FillElementWithValue("chg_new_password_2", "new_pw", "new_pw");
std::string submit =
all_fields_cleared
? "document.getElementById('chg_clear_all_fields_button').click();"
: "document.getElementById('chg_clear_some_fields_button').click()"
";";
ASSERT_TRUE(content::ExecJs(WebContents(), submit));
if (all_fields_cleared) {
prompt_observer->WaitForAutomaticUpdatePrompt();
} else {
EXPECT_FALSE(prompt_observer->IsUpdatePromptShownAutomatically());
}
if (all_fields_cleared) {
// We emulate that the user clicks "Update" button.
prompt_observer->AcceptUpdatePrompt();
// Check that credentials are stored.
WaitForPasswordStore();
CheckThatCredentialsStored("temp", "new_pw");
histogram_tester.ExpectUniqueSample(
"PasswordManager.SuccessfulSubmissionIndicatorEvent",
autofill::mojom::SubmissionIndicatorEvent::
CHANGE_PASSWORD_FORM_CLEARED,
1);
}
}
}
// Tests that submission is detected when the new password field outside the
// form tag is cleared not detected when other password fields are cleared.
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
ChangePwdFormRelevantFormlessFieldsCleared) {
base::HistogramTester histogram_tester;
// At first let us save credentials to the PasswordManager.
scoped_refptr<password_manager::TestPasswordStore> password_store =
static_cast<password_manager::TestPasswordStore*>(
ProfilePasswordStoreFactory::GetForProfile(
browser()->profile(), ServiceAccessType::IMPLICIT_ACCESS)
.get());
password_manager::PasswordForm signin_form;
signin_form.signon_realm = embedded_test_server()->base_url().spec();
signin_form.username_value = u"temp";
signin_form.password_value = u"old_pw";
password_store->AddLogin(signin_form);
for (bool relevant_fields_cleared : {false, true}) {
SCOPED_TRACE(testing::Message("#relevant_fields_cleared = ")
<< relevant_fields_cleared);
NavigateToFile("/password/cleared_change_password_forms.html");
// Fill a form and submit through a <input type="submit"> button.
std::unique_ptr<BubbleObserver> prompt_observer(
new BubbleObserver(WebContents()));
FillElementWithValue("formless_chg_new_password_1", "new_pw", "new_pw");
FillElementWithValue("formless_chg_new_password_2", "new_pw", "new_pw");
std::string submit = relevant_fields_cleared
? "document.getElementById('chg_clear_all_"
"formless_fields_button').click();"
: "document.getElementById('chg_clear_some_"
"formless_fields_button').click();";
ASSERT_TRUE(content::ExecJs(WebContents(), submit));
if (relevant_fields_cleared) {
prompt_observer->WaitForAutomaticUpdatePrompt();
EXPECT_TRUE(prompt_observer->IsUpdatePromptShownAutomatically());
} else {
EXPECT_FALSE(prompt_observer->IsUpdatePromptShownAutomatically());
}
if (relevant_fields_cleared) {
// We emulate that the user clicks "Update" button.
prompt_observer->AcceptUpdatePrompt();
// Check that credentials are stored.
WaitForPasswordStore();
CheckThatCredentialsStored("temp", "new_pw");
histogram_tester.ExpectUniqueSample(
"PasswordManager.SuccessfulSubmissionIndicatorEvent",
autofill::mojom::SubmissionIndicatorEvent::
CHANGE_PASSWORD_FORM_CLEARED,
1);
}
}
}
// Tests that, when choosing the value for saving, user-typed values are
// preferred to values coming from JS.
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTest,
UserTypedValuesAreSavedInsteadOfJsInputs) {
NavigateToFile("/password/simple_password.html");
// Simulate user typing username and password.
const std::string kRealUsername = "real-username";
FillElementWithValue("username_field", kRealUsername, kRealUsername);
const std::string kRealPassword = "real-password";
FillElementWithValue("password_field", kRealPassword, kRealPassword);
// Change input values with JS.
const std::string kFakeUsername = "it-is-a-trap-username";
const std::string kFakePassword = "it-is-a-trap-password";
ASSERT_TRUE(
content::ExecJs(WebContents(),
R"(document.getElementById('username_field').focus();
document.getElementById('username_field').value = ')" +
kFakeUsername + R"(';
document.getElementById('password_field').value = ')" +
kFakePassword + "';"));
WaitForElementValue("username_field", kFakeUsername);
WaitForElementValue("password_field", kFakePassword);
// Submit the form and check that user typed inputs are saved.
PasswordsNavigationObserver navigation_observer(WebContents());
BubbleObserver prompt_observer(WebContents());
std::string submit =
"document.getElementById('input_submit_button').click();";
ASSERT_TRUE(content::ExecJs(WebContents(), submit));
ASSERT_TRUE(navigation_observer.Wait());
prompt_observer.WaitForAutomaticSavePrompt();
prompt_observer.AcceptSavePrompt();
WaitForPasswordStore();
CheckThatCredentialsStored(kRealUsername, kRealPassword);
}
#if BUILDFLAG(ENABLE_DICE_SUPPORT)
// This test suite only applies to Gaia signin page, and checks that the
// signin interception bubble and the password bubbles never conflict.
class PasswordManagerInteractiveTestWithSigninInterception
: public PasswordManagerInteractiveTest {
public:
PasswordManagerInteractiveTestWithSigninInterception()
: helper_(&https_test_server()) {}
void SetUpCommandLine(base::CommandLine* command_line) override {
PasswordManagerInteractiveTest::SetUpCommandLine(command_line);
helper_.SetUpCommandLine(command_line);
}
void SetUpOnMainThread() override {
helper_.SetUpOnMainThread();
PasswordManagerInteractiveTest::SetUpOnMainThread();
}
protected:
PasswordManagerSigninInterceptTestHelper helper_;
};
// Checks that password update suppresses signin interception.
IN_PROC_BROWSER_TEST_F(PasswordManagerInteractiveTestWithSigninInterception,
InterceptionBubbleSuppressedByPendingPasswordUpdate) {
Profile* profile = browser()->profile();
helper_.SetupProfilesForInterception(profile);
// Prepopulate Gaia credentials to trigger an update bubble.
scoped_refptr<password_manager::TestPasswordStore> password_store =
static_cast<password_manager::TestPasswordStore*>(
ProfilePasswordStoreFactory::GetForProfile(
profile, ServiceAccessType::IMPLICIT_ACCESS)
.get());
helper_.StoreGaiaCredentials(password_store);
helper_.NavigateToGaiaSigninPage(WebContents());
// Have user interact with the page
content::SimulateMouseClickAt(
WebContents(), 0, blink::WebMouseEvent::Button::kLeft, gfx::Point(1, 1));
// Wait for password to be autofilled.
WaitForElementValue("password_field", "pw");
// Change username and submit. This should add the characters "new" to the
// already autofilled password.
FillElementWithValue("password_field", "new", "pwnew");
// Wait until the form change is picked up by the password manager.
const PasswordManagerInterface* password_manager =
ChromePasswordManagerClient::FromWebContents(WebContents())
->GetPasswordManager();
EXPECT_TRUE(base::test::RunUntil([&]() {
return password_manager->IsFormManagerPendingPasswordUpdate();
}));
// Start the navigation.
PasswordsNavigationObserver navigation_observer(WebContents());
content::ExecuteScriptAsync(
WebContents(), "document.getElementById('input_submit_button').click()");
// Complete the Gaia signin before the navigation completes.
CoreAccountId account_id = helper_.AddGaiaAccountToProfile(
profile, helper_.gaia_email(), helper_.gaia_id());
// Check that interception does not happen.
base::HistogramTester histogram_tester;
DiceWebSigninInterceptor* signin_interceptor =
helper_.GetSigninInterceptor(profile);
signin_interceptor->MaybeInterceptWebSignin(
WebContents(), account_id, signin_metrics::AccessPoint::kUnknown,
/*is_new_account=*/true,
/*is_sync_signin=*/false);
EXPECT_FALSE(signin_interceptor->is_interception_in_progress());
histogram_tester.ExpectUniqueSample(
"Signin.Intercept.HeuristicOutcome",
SigninInterceptionHeuristicOutcome::kAbortPasswordUpdatePending, 1);
// Complete the navigation. The stored password "pw" was overridden with
// "pwnew", so update prompt is expected.
BubbleObserver prompt_observer(WebContents());
ASSERT_TRUE(navigation_observer.Wait());
prompt_observer.WaitForAutomaticUpdatePrompt();
}
#endif // BUILDFLAG(ENABLE_DICE_SUPPORT)
} // namespace password_manager
|