File: picture_in_picture_occlusion_tracker_unittest.cc

package info (click to toggle)
chromium 138.0.7204.157-1
  • links: PTS, VCS
  • area: main
  • in suites: sid, trixie
  • size: 6,071,864 kB
  • sloc: cpp: 34,936,859; ansic: 7,176,967; javascript: 4,110,704; python: 1,419,953; asm: 946,768; xml: 739,967; pascal: 187,324; sh: 89,623; perl: 88,663; objc: 79,944; sql: 50,304; cs: 41,786; fortran: 24,137; makefile: 21,806; php: 13,980; tcl: 13,166; yacc: 8,925; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (308 lines) | stat: -rw-r--r-- 13,145 bytes parent folder | download | duplicates (3)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "chrome/browser/picture_in_picture/picture_in_picture_occlusion_tracker.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/picture_in_picture/picture_in_picture_occlusion_observer.h"
#include "chrome/browser/picture_in_picture/picture_in_picture_window_manager.h"
#include "chrome/browser/picture_in_picture/scoped_picture_in_picture_occlusion_observation.h"
#include "chrome/test/views/chrome_views_test_base.h"
#include "media/base/media_switches.h"
#include "testing/gmock/include/gmock/gmock.h"

namespace {

using testing::_;
using testing::Invoke;

class MockPictureInPictureOcclusionObserver
    : public PictureInPictureOcclusionObserver {
 public:
  MockPictureInPictureOcclusionObserver() = default;
  MockPictureInPictureOcclusionObserver(
      const MockPictureInPictureOcclusionObserver&) = delete;
  MockPictureInPictureOcclusionObserver& operator=(
      const MockPictureInPictureOcclusionObserver&) = delete;
  ~MockPictureInPictureOcclusionObserver() override = default;

  // PictureInPictureOcclusionObserver:
  MOCK_METHOD(void, OnOcclusionStateChanged, (bool occluded), (override));
};

class PictureInPictureOcclusionTrackerTest : public ChromeViewsTestBase {
 public:
  PictureInPictureOcclusionTrackerTest() = default;
  PictureInPictureOcclusionTrackerTest(
      const PictureInPictureOcclusionTrackerTest&) = delete;
  PictureInPictureOcclusionTrackerTest& operator=(
      const PictureInPictureOcclusionTrackerTest&) = delete;
  ~PictureInPictureOcclusionTrackerTest() override = default;

  void SetUp() override {
    feature_list_.InitAndEnableFeature(
        media::kPictureInPictureOcclusionTracking);
    ChromeViewsTestBase::SetUp();
  }

 protected:
  std::unique_ptr<views::Widget> CreatePictureInPictureWidget() {
    // Create a picture-in-picture widget and inform the occlusion tracker.
    std::unique_ptr<views::Widget> picture_in_picture_widget =
        CreateTestWidget(views::Widget::InitParams::CLIENT_OWNS_WIDGET);
    picture_in_picture_widget->Show();
    picture_in_picture_widget->SetBounds({0, 0, 200, 200});
    PictureInPictureWindowManager::GetInstance()
        ->GetOcclusionTracker()
        ->OnPictureInPictureWidgetOpened(picture_in_picture_widget.get());
    return picture_in_picture_widget;
  }

  void WaitForBoundsChangedDebounce() {
    task_environment()->FastForwardBy(base::Milliseconds(300));
  }

 private:
  base::test::ScopedFeatureList feature_list_;
};

TEST_F(PictureInPictureOcclusionTrackerTest,
       NotifiesObserversWhenEitherWidgetMoves) {
  MockPictureInPictureOcclusionObserver observer;
  ScopedPictureInPictureOcclusionObservation observation(&observer);
  std::unique_ptr<views::Widget> picture_in_picture_widget =
      CreatePictureInPictureWidget();

  // Create a widget to track the occlusion state of, placing it so that it
  // starts out unoccluded.
  std::unique_ptr<views::Widget> occludable_widget =
      CreateTestWidget(views::Widget::InitParams::CLIENT_OWNS_WIDGET);
  occludable_widget->Show();
  occludable_widget->SetBounds({300, 0, 200, 200});

  // Start observing occlusion state. This should immediately tell the observer
  // that it's not occluded.
  EXPECT_CALL(observer, OnOcclusionStateChanged(false));
  observation.Observe(occludable_widget.get());
  testing::Mock::VerifyAndClearExpectations(&observer);

  // Move the occludable widget under the picture-in-picture window. This should
  // update the observer.
  EXPECT_CALL(observer, OnOcclusionStateChanged(true));
  occludable_widget->SetBounds({50, 50, 200, 200});
  WaitForBoundsChangedDebounce();
  testing::Mock::VerifyAndClearExpectations(&observer);

  // Move the picture-in-picture widget off of the occludable widget. This
  // should update the observer.
  EXPECT_CALL(observer, OnOcclusionStateChanged(false));
  picture_in_picture_widget->SetBounds({300, 0, 200, 200});
  WaitForBoundsChangedDebounce();
  testing::Mock::VerifyAndClearExpectations(&observer);
}

TEST_F(PictureInPictureOcclusionTrackerTest,
       InvisiblePictureInPictureWidgetsDontOcclude) {
  MockPictureInPictureOcclusionObserver observer;
  ScopedPictureInPictureOcclusionObservation observation(&observer);
  std::unique_ptr<views::Widget> picture_in_picture_widget =
      CreatePictureInPictureWidget();

  // Create a widget to track the occlusion state of, placing it so that it
  // starts out occluded.
  std::unique_ptr<views::Widget> occludable_widget =
      CreateTestWidget(views::Widget::InitParams::CLIENT_OWNS_WIDGET);
  occludable_widget->Show();
  occludable_widget->SetBounds({50, 50, 200, 200});

  // Start observing occlusion state. This should immediately tell the observer
  // that it's occluded.
  EXPECT_CALL(observer, OnOcclusionStateChanged(true));
  observation.Observe(occludable_widget.get());
  testing::Mock::VerifyAndClearExpectations(&observer);

  // Make the picture-in-picture widget invisible. This should inform the
  // observer that it's no longer occluded.
  EXPECT_CALL(observer, OnOcclusionStateChanged(false));
  picture_in_picture_widget->Hide();
  testing::Mock::VerifyAndClearExpectations(&observer);

  // Show the picture-in-picture widget again. This should inform the observer
  // that it's occluded again.
  EXPECT_CALL(observer, OnOcclusionStateChanged(true));
  picture_in_picture_widget->Show();
  testing::Mock::VerifyAndClearExpectations(&observer);
}

TEST_F(PictureInPictureOcclusionTrackerTest,
       UpdatesOcclusionStateWhenWidgetMovesDueToParentMoving) {
  MockPictureInPictureOcclusionObserver observer;
  ScopedPictureInPictureOcclusionObservation observation(&observer);
  std::unique_ptr<views::Widget> picture_in_picture_widget =
      CreatePictureInPictureWidget();

  // Create a parent widget for our occludable widget that is underneath the
  // picture-in-picture window.
  std::unique_ptr<views::Widget> parent_widget =
      CreateTestWidget(views::Widget::InitParams::CLIENT_OWNS_WIDGET);
  parent_widget->Show();
  parent_widget->SetBounds({0, 0, 200, 200});

  // Create an occludable widget that is a child of `parent_widget`.
  views::Widget::InitParams params =
      CreateParams(views::Widget::InitParams::CLIENT_OWNS_WIDGET,
                   views::Widget::InitParams::TYPE_WINDOW_FRAMELESS);
  params.parent = parent_widget->GetNativeView();
  params.child = true;
  params.bounds = gfx::Rect(0, 0, 50, 50);
  std::unique_ptr<views::Widget> occludable_widget =
      CreateTestWidget(std::move(params));
  occludable_widget->Show();

  // Start observing `occludable_widget`. This should immediately inform the
  // observer that the window is occluded.
  EXPECT_CALL(observer, OnOcclusionStateChanged(true));
  observation.Observe(occludable_widget.get());
  testing::Mock::VerifyAndClearExpectations(&observer);

  // Indirectly move `occludable_widget` out from underneath the
  // picture-in-picture window by moving its parent window. This should inform
  // the observer that the window is no longer occluded.
  EXPECT_CALL(observer, OnOcclusionStateChanged(false));
  parent_widget->SetBounds({300, 0, 200, 200});
  WaitForBoundsChangedDebounce();
  testing::Mock::VerifyAndClearExpectations(&observer);
}

TEST_F(PictureInPictureOcclusionTrackerTest, MultipleObserversForOneWidget) {
  MockPictureInPictureOcclusionObserver observer1;
  ScopedPictureInPictureOcclusionObservation observation1(&observer1);
  std::unique_ptr<views::Widget> picture_in_picture_widget =
      CreatePictureInPictureWidget();

  // Create a widget to track the occlusion state of, placing it so that it
  // starts out occluded.
  std::unique_ptr<views::Widget> occludable_widget =
      CreateTestWidget(views::Widget::InitParams::CLIENT_OWNS_WIDGET);
  occludable_widget->Show();
  occludable_widget->SetBounds({50, 50, 200, 200});

  // Start observing `occludable_widget`. This should immediately inform the
  // observer that the window is occluded.
  EXPECT_CALL(observer1, OnOcclusionStateChanged(true));
  observation1.Observe(occludable_widget.get());
  testing::Mock::VerifyAndClearExpectations(&observer1);

  {
    MockPictureInPictureOcclusionObserver observer2;
    ScopedPictureInPictureOcclusionObservation observation2(&observer2);

    // Start observing `occludable_widget` with a second observer. This should
    // immediately inform the new observer but not the original one.
    EXPECT_CALL(observer1, OnOcclusionStateChanged(_)).Times(0);
    EXPECT_CALL(observer2, OnOcclusionStateChanged(true));
    observation2.Observe(occludable_widget.get());
    testing::Mock::VerifyAndClearExpectations(&observer1);
    testing::Mock::VerifyAndClearExpectations(&observer2);

    // Unocclude the widget. This should inform both observers.
    EXPECT_CALL(observer1, OnOcclusionStateChanged(false));
    EXPECT_CALL(observer2, OnOcclusionStateChanged(false));
    picture_in_picture_widget->SetBounds({300, 0, 200, 200});
    WaitForBoundsChangedDebounce();
    testing::Mock::VerifyAndClearExpectations(&observer1);
    testing::Mock::VerifyAndClearExpectations(&observer2);
  }

  // The second observer is now out of scope, but the original observer should
  // still receive updates.
  EXPECT_CALL(observer1, OnOcclusionStateChanged(true));
  picture_in_picture_widget->SetBounds({0, 0, 200, 200});
  WaitForBoundsChangedDebounce();
  testing::Mock::VerifyAndClearExpectations(&observer1);
}

TEST_F(PictureInPictureOcclusionTrackerTest,
       ChildOfPictureInPictureWidgetIsntOccluded) {
  MockPictureInPictureOcclusionObserver observer;
  ScopedPictureInPictureOcclusionObservation observation(&observer);
  std::unique_ptr<views::Widget> picture_in_picture_widget =
      CreatePictureInPictureWidget();

  // Create an occludable widget that is a child of `picture_in_picture_widget`.
  views::Widget::InitParams params =
      CreateParams(views::Widget::InitParams::CLIENT_OWNS_WIDGET,
                   views::Widget::InitParams::TYPE_WINDOW_FRAMELESS);
  params.parent = picture_in_picture_widget->GetNativeView();
  params.child = true;
  params.bounds = gfx::Rect(0, 0, 50, 50);
  std::unique_ptr<views::Widget> occludable_widget =
      CreateTestWidget(std::move(params));
  occludable_widget->Show();

  // Start observing occlusion state. Even though the picture-in-picture widget
  // intersects with the widget, it should not be considered occluded since it
  // is a child of the picture-in-picture widget.
  EXPECT_CALL(observer, OnOcclusionStateChanged(false));
  observation.Observe(occludable_widget.get());
  testing::Mock::VerifyAndClearExpectations(&observer);
}

// Regression test for https://crbug.com/1509371.
TEST_F(PictureInPictureOcclusionTrackerTest, ObserveTwiceDoesNotCrash) {
  MockPictureInPictureOcclusionObserver observer;
  ScopedPictureInPictureOcclusionObservation observation(&observer);

  // Create an observed widget.
  std::unique_ptr<views::Widget> occludable_widget1 =
      CreateTestWidget(views::Widget::InitParams::CLIENT_OWNS_WIDGET);
  occludable_widget1->Show();
  observation.Observe(occludable_widget1.get());

  // Create a second observed widget, and observe that one with the same
  // ScopedPictureInPictureOcclusionObservation, replacing the first one.
  std::unique_ptr<views::Widget> occludable_widget2 =
      CreateTestWidget(views::Widget::InitParams::CLIENT_OWNS_WIDGET);
  occludable_widget2->Show();
  observation.Observe(occludable_widget2.get());

  // Destroy the original widget. This should not crash.
  occludable_widget1.reset();
}

// Regression test for https://crbug/com/353039531.
TEST_F(PictureInPictureOcclusionTrackerTest,
       SynchronouslyReobservingDoesNotCrash) {
  MockPictureInPictureOcclusionObserver observer;
  ScopedPictureInPictureOcclusionObservation observation(&observer);
  std::unique_ptr<views::Widget> picture_in_picture_widget =
      CreatePictureInPictureWidget();

  // Create a widget to track the occlusion state of, placing it so that it
  // starts out occluded.
  std::unique_ptr<views::Widget> occludable_widget1 =
      CreateTestWidget(views::Widget::InitParams::CLIENT_OWNS_WIDGET);
  occludable_widget1->Show();
  occludable_widget1->SetBounds({50, 50, 200, 200});

  // Create a second widget to observe in the `OnOcclusionStateChanged`
  // callback.
  std::unique_ptr<views::Widget> occludable_widget2 =
      CreateTestWidget(views::Widget::InitParams::CLIENT_OWNS_WIDGET);
  occludable_widget2->Show();

  EXPECT_CALL(observer, OnOcclusionStateChanged(true)).WillOnce(Invoke([&]() {
    testing::Mock::VerifyAndClearExpectations(&observer);

    // Synchronously start observing the second widget when we see that the
    // first is occluded. This should not crash.
    observation.Observe(occludable_widget2.get());
  }));

  // Start observing `occludable_widget`. This should immediately inform the
  // observer that the window is occluded and therefore synchronously start
  // observing `occludable_widget2`.
  observation.Observe(occludable_widget1.get());
}

}  // namespace