1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367
|
// Copyright 2015 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/process_singleton.h"
#include <windows.h>
#include <memory>
#include <string>
#include "base/check.h"
#include "base/command_line.h"
#include "base/compiler_specific.h"
#include "base/files/file_path.h"
#include "base/files/scoped_temp_dir.h"
#include "base/functional/bind.h"
#include "base/notreached.h"
#include "base/process/launch.h"
#include "base/process/process.h"
#include "base/process/process_handle.h"
#include "base/strings/string_number_conversions_win.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/multiprocess_test.h"
#include "base/time/time.h"
#include "base/win/scoped_handle.h"
#include "base/win/wrapped_window_proc.h"
#include "chrome/browser/win/chrome_process_finder.h"
#include "chrome/common/chrome_constants.h"
#include "chrome/common/chrome_switches.h"
#include "content/public/common/result_codes.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/multiprocess_func_list.h"
namespace {
const char kReadyEventNameFlag[] = "ready_event_name";
const char kContinueEventNameFlag[] = "continue_event_name";
const char kCreateWindowFlag[] = "create_window";
const int kErrorResultCode = 0x345;
bool NotificationCallback(base::CommandLine command_line,
const base::FilePath& current_directory) {
// This is never called in this test, but would signal that the singleton
// notification was successfully handled.
NOTREACHED();
}
// The ProcessSingleton kills hung browsers with no visible windows without user
// interaction. If a hung browser has visible UI, however, it asks the user
// first.
// This class is the very minimal implementation to create a visible window
// in the hung test process to allow testing the latter path.
class ScopedVisibleWindow {
public:
ScopedVisibleWindow() : class_(0), window_(NULL) {}
ScopedVisibleWindow(const ScopedVisibleWindow&) = delete;
ScopedVisibleWindow& operator=(const ScopedVisibleWindow&) = delete;
~ScopedVisibleWindow() {
if (window_)
::DestroyWindow(window_);
if (class_)
::UnregisterClass(reinterpret_cast<LPCWSTR>(class_), NULL);
}
bool Create() {
WNDCLASSEX wnd_cls = {0};
base::win::InitializeWindowClass(
L"ProcessSingletonTest", base::win::WrappedWindowProc<::DefWindowProc>,
0, // style
0, // class_extra
0, // window_extra
NULL, // cursor
NULL, // background
NULL, // menu_name
NULL, // large_icon
NULL, // small_icon
&wnd_cls);
class_ = ::RegisterClassEx(&wnd_cls);
if (!class_)
return false;
window_ = ::CreateWindow(reinterpret_cast<LPCWSTR>(class_), 0, WS_POPUP, 0,
0, 0, 0, 0, 0, NULL, 0);
if (!window_)
return false;
::ShowWindow(window_, SW_SHOW);
DCHECK(window_);
return true;
}
private:
ATOM class_;
HWND window_;
};
MULTIPROCESS_TEST_MAIN(ProcessSingletonTestProcessMain) {
base::CommandLine* cmd_line = base::CommandLine::ForCurrentProcess();
base::FilePath user_data_dir =
cmd_line->GetSwitchValuePath(switches::kUserDataDir);
if (user_data_dir.empty())
return kErrorResultCode;
std::wstring ready_event_name =
cmd_line->GetSwitchValueNative(kReadyEventNameFlag);
base::win::ScopedHandle ready_event(
::OpenEvent(EVENT_MODIFY_STATE, FALSE, ready_event_name.c_str()));
if (!ready_event.IsValid())
return kErrorResultCode;
std::wstring continue_event_name =
cmd_line->GetSwitchValueNative(kContinueEventNameFlag);
base::win::ScopedHandle continue_event(
::OpenEvent(SYNCHRONIZE, FALSE, continue_event_name.c_str()));
if (!continue_event.IsValid())
return kErrorResultCode;
ScopedVisibleWindow visible_window;
if (cmd_line->HasSwitch(kCreateWindowFlag)) {
if (!visible_window.Create())
return kErrorResultCode;
}
// Instantiate the process singleton.
ProcessSingleton process_singleton(
user_data_dir, base::BindRepeating(&NotificationCallback));
if (!process_singleton.Create())
return kErrorResultCode;
// Signal ready and block for the continue event.
if (!::SetEvent(ready_event.Get()))
return kErrorResultCode;
if (::WaitForSingleObject(continue_event.Get(), INFINITE) != WAIT_OBJECT_0)
return kErrorResultCode;
return 0;
}
// This fixture is for testing the Windows platform-specific failure modes
// of rendezvous, specifically the ones where the singleton-owning process
// is hung.
class ProcessSingletonTest : public base::MultiProcessTest {
public:
ProcessSingletonTest(const ProcessSingletonTest&) = delete;
ProcessSingletonTest& operator=(const ProcessSingletonTest&) = delete;
protected:
enum WindowOption { WITH_WINDOW, NO_WINDOW };
ProcessSingletonTest()
: window_option_(NO_WINDOW), should_kill_called_(false) {}
void SetUp() override {
ASSERT_NO_FATAL_FAILURE(base::MultiProcessTest::SetUp());
// Drop the process finder notification timeout to one second for testing.
old_notification_timeout_ =
SetNotificationTimeoutForTesting(base::Seconds(1));
}
void TearDown() override {
SetNotificationTimeoutForTesting(old_notification_timeout_);
if (browser_victim_.IsValid()) {
EXPECT_TRUE(::SetEvent(continue_event_.Get()));
EXPECT_TRUE(browser_victim_.WaitForExit(nullptr));
}
base::MultiProcessTest::TearDown();
}
void LaunchHungBrowserProcess(WindowOption window_option) {
// Create a unique user data dir to rendezvous on.
ASSERT_TRUE(user_data_dir_.CreateUniqueTempDir());
// Create the named "ready" event, this is unique to our process.
ready_event_name_ =
L"ready-event-" + base::NumberToWString(base::GetCurrentProcId());
base::win::ScopedHandle ready_event(
::CreateEvent(NULL, TRUE, FALSE, ready_event_name_.c_str()));
ASSERT_TRUE(ready_event.IsValid());
// Create the named "continue" event, this is unique to our process.
continue_event_name_ =
L"continue-event-" + base::NumberToWString(base::GetCurrentProcId());
continue_event_.Set(
::CreateEvent(NULL, TRUE, FALSE, continue_event_name_.c_str()));
ASSERT_TRUE(continue_event_.IsValid());
window_option_ = window_option;
base::LaunchOptions options;
options.start_hidden = true;
browser_victim_ =
SpawnChildWithOptions("ProcessSingletonTestProcessMain", options);
// Wait for the ready event (or process exit).
HANDLE handles[] = {ready_event.Get(), browser_victim_.Handle()};
// The wait should always return because either |ready_event| is signaled or
// |browser_victim_| died unexpectedly or exited on error.
DWORD result =
::WaitForMultipleObjects(std::size(handles), handles, FALSE, INFINITE);
ASSERT_EQ(WAIT_OBJECT_0, result);
}
base::CommandLine MakeCmdLine(const std::string& procname) override {
base::CommandLine cmd_line = base::MultiProcessTest::MakeCmdLine(procname);
cmd_line.AppendSwitchPath(switches::kUserDataDir, user_data_dir_.GetPath());
cmd_line.AppendSwitchNative(kReadyEventNameFlag, ready_event_name_);
cmd_line.AppendSwitchNative(kContinueEventNameFlag, continue_event_name_);
if (window_option_ == WITH_WINDOW)
cmd_line.AppendSwitch(kCreateWindowFlag);
return cmd_line;
}
void PrepareTest(WindowOption window_option, bool allow_kill) {
ASSERT_NO_FATAL_FAILURE(LaunchHungBrowserProcess(window_option));
// The ready event has been signalled - the process singleton is held by
// the hung sub process.
test_singleton_ = std::make_unique<ProcessSingleton>(
user_data_dir(), base::BindRepeating(&NotificationCallback));
test_singleton_->OverrideShouldKillRemoteProcessCallbackForTesting(
base::BindRepeating(&ProcessSingletonTest::MockShouldKillRemoteProcess,
base::Unretained(this), allow_kill));
}
base::Process* browser_victim() { return &browser_victim_; }
const base::FilePath& user_data_dir() const {
return user_data_dir_.GetPath();
}
ProcessSingleton* test_singleton() const { return test_singleton_.get(); }
bool should_kill_called() const { return should_kill_called_; }
const base::HistogramTester& histogram_tester() const {
return histogram_tester_;
}
private:
bool MockShouldKillRemoteProcess(bool allow_kill) {
should_kill_called_ = true;
return allow_kill;
}
std::wstring ready_event_name_;
std::wstring continue_event_name_;
WindowOption window_option_;
base::ScopedTempDir user_data_dir_;
base::Process browser_victim_;
base::win::ScopedHandle continue_event_;
std::unique_ptr<ProcessSingleton> test_singleton_;
base::TimeDelta old_notification_timeout_;
bool should_kill_called_;
base::HistogramTester histogram_tester_;
};
} // namespace
TEST_F(ProcessSingletonTest, KillsHungBrowserWithNoWindows) {
ASSERT_NO_FATAL_FAILURE(PrepareTest(NO_WINDOW, false));
// As the hung browser has no visible window, it'll be killed without
// user interaction.
ProcessSingleton::NotifyResult notify_result =
test_singleton()->NotifyOtherProcessOrCreate();
// The hung process was killed and the notification is equivalent to
// a non existent process.
ASSERT_EQ(ProcessSingleton::PROCESS_NONE, notify_result);
// The should-kill callback should not have been called, as the "browser" does
// not have visible window.
EXPECT_FALSE(should_kill_called());
histogram_tester().ExpectUniqueSample(
"Chrome.ProcessSingleton.RemoteProcessInteractionResult",
ProcessSingleton::TERMINATE_SUCCEEDED, 1u);
histogram_tester().ExpectTotalCount(
"Chrome.ProcessSingleton.TerminateProcessTime", 1u);
histogram_tester().ExpectUniqueSample(
"Chrome.ProcessSingleton.TerminateProcessErrorCode.Windows", 0, 1u);
histogram_tester().ExpectUniqueSample(
"Chrome.ProcessSingleton.TerminationWaitErrorCode.Windows", 0, 1u);
histogram_tester().ExpectUniqueSample(
"Chrome.ProcessSingleton.RemoteHungProcessTerminateReason",
ProcessSingleton::NO_VISIBLE_WINDOW_FOUND, 1u);
// Verify that the hung browser has been terminated with the
// RESULT_CODE_HUNG exit code.
int exit_code = 0;
EXPECT_TRUE(
browser_victim()->WaitForExitWithTimeout(base::TimeDelta(), &exit_code));
EXPECT_EQ(content::RESULT_CODE_HUNG, exit_code);
}
TEST_F(ProcessSingletonTest, DoesntKillWithoutUserPermission) {
ASSERT_NO_FATAL_FAILURE(PrepareTest(WITH_WINDOW, false));
// As the hung browser has a visible window, this should query the user
// before killing the hung process.
ProcessSingleton::NotifyResult notify_result =
test_singleton()->NotifyOtherProcessOrCreate();
ASSERT_EQ(ProcessSingleton::PROCESS_NOTIFIED, notify_result);
// The should-kill callback should have been called, as the "browser" has a
// visible window.
EXPECT_TRUE(should_kill_called());
histogram_tester().ExpectUniqueSample(
"Chrome.ProcessSingleton.RemoteProcessInteractionResult",
ProcessSingleton::USER_REFUSED_TERMINATION, 1u);
// Make sure the process hasn't been killed.
int exit_code = 0;
EXPECT_FALSE(
browser_victim()->WaitForExitWithTimeout(base::TimeDelta(), &exit_code));
}
TEST_F(ProcessSingletonTest, KillWithUserPermission) {
ASSERT_NO_FATAL_FAILURE(PrepareTest(WITH_WINDOW, true));
// As the hung browser has a visible window, this should query the user
// before killing the hung process.
ProcessSingleton::NotifyResult notify_result =
test_singleton()->NotifyOtherProcessOrCreate();
// The hung process was killed and the notification is equivalent to
// a non existent process.
ASSERT_EQ(ProcessSingleton::PROCESS_NONE, notify_result);
// The should-kill callback should have been called, as the "browser" has a
// visible window.
EXPECT_TRUE(should_kill_called());
histogram_tester().ExpectUniqueSample(
"Chrome.ProcessSingleton.RemoteProcessInteractionResult",
ProcessSingleton::TERMINATE_SUCCEEDED, 1u);
histogram_tester().ExpectTotalCount(
"Chrome.ProcessSingleton.TerminateProcessTime", 1u);
histogram_tester().ExpectUniqueSample(
"Chrome.ProcessSingleton.TerminateProcessErrorCode.Windows", 0, 1u);
histogram_tester().ExpectUniqueSample(
"Chrome.ProcessSingleton.TerminationWaitErrorCode.Windows", 0, 1u);
histogram_tester().ExpectUniqueSample(
"Chrome.ProcessSingleton.RemoteHungProcessTerminateReason",
ProcessSingleton::USER_ACCEPTED_TERMINATION, 1u);
// Verify that the hung browser has been terminated with the
// RESULT_CODE_HUNG exit code.
int exit_code = 0;
EXPECT_TRUE(
browser_victim()->WaitForExitWithTimeout(base::TimeDelta(), &exit_code));
EXPECT_EQ(content::RESULT_CODE_HUNG, exit_code);
}
|