1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
|
// Copyright 2020 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/safe_browsing/generated_safe_browsing_pref.h"
#include <algorithm>
#include "chrome/browser/extensions/api/settings_private/generated_pref_test_base.h"
#include "chrome/test/base/testing_profile.h"
#include "components/safe_browsing/core/common/safe_browsing_prefs.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
#include "content/public/test/browser_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace settings_api = extensions::api::settings_private;
namespace settings_private = extensions::settings_private;
namespace safe_browsing {
namespace {
// Sets the value of |generated_pref| to |pref_value| and then checks Safe
// Browsing preference values in |prefs| match the provided expected values.
// After preference has been set, the value of |generated_pref| is checked to
// ensure it has correctly updated to |pref_value|.
void ValidateGeneratedPrefSetting(
sync_preferences::TestingPrefServiceSyncable* prefs,
GeneratedSafeBrowsingPref* generated_pref,
SafeBrowsingSetting pref_value,
bool expected_safe_browsing_enabled,
bool expected_safe_browsing_enhanced) {
EXPECT_EQ(
generated_pref->SetPref(
std::make_unique<base::Value>(static_cast<int>(pref_value)).get()),
settings_private::SetPrefResult::SUCCESS);
EXPECT_EQ(prefs->GetUserPref(prefs::kSafeBrowsingEnabled)->GetBool(),
expected_safe_browsing_enabled);
EXPECT_EQ(prefs->GetUserPref(prefs::kSafeBrowsingEnhanced)->GetBool(),
expected_safe_browsing_enhanced);
EXPECT_EQ(static_cast<SafeBrowsingSetting>(
generated_pref->GetPrefObject().value->GetInt()),
pref_value);
}
// Define additional value for SafeBrowsingSetting to support testing a not
// set recommended value or not enforced value.
const SafeBrowsingSetting kNoRecommendedValue =
static_cast<SafeBrowsingSetting>(-1);
const SafeBrowsingSetting kNoEnforcedValue =
static_cast<SafeBrowsingSetting>(-2);
struct SafeBrowsingManagementTestCase {
settings_private::PrefSetting safe_browsing_enabled;
settings_private::PrefSetting safe_browsing_enhanced;
settings_private::PrefSetting safe_browsing_reporting;
settings_private::PrefSource enabled_enhanced_preference_source;
settings_private::PrefSource reporting_preference_source;
settings_api::ControlledBy expected_controlled_by;
settings_api::Enforcement expected_enforcement;
SafeBrowsingSetting expected_enforced_value;
SafeBrowsingSetting expected_recommended_value;
std::vector<SafeBrowsingSetting> expected_user_selectable_values;
};
const std::vector<SafeBrowsingManagementTestCase> kManagedTestCases = {
{settings_private::PrefSetting::kNotSet,
settings_private::PrefSetting::kNotSet,
settings_private::PrefSetting::kNotSet,
settings_private::PrefSource::kNone,
settings_private::PrefSource::kNone,
settings_api::ControlledBy::kNone,
settings_api::Enforcement::kNone,
kNoEnforcedValue,
kNoRecommendedValue,
{}},
{settings_private::PrefSetting::kEnforcedOn,
settings_private::PrefSetting::kEnforcedOn,
settings_private::PrefSetting::kNotSet,
settings_private::PrefSource::kExtension,
settings_private::PrefSource::kNone,
settings_api::ControlledBy::kExtension,
settings_api::Enforcement::kEnforced,
SafeBrowsingSetting::ENHANCED,
kNoRecommendedValue,
{}},
{settings_private::PrefSetting::kEnforcedOff,
settings_private::PrefSetting::kEnforcedOff,
settings_private::PrefSetting::kNotSet,
settings_private::PrefSource::kDevicePolicy,
settings_private::PrefSource::kNone,
settings_api::ControlledBy::kDevicePolicy,
settings_api::Enforcement::kEnforced,
SafeBrowsingSetting::DISABLED,
kNoRecommendedValue,
{}},
{settings_private::PrefSetting::kEnforcedOn,
settings_private::PrefSetting::kEnforcedOff,
settings_private::PrefSetting::kNotSet,
settings_private::PrefSource::kExtension,
settings_private::PrefSource::kNone,
settings_api::ControlledBy::kExtension,
settings_api::Enforcement::kEnforced,
SafeBrowsingSetting::STANDARD,
kNoRecommendedValue,
{}},
{settings_private::PrefSetting::kRecommendedOn,
settings_private::PrefSetting::kRecommendedOn,
settings_private::PrefSetting::kNotSet,
settings_private::PrefSource::kRecommended,
settings_private::PrefSource::kNone,
settings_api::ControlledBy::kNone,
settings_api::Enforcement::kRecommended,
kNoEnforcedValue,
SafeBrowsingSetting::ENHANCED,
{}},
{settings_private::PrefSetting::kRecommendedOn,
settings_private::PrefSetting::kRecommendedOff,
settings_private::PrefSetting::kNotSet,
settings_private::PrefSource::kRecommended,
settings_private::PrefSource::kNone,
settings_api::ControlledBy::kNone,
settings_api::Enforcement::kRecommended,
kNoEnforcedValue,
SafeBrowsingSetting::STANDARD,
{}},
{settings_private::PrefSetting::kRecommendedOff,
settings_private::PrefSetting::kRecommendedOff,
settings_private::PrefSetting::kNotSet,
settings_private::PrefSource::kRecommended,
settings_private::PrefSource::kNone,
settings_api::ControlledBy::kNone,
settings_api::Enforcement::kRecommended,
kNoEnforcedValue,
SafeBrowsingSetting::DISABLED,
{}},
{settings_private::PrefSetting::kNotSet,
settings_private::PrefSetting::kNotSet,
settings_private::PrefSetting::kEnforcedOff,
settings_private::PrefSource::kNone,
settings_private::PrefSource::kDevicePolicy,
settings_api::ControlledBy::kDevicePolicy,
settings_api::Enforcement::kEnforced,
kNoEnforcedValue,
kNoRecommendedValue,
{SafeBrowsingSetting::STANDARD, SafeBrowsingSetting::DISABLED}},
{settings_private::PrefSetting::kRecommendedOff,
settings_private::PrefSetting::kRecommendedOff,
settings_private::PrefSetting::kEnforcedOff,
settings_private::PrefSource::kRecommended,
settings_private::PrefSource::kDevicePolicy,
settings_api::ControlledBy::kDevicePolicy,
settings_api::Enforcement::kEnforced,
kNoEnforcedValue,
SafeBrowsingSetting::DISABLED,
{SafeBrowsingSetting::STANDARD, SafeBrowsingSetting::DISABLED}},
{settings_private::PrefSetting::kRecommendedOn,
settings_private::PrefSetting::kRecommendedOff,
settings_private::PrefSetting::kEnforcedOff,
settings_private::PrefSource::kRecommended,
settings_private::PrefSource::kDevicePolicy,
settings_api::ControlledBy::kDevicePolicy,
settings_api::Enforcement::kEnforced,
kNoEnforcedValue,
SafeBrowsingSetting::STANDARD,
{SafeBrowsingSetting::STANDARD, SafeBrowsingSetting::DISABLED}},
};
void SetupManagedTestConditions(
sync_preferences::TestingPrefServiceSyncable* prefs,
const SafeBrowsingManagementTestCase& test_case) {
extensions::settings_private::SetPrefFromSource(
prefs, prefs::kSafeBrowsingEnabled, test_case.safe_browsing_enabled,
test_case.enabled_enhanced_preference_source);
extensions::settings_private::SetPrefFromSource(
prefs, prefs::kSafeBrowsingEnhanced, test_case.safe_browsing_enhanced,
test_case.enabled_enhanced_preference_source);
extensions::settings_private::SetPrefFromSource(
prefs, prefs::kSafeBrowsingScoutReportingEnabled,
test_case.safe_browsing_reporting, test_case.reporting_preference_source);
}
void ValidateManagedPreference(
settings_api::PrefObject& pref,
const SafeBrowsingManagementTestCase& test_case) {
EXPECT_EQ(pref.controlled_by, test_case.expected_controlled_by);
EXPECT_EQ(pref.enforcement, test_case.expected_enforcement);
if (test_case.expected_enforced_value != kNoEnforcedValue) {
EXPECT_EQ(static_cast<SafeBrowsingSetting>(pref.value->GetInt()),
test_case.expected_enforced_value);
}
if (test_case.expected_recommended_value == kNoRecommendedValue) {
EXPECT_FALSE(pref.recommended_value);
} else {
EXPECT_EQ(
static_cast<SafeBrowsingSetting>(pref.recommended_value->GetInt()),
test_case.expected_recommended_value);
}
// Ensure the user selectable values for the preference are correct.
std::vector<SafeBrowsingSetting> pref_user_selectable_values;
if (pref.user_selectable_values) {
for (const auto& value : *pref.user_selectable_values) {
pref_user_selectable_values.push_back(
static_cast<SafeBrowsingSetting>(value.GetInt()));
}
}
EXPECT_TRUE(std::ranges::equal(pref_user_selectable_values,
test_case.expected_user_selectable_values));
}
} // namespace
typedef settings_private::GeneratedPrefTestBase GeneratedSafeBrowsingPrefTest;
TEST_F(GeneratedSafeBrowsingPrefTest, UpdatePreference) {
// Validate that the generated Safe Browsing preference correctly updates
// the base Safe Browsing preferences.
auto pref = std::make_unique<GeneratedSafeBrowsingPref>(profile());
// Setup baseline profile preference state.
prefs()->SetDefaultPrefValue(prefs::kSafeBrowsingEnabled, base::Value(false));
prefs()->SetDefaultPrefValue(prefs::kSafeBrowsingEnhanced,
base::Value(false));
// Check all possible settings both correctly update preferences and are
// correctly returned by the generated preference.
ValidateGeneratedPrefSetting(prefs(), pref.get(),
SafeBrowsingSetting::ENHANCED,
/* enabled */ true, /* enhanced */ true);
ValidateGeneratedPrefSetting(prefs(), pref.get(),
SafeBrowsingSetting::STANDARD,
/* enabled */ true, /* enhanced */ false);
ValidateGeneratedPrefSetting(prefs(), pref.get(),
SafeBrowsingSetting::DISABLED,
/* enabled */ false, /* enhanced */ false);
// Confirm that a type mismatch is reported as such.
EXPECT_EQ(pref->SetPref(std::make_unique<base::Value>(true).get()),
settings_private::SetPrefResult::PREF_TYPE_MISMATCH);
// Check a numerical value outside of the acceptable range.
EXPECT_EQ(
pref->SetPref(std::make_unique<base::Value>(
static_cast<int>(SafeBrowsingSetting::DISABLED) + 1)
.get()),
settings_private::SetPrefResult::PREF_TYPE_MISMATCH);
// Confirm when SBER is forcefully disabled, setting the preference to
// enhanced is reported as invalid.
prefs()->SetManagedPref(prefs::kSafeBrowsingScoutReportingEnabled,
std::make_unique<base::Value>(false));
EXPECT_EQ(pref->SetPref(std::make_unique<base::Value>(
static_cast<int>(SafeBrowsingSetting::ENHANCED))
.get()),
settings_private::SetPrefResult::PREF_NOT_MODIFIABLE);
}
TEST_F(GeneratedSafeBrowsingPrefTest, NotifyPrefUpdates) {
// Update source Safe Browsing preferences and ensure an observer is fired.
auto pref = std::make_unique<GeneratedSafeBrowsingPref>(profile());
settings_private::TestGeneratedPrefObserver test_observer;
pref->AddObserver(&test_observer);
prefs()->SetUserPref(prefs::kSafeBrowsingEnabled,
std::make_unique<base::Value>(true));
EXPECT_EQ(test_observer.GetUpdatedPrefName(), kGeneratedSafeBrowsingPref);
test_observer.Reset();
prefs()->SetUserPref(prefs::kSafeBrowsingEnhanced,
std::make_unique<base::Value>(true));
EXPECT_EQ(test_observer.GetUpdatedPrefName(), kGeneratedSafeBrowsingPref);
test_observer.Reset();
prefs()->SetUserPref(prefs::kSafeBrowsingScoutReportingEnabled,
std::make_unique<base::Value>(true));
EXPECT_EQ(test_observer.GetUpdatedPrefName(), kGeneratedSafeBrowsingPref);
test_observer.Reset();
}
TEST_F(GeneratedSafeBrowsingPrefTest, ManagementState) {
for (const auto& test_case : kManagedTestCases) {
TestingProfile profile;
testing::Message scope_message;
scope_message << "Enabled:"
<< static_cast<int>(test_case.safe_browsing_enabled)
<< " Enhanced:"
<< static_cast<int>(test_case.safe_browsing_enhanced)
<< " Reporting:"
<< static_cast<int>(test_case.safe_browsing_reporting);
SCOPED_TRACE(scope_message);
SetupManagedTestConditions(profile.GetTestingPrefService(), test_case);
auto pref = std::make_unique<GeneratedSafeBrowsingPref>(&profile);
auto pref_object = pref->GetPrefObject();
ValidateManagedPreference(pref_object, test_case);
}
}
} // namespace safe_browsing
|
