1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/autofill/autofill_client_provider.h"
#include <memory>
#include "base/test/metrics/histogram_tester.h"
#include "base/test/mock_callback.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/autofill/android/android_autofill_availability_status.h"
#include "chrome/browser/ui/autofill/autofill_client_provider_factory.h"
#include "chrome/test/base/testing_profile.h"
#include "components/autofill/content/browser/test_content_autofill_client.h"
#include "components/autofill/core/common/autofill_features.h"
#include "components/autofill/core/common/autofill_prefs.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
#include "components/prefs/pref_service.h"
#include "content/public/test/browser_task_environment.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace autofill {
namespace {
#if BUILDFLAG(IS_ANDROID)
constexpr const char* kAvailabilityMetric =
"Autofill.AndroidAutofillAvailabilityStatus";
constexpr const char* kResetPrefMetric = "Autofill.ResetAutofillPrefToChrome";
#endif // BUILDFLAG(IS_ANDROID)
class AutofillClientProviderBaseTest : public testing::Test {
public:
void SetUp() override { profile_ = std::make_unique<TestingProfile>(); }
void TearDown() override {
profile_.reset(); // Important since it also resets the prefs.
}
TestingProfile* profile() { return profile_.get(); }
AutofillClientProvider& provider() {
return AutofillClientProviderFactory::GetForProfile(profile());
}
PrefService* prefs() { return profile()->GetPrefs(); }
private:
content::BrowserTaskEnvironment task_environment_;
std::unique_ptr<TestingProfile> profile_;
};
TEST_F(AutofillClientProviderBaseTest, ProvidesServiceInNonIncognito) {
AutofillClientProviderFactory::GetForProfile(profile());
}
TEST_F(AutofillClientProviderBaseTest, ProvidesServiceInIncognito) {
AutofillClientProviderFactory::GetForProfile(
profile()->GetOffTheRecordProfile(
Profile::OTRProfileID::CreateUniqueForTesting(), true));
}
TEST_F(AutofillClientProviderBaseTest, ProvidesNoServiceWithoutProfile) {
ASSERT_DEATH(AutofillClientProviderFactory::GetForProfile(nullptr), "");
}
TEST_F(AutofillClientProviderBaseTest, UsesBuiltInAutofillForDisabledPref) {
#if BUILDFLAG(IS_ANDROID)
// Independent of platform or feature, a disabled pref means Chrome fills.
prefs()->SetBoolean(prefs::kAutofillUsingVirtualViewStructure, false);
#endif // BUILDFLAG(IS_ANDROID)
EXPECT_FALSE(provider().uses_platform_autofill());
}
#if BUILDFLAG(IS_ANDROID)
class AutofillClientProviderLegacyTest : public AutofillClientProviderBaseTest {
public:
void SetUp() override {
AutofillClientProviderBaseTest::SetUp();
scoped_feature_list_.InitAndDisableFeature(
features::kAutofillVirtualViewStructureAndroid);
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
TEST_F(AutofillClientProviderLegacyTest, AlwaysCreatesChromeClient) {
base::HistogramTester histogram_tester;
// The pref is irrelevant if the feature is disabled.
prefs()->SetBoolean(prefs::kAutofillUsingVirtualViewStructure, true);
EXPECT_FALSE(provider().uses_platform_autofill());
histogram_tester.ExpectUniqueSample(
kAvailabilityMetric, AndroidAutofillAvailabilityStatus::kSettingTurnedOff,
1);
}
class AutofillClientProviderTest : public AutofillClientProviderBaseTest {
public:
AutofillClientProviderTest() {
scoped_feature_list_.InitAndEnableFeatureWithParameters(
features::kAutofillVirtualViewStructureAndroid,
{{features::kAutofillVirtualViewStructureAndroidSkipsCompatibilityCheck
.name,
"skip_all_checks"}});
}
private:
base::test::ScopedFeatureList scoped_feature_list_;
};
TEST_F(AutofillClientProviderTest, CreateAndroidClientForEnabledPref) {
base::HistogramTester histogram_tester;
prefs()->SetBoolean(prefs::kAutofillUsingVirtualViewStructure, true);
EXPECT_TRUE(provider().uses_platform_autofill());
// A changing pref doesn't change the clients for new tabs:
prefs()->SetBoolean(prefs::kAutofillUsingVirtualViewStructure, false);
EXPECT_TRUE(provider().uses_platform_autofill());
// The pref is used as is and not reset. (Availability metric is skewed by
// trybot config, so don't assume it's available.)
histogram_tester.ExpectUniqueSample(kResetPrefMetric, false, 1);
}
TEST_F(AutofillClientProviderTest, CreateChromeClientIfPolicyDisabled) {
base::HistogramTester histogram_tester;
prefs()->SetBoolean(prefs::kAutofillThirdPartyPasswordManagersAllowed, false);
// The general pref may be set but it's ineffective if a policy overrides it.
prefs()->SetBoolean(prefs::kAutofillUsingVirtualViewStructure, true);
EXPECT_FALSE(provider().uses_platform_autofill());
histogram_tester.ExpectUniqueSample(kResetPrefMetric, true, 1);
// Check that the pref was reset.
EXPECT_FALSE(prefs()->GetBoolean(prefs::kAutofillUsingVirtualViewStructure));
histogram_tester.ExpectUniqueSample(
kAvailabilityMetric,
AndroidAutofillAvailabilityStatus::kNotAllowedByPolicy, 1);
}
#endif // BUILDFLAG(IS_ANDROID)
} // namespace
} // namespace autofill
|
