1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677
|
// Copyright 2012 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/browser_command_controller.h"
#include <array>
#include "base/command_line.h"
#include "base/memory/raw_ptr.h"
#include "base/test/run_until.h"
#include "base/test/scoped_feature_list.h"
#include "build/branding_buildflags.h"
#include "build/build_config.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/command_updater.h"
#include "chrome/browser/prefs/incognito_mode_prefs.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/profiles/profiles_state.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_window_state.h"
#include "chrome/browser/ui/exclusive_access/exclusive_access_context.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/pref_names.h"
#include "chrome/test/base/browser_with_test_window_test.h"
#include "chrome/test/base/test_browser_window.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile_manager.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/input/native_web_keyboard_event.h"
#include "components/performance_manager/public/features.h"
#include "components/policy/core/common/policy_pref_names.h"
#include "components/signin/public/base/signin_pref_names.h"
#include "content/public/test/web_contents_tester.h"
#include "extensions/buildflags/buildflags.h"
#include "ui/events/keycodes/dom/dom_code.h"
#include "ui/events/keycodes/keyboard_codes.h"
#if ((BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_WIN)) && \
BUILDFLAG(ENABLE_EXTENSIONS))
#include "base/memory/scoped_refptr.h"
#include "chrome/browser/extensions/test_extension_system.h"
#include "extensions/browser/extension_registrar.h"
#include "extensions/browser/extension_system.h"
#include "extensions/common/extension_builder.h"
#endif // ((BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_WIN)) &&
// BUILDFLAG(ENABLE_EXTENSIONS))
#if BUILDFLAG(ENABLE_GLIC)
#include "chrome/common/chrome_features.h"
#endif
class BrowserCommandControllerTest : public BrowserWithTestWindowTest {
public:
BrowserCommandControllerTest() = default;
};
TEST_F(BrowserCommandControllerTest, IsReservedCommandOrKey) {
#if BUILDFLAG(IS_CHROMEOS)
// F1-3 keys are reserved Chrome accelerators on Chrome OS.
EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_BACK, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_BROWSER_BACK,
ui::DomCode::BROWSER_BACK, 0))));
EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_FORWARD, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_BROWSER_FORWARD,
ui::DomCode::BROWSER_FORWARD, 0))));
EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_RELOAD, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_BROWSER_REFRESH,
ui::DomCode::BROWSER_REFRESH, 0))));
// When there are modifier keys pressed, don't reserve.
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_RELOAD_BYPASSING_CACHE, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F3,
ui::DomCode::F3, ui::EF_SHIFT_DOWN))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_RELOAD_BYPASSING_CACHE, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F3,
ui::DomCode::F3, ui::EF_CONTROL_DOWN))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_FULLSCREEN, input::NativeWebKeyboardEvent(
ui::KeyEvent(ui::EventType::kKeyPressed, ui::VKEY_F4,
ui::DomCode::F4, ui::EF_SHIFT_DOWN))));
// F4-10 keys are not reserved since they are Ash accelerators.
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
-1, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F4, ui::DomCode::F4, 0))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
-1, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F5, ui::DomCode::F5, 0))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
-1, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F6, ui::DomCode::F6, 0))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
-1, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F7, ui::DomCode::F7, 0))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
-1, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F8, ui::DomCode::F8, 0))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
-1, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F9, ui::DomCode::F9, 0))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
-1, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F10, ui::DomCode::F10, 0))));
// Shift+Control+Alt+F3 is also an Ash accelerator. Don't reserve it.
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
-1, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F3, ui::DomCode::F3,
ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN))));
#endif // BUILDFLAG(IS_CHROMEOS)
#if defined(USE_AURA)
// Ctrl+n, Ctrl+w are reserved while Ctrl+f is not.
// The input::NativeWebKeyboardEvent constructor is available only when
// USE_AURA is #defined.
EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_NEW_WINDOW, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_N,
ui::DomCode::US_N, ui::EF_CONTROL_DOWN))));
EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_CLOSE_TAB, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_W,
ui::DomCode::US_W, ui::EF_CONTROL_DOWN))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_FIND, input::NativeWebKeyboardEvent(
ui::KeyEvent(ui::EventType::kKeyPressed, ui::VKEY_F,
ui::DomCode::US_F, ui::EF_CONTROL_DOWN))));
#endif // USE_AURA
}
TEST_F(BrowserCommandControllerTest, IsReservedCommandOrKeyIsApp) {
Browser::CreateParams params = Browser::CreateParams::CreateForApp(
"app",
/*trusted_source=*/true, browser()->window()->GetBounds(), profile(),
/*user_gesture=*/true);
params.window = browser()->window();
set_browser(Browser::Create(params));
ASSERT_TRUE(browser()->is_type_app());
// When is_type_app(), no keys are reserved.
#if BUILDFLAG(IS_CHROMEOS)
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_BACK,
input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F1, ui::DomCode::F1, 0))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_FORWARD,
input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F2, ui::DomCode::F2, 0))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_RELOAD,
input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F3, ui::DomCode::F3, 0))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
-1, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_F4, ui::DomCode::F4, 0))));
#endif // BUILDFLAG(IS_CHROMEOS)
#if defined(USE_AURA)
// The input::NativeWebKeyboardEvent constructor is available only when
// USE_AURA is #defined.
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_NEW_WINDOW, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_N,
ui::DomCode::US_N, ui::EF_CONTROL_DOWN))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_CLOSE_TAB, input::NativeWebKeyboardEvent(ui::KeyEvent(
ui::EventType::kKeyPressed, ui::VKEY_W,
ui::DomCode::US_W, ui::EF_CONTROL_DOWN))));
EXPECT_FALSE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_FIND, input::NativeWebKeyboardEvent(
ui::KeyEvent(ui::EventType::kKeyPressed, ui::VKEY_F,
ui::DomCode::US_F, ui::EF_CONTROL_DOWN))));
#endif // USE_AURA
}
TEST_F(BrowserWithTestWindowTest, IncognitoCommands) {
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_PERFORMANCE));
TestingProfile* testprofile = browser()->profile()->AsTestingProfile();
EXPECT_TRUE(testprofile);
testprofile->SetGuestSession(true);
chrome::BrowserCommandController ::
UpdateSharedCommandsForIncognitoAvailability(
browser()->command_controller(), testprofile);
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_PERFORMANCE));
testprofile->SetGuestSession(false);
IncognitoModePrefs::SetAvailability(
browser()->profile()->GetPrefs(),
policy::IncognitoModeAvailability::kForced);
chrome::BrowserCommandController ::
UpdateSharedCommandsForIncognitoAvailability(
browser()->command_controller(), testprofile);
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_PERFORMANCE));
}
TEST_F(BrowserCommandControllerTest, AppFullScreen) {
// Enable for tabbed browser.
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
// Enabled for app windows.
Browser::CreateParams params = Browser::CreateParams::CreateForApp(
"app",
/*trusted_source=*/true, browser()->window()->GetBounds(), profile(),
/*user_gesture=*/true);
params.window = browser()->window();
set_browser(Browser::Create(params));
ASSERT_TRUE(browser()->is_type_app());
browser()->command_controller()->FullscreenStateChanged();
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_FULLSCREEN));
}
TEST_F(BrowserCommandControllerTest, AvatarAcceleratorEnabledOnDesktop) {
if (!profiles::IsMultipleProfilesEnabled()) {
return;
}
TestingProfileManager* testing_profile_manager = profile_manager();
ProfileManager* profile_manager = testing_profile_manager->profile_manager();
chrome::BrowserCommandController command_controller(browser());
const CommandUpdater* command_updater = &command_controller;
// Chrome OS uses system tray menu to handle multi-profiles.
bool enabled = !BUILDFLAG(IS_CHROMEOS);
ASSERT_EQ(1u, profile_manager->GetNumberOfProfiles());
EXPECT_EQ(enabled, command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
testing_profile_manager->CreateTestingProfile("p2");
ASSERT_EQ(2u, profile_manager->GetNumberOfProfiles());
EXPECT_EQ(enabled, command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
testing_profile_manager->DeleteTestingProfile("p2");
ASSERT_EQ(1u, profile_manager->GetNumberOfProfiles());
EXPECT_EQ(enabled, command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
}
TEST_F(BrowserCommandControllerTest, AvatarMenuAlwaysEnabledInIncognitoMode) {
// Set up a profile with an off the record profile.
TestingProfile::Builder normal_builder;
std::unique_ptr<TestingProfile> original_profile = normal_builder.Build();
// Create a new browser based on the off the record profile.
Browser::CreateParams profile_params(
original_profile->GetPrimaryOTRProfile(/*create_if_needed=*/true), true);
std::unique_ptr<Browser> otr_browser(
CreateBrowserWithTestWindowForParams(profile_params));
chrome::BrowserCommandController command_controller(otr_browser.get());
const CommandUpdater* command_updater = &command_controller;
// The avatar menu should be enabled.
EXPECT_TRUE(command_updater->IsCommandEnabled(IDC_SHOW_AVATAR_MENU));
// The command line is reset at the end of every test by the test suite.
}
//////////////////////////////////////////////////////////////////////////////
class BrowserCommandControllerFullscreenTest;
// A test browser window that can toggle fullscreen state.
class FullscreenTestBrowserWindow : public TestBrowserWindow,
ExclusiveAccessContext {
public:
explicit FullscreenTestBrowserWindow(
BrowserCommandControllerFullscreenTest* test_browser)
: test_browser_(test_browser) {}
FullscreenTestBrowserWindow(const FullscreenTestBrowserWindow&) = delete;
FullscreenTestBrowserWindow& operator=(const FullscreenTestBrowserWindow&) =
delete;
~FullscreenTestBrowserWindow() override = default;
// TestBrowserWindow overrides:
bool ShouldHideUIForFullscreen() const override { return fullscreen_; }
bool IsFullscreen() const override { return fullscreen_; }
void EnterFullscreen(const url::Origin& origin,
ExclusiveAccessBubbleType type,
int64_t display_id) override {
fullscreen_ = true;
}
void ExitFullscreen() override { fullscreen_ = false; }
bool IsToolbarShowing() const override { return toolbar_showing_; }
bool IsLocationBarVisible() const override { return true; }
ExclusiveAccessContext* GetExclusiveAccessContext() override { return this; }
// Exclusive access interface:
Profile* GetProfile() override;
content::WebContents* GetWebContentsForExclusiveAccess() override;
void UpdateExclusiveAccessBubble(
const ExclusiveAccessBubbleParams& params,
ExclusiveAccessBubbleHideCallback first_hide_callback) override {}
bool IsExclusiveAccessBubbleDisplayed() const override { return false; }
void OnExclusiveAccessUserInput() override {}
bool CanUserEnterFullscreen() const override { return true; }
bool CanUserExitFullscreen() const override { return true; }
void set_toolbar_showing(bool showing) { toolbar_showing_ = showing; }
private:
bool fullscreen_ = false;
bool toolbar_showing_ = false;
raw_ptr<BrowserCommandControllerFullscreenTest> test_browser_;
};
// Test that uses FullscreenTestBrowserWindow for its window.
class BrowserCommandControllerFullscreenTest
: public BrowserWithTestWindowTest {
public:
BrowserCommandControllerFullscreenTest() = default;
BrowserCommandControllerFullscreenTest(
const BrowserCommandControllerFullscreenTest&) = delete;
BrowserCommandControllerFullscreenTest& operator=(
const BrowserCommandControllerFullscreenTest&) = delete;
~BrowserCommandControllerFullscreenTest() override = default;
Browser* GetBrowser() { return BrowserWithTestWindowTest::browser(); }
// BrowserWithTestWindowTest overrides:
std::unique_ptr<BrowserWindow> CreateBrowserWindow() override {
return std::make_unique<FullscreenTestBrowserWindow>(this);
}
};
Profile* FullscreenTestBrowserWindow::GetProfile() {
return test_browser_->GetBrowser()->profile();
}
content::WebContents*
FullscreenTestBrowserWindow::GetWebContentsForExclusiveAccess() {
return test_browser_->GetBrowser()->tab_strip_model()->GetActiveWebContents();
}
TEST_F(BrowserCommandControllerFullscreenTest,
UpdateCommandsForFullscreenMode) {
struct Commands {
int command_id;
// Whether the command is enabled in tab mode.
bool enabled_in_tab;
// Whether the keyboard shortcut is reserved in tab mode.
bool reserved_in_tab;
// Whether the command is enabled in fullscreen mode.
bool enabled_in_fullscreen;
// Whether the keyboard shortcut is reserved in fullscreen mode.
bool reserved_in_fullscreen;
};
auto commands = std::to_array<Commands>({
// 1. Most commands are disabled in fullscreen.
// 2. In fullscreen, only the exit fullscreen commands are reserved. All
// other shortcuts should be delivered to the web page. See
// http://crbug.com/680809.
// Command ID | tab mode | fullscreen |
// | enabled | reserved | enabled | reserved |
// clang-format off
{ IDC_OPEN_CURRENT_URL, true, false, false, false },
{ IDC_FOCUS_TOOLBAR, true, false, false, false },
{ IDC_FOCUS_LOCATION, true, false, false, false },
{ IDC_FOCUS_SEARCH, true, false, false, false },
{ IDC_FOCUS_MENU_BAR, true, false, false, false },
{ IDC_FOCUS_NEXT_PANE, true, false, false, false },
{ IDC_FOCUS_PREVIOUS_PANE, true, false, false, false },
{ IDC_FOCUS_BOOKMARKS, true, false, false, false },
{ IDC_DEVELOPER_MENU, true, false, false, false },
#if BUILDFLAG(GOOGLE_CHROME_BRANDING)
{ IDC_FEEDBACK, true, false, false, false },
#endif
{ IDC_OPTIONS, true, false, false, false },
{ IDC_IMPORT_SETTINGS, true, false, false, false },
{ IDC_EDIT_SEARCH_ENGINES, true, false, false, false },
{ IDC_VIEW_PASSWORDS, true, false, false, false },
{ IDC_ABOUT, true, false, false, false },
{ IDC_SHOW_APP_MENU, true, false, false, false },
{ IDC_FULLSCREEN, true, false, true, true },
{ IDC_CLOSE_TAB, true, true, true, false },
{ IDC_CLOSE_WINDOW, true, true, true, false },
{ IDC_NEW_INCOGNITO_WINDOW, true, true, true, false },
{ IDC_NEW_TAB, true, true, true, false },
{ IDC_NEW_WINDOW, true, true, true, false },
{ IDC_SELECT_NEXT_TAB, true, true, true, false },
{ IDC_SELECT_PREVIOUS_TAB, true, true, true, false },
{ IDC_EXIT, true, true, true, true },
{ IDC_SHOW_AS_TAB, false, false, false, false },
// clang-format on
});
const input::NativeWebKeyboardEvent key_event(
blink::WebInputEvent::Type::kUndefined, 0,
blink::WebInputEvent::GetStaticTimeStampForTests());
// Defaults for a tabbed browser.
for (auto& command : commands) {
SCOPED_TRACE(command.command_id);
EXPECT_EQ(chrome::IsCommandEnabled(browser(), command.command_id),
command.enabled_in_tab);
EXPECT_EQ(browser()->command_controller()->IsReservedCommandOrKey(
command.command_id, key_event),
command.reserved_in_tab);
}
// Simulate going fullscreen.
chrome::ToggleFullscreenMode(browser());
ASSERT_TRUE(browser()->window()->IsFullscreen());
browser()->command_controller()->FullscreenStateChanged();
// By default, in fullscreen mode, the toolbar should be hidden; and all
// platforms behave similarly.
EXPECT_FALSE(window()->IsToolbarShowing());
for (auto& command : commands) {
SCOPED_TRACE(command.command_id);
EXPECT_EQ(chrome::IsCommandEnabled(browser(), command.command_id),
command.enabled_in_fullscreen);
EXPECT_EQ(browser()->command_controller()->IsReservedCommandOrKey(
command.command_id, key_event),
command.reserved_in_fullscreen);
}
#if BUILDFLAG(IS_MAC)
// When the toolbar is showing, commands should be reserved as if the content
// were in a tab; IDC_FULLSCREEN should also be reserved.
static_cast<FullscreenTestBrowserWindow*>(window())->set_toolbar_showing(
true);
EXPECT_TRUE(browser()->command_controller()->IsReservedCommandOrKey(
IDC_FULLSCREEN, key_event));
for (size_t i = 0; i < std::size(commands); i++) {
if (commands[i].command_id != IDC_FULLSCREEN) {
SCOPED_TRACE(commands[i].command_id);
EXPECT_EQ(browser()->command_controller()->IsReservedCommandOrKey(
commands[i].command_id, key_event),
commands[i].reserved_in_tab);
}
}
// Return to default state.
static_cast<FullscreenTestBrowserWindow*>(window())->set_toolbar_showing(
false);
#endif
// Exit fullscreen.
chrome::ToggleFullscreenMode(browser());
ASSERT_FALSE(browser()->window()->IsFullscreen());
browser()->command_controller()->FullscreenStateChanged();
for (auto& command : commands) {
SCOPED_TRACE(command.command_id);
EXPECT_EQ(chrome::IsCommandEnabled(browser(), command.command_id),
command.enabled_in_tab);
EXPECT_EQ(browser()->command_controller()->IsReservedCommandOrKey(
command.command_id, key_event),
command.reserved_in_tab);
}
// Guest Profiles disallow some options.
TestingProfile* testprofile = browser()->profile()->AsTestingProfile();
EXPECT_TRUE(testprofile);
testprofile->SetGuestSession(true);
browser()->command_controller()->FullscreenStateChanged();
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_IMPORT_SETTINGS));
}
// Ensure that the logic for enabling IDC_OPTIONS is consistent, regardless of
// the order of entering fullscreen and forced incognito modes. See
// http://crbug.com/694331.
TEST_F(BrowserWithTestWindowTest, OptionsConsistency) {
TestingProfile* profile = browser()->profile()->AsTestingProfile();
// Setup guest session.
profile->SetGuestSession(true);
// Setup forced incognito mode.
IncognitoModePrefs::SetAvailability(
browser()->profile()->GetPrefs(),
policy::IncognitoModeAvailability::kForced);
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
// Enter fullscreen.
browser()->command_controller()->FullscreenStateChanged();
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
// Exit fullscreen
browser()->command_controller()->FullscreenStateChanged();
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
// Reenter incognito mode, this should trigger
// UpdateSharedCommandsForIncognitoAvailability() again.
IncognitoModePrefs::SetAvailability(
browser()->profile()->GetPrefs(),
policy::IncognitoModeAvailability::kDisabled);
IncognitoModePrefs::SetAvailability(
browser()->profile()->GetPrefs(),
policy::IncognitoModeAvailability::kForced);
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_OPTIONS));
}
TEST_F(BrowserCommandControllerTest,
SavePageDisabledByDownloadRestrictionsPolicy) {
chrome::BrowserCommandController command_controller(browser());
const CommandUpdater* command_updater = &command_controller;
EXPECT_TRUE(command_updater->IsCommandEnabled(IDC_SAVE_PAGE));
profile()->GetPrefs()->SetInteger(policy::policy_prefs::kDownloadRestrictions,
3 /*ALL_FILES*/);
EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_SAVE_PAGE));
}
TEST_F(BrowserCommandControllerTest,
SavePageDisabledByAllowFileSelectionDialogsPolicy) {
chrome::BrowserCommandController command_controller(browser());
const CommandUpdater* command_updater = &command_controller;
EXPECT_TRUE(command_updater->IsCommandEnabled(IDC_SAVE_PAGE));
g_browser_process->local_state()->SetBoolean(
prefs::kAllowFileSelectionDialogs, false);
EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_SAVE_PAGE));
}
TEST_F(BrowserWithTestWindowTest, ClearBrowsingDataIsEnabledInIncognito) {
// Set up a profile with an off the record profile.
std::unique_ptr<TestingProfile> profile1 = TestingProfile::Builder().Build();
Profile* incognito_profile =
profile1->GetPrimaryOTRProfile(/*create_if_needed=*/true);
EXPECT_EQ(incognito_profile->GetOriginalProfile(), profile1.get());
// Create a new browser based on the off the record profile.
Browser::CreateParams profile_params(incognito_profile, true);
std::unique_ptr<Browser> incognito_browser =
CreateBrowserWithTestWindowForParams(profile_params);
chrome::BrowserCommandController command_controller(incognito_browser.get());
EXPECT_EQ(true, command_controller.IsCommandEnabled(IDC_CLEAR_BROWSING_DATA));
}
class BrowserCommandControllerWithBookmarksTest
: public BrowserCommandControllerTest {
public:
BrowserCommandControllerWithBookmarksTest() = default;
// BrowserWithTestWindowTest overrides:
TestingProfile::TestingFactories GetTestingFactories() override {
return {TestingProfile::TestingFactory{
BookmarkModelFactory::GetInstance(),
BookmarkModelFactory::GetDefaultFactory()}};
}
void AddTab() {
std::unique_ptr<content::WebContents> contents(
content::WebContentsTester::CreateTestWebContents(profile(), nullptr));
browser()->tab_strip_model()->AppendWebContents(std::move(contents),
/*foreground=*/false);
}
};
// Adding and removing background tabs should update the bookmark all tab
// command.
TEST_F(BrowserCommandControllerWithBookmarksTest,
BookmarkAllTabsUpdatesOnTabStripChanges) {
ASSERT_TRUE(base::test::RunUntil([&]() {
return BookmarkModelFactory::GetForBrowserContext(profile())->loaded();
})) << "Timeout waiting for bookmarks to load";
chrome::BrowserCommandController command_controller(browser());
EXPECT_FALSE(command_controller.IsCommandEnabled(IDC_BOOKMARK_ALL_TABS));
AddTab();
ASSERT_EQ(1, browser()->tab_strip_model()->count());
browser()->tab_strip_model()->ActivateTabAt(/*index=*/0);
EXPECT_FALSE(command_controller.IsCommandEnabled(IDC_BOOKMARK_ALL_TABS));
AddTab();
ASSERT_EQ(2, browser()->tab_strip_model()->count());
EXPECT_TRUE(command_controller.IsCommandEnabled(IDC_BOOKMARK_ALL_TABS));
browser()->tab_strip_model()->CloseWebContentsAt(/*index=*/1,
TabCloseTypes::CLOSE_NONE);
EXPECT_FALSE(command_controller.IsCommandEnabled(IDC_BOOKMARK_ALL_TABS));
}
#if BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_WIN)
class CreateShortcutBrowserCommandControllerTest
: public BrowserCommandControllerTest {
public:
CreateShortcutBrowserCommandControllerTest() = default;
#if BUILDFLAG(ENABLE_EXTENSIONS)
scoped_refptr<const extensions::Extension> CreateAndInstallExtension() {
scoped_refptr<const extensions::Extension> extension =
extensions::ExtensionBuilder("ext").Build();
CHECK(extension);
// Simulate installing the extension.
extensions::TestExtensionSystem* extension_system =
static_cast<extensions::TestExtensionSystem*>(
extensions::ExtensionSystem::Get(browser()->profile()));
extension_system->CreateExtensionService(
base::CommandLine::ForCurrentProcess(),
/*install_directory=*/base::FilePath(), /*autoupdate_enabled=*/false);
extensions::ExtensionRegistrar::Get(browser()->profile())
->AddExtension(extension);
return extension;
}
#endif // BUILDFLAG(ENABLE_EXTENSIONS)
};
TEST_F(CreateShortcutBrowserCommandControllerTest, BrowserNoSiteNotEnabled) {
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_CREATE_SHORTCUT));
}
TEST_F(CreateShortcutBrowserCommandControllerTest, DisabledForOTRProfile) {
// Set up a profile with an off the record profile.
std::unique_ptr<TestingProfile> profile1 = TestingProfile::Builder().Build();
Profile* incognito_profile =
profile1->GetPrimaryOTRProfile(/*create_if_needed=*/true);
EXPECT_EQ(incognito_profile->GetOriginalProfile(), profile1.get());
// Create a new browser based on the off the record profile.
Browser::CreateParams profile_params(incognito_profile, true);
std::unique_ptr<Browser> incognito_browser =
CreateBrowserWithTestWindowForParams(profile_params);
EXPECT_FALSE(
chrome::IsCommandEnabled(incognito_browser.get(), IDC_CREATE_SHORTCUT));
}
TEST_F(CreateShortcutBrowserCommandControllerTest, DisabledForGuestProfile) {
TestingProfile* test_profile = browser()->profile()->AsTestingProfile();
EXPECT_TRUE(test_profile);
test_profile->SetGuestSession(true);
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_CREATE_SHORTCUT));
}
TEST_F(CreateShortcutBrowserCommandControllerTest, DisabledForSystemProfile) {
TestingProfile* test_profile = browser()->profile()->AsTestingProfile();
EXPECT_TRUE(test_profile);
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_CREATE_SHORTCUT));
}
TEST_F(CreateShortcutBrowserCommandControllerTest, EnabledValidUrl) {
AddTab(browser(), GURL("https://example.com"));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_CREATE_SHORTCUT));
}
TEST_F(CreateShortcutBrowserCommandControllerTest, InvalidSchemeDisabled) {
AddTab(browser(), GURL("abc://apps"));
EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_CREATE_SHORTCUT));
}
#if BUILDFLAG(ENABLE_EXTENSIONS)
TEST_F(CreateShortcutBrowserCommandControllerTest,
ChromeExtensionSchemeEnabled) {
const char kResource[] = "resource.html";
scoped_refptr<const extensions::Extension> extension =
CreateAndInstallExtension();
AddTab(browser(), extension->GetResourceURL(kResource));
EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_CREATE_SHORTCUT));
}
#endif // BUILDFLAG(ENABLE_EXTENSIONS)
#endif // BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_WIN)
|