1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
|
// Copyright 2019 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/browser_tab_strip_model_delegate.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_list.h"
#include "chrome/browser/ui/tabs/saved_tab_groups/saved_tab_group_utils.h"
#include "chrome/browser/ui/tabs/tab_group_model.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/tabs/tab_utils.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "chrome/test/base/ui_test_utils.h"
#include "components/saved_tab_groups/public/features.h"
#include "content/public/test/browser_test.h"
#include "net/dns/mock_host_resolver.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
namespace chrome {
using BrowserTabStripModelDelegateTest = InProcessBrowserTest;
class BrowserTabStripModelDelegateWithEmbeddedServerTest
: public BrowserTabStripModelDelegateTest {
public:
void SetUpOnMainThread() override {
BrowserTabStripModelDelegateTest::SetUpOnMainThread();
embedded_test_server()->ServeFilesFromDirectory(
base::FilePath{base::FilePath::kCurrentDirectory});
ASSERT_TRUE(embedded_test_server()->Start());
host_resolver()->AddRule("example.com", "127.0.0.1");
}
void ToggleMute(Browser* browser) {
int active_index = browser->tab_strip_model()->active_index();
browser->tab_strip_model()->ExecuteContextMenuCommand(
active_index,
TabStripModel::ContextMenuCommand::CommandToggleSiteMuted);
}
void VerifyMute(Browser* browser, bool isMuted) {
int active_index = browser->tab_strip_model()->active_index();
EXPECT_EQ(isMuted, IsSiteMuted(*browser->tab_strip_model(), active_index));
}
};
// Tests the "Move Tab to New Window" tab context menu command.
IN_PROC_BROWSER_TEST_F(BrowserTabStripModelDelegateTest, MoveTabsToNewWindow) {
std::unique_ptr<TabStripModelDelegate> delegate =
std::make_unique<BrowserTabStripModelDelegate>(browser());
GURL url1("chrome://version");
GURL url2("chrome://about");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url1));
// Moving a tab from a single tab window to a new tab window is a no-op.
// TODO(lgrey): When moving to existing windows is implemented, add a case
// for this test that asserts we *can* move to an existing window from a
// single tab window.
EXPECT_FALSE(delegate->CanMoveTabsToWindow({0}));
ASSERT_TRUE(AddTabAtIndex(1, url2, ui::PAGE_TRANSITION_LINK));
EXPECT_TRUE(delegate->CanMoveTabsToWindow({0}));
EXPECT_TRUE(delegate->CanMoveTabsToWindow({1}));
// Moving *all* the tabs in a window to a new window is a no-op.
EXPECT_FALSE(delegate->CanMoveTabsToWindow({0, 1}));
BrowserList* browser_list = BrowserList::GetInstance();
// Precondition: there's currently one browser with two tabs.
EXPECT_EQ(browser_list->size(), 1u);
EXPECT_EQ(browser()->tab_strip_model()->count(), 2);
EXPECT_EQ(browser()->tab_strip_model()->GetActiveWebContents()->GetURL(),
url2);
// Execute this on a background tab to ensure that the code path can handle
// other tabs besides the active one.
ui_test_utils::BrowserChangeObserver new_browser_observer(
nullptr, ui_test_utils::BrowserChangeObserver::ChangeType::kAdded);
delegate->MoveTabsToNewWindow({0});
Browser* active_browser = new_browser_observer.Wait();
ui_test_utils::WaitUntilBrowserBecomeActive(active_browser);
// Now there are two browsers, each with one tab and the new browser is
// active.
EXPECT_EQ(browser_list->size(), 2u);
EXPECT_NE(active_browser, browser());
EXPECT_EQ(browser()->tab_strip_model()->count(), 1);
EXPECT_EQ(active_browser->tab_strip_model()->count(), 1);
EXPECT_EQ(browser()->tab_strip_model()->GetActiveWebContents()->GetURL(),
url2);
EXPECT_EQ(active_browser->tab_strip_model()->GetActiveWebContents()->GetURL(),
url1);
}
// Tests the "Move Tab to New Window" tab context menu command with multiple
// tabs selected.
IN_PROC_BROWSER_TEST_F(BrowserTabStripModelDelegateTest,
MoveMultipleTabsToNewWindow) {
std::unique_ptr<TabStripModelDelegate> delegate =
std::make_unique<BrowserTabStripModelDelegate>(browser());
GURL url1("chrome://version");
GURL url2("chrome://about");
GURL url3("chrome://terms");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url1));
// Moving a tab from a single tab window to a new tab window is a no-op.
// TODO(jugallag): When moving to existing windows is implemented, add a case
// for this test that asserts we *can* move to an existing window from a
// single tab window.
EXPECT_FALSE(delegate->CanMoveTabsToWindow({0}));
ASSERT_TRUE(AddTabAtIndex(1, url2, ui::PAGE_TRANSITION_LINK));
ASSERT_TRUE(AddTabAtIndex(2, url3, ui::PAGE_TRANSITION_LINK));
EXPECT_TRUE(delegate->CanMoveTabsToWindow({0}));
EXPECT_TRUE(delegate->CanMoveTabsToWindow({1}));
EXPECT_TRUE(delegate->CanMoveTabsToWindow({2}));
EXPECT_TRUE(delegate->CanMoveTabsToWindow({0, 1}));
EXPECT_TRUE(delegate->CanMoveTabsToWindow({0, 2}));
EXPECT_TRUE(delegate->CanMoveTabsToWindow({1, 2}));
// Moving *all* the tabs in a window to a new window is a no-op.
EXPECT_FALSE(delegate->CanMoveTabsToWindow({0, 1, 2}));
BrowserList* browser_list = BrowserList::GetInstance();
// Precondition: there's currently one browser with three tabs.
EXPECT_EQ(browser_list->size(), 1u);
EXPECT_EQ(browser()->tab_strip_model()->count(), 3);
EXPECT_EQ(browser()->tab_strip_model()->GetActiveWebContents()->GetURL(),
url3);
// Execute this on a background tab to ensure that the code path can handle
// other tabs besides the active one.
ui_test_utils::BrowserChangeObserver new_browser_observer(
nullptr, ui_test_utils::BrowserChangeObserver::ChangeType::kAdded);
delegate->MoveTabsToNewWindow({0, 2});
Browser* active_browser = new_browser_observer.Wait();
ui_test_utils::WaitUntilBrowserBecomeActive(active_browser);
// Now there are two browsers, with one or two tabs and the new browser is
// active.
EXPECT_EQ(browser_list->size(), 2u);
EXPECT_NE(active_browser, browser());
EXPECT_EQ(browser()->tab_strip_model()->count(), 1);
EXPECT_EQ(active_browser->tab_strip_model()->count(), 2);
EXPECT_EQ(browser()->tab_strip_model()->GetActiveWebContents()->GetURL(),
url2);
EXPECT_EQ(active_browser->tab_strip_model()->GetActiveWebContents()->GetURL(),
url3);
}
// Test muting tab in regular window is resettable in Incognito window.
IN_PROC_BROWSER_TEST_F(BrowserTabStripModelDelegateWithEmbeddedServerTest,
ToggleMuteInRegularAndThenToggleMuteInIncognito) {
GURL url = embedded_test_server()->GetURL("/title1.html");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
// Mute the site in regular tab.
ToggleMute(browser());
VerifyMute(browser(), /*isMuted=*/true);
// Open Incognito tab and check the site is muted there.
Browser* incognito_browser = CreateIncognitoBrowser(browser()->profile());
ASSERT_TRUE(ui_test_utils::NavigateToURL(incognito_browser, url));
VerifyMute(incognito_browser, /*isMuted=*/true);
// Unmute in Incognito tab.
ToggleMute(incognito_browser);
VerifyMute(incognito_browser, /*isMuted=*/false);
// In regular tab the site should still be muted.
VerifyMute(browser(), /*isMuted=*/true);
}
// Test muting/unmuting tab from regular window is inherited properly in
// Incognito window.
IN_PROC_BROWSER_TEST_F(BrowserTabStripModelDelegateWithEmbeddedServerTest,
ToggleMuteInRegularWindowAndCheckInIncognito) {
GURL url = embedded_test_server()->GetURL("/title1.html");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url));
// Mute the site in regular tab.
ToggleMute(browser());
VerifyMute(browser(), /*isMuted=*/true);
// Open Incognito tab and check the site is muted there.
Browser* incognito_browser = CreateIncognitoBrowser(browser()->profile());
ASSERT_TRUE(ui_test_utils::NavigateToURL(incognito_browser, url));
VerifyMute(incognito_browser, /*isMuted=*/true);
// Unmute in Regular tab.
ToggleMute(browser());
VerifyMute(browser(), /*isMuted=*/false);
// Site should also unmute in Incognito tab.
VerifyMute(incognito_browser, /*isMuted=*/false);
}
IN_PROC_BROWSER_TEST_F(BrowserTabStripModelDelegateWithEmbeddedServerTest,
ToggleMuteOnlyInIncognitoWindow) {
GURL url = embedded_test_server()->GetURL("/title1.html");
// Open tab in Incognito
Browser* incognito_browser = CreateIncognitoBrowser(browser()->profile());
ASSERT_TRUE(ui_test_utils::NavigateToURL(incognito_browser, url));
// Mute the site in Incognito.
ToggleMute(incognito_browser);
// The site should be muted in Incognito.
VerifyMute(incognito_browser, /*isMuted=*/true);
// Unmute the site in Incognito.
ToggleMute(incognito_browser);
// The site should be unmuted in Incognito.
VerifyMute(incognito_browser, /*isMuted=*/false);
}
// Tests that bulk actions will close tab groups without destruction.
IN_PROC_BROWSER_TEST_F(BrowserTabStripModelDelegateTest,
BulkCloseToRightWithTabGroups) {
std::unique_ptr<TabStripModelDelegate> delegate =
std::make_unique<BrowserTabStripModelDelegate>(browser());
GURL url1("chrome://version");
GURL url2("chrome://about");
GURL url3("chrome://terms");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url1));
ASSERT_TRUE(AddTabAtIndex(1, url2, ui::PAGE_TRANSITION_LINK));
ASSERT_TRUE(AddTabAtIndex(2, url3, ui::PAGE_TRANSITION_LINK));
auto* tab_strip_model = browser()->tab_strip_model();
tab_strip_model->AddToNewGroup({1});
tab_strip_model->AddToNewGroup({2});
BrowserList* browser_list = BrowserList::GetInstance();
// Precondition: there's currently one browser with three tabs in two
// groups.
EXPECT_EQ(browser_list->size(), 1u);
EXPECT_EQ(browser()->tab_strip_model()->count(), 3);
EXPECT_EQ(browser()->tab_strip_model()->GetActiveWebContents()->GetURL(),
url3);
EXPECT_EQ(browser()->tab_strip_model()->group_model()->ListTabGroups().size(),
2u);
auto* sync_service = tab_groups::SavedTabGroupUtils::GetServiceForProfile(
browser()->profile());
EXPECT_NE(sync_service, nullptr);
auto groups = sync_service->GetAllGroups();
EXPECT_EQ(groups.size(), 2u);
for (auto group : groups) {
// Group is open
EXPECT_TRUE(group.local_group_id().has_value());
}
// Execute command on first tab to close all tabs to the right.
tab_strip_model->ExecuteContextMenuCommand(
0, TabStripModel::ContextMenuCommand::CommandCloseTabsToRight);
// Now there are is only one tab and groups are minimized.
EXPECT_EQ(browser()->tab_strip_model()->count(), 1);
EXPECT_EQ(browser()->tab_strip_model()->GetActiveWebContents()->GetURL(),
url1);
EXPECT_EQ(browser()->tab_strip_model()->group_model()->ListTabGroups().size(),
0u);
groups = sync_service->GetAllGroups();
EXPECT_EQ(groups.size(), 2u);
for (auto group : groups) {
// Group is not open
EXPECT_FALSE(group.local_group_id().has_value());
}
}
IN_PROC_BROWSER_TEST_F(BrowserTabStripModelDelegateTest,
BulkCloseOtherWithTabGroups) {
std::unique_ptr<TabStripModelDelegate> delegate =
std::make_unique<BrowserTabStripModelDelegate>(browser());
GURL url1("chrome://version");
GURL url2("chrome://about");
GURL url3("chrome://terms");
ASSERT_TRUE(ui_test_utils::NavigateToURL(browser(), url1));
ASSERT_TRUE(AddTabAtIndex(1, url2, ui::PAGE_TRANSITION_LINK));
ASSERT_TRUE(AddTabAtIndex(2, url3, ui::PAGE_TRANSITION_LINK));
auto* tab_strip_model = browser()->tab_strip_model();
tab_strip_model->AddToNewGroup({1});
tab_strip_model->AddToNewGroup({2});
BrowserList* browser_list = BrowserList::GetInstance();
// Precondition: there's currently one browser with three tabs in two
// groups.
EXPECT_EQ(browser_list->size(), 1u);
EXPECT_EQ(browser()->tab_strip_model()->count(), 3);
EXPECT_EQ(browser()->tab_strip_model()->GetActiveWebContents()->GetURL(),
url3);
EXPECT_EQ(browser()->tab_strip_model()->group_model()->ListTabGroups().size(),
2u);
auto* sync_service = tab_groups::SavedTabGroupUtils::GetServiceForProfile(
browser()->profile());
EXPECT_NE(sync_service, nullptr);
auto groups = sync_service->GetAllGroups();
EXPECT_EQ(groups.size(), 2u);
for (auto group : groups) {
// Group is open
EXPECT_TRUE(group.local_group_id().has_value());
}
// Execute command on first tab to close all tabs to the right.
tab_strip_model->ExecuteContextMenuCommand(
1, TabStripModel::ContextMenuCommand::CommandCloseOtherTabs);
// Now there are is only one tab and groups are minimized.
EXPECT_EQ(browser()->tab_strip_model()->count(), 1);
EXPECT_EQ(browser()->tab_strip_model()->GetActiveWebContents()->GetURL(),
url2);
EXPECT_EQ(browser()->tab_strip_model()->group_model()->ListTabGroups().size(),
1u);
groups = sync_service->GetAllGroups();
EXPECT_EQ(groups.size(), 2u);
// Other group is not open
EXPECT_FALSE(groups.at(0).local_group_id().has_value());
// Current group is open
EXPECT_TRUE(groups.at(1).local_group_id().has_value());
}
} // namespace chrome
|
