1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/unload_controller.h"
#include "ash/constants/web_app_id_constants.h"
#include "base/json/json_reader.h"
#include "base/test/scoped_feature_list.h"
#include "base/values.h"
#include "chrome/browser/policy/policy_test_utils.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
#include "chrome/browser/ui/web_applications/test/web_app_browsertest_util.h"
#include "chrome/browser/web_applications/test/prevent_close_test_base.h"
#include "chrome/browser/web_applications/test/web_app_install_test_utils.h"
#include "chrome/browser/web_applications/web_app_install_info.h"
#include "chrome/common/chrome_features.h"
#include "chrome/test/base/in_process_browser_test.h"
#include "components/policy/core/browser/browser_policy_connector.h"
#include "components/policy/core/browser/browser_policy_connector_base.h"
#include "components/policy/core/common/mock_configuration_policy_provider.h"
#include "components/policy/core/common/policy_map.h"
#include "components/policy/policy_constants.h"
#include "components/webapps/common/web_app_id.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test.h"
#include "third_party/abseil-cpp/absl/cleanup/cleanup.h"
#include "ui/base/window_open_disposition.h"
#include "url/gurl.h"
namespace {
constexpr char kCalculatorAppUrl[] = "https://calculator.apps.chrome/";
constexpr char kPreventCloseEnabledForCalculator[] = R"([
{
"manifest_id": "https://calculator.apps.chrome/",
"run_on_os_login": "run_windowed",
"prevent_close_after_run_on_os_login": true
}
])";
constexpr char kCalculatorForceInstalled[] = R"([
{
"url": "https://calculator.apps.chrome/",
"default_launch_container": "window"
}
])";
#if BUILDFLAG(IS_CHROMEOS)
constexpr bool kShouldPreventClose = true;
#else
constexpr bool kShouldPreventClose = false;
#endif // BUILDFLAG(IS_CHROMEOS)
} // namespace
using UnloadControllerPreventCloseTest = PreventCloseTestBase;
IN_PROC_BROWSER_TEST_F(UnloadControllerPreventCloseTest,
PreventCloseEnforcedByPolicy) {
const absl::Cleanup policy_cleanup = [this] {
SetPolicies(/*web_app_settings=*/"[]", /*web_app_install_force_list=*/"[]");
};
InstallPWA(GURL(kCalculatorAppUrl), ash::kCalculatorAppId);
SetPoliciesAndWaitUntilInstalled(ash::kCalculatorAppId,
kPreventCloseEnabledForCalculator,
kCalculatorForceInstalled);
Browser* const browser =
LaunchPWA(ash::kCalculatorAppId, /*launch_in_window=*/true);
ASSERT_TRUE(browser);
UnloadController unload_controller(browser);
EXPECT_EQ(kShouldPreventClose ? BrowserClosingStatus::kDeniedByPolicy
: BrowserClosingStatus::kPermitted,
unload_controller.GetBrowserClosingStatus());
}
// Flaky on IS_CHROMEOS. crbug.com/369817361
#if BUILDFLAG(IS_CHROMEOS)
#define MAYBE_PreventCloseEnforcedByPolicyTabbedAppShallBeClosable \
DISABLED_PreventCloseEnforcedByPolicyTabbedAppShallBeClosable
#else
#define MAYBE_PreventCloseEnforcedByPolicyTabbedAppShallBeClosable \
PreventCloseEnforcedByPolicyTabbedAppShallBeClosable
#endif
IN_PROC_BROWSER_TEST_F(
UnloadControllerPreventCloseTest,
MAYBE_PreventCloseEnforcedByPolicyTabbedAppShallBeClosable) {
const absl::Cleanup policy_cleanup = [this] {
SetPolicies(/*web_app_settings=*/"[]", /*web_app_install_force_list=*/"[]");
};
InstallPWA(GURL(kCalculatorAppUrl), ash::kCalculatorAppId);
SetPoliciesAndWaitUntilInstalled(ash::kCalculatorAppId,
kPreventCloseEnabledForCalculator,
kCalculatorForceInstalled);
Browser* const browser =
LaunchPWA(ash::kCalculatorAppId, /*launch_in_window=*/false);
ASSERT_TRUE(browser);
UnloadController unload_controller(browser);
EXPECT_EQ(BrowserClosingStatus::kPermitted,
unload_controller.GetBrowserClosingStatus());
}
#if BUILDFLAG(IS_CHROMEOS)
// Browser tests for verifying `UnloadController` behavior for apps when locked
// (and not locked) for OnTask. Only relevant for non-web browser scenarios.
class UnloadControllerWithOnTaskTest : public InProcessBrowserTest {
protected:
webapps::AppId InstallMockApp() {
return web_app::test::InstallDummyWebApp(
browser()->profile(), /*app_name=*/"Mock app",
/*app_url=*/GURL("https://www.example.com/"));
}
};
IN_PROC_BROWSER_TEST_F(UnloadControllerWithOnTaskTest,
PreventCloseWhenLockedForOnTask) {
// Install and launch app.
webapps::AppId app_id = InstallMockApp();
Browser* const app_browser =
web_app::LaunchWebAppBrowser(browser()->profile(), app_id);
app_browser->SetLockedForOnTask(true);
// Verify tab cannot be closed.
content::WebContents* const active_web_contents =
app_browser->tab_strip_model()->GetWebContentsAt(0);
UnloadController unload_controller(app_browser);
EXPECT_FALSE(unload_controller.CanCloseContents(active_web_contents));
}
IN_PROC_BROWSER_TEST_F(UnloadControllerWithOnTaskTest,
AllowCloseWhenNotLockedForOnTask) {
// Install and launch app.
webapps::AppId app_id = InstallMockApp();
Browser* const app_browser =
web_app::LaunchWebAppBrowser(browser()->profile(), app_id);
app_browser->SetLockedForOnTask(false);
// Verify tab can be closed.
content::WebContents* const active_web_contents =
app_browser->tab_strip_model()->GetWebContentsAt(0);
UnloadController unload_controller(app_browser);
EXPECT_TRUE(unload_controller.CanCloseContents(active_web_contents));
}
#endif
|
