1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
|
// Copyright 2022 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/web_applications/user_uninstalled_preinstalled_web_app_prefs.h"
#include <memory>
#include "base/containers/flat_set.h"
#include "base/test/metrics/user_action_tester.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/web_applications/web_app_browsertest_base.h"
#include "chrome/browser/web_applications/preinstalled_web_app_manager.h"
#include "chrome/browser/web_applications/test/web_app_install_test_utils.h"
#include "chrome/browser/web_applications/web_app.h"
#include "chrome/browser/web_applications/web_app_constants.h"
#include "chrome/browser/web_applications/web_app_install_info.h"
#include "chrome/browser/web_applications/web_app_management_type.h"
#include "components/webapps/browser/installable/installable_metrics.h"
#include "components/webapps/common/web_app_id.h"
#include "content/public/test/browser_test.h"
#include "url/gurl.h"
namespace web_app {
class UserUninstalledPreinstalledWebAppPrefsBrowserTest
: public WebAppBrowserTestBase {
public:
UserUninstalledPreinstalledWebAppPrefsBrowserTest()
: skip_preinstalled_web_app_startup_(
PreinstalledWebAppManager::SkipStartupForTesting()) {}
~UserUninstalledPreinstalledWebAppPrefsBrowserTest() override = default;
void SetUp() override { WebAppBrowserTestBase::SetUp(); }
private:
base::AutoReset<bool> skip_preinstalled_web_app_startup_;
};
IN_PROC_BROWSER_TEST_F(UserUninstalledPreinstalledWebAppPrefsBrowserTest,
BasicOperations) {
base::UserActionTester tester;
GURL url1("https://foo.com");
GURL url2("https://bar1.com");
GURL url3("https://bar2.com");
webapps::AppId app_id1 = "foo";
webapps::AppId app_id2 = "bar";
UserUninstalledPreinstalledWebAppPrefs preinstalled_prefs(
profile()->GetPrefs());
EXPECT_EQ(tester.GetActionCount(UserUninstalledPreinstalledWebAppPrefs::
kUserUninstalledPreinstalledAppAction),
0);
preinstalled_prefs.Add(app_id1, {url1});
EXPECT_EQ(tester.GetActionCount(UserUninstalledPreinstalledWebAppPrefs::
kUserUninstalledPreinstalledAppAction),
1);
preinstalled_prefs.Add(app_id2, {url2});
EXPECT_EQ(tester.GetActionCount(UserUninstalledPreinstalledWebAppPrefs::
kUserUninstalledPreinstalledAppAction),
2);
// To test that url3 gets appended.
preinstalled_prefs.Add(app_id2, {url3});
EXPECT_EQ(tester.GetActionCount(UserUninstalledPreinstalledWebAppPrefs::
kUserUninstalledPreinstalledAppAction),
2);
// Basic checks to verify app id exists in preinstalled prefs or not.
EXPECT_TRUE(preinstalled_prefs.DoesAppIdExist(app_id1));
EXPECT_TRUE(preinstalled_prefs.DoesAppIdExist(app_id2));
EXPECT_FALSE(preinstalled_prefs.DoesAppIdExist("baz"));
// Basic checks to verify if install_urls exist in preinstalled prefs or not.
EXPECT_EQ(app_id1, preinstalled_prefs.LookUpAppIdByInstallUrl(url1));
EXPECT_EQ(app_id2, preinstalled_prefs.LookUpAppIdByInstallUrl(url2));
EXPECT_EQ(app_id2, preinstalled_prefs.LookUpAppIdByInstallUrl(url3));
EXPECT_NE(app_id1, preinstalled_prefs.LookUpAppIdByInstallUrl(url3));
EXPECT_EQ(std::nullopt, preinstalled_prefs.LookUpAppIdByInstallUrl(GURL()));
EXPECT_EQ(std::nullopt, preinstalled_prefs.LookUpAppIdByInstallUrl(
GURL("https://baz.com")));
}
IN_PROC_BROWSER_TEST_F(UserUninstalledPreinstalledWebAppPrefsBrowserTest,
RemovalOperations) {
GURL url1("https://foo.com");
GURL url2("https://bar1.com");
GURL url3("https://bar2.com");
webapps::AppId app_id1 = "foo";
webapps::AppId app_id2 = "bar";
webapps::AppId app_id3 = "baz";
UserUninstalledPreinstalledWebAppPrefs preinstalled_prefs(
profile()->GetPrefs());
preinstalled_prefs.Add(app_id1, {url1});
preinstalled_prefs.Add(app_id2, {url2, url3});
// Should be false because app_id3 does not exist in the prefs.
// 2nd case should be false because random URL does not exist
// in the prefs.
EXPECT_FALSE(preinstalled_prefs.RemoveByInstallUrl(app_id3, url1));
EXPECT_FALSE(preinstalled_prefs.RemoveByInstallUrl(
app_id3, GURL("https://random_url.com")));
// Should be true because url2 exists for app_id2 and url1 exists
// for app_id1.
EXPECT_TRUE(preinstalled_prefs.RemoveByInstallUrl(app_id2, url2));
EXPECT_TRUE(preinstalled_prefs.RemoveByInstallUrl(app_id1, url1));
// The only remaining left pref should be app_id2 -> {url3}
EXPECT_EQ(app_id2, preinstalled_prefs.LookUpAppIdByInstallUrl(url3));
// url1 has been deleted, so app_id1 has been wiped from the prefs, and url2
// has been plain deleted.
EXPECT_EQ(std::nullopt, preinstalled_prefs.LookUpAppIdByInstallUrl(url1));
EXPECT_EQ(std::nullopt, preinstalled_prefs.LookUpAppIdByInstallUrl(url2));
}
IN_PROC_BROWSER_TEST_F(UserUninstalledPreinstalledWebAppPrefsBrowserTest,
PrefsPropagateProperlyOnDefaultUninstall) {
auto app_info1 = WebAppInstallInfo::CreateWithStartUrlForTesting(
GURL("https://example_url1.com/"));
app_info1->title = u"Example App1";
app_info1->install_url = GURL("https://example_url1.com/install");
auto app_info2 = WebAppInstallInfo::CreateWithStartUrlForTesting(
GURL("https://example_url2.com/"));
app_info2->title = u"Example App2";
app_info2->install_url = GURL("https://example_url2.com/install");
webapps::AppId app_id1 =
test::InstallWebApp(profile(), std::move(app_info1),
/*overwrite_existing_manifest_fields=*/false,
webapps::WebappInstallSource::EXTERNAL_DEFAULT);
webapps::AppId app_id2 =
test::InstallWebApp(profile(), std::move(app_info2),
/*overwrite_existing_manifest_fields=*/false,
webapps::WebappInstallSource::OMNIBOX_INSTALL_ICON);
// Verify that the prefs aren't filled just on installation.
UserUninstalledPreinstalledWebAppPrefs preinstalled_prefs(
profile()->GetPrefs());
EXPECT_FALSE(preinstalled_prefs.DoesAppIdExist(app_id1));
EXPECT_FALSE(preinstalled_prefs.DoesAppIdExist(app_id2));
// Verify that the prefs are filled on uninstall for app_id1. For app_id2,
// this will not happen because external apps installed by sources that are
// not preinstalled are not added to this pref.
test::UninstallWebApp(profile(), app_id1);
test::UninstallWebApp(profile(), app_id2);
EXPECT_TRUE(preinstalled_prefs.DoesAppIdExist(app_id1));
EXPECT_EQ(app_id1, preinstalled_prefs.LookUpAppIdByInstallUrl(
GURL("https://example_url1.com/install")));
EXPECT_FALSE(preinstalled_prefs.DoesAppIdExist(app_id2));
}
IN_PROC_BROWSER_TEST_F(UserUninstalledPreinstalledWebAppPrefsBrowserTest,
VerifyAppIdContainsAllUrls) {
UserUninstalledPreinstalledWebAppPrefs preinstalled_prefs(
profile()->GetPrefs());
base::flat_map<WebAppManagement::Type, WebApp::ExternalManagementConfig>
test_map;
WebApp::ExternalManagementConfig config1;
WebApp::ExternalManagementConfig config2;
config1.install_urls = {GURL("https://a.com")};
config2.install_urls = {GURL("https://c.com")};
// Default source test.
test_map[WebAppManagement::kDefault] = std::move(config1);
preinstalled_prefs.Add("app_id",
{GURL("https://a.com"), GURL("https://b.com")});
EXPECT_TRUE(preinstalled_prefs.AppIdContainsAllUrls("app_id", test_map,
/*only_default=*/true));
// Non-default source test.
test_map[WebAppManagement::kPolicy] = std::move(config2);
EXPECT_FALSE(preinstalled_prefs.AppIdContainsAllUrls("app_id", test_map,
/*only_default=*/false));
// Empty test.
test_map.erase(WebAppManagement::kDefault);
test_map.erase(WebAppManagement::kPolicy);
EXPECT_FALSE(preinstalled_prefs.AppIdContainsAllUrls("app_id", test_map,
/*only_default=*/false));
}
} // namespace web_app
|
