1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436
|
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/search_engines/default_search_manager.h"
#include <stddef.h>
#include <memory>
#include <utility>
#include "base/strings/string_split.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/metrics/histogram_tester.h"
#include "base/test/scoped_feature_list.h"
#include "base/time/time.h"
#include "components/regional_capabilities/regional_capabilities_switches.h"
#include "components/search_engines/search_engine_choice/search_engine_choice_service.h"
#include "components/search_engines/search_engine_type.h"
#include "components/search_engines/search_engines_pref_names.h"
#include "components/search_engines/search_engines_switches.h"
#include "components/search_engines/search_engines_test_environment.h"
#include "components/search_engines/search_engines_test_util.h"
#include "components/search_engines/template_url_data.h"
#include "components/search_engines/template_url_data_util.h"
#include "components/search_engines/template_url_prepopulate_data.h"
#include "components/sync_preferences/testing_pref_service_syncable.h"
#include "components/variations/scoped_variations_ids_provider.h"
#include "template_url_prepopulate_data_resolver.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/search_engines_data/resources/definitions/prepopulated_engines.h"
#include "url/gurl.h"
namespace {
void SetOverrides(sync_preferences::TestingPrefServiceSyncable* prefs,
bool update) {
auto overrides = base::Value::List();
// Lambda facilitating insertion of TemplateURL definitions, ensuring that all
// mandatory fields are present.
auto add_definition = [&overrides](TemplateURLID id,
std::string name_and_keyword,
std::string base_url) {
auto alternate_urls = base::Value::List();
alternate_urls.Append(base_url + "/alternate?q={searchTerms}");
overrides.Append(
base::Value::Dict()
.Set("name", name_and_keyword)
.Set("id", (int)id)
.Set("keyword", name_and_keyword)
.Set("search_url", base_url + "/search?q={searchTerms}")
.Set("suggest_url", base_url + "/suggest?q={searchTerms}")
.Set("favicon_url", base_url + "/favicon.ico")
.Set("encoding", "UTF-8")
.Set("alternate_urls", std::move(alternate_urls)));
};
add_definition(100, update ? "new_foo" : "foo", "https://atlas.com");
add_definition(101, update ? "new_bar" : "bar", "https://brave.com");
add_definition(102, update ? "new_bar" : "bar", "https://conduit.com");
add_definition(103, "at.yahoo.com", "https://at.search.yahoo.com");
add_definition(104, "emea.yahoo.com", "https://emea.search.yahoo.com");
prefs->SetUserPref(prefs::kSearchProviderOverridesVersion, base::Value(1));
prefs->SetUserPref(prefs::kSearchProviderOverrides, std::move(overrides));
}
void SetPolicy(sync_preferences::TestingPrefServiceSyncable* prefs,
bool enabled,
TemplateURLData* data,
bool is_mandatory) {
if (enabled) {
EXPECT_FALSE(data->keyword().empty());
EXPECT_FALSE(data->url().empty());
}
base::Value::Dict entry = TemplateURLDataToDictionary(*data);
entry.Set(DefaultSearchManager::kDisabledByPolicy, !enabled);
is_mandatory ? prefs->SetManagedPref(
DefaultSearchManager::kDefaultSearchProviderDataPrefName,
std::move(entry))
: prefs->SetRecommendedPref(
DefaultSearchManager::kDefaultSearchProviderDataPrefName,
std::move(entry));
}
} // namespace
class DefaultSearchManagerTest : public testing::Test {
public:
void SetUp() override {
// Override the country checks to simulate being in the US.
base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
switches::kSearchEngineChoiceCountry, "US");
}
sync_preferences::TestingPrefServiceSyncable* pref_service() {
return &search_engines_test_environment_.pref_service();
}
search_engines::SearchEngineChoiceService* search_engine_choice_service() {
return &search_engines_test_environment_.search_engine_choice_service();
}
TemplateURLPrepopulateData::Resolver& prepopulate_data_resolver() {
return search_engines_test_environment_.prepopulate_data_resolver();
}
std::unique_ptr<DefaultSearchManager> create_manager() {
return std::make_unique<DefaultSearchManager>(
pref_service(), search_engine_choice_service(),
search_engines_test_environment_.prepopulate_data_resolver(),
DefaultSearchManager::ObserverCallback());
}
private:
variations::ScopedVariationsIdsProvider scoped_variations_ids_provider_{
variations::VariationsIdsProvider::Mode::kUseSignedInState};
search_engines::SearchEnginesTestEnvironment search_engines_test_environment_;
};
// Test that a TemplateURLData object is properly written and read from Prefs.
TEST_F(DefaultSearchManagerTest, ReadAndWritePref) {
auto manager = create_manager();
TemplateURLData data;
data.SetShortName(u"name1");
data.SetKeyword(u"key1");
data.SetURL("http://foo1/{searchTerms}");
data.suggestions_url = "http://sugg1";
data.alternate_urls.push_back("http://foo1/alt");
data.favicon_url = GURL("http://icon1");
data.safe_for_autoreplace = true;
data.input_encodings = base::SplitString(
"UTF-8;UTF-16", ";", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
data.date_created = base::Time();
data.last_modified = base::Time();
data.last_modified = base::Time();
data.regulatory_origin = RegulatoryExtensionType::kAndroidEEA;
manager->SetUserSelectedDefaultSearchEngine(data);
const TemplateURLData* read_data = manager->GetDefaultSearchEngine(nullptr);
ExpectSimilar(&data, read_data);
}
// Test DefaultSearchmanager handles user-selected DSEs correctly.
TEST_F(DefaultSearchManagerTest, DefaultSearchSetByUserPref) {
auto manager = create_manager();
std::unique_ptr<TemplateURLData> fallback_t_url_data =
prepopulate_data_resolver().GetFallbackSearch();
EXPECT_EQ(fallback_t_url_data->keyword(),
TemplateURLPrepopulateData::google.keyword);
EXPECT_EQ(fallback_t_url_data->prepopulate_id,
TemplateURLPrepopulateData::google.id);
DefaultSearchManager::Source source = DefaultSearchManager::FROM_POLICY;
// If no user pref is set, we should use the pre-populated values.
ExpectSimilar(fallback_t_url_data.get(),
manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_FALLBACK, source);
base::HistogramTester histograms;
// Setting a user pref overrides the pre-populated values.
std::unique_ptr<TemplateURLData> data = GenerateDummyTemplateURLData("user");
manager->SetUserSelectedDefaultSearchEngine(*data);
ExpectSimilar(data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
// Updating the user pref (externally to this instance of
// DefaultSearchManager) triggers an update.
std::unique_ptr<TemplateURLData> new_data =
GenerateDummyTemplateURLData("user2");
auto other_manager = create_manager();
other_manager->SetUserSelectedDefaultSearchEngine(*new_data);
ExpectSimilar(new_data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
// Check that the mirrored pref metric didn't record a mismatch.
// Metric is recorded once for the first search manager, and then four more
// times when there are two search managers.
histograms.ExpectBucketCount(
DefaultSearchManager::kDefaultSearchEngineMirroredMetric, true, 1);
histograms.ExpectBucketCount(
DefaultSearchManager::kDefaultSearchEngineMirroredMetric, false, 0);
// Clearing the user pref should cause the default search to revert to the
// prepopulated values.
manager->ClearUserSelectedDefaultSearchEngine();
ExpectSimilar(fallback_t_url_data.get(),
manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_FALLBACK, source);
}
// Test that DefaultSearch manager detects changes to kSearchProviderOverrides.
TEST_F(DefaultSearchManagerTest, DefaultSearchSetByOverrides) {
SetOverrides(pref_service(), false);
auto manager = create_manager();
std::unique_ptr<TemplateURLData> fallback_t_url_data =
prepopulate_data_resolver().GetFallbackSearch();
EXPECT_NE(fallback_t_url_data->keyword(),
TemplateURLPrepopulateData::google.keyword);
EXPECT_NE(fallback_t_url_data->prepopulate_id,
TemplateURLPrepopulateData::google.id);
DefaultSearchManager::Source source = DefaultSearchManager::FROM_POLICY;
EXPECT_TRUE(manager->GetDefaultSearchEngine(&source));
TemplateURLData first_default(*manager->GetDefaultSearchEngine(&source));
ExpectSimilar(fallback_t_url_data.get(), &first_default);
EXPECT_EQ(DefaultSearchManager::FROM_FALLBACK, source);
// Update the overrides:
SetOverrides(pref_service(), true);
fallback_t_url_data = prepopulate_data_resolver().GetFallbackSearch();
// Make sure DefaultSearchManager updated:
ExpectSimilar(fallback_t_url_data.get(),
manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_FALLBACK, source);
EXPECT_NE(manager->GetDefaultSearchEngine(nullptr)->short_name(),
first_default.short_name());
EXPECT_NE(manager->GetDefaultSearchEngine(nullptr)->keyword(),
first_default.keyword());
}
// Test DefaultSearchManager handles policy-enforced DSEs correctly.
TEST_F(DefaultSearchManagerTest, DefaultSearchSetByEnforcedPolicy) {
auto manager = create_manager();
std::unique_ptr<TemplateURLData> data = GenerateDummyTemplateURLData("user");
manager->SetUserSelectedDefaultSearchEngine(*data);
DefaultSearchManager::Source source = DefaultSearchManager::FROM_FALLBACK;
ExpectSimilar(data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
std::unique_ptr<TemplateURLData> policy_data =
GenerateDummyTemplateURLData("policy");
SetPolicy(pref_service(), true, policy_data.get(), /*is_mandatory=*/true);
ExpectSimilar(policy_data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_POLICY, source);
TemplateURLData null_policy_data;
SetPolicy(pref_service(), false, &null_policy_data, /*is_mandatory=*/true);
EXPECT_EQ(nullptr, manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_POLICY, source);
pref_service()->RemoveManagedPref(
DefaultSearchManager::kDefaultSearchProviderDataPrefName);
ExpectSimilar(data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
}
// Policy-recommended DSE is handled correctly when no existing DSE is present.
TEST_F(DefaultSearchManagerTest, DefaultSearchSetByRecommendedPolicy) {
auto manager = create_manager();
DefaultSearchManager::Source source = DefaultSearchManager::FROM_FALLBACK;
// Set recommended policy DSE with valid data.
std::unique_ptr<TemplateURLData> policy_data =
GenerateDummyTemplateURLData("policy");
SetPolicy(pref_service(), true, policy_data.get(), /*is_mandatory=*/false);
ExpectSimilar(policy_data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_POLICY_RECOMMENDED, source);
// Set recommended policy DSE with null data.
TemplateURLData null_policy_data;
SetPolicy(pref_service(), false, &null_policy_data, /*is_mandatory=*/false);
EXPECT_EQ(nullptr, manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_POLICY_RECOMMENDED, source);
// Set user-configured DSE.
std::unique_ptr<TemplateURLData> user_data =
GenerateDummyTemplateURLData("user");
manager->SetUserSelectedDefaultSearchEngine(*user_data);
// The user-configured DSE overrides the recommended policy DSE.
ExpectSimilar(user_data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
// Remove the recommended policy DSE.
pref_service()->RemoveRecommendedPref(
DefaultSearchManager::kDefaultSearchProviderDataPrefName);
ExpectSimilar(user_data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
}
// Policy-recommended DSE does not override existing DSE set by user.
TEST_F(DefaultSearchManagerTest, DefaultSearchSetByUserAndRecommendedPolicy) {
auto manager = create_manager();
// Set user-configured DSE.
std::unique_ptr<TemplateURLData> user_data =
GenerateDummyTemplateURLData("user");
manager->SetUserSelectedDefaultSearchEngine(*user_data);
DefaultSearchManager::Source source = DefaultSearchManager::FROM_FALLBACK;
ExpectSimilar(user_data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
// Check that the TemplateURLData was mirrored to the mirrored pref.
const base::Value* user_value = pref_service()->GetUserPrefValue(
DefaultSearchManager::kMirroredDefaultSearchProviderDataPrefName);
ASSERT_TRUE(user_value && user_value->is_dict());
auto turl_data = TemplateURLDataFromDictionary(user_value->GetDict());
ExpectSimilar(user_data.get(), turl_data.get());
// Set recommended policy DSE.
std::unique_ptr<TemplateURLData> policy_data =
GenerateDummyTemplateURLData("policy");
SetPolicy(pref_service(), true, policy_data.get(), /*is_mandatory=*/false);
// The recommended policy DSE does not override the existing user DSE.
ExpectSimilar(user_data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
// Remove the recommended policy DSE.
pref_service()->RemoveRecommendedPref(
DefaultSearchManager::kDefaultSearchProviderDataPrefName);
ExpectSimilar(user_data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
}
// Test DefaultSearchManager handles extension-controlled DSEs correctly.
TEST_F(DefaultSearchManagerTest, DefaultSearchSetByExtension) {
auto manager = create_manager();
std::unique_ptr<TemplateURLData> data = GenerateDummyTemplateURLData("user");
manager->SetUserSelectedDefaultSearchEngine(*data);
DefaultSearchManager::Source source = DefaultSearchManager::FROM_FALLBACK;
ExpectSimilar(data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
// Extension trumps prefs:
std::unique_ptr<TemplateURLData> extension_data_1 =
GenerateDummyTemplateURLData("ext1");
SetExtensionDefaultSearchInPrefs(pref_service(), *extension_data_1);
ExpectSimilar(extension_data_1.get(),
manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_EXTENSION, source);
// Policy trumps extension:
std::unique_ptr<TemplateURLData> policy_data =
GenerateDummyTemplateURLData("policy");
SetPolicy(pref_service(), true, policy_data.get(), /*is_mandatory=*/true);
ExpectSimilar(policy_data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_POLICY, source);
pref_service()->RemoveManagedPref(
DefaultSearchManager::kDefaultSearchProviderDataPrefName);
// Extensions trump each other:
std::unique_ptr<TemplateURLData> extension_data_2 =
GenerateDummyTemplateURLData("ext2");
std::unique_ptr<TemplateURLData> extension_data_3 =
GenerateDummyTemplateURLData("ext3");
SetExtensionDefaultSearchInPrefs(pref_service(), *extension_data_2);
SetExtensionDefaultSearchInPrefs(pref_service(), *extension_data_3);
ExpectSimilar(extension_data_3.get(),
manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_EXTENSION, source);
RemoveExtensionDefaultSearchFromPrefs(pref_service());
ExpectSimilar(data.get(), manager->GetDefaultSearchEngine(&source));
EXPECT_EQ(DefaultSearchManager::FROM_USER, source);
}
TEST_F(DefaultSearchManagerTest,
DefaultSearchSetByPlayAPI_MergeByPrepopulatedId) {
auto manager = create_manager();
auto* builtin_engine = manager->GetDefaultSearchEngine(nullptr);
// The test tries to set DSE to the one with prepopulate_id, matching existing
// prepopulated search engine.
auto supplied_engine = GenerateDummyTemplateURLData(
base::UTF16ToUTF8(builtin_engine->keyword()));
supplied_engine->prepopulate_id = builtin_engine->prepopulate_id;
// Needed by ExpectSimilar.
supplied_engine->favicon_url = builtin_engine->favicon_url;
// Non-Play definitions should be reconciled using prepopulated_id.
manager->SetUserSelectedDefaultSearchEngine(*supplied_engine);
auto* result = manager->GetDefaultSearchEngine(nullptr);
ExpectSimilar(builtin_engine, result);
}
TEST_F(DefaultSearchManagerTest,
DefaultSearchSetByPlayAPI_MergeByKeyword_FeatureEnabled) {
auto manager = create_manager();
auto* builtin_engine = manager->GetDefaultSearchEngine(nullptr);
auto supplied_engine = GenerateDummyTemplateURLData(
base::UTF16ToUTF8(builtin_engine->keyword()));
supplied_engine->regulatory_origin = RegulatoryExtensionType::kAndroidEEA;
// Needed by ExpectSimilar.
supplied_engine->favicon_url = builtin_engine->favicon_url;
// Verify engine reconciled with builtin definition.
manager->SetUserSelectedDefaultSearchEngine(*supplied_engine);
auto* result = manager->GetDefaultSearchEngine(nullptr);
TemplateURLData expected_engine = *builtin_engine;
expected_engine.regulatory_origin = RegulatoryExtensionType::kAndroidEEA;
ExpectSimilar(&expected_engine, result);
}
TEST_F(DefaultSearchManagerTest,
DefaultSearchSetByPlayAPI_MergeByDomainName_FeatureEnabled) {
SetOverrides(pref_service(), false);
auto manager = create_manager();
// Find the expected engine. We could fabricate one too, this is easier.
auto all_engines = prepopulate_data_resolver().GetPrepopulatedEngines();
const auto& builtin_engine =
*std::ranges::find_if(all_engines, [](const auto& engine) {
GURL url(engine->url());
return url.is_valid() && url.host_piece() == "emea.search.yahoo.com";
});
auto supplied_engine = GenerateDummyTemplateURLData("yahoo.com");
supplied_engine->SetURL("https://emea.search.yahoo.com/any_path");
supplied_engine->regulatory_origin = RegulatoryExtensionType::kAndroidEEA;
// Needed by ExpectSimilar.
supplied_engine->favicon_url = builtin_engine->favicon_url;
// Verify engine reconciled with builtin definition.
manager->SetUserSelectedDefaultSearchEngine(*supplied_engine);
auto* result = manager->GetDefaultSearchEngine(nullptr);
TemplateURLData expected_engine = *builtin_engine;
expected_engine.regulatory_origin = RegulatoryExtensionType::kAndroidEEA;
ExpectSimilar(&expected_engine, result);
}
|