File: template_url_service_util_unittest.cc

package info (click to toggle)
chromium 138.0.7204.157-1
  • links: PTS, VCS
  • area: main
  • in suites: trixie
  • size: 6,071,864 kB
  • sloc: cpp: 34,936,859; ansic: 7,176,967; javascript: 4,110,704; python: 1,419,953; asm: 946,768; xml: 739,967; pascal: 187,324; sh: 89,623; perl: 88,663; objc: 79,944; sql: 50,304; cs: 41,786; fortran: 24,137; makefile: 21,806; php: 13,980; tcl: 13,166; yacc: 8,925; ruby: 7,485; awk: 3,720; lisp: 3,096; lex: 1,327; ada: 727; jsp: 228; sed: 36
file content (444 lines) | stat: -rw-r--r-- 19,908 bytes parent folder | download | duplicates (3)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
// Copyright 2014 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include <stddef.h>

#include <memory>

#include "base/check_deref.h"
#include "base/files/scoped_temp_dir.h"
#include "base/memory/scoped_refptr.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/test/task_environment.h"
#include "base/values.h"
#include "components/country_codes/country_codes.h"
#include "components/os_crypt/async/browser/test_utils.h"
#include "components/regional_capabilities/regional_capabilities_country_id.h"
#include "components/regional_capabilities/regional_capabilities_service.h"
#include "components/search_engines/keyword_web_data_service.h"
#include "components/search_engines/search_engine_choice/search_engine_choice_service.h"
#include "components/search_engines/search_engines_pref_names.h"
#include "components/search_engines/search_engines_test_environment.h"
#include "components/search_engines/search_terms_data.h"
#include "components/search_engines/template_url.h"
#include "components/search_engines/template_url_prepopulate_data.h"
#include "components/search_engines/template_url_prepopulate_data_resolver.h"
#include "components/search_engines/template_url_service.h"
#include "components/search_engines/template_url_starter_pack_data.h"
#include "components/search_engines/util.h"
#include "components/webdata/common/web_database_service.h"
#include "components/webdata/common/webdata_constants.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/search_engines_data/resources/definitions/regional_settings.h"

namespace {

using regional_capabilities::CountryIdHolder;

std::unique_ptr<TemplateURLData> CreatePrepopulateTemplateURLData(
    int prepopulate_id,
    const std::string& keyword) {
  return std::make_unique<TemplateURLData>(
      u"Search engine name", base::ASCIIToUTF16(keyword), "https://search.url",
      "" /* suggest_url */, "" /* image_url */, "" /* image_translate_url */,
      "" /* new_tab_url */, "" /* contextual_search_url */, "" /* logo_url */,
      "" /* doodle_url */, "" /* base_builtin_resource_id */,
      "" /* search_url_post_params */, "" /* suggest_url_post_params */,
      "" /* image_url_post_params */,
      "" /* image_translate_source_language_param_key */,
      "" /* image_translate_target_language_param_key */,
      std::vector<std::string>() /* search_intent_params */,
      "" /* favicon_url */, "UTF-8", u"" /* image_search_branding_label */,
      base::Value::List() /* alternate_urls_list */,
      false /* preconnect_to_search_url */,
      false /* prefetch_likely_navigations */, prepopulate_id,
      /* regulatory extensions */
      base::span<TemplateURLData::RegulatoryExtension>());
}

// Creates a TemplateURL with default values except for the prepopulate ID,
// keyword and TemplateURLID. Only use this in tests if your tests do not
// care about other fields.
std::unique_ptr<TemplateURL> CreatePrepopulateTemplateURL(
    int prepopulate_id,
    const std::string& keyword,
    TemplateURLID id,
    RegulatoryExtensionType reg_ext_type = RegulatoryExtensionType::kDefault) {
  std::unique_ptr<TemplateURLData> data =
      CreatePrepopulateTemplateURLData(prepopulate_id, keyword);
  data->id = id;
  data->regulatory_origin = reg_ext_type;
  return std::make_unique<TemplateURL>(*data);
}

// Sets up dependencies and calls `GetSearchProvidersUsingLoadedEngines()`.
// As with the wrapped function, `template_urls` will be updated with the loaded
// engines, including the starter pack ones, and `*resource_keyword_version`
// will be set to the version number for the loaded data or to 0 if no
// prepopulated engines were loaded.
void CallGetSearchProvidersUsingLoadedEngines(
    search_engines::SearchEnginesTestEnvironment&
        search_engines_test_environment,
    TemplateURLService::OwnedTemplateURLVector* template_urls,
    WDKeywordsResult::Metadata& inout_resource_metadata,
    os_crypt_async::OSCryptAsync* os_crypt) {
  // Setup inspired by `//components/webdata_services/web_data_service_wrapper*`

  base::test::TaskEnvironment task_environment{
      base::test::TaskEnvironment::MainThreadType::UI};
  auto task_runner = task_environment.GetMainThreadTaskRunner();

  base::ScopedTempDir scoped_temp_dir;
  ASSERT_TRUE(scoped_temp_dir.CreateUniqueTempDir());

  auto profile_database = base::MakeRefCounted<WebDatabaseService>(
      scoped_temp_dir.GetPath().Append(kWebDataFilename),
      /*ui_task_runner=*/task_runner,
      /*db_task_runner=*/task_runner);
  profile_database->AddTable(std::make_unique<KeywordTable>());
  profile_database->LoadDatabase(os_crypt);

  auto keyword_web_data = base::MakeRefCounted<KeywordWebDataService>(
      profile_database, task_runner);
  keyword_web_data->Init(base::DoNothing());

  {
    SearchTermsData search_terms_data;
    std::set<std::string> removed_keyword_guids;

    GetSearchProvidersUsingLoadedEngines(
        keyword_web_data.get(), &search_engines_test_environment.pref_service(),
        search_engines_test_environment.prepopulate_data_resolver(),
        template_urls,
        /*default_search_provider=*/nullptr, search_terms_data,
        inout_resource_metadata, &removed_keyword_guids);

    EXPECT_TRUE(removed_keyword_guids.empty());
  }

  keyword_web_data->ShutdownOnUISequence();
  profile_database->ShutdownDatabase();
}

}  // namespace

TEST(TemplateURLServiceUtilTest, RemoveDuplicatePrepopulateIDs) {
  std::vector<std::unique_ptr<TemplateURLData>> prepopulated_turls;
  TemplateURLService::OwnedTemplateURLVector local_turls;

  prepopulated_turls.push_back(CreatePrepopulateTemplateURLData(1, "winner4"));
  prepopulated_turls.push_back(CreatePrepopulateTemplateURLData(2, "xxx"));
  prepopulated_turls.push_back(CreatePrepopulateTemplateURLData(3, "yyy"));

  // Create a sets of different TURLs grouped by prepopulate ID. Each group
  // will test a different heuristic of RemoveDuplicatePrepopulateIDs.
  // Ignored set - These should be left alone as they do not have valid
  // prepopulate IDs.
  local_turls.push_back(CreatePrepopulateTemplateURL(0, "winner1", 4));
  local_turls.push_back(CreatePrepopulateTemplateURL(0, "winner2", 5));
  local_turls.push_back(CreatePrepopulateTemplateURL(0, "winner3", 6));
  size_t num_non_prepopulated_urls = local_turls.size();

  // Keyword match set - Prefer the one that matches the keyword of the
  // prepopulate ID.
  local_turls.push_back(CreatePrepopulateTemplateURL(1, "loser1", 7));
  local_turls.push_back(CreatePrepopulateTemplateURL(1, "loser2", 8));
  local_turls.push_back(CreatePrepopulateTemplateURL(1, "winner4", 9));

  // Default set - Prefer the default search engine over all other criteria.
  // The last one is the default. It will be passed as the
  // default_search_provider parameter to RemoveDuplicatePrepopulateIDs.
  local_turls.push_back(CreatePrepopulateTemplateURL(2, "loser3", 10));
  local_turls.push_back(CreatePrepopulateTemplateURL(2, "xxx", 11));
  local_turls.push_back(CreatePrepopulateTemplateURL(2, "winner5", 12));
  TemplateURL* default_turl = local_turls.back().get();

  // ID set - Prefer the lowest TemplateURLID if the keywords don't match and if
  // none are the default.
  local_turls.push_back(CreatePrepopulateTemplateURL(3, "winner6", 13));
  local_turls.push_back(CreatePrepopulateTemplateURL(3, "loser5", 14));
  local_turls.push_back(CreatePrepopulateTemplateURL(3, "loser6", 15));

  RemoveDuplicatePrepopulateIDs(nullptr, prepopulated_turls, default_turl,
                                &local_turls, SearchTermsData(), nullptr);

  // Verify that the expected local TURLs survived the process.
  EXPECT_EQ(local_turls.size(),
            prepopulated_turls.size() + num_non_prepopulated_urls);
  for (const auto& turl : local_turls) {
    EXPECT_TRUE(base::StartsWith(turl->keyword(), u"winner",
                                 base::CompareCase::SENSITIVE));
  }
}

// Tests correct interaction of Play API search engine during prepopulated list
// update.
TEST(TemplateURLServiceUtilTest, MergeEnginesFromPrepopulateData_PlayAPI) {
  std::vector<std::unique_ptr<TemplateURLData>> prepopulated_turls;
  TemplateURLService::OwnedTemplateURLVector local_turls;

  // Start with single search engine created from Play API data.
  local_turls.push_back(CreatePrepopulateTemplateURL(
      0, "play", 1, RegulatoryExtensionType::kAndroidEEA));

  // Test that prepopulated search engine with matching keyword is merged with
  // Play API search engine. Search URL should come from Play API search engine.
  const std::string prepopulated_search_url = "http://prepopulated.url";
  prepopulated_turls.push_back(CreatePrepopulateTemplateURLData(1, "play"));
  prepopulated_turls.back()->SetURL(prepopulated_search_url);
  MergeEnginesFromPrepopulateData(nullptr, &prepopulated_turls, &local_turls,
                                  nullptr, nullptr);
  ASSERT_EQ(local_turls.size(), 1U);
  // Merged search engine should have both Play API flag and valid
  // prepopulate_id.
  ASSERT_EQ(local_turls[0]->GetRegulatoryExtensionType(),
            RegulatoryExtensionType::kAndroidEEA);
  EXPECT_EQ(1, local_turls[0]->prepopulate_id());
  EXPECT_NE(prepopulated_search_url, local_turls[0]->url());

  // Test that merging prepopulated search engine with matching prepopulate_id
  // preserves keyword of Play API search engine.
  prepopulated_turls.clear();
  prepopulated_turls.push_back(CreatePrepopulateTemplateURLData(1, "play2"));
  MergeEnginesFromPrepopulateData(nullptr, &prepopulated_turls, &local_turls,
                                  nullptr, nullptr);
  ASSERT_EQ(local_turls.size(), 1U);
  ASSERT_EQ(local_turls[0]->GetRegulatoryExtensionType(),
            RegulatoryExtensionType::kAndroidEEA);
  EXPECT_EQ(local_turls[0]->keyword(), u"play");

  // Test that removing search engine from prepopulated list doesn't delete Play
  // API search engine record.
  prepopulated_turls.clear();
  MergeEnginesFromPrepopulateData(nullptr, &prepopulated_turls, &local_turls,
                                  nullptr, nullptr);
  ASSERT_EQ(local_turls.size(), 1U);
  ASSERT_EQ(local_turls[0]->GetRegulatoryExtensionType(),
            RegulatoryExtensionType::kAndroidEEA);
  EXPECT_EQ(local_turls[0]->prepopulate_id(), 0);
}

// Tests that user modified fields are preserved and overwritten appropriately
// in MergeIntoEngineData().
TEST(TemplateURLServiceUtilTest, MergeIntoEngineData) {
  std::unique_ptr<TemplateURLData> original_turl_data =
      CreatePrepopulateTemplateURLData(1, "google");
  std::unique_ptr<TemplateURLData> url_to_update =
      CreatePrepopulateTemplateURLData(1, "google");

  // Modify the keyword and title for original_turl and set safe_for_autoreplace
  // to false to simulate a "user edited" template url.
  original_turl_data->SetShortName(u"modified name");
  original_turl_data->SetKeyword(u"newkeyword");
  original_turl_data->safe_for_autoreplace = false;

  std::unique_ptr<TemplateURL> original_turl =
      std::make_unique<TemplateURL>(*original_turl_data);

  // Set `merge_options` to kOverwriteUserEdits. This should NOT preserve the
  // modified fields.  `url_to_update` should keep the default keyword and name
  // values as well as safe_for_autoreplace being true.
  MergeIntoEngineData(original_turl.get(), url_to_update.get(),
                      TemplateURLMergeOption::kOverwriteUserEdits);

  EXPECT_TRUE(url_to_update->safe_for_autoreplace);
  EXPECT_EQ(url_to_update->short_name(), u"Search engine name");
  EXPECT_EQ(url_to_update->keyword(), u"google");

  // Set `merge_options` to kDefault. This should preserve the modified
  // keyword and title fields from original_turl and update url_to_update
  // accordingly.
  MergeIntoEngineData(original_turl.get(), url_to_update.get(),
                      TemplateURLMergeOption::kDefault);

  EXPECT_FALSE(url_to_update->safe_for_autoreplace);
  EXPECT_EQ(url_to_update->short_name(), u"modified name");
  EXPECT_EQ(url_to_update->keyword(), u"newkeyword");
}

class TemplateURLServiceUtilLoadTest : public testing::Test {
 public:
  TemplateURLServiceUtilLoadTest()
      : os_crypt_(os_crypt_async::GetTestOSCryptAsyncForTesting(
            /*is_sync_for_unittests=*/true)) {}

  // Type used both as input and output of test helpers, to represent the
  // state of the database from its metadata.
  struct KeywordTestMetadata {
    // Version of the built-in keywords data.
    int data_version = 0;

    // Country stored in the database. As such, when passed as input, it will
    // be used to update only the database. To change the profile's country,
    // write directly to prefs.
    std::optional<CountryIdHolder> country = std::nullopt;

    // Number of keywords search engines available. Ignored when passing the
    // struct as input to set the database's initial state.
    size_t keyword_engines_count = 0;

    // Formatter method for Google Test.
    friend std::ostream& operator<<(std::ostream& out,
                                    const KeywordTestMetadata& m) {
      return out << "{data_version=" << m.data_version << ", country="
                 << (m.country.has_value()
                         ? base::NumberToString(
                               m.country->GetForTesting().Serialize())
                         : "<null>")
                 << ", keyword_engines_count=" << m.keyword_engines_count
                 << "}";
    }

    // Needed to be able to use EXPECT_EQ with this struct.
    bool operator==(const KeywordTestMetadata& rhs) const {
      return data_version == rhs.data_version && country == rhs.country &&
             keyword_engines_count == rhs.keyword_engines_count;
    }
  };

  const int kCurrentDataVersion =
      TemplateURLPrepopulateData::kCurrentDataVersion;

  // For country samples, using Belgium and France for EEA, and the United
  // States for non-EEA.
  const CountryIdHolder kEeaCountryId =
      CountryIdHolder(country_codes::CountryId("BE"));
  const CountryIdHolder kOtherEeaCountryId =
      CountryIdHolder(country_codes::CountryId("FR"));
  const CountryIdHolder kNonEeaCountryId =
      CountryIdHolder(country_codes::CountryId("US"));

  // Simulates how the search providers are loaded during Chrome init by
  // calling `GetSearchProvidersUsingLoadedEngines()`.
  // The `initial_state` struct represents the state of the database from its
  // metadata, before the search providers are loaded. Note:
  // `keyword_engines_count` is ignored in the input.
  // The returned struct represents the database state after the search
  // providers are loaded.
  KeywordTestMetadata SimulateFromDatabaseState(
      KeywordTestMetadata initial_state) {
    TemplateURLService::OwnedTemplateURLVector template_urls;
    WDKeywordsResult::Metadata resource_metadata;
    resource_metadata.builtin_keyword_data_version = initial_state.data_version;
    resource_metadata.builtin_keyword_country = initial_state.country;
    CallGetSearchProvidersUsingLoadedEngines(search_engines_test_environment_,
                                             &template_urls, resource_metadata,
                                             os_crypt_.get());
    size_t keyword_engines_count =
        template_urls.size() -
        TemplateURLStarterPackData::GetStarterPackEngines().size();

    return {
        .data_version = resource_metadata.builtin_keyword_data_version,
        .country = resource_metadata.builtin_keyword_country,
        .keyword_engines_count = keyword_engines_count,
    };
  }

  PrefService& prefs() {
    return search_engines_test_environment_.pref_service();
  }

  search_engines::SearchEngineChoiceService& search_engine_choice_service() {
    return search_engines_test_environment_.search_engine_choice_service();
  }

 private:
  std::unique_ptr<os_crypt_async::OSCryptAsync> os_crypt_;
  search_engines::SearchEnginesTestEnvironment search_engines_test_environment_;
};

TEST_F(TemplateURLServiceUtilLoadTest,
       GetSearchProvidersUsingLoadedEngines_OutOfEea) {
  search_engine_choice_service().ClearCountryIdCacheForTesting();
  prefs().SetInteger(country_codes::kCountryIDAtInstall,
                     kNonEeaCountryId.GetForTesting().Serialize());

  const KeywordTestMetadata kDefaultUpdatedState = {
      .data_version = kCurrentDataVersion,
      .country = kNonEeaCountryId,
      .keyword_engines_count = 5u};
  const KeywordTestMetadata kNoUpdate = {};

  // Initial state: nothing. Simulates a fresh install.
  // The function should populate the profile with 5 engines and current
  // metadata.
  auto output = SimulateFromDatabaseState({});
  EXPECT_EQ(output, kDefaultUpdatedState);

  // When using the latest metadata from the binary, the function should not
  // update anything.
  output = SimulateFromDatabaseState({.data_version = kCurrentDataVersion,
                                      .country = kNonEeaCountryId});
  EXPECT_EQ(output, kNoUpdate);

  // Missing country ID doesn't trigger an update either.
  output = SimulateFromDatabaseState({.data_version = kCurrentDataVersion});
  EXPECT_EQ(output, kNoUpdate);

  // Out of date keyword data versions trigger updates
  output = SimulateFromDatabaseState({.data_version = kCurrentDataVersion - 1});
  EXPECT_EQ(output, kDefaultUpdatedState);

  // Country changes trigger updates
  output = SimulateFromDatabaseState(
      {.data_version = kCurrentDataVersion, .country = kOtherEeaCountryId});
  EXPECT_EQ(output, kDefaultUpdatedState);

  // If database's data version is more recent than the one built-in to the
  // client, the updates are suppressed.
  output = SimulateFromDatabaseState(
      {.data_version = kCurrentDataVersion + 1, .country = kOtherEeaCountryId});
  EXPECT_EQ(output, kNoUpdate);
}

TEST_F(TemplateURLServiceUtilLoadTest,
       GetSearchProvidersUsingLoadedEngines_InEea) {
  search_engine_choice_service().ClearCountryIdCacheForTesting();
  prefs().SetInteger(country_codes::kCountryIDAtInstall,
                     kEeaCountryId.GetForTesting().Serialize());
  const size_t kEeaKeywordEnginesCount =
      TemplateURLPrepopulateData::kRegionalSettings
          .find(kEeaCountryId.GetForTesting())
          ->second->search_engines.size();

  const KeywordTestMetadata kDefaultUpdatedState = {
      .data_version = kCurrentDataVersion,
      .country = kEeaCountryId,
      .keyword_engines_count = kEeaKeywordEnginesCount};
  const KeywordTestMetadata kNoUpdate = {};

  // Initial state: nothing. Simulates a fresh install.
  // The function should populate the profile with 8 engines and current
  // metadata.
  auto output = SimulateFromDatabaseState({});
  EXPECT_EQ(output, kDefaultUpdatedState);

  // When using the latest metadata from the binary, the function should not
  // update anything.
  output = SimulateFromDatabaseState(
      {.data_version = kCurrentDataVersion, .country = kEeaCountryId});
  EXPECT_EQ(output, kNoUpdate);

  // Missing country ID doesn't trigger an update either.
  output = SimulateFromDatabaseState({.data_version = kCurrentDataVersion});
  EXPECT_EQ(output, kNoUpdate);

  // Out of date keyword data versions trigger updates
  output = SimulateFromDatabaseState({.data_version = kCurrentDataVersion - 1});
  EXPECT_EQ(output, kDefaultUpdatedState);

  // Country changes trigger updates
  output = SimulateFromDatabaseState(
      {.data_version = kCurrentDataVersion, .country = kOtherEeaCountryId});
  EXPECT_EQ(output, kDefaultUpdatedState);

  // If database's data version is more recent than the one built-in to the
  // client, the updates are suppressed.
  output = SimulateFromDatabaseState(
      {.data_version = kCurrentDataVersion + 1, .country = kOtherEeaCountryId});
  EXPECT_EQ(output, kNoUpdate);
}