1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405
|
// Copyright 2013 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/update_client/crx_downloader.h"
#include <utility>
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/functional/bind.h"
#include "base/memory/ref_counted.h"
#include "base/run_loop.h"
#include "base/test/bind.h"
#include "base/test/task_environment.h"
#include "build/build_config.h"
#include "components/update_client/crx_downloader_factory.h"
#include "components/update_client/net/network_chromium.h"
#include "components/update_client/test_utils.h"
#include "components/update_client/update_client_errors.h"
#include "components/update_client/utils.h"
#include "net/base/net_errors.h"
#include "services/network/public/cpp/weak_wrapper_shared_url_loader_factory.h"
#include "services/network/public/mojom/url_response_head.mojom.h"
#include "services/network/test/test_url_loader_factory.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::ContentsEqual;
namespace update_client {
namespace {
constexpr char kTestFileName[] = "jebgalgnebhfojomionfpkfelancnnkf.crx";
constexpr char hash_jebg[] =
"7ab32f071cd9b5ef8e0d7913be161f532d98b3e9fa284a7cd8059c3409ce0498";
} // namespace
class CrxDownloaderTest : public testing::Test {
public:
CrxDownloaderTest();
~CrxDownloaderTest() override;
// Overrides from testing::Test.
void SetUp() override;
void TearDown() override;
void Quit();
void RunThreads();
void RunThreadsUntilIdle();
void DownloadComplete(const CrxDownloader::Result& result);
void DownloadProgress(int64_t downloaded_bytes, int64_t total_bytes);
int GetInterceptorCount() { return interceptor_count_; }
void AddResponse(const GURL& url,
const base::FilePath& file_path,
int net_error);
protected:
scoped_refptr<CrxDownloader> crx_downloader_;
network::TestURLLoaderFactory test_url_loader_factory_;
CrxDownloader::DownloadCallback callback_;
CrxDownloader::ProgressCallback progress_callback_;
int num_download_complete_calls_ = 0;
CrxDownloader::Result download_complete_result_ = {};
// These members are updated by DownloadProgress.
int num_progress_calls_ = 0;
int64_t downloaded_bytes_ = -1;
int64_t total_bytes_ = -1;
// Accumulates the number of loads triggered.
int interceptor_count_ = 0;
private:
base::test::TaskEnvironment task_environment_;
scoped_refptr<network::SharedURLLoaderFactory>
test_shared_url_loader_factory_;
base::OnceClosure quit_closure_;
};
CrxDownloaderTest::CrxDownloaderTest()
: callback_(base::BindOnce(&CrxDownloaderTest::DownloadComplete,
base::Unretained(this))),
progress_callback_(
base::BindRepeating(&CrxDownloaderTest::DownloadProgress,
base::Unretained(this))),
task_environment_(base::test::TaskEnvironment::MainThreadType::IO),
test_shared_url_loader_factory_(
base::MakeRefCounted<network::WeakWrapperSharedURLLoaderFactory>(
&test_url_loader_factory_)) {}
CrxDownloaderTest::~CrxDownloaderTest() = default;
void CrxDownloaderTest::SetUp() {
// Do not use the background downloader in these tests.
crx_downloader_ =
MakeCrxDownloaderFactory(
base::MakeRefCounted<NetworkFetcherChromiumFactory>(
test_shared_url_loader_factory_,
base::BindRepeating([](const GURL& url) { return false; })))
->MakeCrxDownloader(false);
crx_downloader_->set_progress_callback(progress_callback_);
test_url_loader_factory_.SetInterceptor(base::BindLambdaForTesting(
[&](const network::ResourceRequest& request) { interceptor_count_++; }));
}
void CrxDownloaderTest::TearDown() {
crx_downloader_ = nullptr;
}
void CrxDownloaderTest::Quit() {
if (!quit_closure_.is_null()) {
std::move(quit_closure_).Run();
}
}
void CrxDownloaderTest::DownloadComplete(const CrxDownloader::Result& result) {
++num_download_complete_calls_;
download_complete_result_ = result;
Quit();
}
void CrxDownloaderTest::DownloadProgress(int64_t downloaded_bytes,
int64_t total_bytes) {
if (downloaded_bytes != -1 && total_bytes != -1) {
EXPECT_LE(downloaded_bytes, total_bytes);
}
downloaded_bytes_ = downloaded_bytes;
total_bytes_ = total_bytes;
++num_progress_calls_;
}
void CrxDownloaderTest::AddResponse(const GURL& url,
const base::FilePath& file_path,
int net_error) {
if (net_error == net::OK) {
std::string data;
EXPECT_TRUE(base::ReadFileToString(file_path, &data));
auto head = network::mojom::URLResponseHead::New();
head->content_length = data.size();
network::URLLoaderCompletionStatus status(net_error);
status.decoded_body_length = data.size();
test_url_loader_factory_.AddResponse(url, std::move(head), data, status);
return;
}
EXPECT_NE(net_error, net::OK);
test_url_loader_factory_.AddResponse(
url, network::mojom::URLResponseHead::New(), std::string(),
network::URLLoaderCompletionStatus(net_error));
}
void CrxDownloaderTest::RunThreads() {
base::RunLoop runloop;
quit_closure_ = runloop.QuitClosure();
runloop.Run();
// Since some tests need to drain currently enqueued tasks such as network
// intercepts on the IO thread, run the threads until they are
// idle. The component updater service won't loop again until the loop count
// is set and the service is started.
RunThreadsUntilIdle();
}
void CrxDownloaderTest::RunThreadsUntilIdle() {
task_environment_.RunUntilIdle();
base::RunLoop().RunUntilIdle();
}
// Tests that starting a download without a url results in an error.
TEST_F(CrxDownloaderTest, NoUrl) {
std::vector<GURL> urls;
crx_downloader_->StartDownload(urls, std::string("abcd"),
std::move(callback_));
RunThreadsUntilIdle();
EXPECT_EQ(1, num_download_complete_calls_);
EXPECT_EQ(static_cast<int>(CrxDownloaderError::NO_URL),
download_complete_result_.error);
EXPECT_EQ(download_complete_result_.extra_code1, 0);
EXPECT_TRUE(download_complete_result_.response.empty());
EXPECT_EQ(0, num_progress_calls_);
}
// Tests that starting a download without providing a hash results in an error.
TEST_F(CrxDownloaderTest, NoHash) {
std::vector<GURL> urls(1, GURL("http://somehost/somefile"));
crx_downloader_->StartDownload(urls, std::string(), std::move(callback_));
RunThreadsUntilIdle();
EXPECT_EQ(1, num_download_complete_calls_);
EXPECT_EQ(static_cast<int>(CrxDownloaderError::NO_HASH),
download_complete_result_.error);
EXPECT_EQ(download_complete_result_.extra_code1, 0);
EXPECT_TRUE(download_complete_result_.response.empty());
EXPECT_EQ(0, num_progress_calls_);
}
// Tests that downloading from one url is successful.
TEST_F(CrxDownloaderTest, OneUrl) {
const GURL expected_crx_url =
GURL("http://localhost/download/jebgalgnebhfojomionfpkfelancnnkf.crx");
const base::FilePath test_file(GetTestFilePath(kTestFileName));
AddResponse(expected_crx_url, test_file, net::OK);
crx_downloader_->StartDownloadFromUrl(
expected_crx_url, std::string(hash_jebg), std::move(callback_));
RunThreads();
EXPECT_EQ(1, GetInterceptorCount());
EXPECT_EQ(1, num_download_complete_calls_);
EXPECT_EQ(0, download_complete_result_.error);
EXPECT_EQ(0, download_complete_result_.extra_code1);
EXPECT_TRUE(ContentsEqual(download_complete_result_.response, test_file));
EXPECT_TRUE(
DeleteFileAndEmptyParentDirectory(download_complete_result_.response));
EXPECT_LE(1, num_progress_calls_);
EXPECT_EQ(total_bytes_, 1015);
}
// Tests that downloading from one url fails if the actual hash of the file
// does not match the expected hash.
TEST_F(CrxDownloaderTest, OneUrlBadHash) {
const GURL expected_crx_url =
GURL("http://localhost/download/jebgalgnebhfojomionfpkfelancnnkf.crx");
const base::FilePath test_file(GetTestFilePath(kTestFileName));
AddResponse(expected_crx_url, test_file, net::OK);
crx_downloader_->StartDownloadFromUrl(
expected_crx_url,
std::string(
"813c59747e139a608b3b5fc49633affc6db574373f309f156ea6d27229c0b3f9"),
std::move(callback_));
RunThreads();
EXPECT_EQ(1, GetInterceptorCount());
EXPECT_EQ(1, num_download_complete_calls_);
EXPECT_EQ(static_cast<int>(CrxDownloaderError::BAD_HASH),
download_complete_result_.error);
EXPECT_EQ(download_complete_result_.extra_code1, 0);
EXPECT_TRUE(download_complete_result_.response.empty());
EXPECT_LE(1, num_progress_calls_);
}
// Tests that specifying two urls has no side effects. Expect a successful
// download, and only one download request be made.
TEST_F(CrxDownloaderTest, TwoUrls) {
const GURL expected_crx_url =
GURL("http://localhost/download/jebgalgnebhfojomionfpkfelancnnkf.crx");
const base::FilePath test_file(GetTestFilePath(kTestFileName));
AddResponse(expected_crx_url, test_file, net::OK);
std::vector<GURL> urls;
urls.push_back(expected_crx_url);
urls.push_back(expected_crx_url);
crx_downloader_->StartDownload(urls, std::string(hash_jebg),
std::move(callback_));
RunThreads();
EXPECT_EQ(1, GetInterceptorCount());
EXPECT_EQ(1, num_download_complete_calls_);
EXPECT_EQ(0, download_complete_result_.error);
EXPECT_EQ(0, download_complete_result_.extra_code1);
EXPECT_TRUE(ContentsEqual(download_complete_result_.response, test_file));
EXPECT_TRUE(
DeleteFileAndEmptyParentDirectory(download_complete_result_.response));
EXPECT_LE(1, num_progress_calls_);
}
// Tests that the fallback to a valid url is successful.
TEST_F(CrxDownloaderTest, TwoUrls_FirstInvalid) {
const GURL expected_crx_url =
GURL("http://localhost/download/jebgalgnebhfojomionfpkfelancnnkf.crx");
const GURL no_file_url =
GURL("http://localhost/download/ihfokbkgjpifnbbojhneepfflplebdkc.crx");
const base::FilePath test_file(GetTestFilePath(kTestFileName));
AddResponse(expected_crx_url, test_file, net::OK);
AddResponse(no_file_url, base::FilePath(), net::ERR_FILE_NOT_FOUND);
std::vector<GURL> urls;
urls.push_back(no_file_url);
urls.push_back(expected_crx_url);
crx_downloader_->StartDownload(urls, std::string(hash_jebg),
std::move(callback_));
RunThreads();
EXPECT_EQ(2, GetInterceptorCount());
EXPECT_EQ(1, num_download_complete_calls_);
EXPECT_EQ(0, download_complete_result_.error);
EXPECT_EQ(0, download_complete_result_.extra_code1);
EXPECT_TRUE(ContentsEqual(download_complete_result_.response, test_file));
EXPECT_TRUE(
DeleteFileAndEmptyParentDirectory(download_complete_result_.response));
// Expect at least some progress reported by the loader.
EXPECT_LE(1, num_progress_calls_);
const auto download_metrics = crx_downloader_->download_metrics();
ASSERT_EQ(2u, download_metrics.size());
EXPECT_EQ(no_file_url, download_metrics[0].url);
EXPECT_EQ(net::ERR_FILE_NOT_FOUND, download_metrics[0].error);
EXPECT_EQ(-1, download_metrics[0].downloaded_bytes);
EXPECT_EQ(-1, download_metrics[0].total_bytes);
EXPECT_EQ(expected_crx_url, download_metrics[1].url);
EXPECT_EQ(0, download_metrics[1].error);
EXPECT_EQ(1015, download_metrics[1].downloaded_bytes);
EXPECT_EQ(1015, download_metrics[1].total_bytes);
}
// Tests that the download succeeds if the first url is correct and the
// second bad url does not have a side-effect.
TEST_F(CrxDownloaderTest, TwoUrls_SecondInvalid) {
const GURL expected_crx_url =
GURL("http://localhost/download/jebgalgnebhfojomionfpkfelancnnkf.crx");
const GURL no_file_url =
GURL("http://localhost/download/ihfokbkgjpifnbbojhneepfflplebdkc.crx");
const base::FilePath test_file(GetTestFilePath(kTestFileName));
AddResponse(expected_crx_url, test_file, net::OK);
AddResponse(no_file_url, base::FilePath(), net::ERR_FILE_NOT_FOUND);
std::vector<GURL> urls;
urls.push_back(expected_crx_url);
urls.push_back(no_file_url);
crx_downloader_->StartDownload(urls, std::string(hash_jebg),
std::move(callback_));
RunThreads();
EXPECT_EQ(1, GetInterceptorCount());
EXPECT_EQ(1, num_download_complete_calls_);
EXPECT_EQ(0, download_complete_result_.error);
EXPECT_EQ(0, download_complete_result_.extra_code1);
EXPECT_TRUE(ContentsEqual(download_complete_result_.response, test_file));
EXPECT_TRUE(
DeleteFileAndEmptyParentDirectory(download_complete_result_.response));
EXPECT_LE(1, num_progress_calls_);
EXPECT_EQ(1u, crx_downloader_->download_metrics().size());
}
// Tests that the download fails if both urls don't serve content.
TEST_F(CrxDownloaderTest, TwoUrls_BothInvalid) {
const GURL expected_crx_url =
GURL("http://localhost/download/jebgalgnebhfojomionfpkfelancnnkf.crx");
AddResponse(expected_crx_url, base::FilePath(), net::ERR_FILE_NOT_FOUND);
std::vector<GURL> urls;
urls.push_back(expected_crx_url);
urls.push_back(expected_crx_url);
crx_downloader_->StartDownload(urls, std::string(hash_jebg),
std::move(callback_));
RunThreads();
EXPECT_EQ(2, GetInterceptorCount());
EXPECT_EQ(1, num_download_complete_calls_);
EXPECT_NE(0, download_complete_result_.error);
EXPECT_EQ(0, download_complete_result_.extra_code1);
EXPECT_TRUE(download_complete_result_.response.empty());
const auto download_metrics = crx_downloader_->download_metrics();
ASSERT_EQ(2u, download_metrics.size());
EXPECT_EQ(expected_crx_url, download_metrics[0].url);
EXPECT_EQ(net::ERR_FILE_NOT_FOUND, download_metrics[0].error);
EXPECT_EQ(-1, download_metrics[0].downloaded_bytes);
EXPECT_EQ(-1, download_metrics[0].total_bytes);
EXPECT_EQ(expected_crx_url, download_metrics[1].url);
EXPECT_EQ(net::ERR_FILE_NOT_FOUND, download_metrics[1].error);
EXPECT_EQ(-1, download_metrics[1].downloaded_bytes);
EXPECT_EQ(-1, download_metrics[1].total_bytes);
}
} // namespace update_client
|