1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138
|
#!/usr/bin/env vpython3
# Copyright 2025 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import unittest
import crate_utils
from run_presubmits import (
# Functions under test:
_GetExtraKvForCrateName,
CheckExplicitAllowUnsafeForAllCrates,
CheckMultiversionCrates,
CheckNonapplicableGnrtConfigEntries,
)
class CheckExplicitAllowUnsafeForAllCratesTests(unittest.TestCase):
def testAllowUnsafeMissing(self):
crate_ids = set(["foo@1.2.3"])
gnrt_config = {}
msg = CheckExplicitAllowUnsafeForAllCrates(crate_ids, gnrt_config)
self.assertTrue("explicitly specifies `allow_unsafe = ...`" in msg)
self.assertTrue(
"all crates that `chromium_crates_io` depends on" in msg)
self.assertTrue("gnrt_config.toml" in msg)
self.assertTrue("[crate.foo.extra_kv]" in msg)
self.assertTrue("allow_unsafe = " in msg)
def testAllowUnsafePresent(self):
crate_ids = set(["foo@1.2.3"])
gnrt_config = {"crate": {"foo": {"extra_kv": {"allow_unsafe": True}}}}
self.assertEqual(
"", CheckExplicitAllowUnsafeForAllCrates(crate_ids, gnrt_config))
def testFakeRootCrateIsIgnored(self):
crate_ids = set(["chromium@1.2.3"])
gnrt_config = {}
self.assertEqual(
"", CheckExplicitAllowUnsafeForAllCrates(crate_ids, gnrt_config))
def testPlaceholderCratesAreIgnored(self):
crate_ids = set([crate_utils.GetPlaceholderCrateIdForTesting()])
gnrt_config = {}
self.assertEqual(
"", CheckExplicitAllowUnsafeForAllCrates(crate_ids, gnrt_config))
class CheckMultiversionCratesTests(unittest.TestCase):
def testNoMultiversionCrates(self):
crate_ids = set(["foo@1.2.3", "bar@4.5.6"])
gnrt_config = {}
self.assertEqual("", CheckMultiversionCrates(crate_ids, gnrt_config))
def testBugLinkPresent(self):
crate_ids = set(["foo@1.2.3", "foo@4.5.6"])
gnrt_config = {
"crate": {
"foo": {
"extra_kv": {
"multiversion_cleanup_bug": "blah"
}
}
}
}
self.assertEqual("", CheckMultiversionCrates(crate_ids, gnrt_config))
def testProblemDetection(self):
crate_ids = set(["foo@1.2.3", "foo@4.5.6"])
gnrt_config = {}
msg = CheckMultiversionCrates(crate_ids, gnrt_config)
self.assertTrue("multiple versions of the same crate" in msg)
self.assertTrue("gnrt_config.toml" in msg)
self.assertTrue("foo@1.2.3, foo@4.5.6" in msg)
self.assertTrue("[crate.foo.extra_kv]" in msg)
self.assertTrue("multiversion_cleanup_bug = " in msg)
class CheckNonapplicableGnrtConfigEntriesTests(unittest.TestCase):
def testNoProblems(self):
crate_ids = set(["foo@1.2.3"])
gnrt_config = {"crate": {"foo": {"bar": 123}}}
self.assertEqual(
"", CheckNonapplicableGnrtConfigEntries(crate_ids, gnrt_config))
def testProblem(self):
crate_ids = set()
gnrt_config = {"crate": {"foo": {"bar": 123}}}
msg = CheckNonapplicableGnrtConfigEntries(crate_ids, gnrt_config)
self.assertTrue("foo" in msg)
self.assertTrue("gnrt_config.toml" in msg)
def testPlaceholderCrate(self):
crate_id = crate_utils.GetPlaceholderCrateIdForTesting()
crate_name = crate_utils.ConvertCrateIdToCrateName(crate_id)
crate_ids = set([crate_id])
gnrt_config = {"crate": {crate_name: {"bar": 123}}}
msg = CheckNonapplicableGnrtConfigEntries(crate_ids, gnrt_config)
self.assertTrue(msg != "")
class GetExtraKvForCrateNameTests(unittest.TestCase):
def testHappyPath(self):
gnrt_config = {"crate": {"foo": {"extra_kv": {"entry": 123}}}}
extra_kv = _GetExtraKvForCrateName("foo", gnrt_config)
self.assertEqual({"entry": 123}, extra_kv)
def testMissingExtraKv(self):
""" Verify an empty dictionary is a fallback when no `extra_kv`. """
gnrt_config = {"crate": {"foo": {"bar": 123}}}
extra_kv = _GetExtraKvForCrateName("foo", gnrt_config)
self.assertEqual({}, extra_kv)
def testMissingCrateEntry(self):
gnrt_config = {"crate": {"other_crate": {"extra_kv": {"entry": 123}}}}
extra_kv = _GetExtraKvForCrateName("foo", gnrt_config)
self.assertEqual({}, extra_kv)
def testMistypedExtraKv(self):
""" Test fallback behavior when `extra_kv` is not a dictionary. """
gnrt_config = {"crate": {"foo": {"extra_kv": 123}}}
extra_kv = _GetExtraKvForCrateName("foo", gnrt_config)
self.assertEqual({}, extra_kv)
def testEmptyConfigSuchAsUsedInSomeTestsHere(self):
gnrt_config = {}
extra_kv = _GetExtraKvForCrateName("foo", gnrt_config)
self.assertEqual({}, extra_kv)
if __name__ == '__main__':
unittest.main()
|