1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
|
# Copyright 2022 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Presubmit script for ukm/ukm.xml on changes made to histograms/enums.xml
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details on the presubmit API built into gcl.
"""
UKM_XML = 'ukm.xml'
ENUMS_XML = 'enums.xml'
def CheckChange(input_api, output_api):
"""Checks that ukm/ukm.xml is validated on changes to histograms/enums.xml"""
absolute_paths_of_affected_files = [
f.AbsoluteLocalPath() for f in input_api.AffectedFiles()
]
ukm_xml_modified = any([
input_api.basename(p) == UKM_XML for p in absolute_paths_of_affected_files
])
# Early return if the ukm file is changed, then the presubmit script in the
# ukm directory would run and report the errors.
if ukm_xml_modified:
return []
enums_changed = any([
input_api.basename(p) == ENUMS_XML
for p in absolute_paths_of_affected_files
])
# This check only applies to changes to enums.xml, so if no enums are changed,
# then there is nothing to check and we return early with no errors.
if not enums_changed:
return []
cwd = input_api.os_path.dirname(input_api.PresubmitLocalPath())
args = [
input_api.python3_executable, 'metrics/ukm/validate_format.py',
'--presubmit'
]
exit_code = input_api.subprocess.call(args, cwd=cwd)
if exit_code != 0:
return [
output_api.PresubmitError(
'%s does not pass format validation; run '
'%s/ukm/validate_format.py and fix the reported error(s) or '
'warning(s).' % (UKM_XML, input_api.PresubmitLocalPath())),
]
return []
def CheckChangeOnUpload(input_api, output_api):
return CheckChange(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return CheckChange(input_api, output_api)
|
