1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "ash/assistant/ui/base/assistant_button.h"
#include <memory>
#include "ash/assistant/model/assistant_ui_model.h"
#include "ash/constants/ash_pref_names.h"
#include "ash/public/cpp/assistant/controller/assistant_ui_controller.h"
#include "ash/resources/vector_icons/vector_icons.h"
#include "ash/session/session_controller_impl.h"
#include "ash/shell.h"
#include "ash/strings/grit/ash_strings.h"
#include "ash/style/dark_light_mode_controller_impl.h"
#include "ash/test/ash_test_base.h"
#include "components/prefs/pref_service.h"
#include "components/vector_icons/vector_icons.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/skia/include/core/SkBitmap.h"
#include "third_party/skia/include/core/SkColor.h"
#include "ui/chromeos/styles/cros_tokens_color_mappings.h"
#include "ui/gfx/canvas.h"
#include "ui/gfx/color_palette.h"
#include "ui/gfx/geometry/insets.h"
#include "ui/gfx/image/image_unittest_util.h"
#include "ui/gfx/paint_vector_icon.h"
#include "ui/gfx/vector_icon_types.h"
#include "ui/views/controls/button/button.h"
#include "ui/views/painter.h"
#include "ui/views/widget/widget.h"
namespace ash {
namespace {
constexpr int kSizeInDip = 32;
constexpr int kIconSizeInDip = 24;
constexpr int kIconOffset = 4;
constexpr int kFocusRingStrokeWidth = 2;
SkBitmap CreateExpectedImageWithFocus(SkColor icon_color, SkColor focus_color) {
gfx::Canvas expected(gfx::Size(kSizeInDip, kSizeInDip), /*image_scale=*/1.0f,
/*is_opaque=*/true);
expected.DrawImageInt(
gfx::CreateVectorIcon(
vector_icons::kKeyboardIcon, kIconSizeInDip, icon_color),
kIconOffset, kIconOffset);
cc::PaintFlags circle_flags;
circle_flags.setAntiAlias(true);
circle_flags.setColor(focus_color);
circle_flags.setStyle(cc::PaintFlags::kStroke_Style);
circle_flags.setStrokeWidth(kFocusRingStrokeWidth);
expected.DrawCircle(gfx::Point(kSizeInDip / 2, kSizeInDip / 2),
kSizeInDip / 2 - kFocusRingStrokeWidth, circle_flags);
return expected.GetBitmap();
}
SkBitmap CreateExpectedImageWithoutFocus(SkColor icon_color) {
gfx::Canvas expected(gfx::Size(kSizeInDip, kSizeInDip), /*image_scale=*/1.0f,
/*is_opaque=*/true);
expected.DrawImageInt(gfx::CreateVectorIcon(vector_icons::kKeyboardIcon,
kIconSizeInDip, icon_color),
kIconOffset, kIconOffset);
return expected.GetBitmap();
}
} // namespace
using AssistantButtonTest = AshTestBase;
TEST_F(AssistantButtonTest, IconColor) {
AssistantButton::InitParams params;
params.icon_color = gfx::kGoogleBlue900;
params.size_in_dip = kSizeInDip;
params.icon_size_in_dip = kIconSizeInDip;
params.accessible_name_id = IDS_ASH_ASSISTANT_DIALOG_PLATE_KEYBOARD_ACCNAME;
std::unique_ptr<views::Widget> widget =
CreateTestWidget(views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET);
AssistantButton* button =
widget->GetContentsView()->AddChildView(AssistantButton::Create(
nullptr, vector_icons::kKeyboardIcon,
AssistantButtonId::kKeyboardInputToggle, std::move(params)));
EXPECT_TRUE(gfx::test::AreBitmapsEqual(
*gfx::CreateVectorIcon(vector_icons::kKeyboardIcon, kIconSizeInDip,
gfx::kGoogleBlue900).bitmap(),
*button->GetImage(views::Button::STATE_NORMAL).bitmap()));
}
TEST_F(AssistantButtonTest, IconColorType) {
auto* dark_light_mode_controller = DarkLightModeControllerImpl::Get();
dark_light_mode_controller->OnActiveUserPrefServiceChanged(
Shell::Get()->session_controller()->GetActivePrefService());
AssistantButton::InitParams params;
// Set icon_color to confirm that icon_color is ignored if icon_color_type is
// set at the same time.
params.icon_color = gfx::kGoogleBlue900;
params.size_in_dip = kSizeInDip;
params.icon_size_in_dip = kIconSizeInDip;
params.accessible_name_id = IDS_ASH_ASSISTANT_DIALOG_PLATE_KEYBOARD_ACCNAME;
params.icon_color_type = cros_tokens::kColorPrimary;
std::unique_ptr<views::Widget> widget =
CreateTestWidget(views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET);
AssistantButton* button =
widget->GetContentsView()->AddChildView(AssistantButton::Create(
nullptr, vector_icons::kKeyboardIcon,
AssistantButtonId::kKeyboardInputToggle, std::move(params)));
auto icon_color = button->GetColorProvider()->GetColor(
static_cast<ui::ColorId>(cros_tokens::kColorPrimary));
const SkBitmap initial_expected_image =
*gfx::CreateVectorIcon(vector_icons::kKeyboardIcon, kIconSizeInDip,
icon_color)
.bitmap();
const bool initial_dark_mode_status =
dark_light_mode_controller->IsDarkModeEnabled();
EXPECT_TRUE(gfx::test::AreBitmapsEqual(
initial_expected_image,
*button->GetImage(views::Button::STATE_NORMAL).bitmap()));
// Switch the color mode.
dark_light_mode_controller->ToggleColorMode();
const bool dark_mode_status = dark_light_mode_controller->IsDarkModeEnabled();
ASSERT_NE(initial_dark_mode_status, dark_mode_status);
icon_color = button->GetColorProvider()->GetColor(
static_cast<ui::ColorId>(cros_tokens::kColorPrimary));
const SkBitmap expected_image =
*gfx::CreateVectorIcon(vector_icons::kKeyboardIcon, kIconSizeInDip,
icon_color)
.bitmap();
EXPECT_FALSE(
gfx::test::AreBitmapsEqual(expected_image, initial_expected_image));
EXPECT_TRUE(gfx::test::AreBitmapsEqual(
expected_image, *button->GetImage(views::Button::STATE_NORMAL).bitmap()));
}
TEST_F(AssistantButtonTest, FocusAndHoverColorDarkLightMode) {
auto* dark_light_mode_controller = DarkLightModeControllerImpl::Get();
dark_light_mode_controller->OnActiveUserPrefServiceChanged(
Shell::Get()->session_controller()->GetActivePrefService());
AssistantButton::InitParams params;
params.size_in_dip = kSizeInDip;
params.icon_size_in_dip = kIconSizeInDip;
params.accessible_name_id = IDS_ASH_ASSISTANT_DIALOG_PLATE_KEYBOARD_ACCNAME;
params.icon_color_type = cros_tokens::kColorPrimary;
std::unique_ptr<views::Widget> widget =
CreateTestWidget(views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET);
AssistantButton* button =
widget->GetContentsView()->AddChildView(AssistantButton::Create(
nullptr, vector_icons::kKeyboardIcon,
AssistantButtonId::kKeyboardInputToggle, std::move(params)));
button->SizeToPreferredSize();
gfx::Canvas canvas(gfx::Size(kSizeInDip, kSizeInDip), /*image_scale=*/1.0f,
/*is_opaque=*/true);
const bool initial_dark_mode_status =
dark_light_mode_controller->IsDarkModeEnabled();
auto icon_color = button->GetColorProvider()->GetColor(
static_cast<ui::ColorId>(cros_tokens::kColorPrimary));
auto focus_ring_color = button->GetColorProvider()->GetColor(
static_cast<ui::ColorId>(cros_tokens::kFocusRingColor));
SkBitmap initial_button_image_with_focus =
CreateExpectedImageWithFocus(icon_color, focus_ring_color);
SkBitmap initial_button_image_without_focus =
CreateExpectedImageWithoutFocus(icon_color);
button->RequestFocus();
ASSERT_TRUE(button->HasFocus());
// Expect focus ring to be shown when keyboard traversal is enabled.
AssistantUiController::Get()->SetKeyboardTraversalMode(true);
button->OnPaint(&canvas);
EXPECT_TRUE(gfx::test::AreBitmapsEqual(initial_button_image_with_focus,
canvas.GetBitmap()));
canvas.RecreateBackingCanvas(gfx::Size(kSizeInDip, kSizeInDip),
/*image_scale=*/1.0f, /*is_opaque=*/true);
button->RequestFocus();
ASSERT_TRUE(button->HasFocus());
// Expect focus ring to be hidden when keyboard traversal mode is disabled.
AssistantUiController::Get()->SetKeyboardTraversalMode(false);
button->OnPaint(&canvas);
EXPECT_TRUE(gfx::test::AreBitmapsEqual(initial_button_image_without_focus,
canvas.GetBitmap()));
// Switch the color mode.
dark_light_mode_controller->ToggleColorMode();
const bool dark_mode_status = dark_light_mode_controller->IsDarkModeEnabled();
ASSERT_NE(initial_dark_mode_status, dark_mode_status);
canvas.RecreateBackingCanvas(gfx::Size(kSizeInDip, kSizeInDip),
/*image_scale=*/1.0f, /*is_opaque=*/true);
icon_color = button->GetColorProvider()->GetColor(
static_cast<ui::ColorId>(cros_tokens::kColorPrimary));
focus_ring_color = button->GetColorProvider()->GetColor(
static_cast<ui::ColorId>(cros_tokens::kFocusRingColor));
SkBitmap button_image_with_focus =
CreateExpectedImageWithFocus(icon_color, focus_ring_color);
SkBitmap button_image_without_focus =
CreateExpectedImageWithoutFocus(icon_color);
button->RequestFocus();
ASSERT_TRUE(button->HasFocus());
// Expect focus ring to be shown when keyboard traversal is enabled.
AssistantUiController::Get()->SetKeyboardTraversalMode(true);
button->OnPaint(&canvas);
EXPECT_FALSE(gfx::test::AreBitmapsEqual(initial_button_image_with_focus,
button_image_with_focus));
EXPECT_TRUE(
gfx::test::AreBitmapsEqual(button_image_with_focus, canvas.GetBitmap()));
canvas.RecreateBackingCanvas(gfx::Size(kSizeInDip, kSizeInDip),
/*image_scale=*/1.0f, /*is_opaque=*/true);
button->RequestFocus();
ASSERT_TRUE(button->HasFocus());
// Expect focus ring to be hidden when keyboard traversal mode is disabled.
AssistantUiController::Get()->SetKeyboardTraversalMode(false);
button->OnPaint(&canvas);
EXPECT_FALSE(gfx::test::AreBitmapsEqual(initial_button_image_without_focus,
button_image_without_focus));
EXPECT_TRUE(gfx::test::AreBitmapsEqual(button_image_without_focus,
canvas.GetBitmap()));
}
} // namespace ash
|
