1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
|
// Copyright 2016 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "cc/tiles/decoded_image_tracker.h"
#include <algorithm>
#include <unordered_map>
#include <vector>
#include "base/containers/contains.h"
#include "base/functional/bind.h"
#include "base/test/test_mock_time_task_runner.h"
#include "cc/paint/paint_image_builder.h"
#include "cc/test/skia_common.h"
#include "cc/tiles/image_controller.h"
#include "cc/tiles/software_image_decode_cache.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace cc {
class TestImageController : public ImageController {
public:
TestImageController()
: ImageController(nullptr, nullptr, base::DoNothing()) {}
void UnlockImageDecode(ImageDecodeRequestId id) override {
auto it = std::ranges::find(locked_ids_, id, &LockedIds::value_type::first);
ASSERT_FALSE(it == locked_ids_.end());
locked_ids_.erase(it);
}
ImageDecodeRequestId QueueImageDecode(const DrawImage& image,
ImageDecodedCallback callback,
bool speculative) override {
auto id = next_id_++;
locked_ids_.insert(
std::make_pair(id, SoftwareImageDecodeCache::CacheKey::FromDrawImage(
image, kRGBA_8888_SkColorType)));
std::move(callback).Run(id, ImageDecodeResult::SUCCESS);
return id;
}
bool IsDrawImageLocked(const DrawImage& image) {
SoftwareImageDecodeCache::CacheKey key =
SoftwareImageDecodeCache::CacheKey::FromDrawImage(
image, kRGBA_8888_SkColorType);
return base::Contains(locked_ids_, key, &LockedIds::value_type::second);
}
size_t num_locked_images() { return locked_ids_.size(); }
private:
using LockedIds = std::unordered_map<ImageDecodeRequestId,
SoftwareImageDecodeCache::CacheKey>;
ImageDecodeRequestId next_id_ = 1;
LockedIds locked_ids_;
};
class DecodedImageTrackerTest : public testing::Test {
public:
DecodedImageTrackerTest()
: task_runner_(new base::TestMockTimeTaskRunner()),
decoded_image_tracker_(&image_controller_, task_runner_) {
decoded_image_tracker_.SetTickClockForTesting(
task_runner_->GetMockTickClock());
}
DrawImage DrawImageForDecoding(const PaintImage& paint_image,
const TargetColorParams& color_params) const {
return DrawImage(paint_image,
/*use_dark_mode=*/false,
SkIRect::MakeWH(paint_image.width(), paint_image.height()),
PaintFlags::FilterQuality::kNone, SkM44(),
PaintImage::kDefaultFrameIndex, color_params);
}
TestImageController* image_controller() { return &image_controller_; }
DecodedImageTracker* decoded_image_tracker() {
return &decoded_image_tracker_;
}
base::TestMockTimeTaskRunner* task_runner() { return task_runner_.get(); }
private:
TestImageController image_controller_;
scoped_refptr<base::TestMockTimeTaskRunner> task_runner_;
DecodedImageTracker decoded_image_tracker_;
};
TEST_F(DecodedImageTrackerTest, QueueImageLocksImages) {
bool locked = false;
decoded_image_tracker()->QueueImageDecode(
DrawImageForDecoding(CreateDiscardablePaintImage(gfx::Size(1, 1)),
TargetColorParams()),
base::BindOnce([](bool* locked, bool success) { *locked = true; },
base::Unretained(&locked)),
/*speculative*/ false);
EXPECT_TRUE(locked);
EXPECT_EQ(1u, image_controller()->num_locked_images());
}
TEST_F(DecodedImageTrackerTest, Colorspace) {
bool locked = false;
gfx::ColorSpace decoded_color_space(gfx::ColorSpace::PrimaryID::XYZ_D50,
gfx::ColorSpace::TransferID::SRGB);
TargetColorParams srgb_target_color_params;
auto paint_image = CreateDiscardablePaintImage(gfx::Size(1, 1));
TargetColorParams target_color_params;
target_color_params.color_space = decoded_color_space;
decoded_image_tracker()->QueueImageDecode(
DrawImageForDecoding(paint_image, target_color_params),
base::BindOnce([](bool* locked, bool success) { *locked = true; },
base::Unretained(&locked)),
/*speculative*/ false);
// Check that the decoded color space images are locked, but if the color
// space differs then that image is not locked. Note that we use the high
// filter quality here, since it shouldn't matter and the checks should
// succeed anyway.
DrawImage locked_draw_image(paint_image, false, SkIRect::MakeWH(1, 1),
PaintFlags::FilterQuality::kHigh, SkM44(),
PaintImage::kDefaultFrameIndex,
target_color_params);
EXPECT_TRUE(image_controller()->IsDrawImageLocked(locked_draw_image));
DrawImage srgb_draw_image(paint_image, false, SkIRect::MakeWH(1, 1),
PaintFlags::FilterQuality::kHigh, SkM44(),
PaintImage::kDefaultFrameIndex,
srgb_target_color_params);
EXPECT_FALSE(image_controller()->IsDrawImageLocked(srgb_draw_image));
}
TEST_F(DecodedImageTrackerTest, ImagesTimeOut) {
// Add an image, this will start a 250ms timeout to release it.
bool locked = false;
decoded_image_tracker()->QueueImageDecode(
DrawImageForDecoding(CreateDiscardablePaintImage(gfx::Size(1, 1)),
TargetColorParams()),
base::BindOnce([](bool* locked, bool success) { *locked = true; },
base::Unretained(&locked)),
/*speculative*/ false);
EXPECT_TRUE(locked);
EXPECT_EQ(1u, image_controller()->num_locked_images());
// Advance by 150ms, the image should still be locked.
task_runner()->FastForwardBy(base::Milliseconds(150));
EXPECT_EQ(1u, image_controller()->num_locked_images());
// Add an image, this will not start a new timeout, as one is pending.
locked = false;
decoded_image_tracker()->QueueImageDecode(
DrawImageForDecoding(CreateDiscardablePaintImage(gfx::Size(1, 1)),
TargetColorParams()),
base::BindOnce([](bool* locked, bool success) { *locked = true; },
base::Unretained(&locked)),
/*speculative*/ false);
EXPECT_TRUE(locked);
EXPECT_EQ(2u, image_controller()->num_locked_images());
// Advance by 100ms, we our first image should be released.
// Trigger a single commit, the first image should be unlocked.
task_runner()->FastForwardBy(base::Milliseconds(100));
EXPECT_EQ(1u, image_controller()->num_locked_images());
// Advance by another 250ms, our second image should release.
task_runner()->FastForwardBy(base::Milliseconds(250));
EXPECT_EQ(0u, image_controller()->num_locked_images());
}
TEST_F(DecodedImageTrackerTest, ImageUsedInDraw) {
TargetColorParams target_color_params;
// Insert two images:
bool locked = false;
auto paint_image_1 = CreateDiscardablePaintImage(gfx::Size(1, 1));
decoded_image_tracker()->QueueImageDecode(
DrawImageForDecoding(paint_image_1, target_color_params),
base::BindOnce([](bool* locked, bool success) { *locked = true; },
base::Unretained(&locked)),
/*speculative*/ false);
EXPECT_TRUE(locked);
EXPECT_EQ(1u, image_controller()->num_locked_images());
locked = false;
auto paint_image_2 = CreateDiscardablePaintImage(gfx::Size(1, 1));
decoded_image_tracker()->QueueImageDecode(
DrawImageForDecoding(paint_image_2, target_color_params),
base::BindOnce([](bool* locked, bool success) { *locked = true; },
base::Unretained(&locked)),
/*speculative*/ false);
EXPECT_TRUE(locked);
EXPECT_EQ(2u, image_controller()->num_locked_images());
// Create dummy draw images for each:
DrawImage draw_image_1(paint_image_1, false, SkIRect::MakeWH(1, 1),
PaintFlags::FilterQuality::kHigh, SkM44(), 0,
target_color_params);
DrawImage draw_image_2(paint_image_2, false, SkIRect::MakeWH(1, 1),
PaintFlags::FilterQuality::kHigh, SkM44(), 0,
target_color_params);
// Both should be in the cache:
EXPECT_TRUE(image_controller()->IsDrawImageLocked(draw_image_1));
EXPECT_TRUE(image_controller()->IsDrawImageLocked(draw_image_2));
// Pretend we've drawn with image 2.
decoded_image_tracker()->OnImagesUsedInDraw({draw_image_2});
// Only image 1 should now be in the cache.
EXPECT_TRUE(image_controller()->IsDrawImageLocked(draw_image_1));
EXPECT_FALSE(image_controller()->IsDrawImageLocked(draw_image_2));
}
TEST_F(DecodedImageTrackerTest, UnlockAllImages) {
// Insert two images:
bool locked = false;
decoded_image_tracker()->QueueImageDecode(
DrawImageForDecoding(CreateDiscardablePaintImage(gfx::Size(1, 1)),
TargetColorParams()),
base::BindOnce([](bool* locked, bool success) { *locked = true; },
base::Unretained(&locked)),
/*speculative*/ false);
EXPECT_TRUE(locked);
EXPECT_EQ(1u, image_controller()->num_locked_images());
locked = false;
decoded_image_tracker()->QueueImageDecode(
DrawImageForDecoding(CreateDiscardablePaintImage(gfx::Size(1, 1)),
TargetColorParams()),
base::BindOnce([](bool* locked, bool success) { *locked = true; },
base::Unretained(&locked)),
/*speculative*/ false);
EXPECT_TRUE(locked);
EXPECT_EQ(2u, image_controller()->num_locked_images());
// Unlock all images.
decoded_image_tracker()->UnlockAllImages();
EXPECT_EQ(0u, image_controller()->num_locked_images());
}
} // namespace cc
|
