1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
|
// Copyright 2023 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ash/arc/memory_pressure/container_app_killer.h"
#include <map>
#include <vector>
#include "base/process/process_handle.h" // For ProcessId.
#include "chromeos/ash/experiences/arc/mojom/process.mojom.h" // For ProcessState.
#include "content/public/test/browser_task_environment.h"
#include "testing/gtest/include/gtest/gtest.h" // For TEST.
namespace {
constexpr bool kIsFocused = true;
constexpr bool kNotFocused = false;
} // namespace
class ContainerAppKillerTest : public testing::Test {
public:
ContainerAppKillerTest() = default;
~ContainerAppKillerTest() override = default;
private:
content::BrowserTaskEnvironment task_environment_;
};
TEST_F(ContainerAppKillerTest, SortedCandidates) {
std::vector<arc::ArcProcess> arc_processes;
arc_processes.emplace_back(1, 20, "visible1", arc::mojom::ProcessState::TOP,
kNotFocused, 6000);
arc_processes.emplace_back(
2, 30, "service", arc::mojom::ProcessState::SERVICE, kNotFocused, 2001);
arc_processes.emplace_back(3, 40, "visible2", arc::mojom::ProcessState::TOP,
kNotFocused, 5001);
arc::ArcProcessService::OptionalArcProcessList opt_arc_processes(
std::move(arc_processes));
std::vector<arc::ContainerAppKiller::KillCandidate> candidates =
arc::ContainerAppKiller::GetSortedCandidates(opt_arc_processes);
EXPECT_EQ(3U, candidates.size());
// Background service.
EXPECT_EQ("service", candidates[0].process_name());
// Visible app 2, last_activity_time less than visible app 1.
EXPECT_EQ("visible2", candidates[1].process_name());
// Visible app 1, last_activity_time larger than visible app 2.
EXPECT_EQ("visible1", candidates[2].process_name());
}
class MockContainerAppKiller : public arc::ContainerAppKiller {
public:
void SetProcessRssKB(base::ProcessId pid, uint64_t rss_kb) {
process_rss_kb_[pid] = rss_kb;
}
std::vector<base::ProcessId> GetKilledProcesses() {
return killed_processes_;
}
bool IsRecentlyKilled(const std::string& process_name,
const base::TimeTicks& now) override {
if (always_return_true_from_is_recently_killed_) {
return true;
}
return arc::ContainerAppKiller::IsRecentlyKilled(process_name, now);
}
void set_always_return_true_from_is_recently_killed(
bool always_return_true_from_is_recently_killed) {
always_return_true_from_is_recently_killed_ =
always_return_true_from_is_recently_killed;
}
protected:
uint64_t GetMemoryFootprintKB(base::ProcessId pid) override {
return process_rss_kb_[pid];
}
bool KillArcProcess(base::ProcessId nspid) override {
killed_processes_.push_back(nspid);
return true;
}
private:
std::map<base::ProcessId, uint64_t> process_rss_kb_;
std::vector<base::ProcessId> killed_processes_;
bool always_return_true_from_is_recently_killed_ = false;
};
TEST_F(ContainerAppKillerTest, IsRecentlyKilled) {
constexpr char kProcessName1[] = "org.chromium.arc.test1";
constexpr char kProcessName2[] = "org.chromium.arc.test2";
// Instantiate the mock instance.
MockContainerAppKiller app_killer;
// When the process name is not in the map, IsRecentlyKilled should
// return false.
const base::TimeTicks now = base::TimeTicks::Now();
EXPECT_FALSE(app_killer.IsRecentlyKilled(kProcessName1, now));
EXPECT_FALSE(app_killer.IsRecentlyKilled(kProcessName2, now));
// Update the map to tell the manager that the process was killed very
// recently.
app_killer.recently_killed_[kProcessName1] = now;
EXPECT_TRUE(app_killer.IsRecentlyKilled(kProcessName1, now));
EXPECT_FALSE(app_killer.IsRecentlyKilled(kProcessName2, now));
app_killer.recently_killed_[kProcessName1] = now - base::Microseconds(1);
EXPECT_TRUE(app_killer.IsRecentlyKilled(kProcessName1, now));
EXPECT_FALSE(app_killer.IsRecentlyKilled(kProcessName2, now));
app_killer.recently_killed_[kProcessName1] =
now - arc::ContainerAppKiller::kArcRespawnKillDelay;
EXPECT_TRUE(app_killer.IsRecentlyKilled(kProcessName1, now));
EXPECT_FALSE(app_killer.IsRecentlyKilled(kProcessName2, now));
// Update the map to tell the manager that the process was killed
// (GetArcRespawnKillDelay() + 1) seconds ago. In this case,
// IsRecentlyKilled(kProcessName1) should return false.
app_killer.recently_killed_[kProcessName1] =
now - arc::ContainerAppKiller::kArcRespawnKillDelay - base::Seconds(1);
EXPECT_FALSE(app_killer.IsRecentlyKilled(kProcessName1, now));
EXPECT_FALSE(app_killer.IsRecentlyKilled(kProcessName2, now));
}
TEST_F(ContainerAppKillerTest, DoNotKillRecentlyKilled) {
// Instantiate the mock instance.
MockContainerAppKiller app_killer;
app_killer.set_always_return_true_from_is_recently_killed(true);
std::vector<arc::ArcProcess> arc_processes;
arc_processes.emplace_back(
1, 10, "service", arc::mojom::ProcessState::SERVICE, kNotFocused, 500);
app_killer.SetProcessRssKB(10, 10000);
app_killer.LowMemoryKill(
ash::ResourcedClient::PressureLevelArcContainer::kPerceptible, 250000,
std::move(arc_processes));
auto killed = app_killer.GetKilledProcesses();
EXPECT_EQ(0U, killed.size());
}
TEST_F(ContainerAppKillerTest, KillMultipleProcesses) {
// Instantiate the mock instance.
MockContainerAppKiller app_killer;
std::vector<arc::ArcProcess> arc_processes;
arc_processes.emplace_back(1, 10, "focused", arc::mojom::ProcessState::TOP,
kIsFocused, 100);
arc_processes.emplace_back(2, 20, "visible1", arc::mojom::ProcessState::TOP,
kNotFocused, 200);
arc_processes.emplace_back(
3, 30, "service", arc::mojom::ProcessState::SERVICE, kNotFocused, 500);
arc_processes.emplace_back(4, 40, "visible2",
arc::mojom::ProcessState::IMPORTANT_FOREGROUND,
kNotFocused, 150);
arc_processes.emplace_back(5, 50, "not-visible",
arc::mojom::ProcessState::IMPORTANT_BACKGROUND,
kNotFocused, 300);
arc_processes.emplace_back(6, 60, "persistent",
arc::mojom::ProcessState::PERSISTENT, kNotFocused,
400);
// Entities to be killed.
app_killer.SetProcessRssKB(20, 30000);
app_killer.SetProcessRssKB(30, 10000);
app_killer.SetProcessRssKB(40, 50000);
app_killer.SetProcessRssKB(50, 60000);
// Should not be killed.
app_killer.SetProcessRssKB(60, 500000);
app_killer.SetProcessRssKB(10, 100000);
app_killer.LowMemoryKill(
ash::ResourcedClient::PressureLevelArcContainer::kPerceptible, 250000,
std::move(arc_processes));
auto killed_processes = app_killer.GetKilledProcesses();
// Sorted order (by GetSortedCandidates, focused and persistent are excluded):
// app "service" pid: 30 nspid 3
// app "visible2" pid: 40 nspid 4
// app "visible1" pid: 20 nspid 2
// app "not-visible" pid: 50 nspid 5
// Killed processes and their nspid. All of the apps (except the focused and
// persistent processes) should have been killed.
EXPECT_EQ(4U, killed_processes.size());
EXPECT_EQ(3, killed_processes[0]);
EXPECT_EQ(4, killed_processes[1]);
EXPECT_EQ(2, killed_processes[2]);
EXPECT_EQ(5, killed_processes[3]);
// Check that killed apps are in the map.
const arc::ContainerAppKiller::KilledProcessesMap& processes_map =
app_killer.recently_killed_;
EXPECT_EQ(4U, processes_map.size());
EXPECT_EQ(1U, processes_map.count("service"));
EXPECT_EQ(1U, processes_map.count("not-visible"));
EXPECT_EQ(1U, processes_map.count("visible1"));
EXPECT_EQ(1U, processes_map.count("visible2"));
}
|
