1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
|
// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/ui/webui/whats_new/whats_new_fetcher.h"
#include "base/strings/stringprintf.h"
#include "base/test/scoped_feature_list.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/global_features.h"
#include "chrome/browser/ui/webui/whats_new/whats_new_storage_service_impl.h"
#include "chrome/common/chrome_version.h"
#include "chrome/test/interaction/interactive_browser_test.h"
#include "components/user_education/webui/whats_new_registry.h"
#include "content/public/test/browser_test.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
using BrowserCommand = browser_command::mojom::Command;
// Enabled through feature list.
BASE_FEATURE(kTestModuleEnabled,
"TestModuleEnabled",
base::FEATURE_DISABLED_BY_DEFAULT);
// Enabled through feature list.
BASE_FEATURE(kTestModule2Enabled,
"TestModule2Enabled",
base::FEATURE_DISABLED_BY_DEFAULT);
// Enabled through feature list.
BASE_FEATURE(kTestEditionEnabled,
"TestEditionEnabled",
base::FEATURE_DISABLED_BY_DEFAULT);
// Disabled through feature list.
BASE_FEATURE(kTestModuleDisabled,
"TestModuleDisabled",
base::FEATURE_DISABLED_BY_DEFAULT);
// Enabled by default.
BASE_FEATURE(kTestModuleEnabledByDefault,
"TestModuleEnabledByDefault",
base::FEATURE_ENABLED_BY_DEFAULT);
// Disabled by default.
BASE_FEATURE(kTestModuleDisabledByDefault,
"TestModuleDisabledByDefault",
base::FEATURE_DISABLED_BY_DEFAULT);
} // namespace
class GlobalFeaturesFake : public GlobalFeatures {
public:
GlobalFeaturesFake() = default;
protected:
std::unique_ptr<whats_new::WhatsNewRegistry> CreateWhatsNewRegistry()
override {
auto registry = std::make_unique<whats_new::WhatsNewRegistry>(
std::make_unique<whats_new::WhatsNewStorageServiceImpl>());
return registry;
}
};
std::unique_ptr<GlobalFeatures> CreateGlobalFeatures() {
return std::make_unique<GlobalFeaturesFake>();
}
class WhatsNewFetcherBrowserTest : public InteractiveBrowserTest {
public:
WhatsNewFetcherBrowserTest() {
GlobalFeatures::ReplaceGlobalFeaturesForTesting(
base::BindRepeating(&CreateGlobalFeatures));
}
void SetUp() override {
InitFeatures();
InteractiveBrowserTest::SetUp();
}
virtual void InitFeatures() {
feature_list_.InitWithFeatures({kTestModuleEnabled, kTestModule2Enabled},
{kTestModuleDisabled});
}
~WhatsNewFetcherBrowserTest() override {
GlobalFeatures::ReplaceGlobalFeaturesForTesting(base::NullCallback());
}
whats_new::WhatsNewRegistry* GetRegistry() {
return g_browser_process->GetFeatures()->whats_new_registry();
}
protected:
base::test::ScopedFeatureList feature_list_;
};
IN_PROC_BROWSER_TEST_F(WhatsNewFetcherBrowserTest, GetV2ServerURL) {
const std::string expected = base::StringPrintf(
"https://www.google.com/chrome/v2/whats-new/?version=%d",
CHROME_VERSION_MAJOR);
EXPECT_EQ(expected, whats_new::GetV2ServerURL().possibly_invalid_spec());
}
IN_PROC_BROWSER_TEST_F(WhatsNewFetcherBrowserTest,
GetV2ServerURLForRenderNoFeatures) {
std::string expected = base::StringPrintf(
"https://www.google.com/chrome/v2/whats-new/?version=%d&internal=true",
CHROME_VERSION_MAJOR);
EXPECT_EQ(expected, whats_new::GetV2ServerURLForRender(*GetRegistry())
.possibly_invalid_spec());
}
IN_PROC_BROWSER_TEST_F(WhatsNewFetcherBrowserTest,
GetV2ServerStagingURLForRenderNoFeatures) {
std::string expected = base::StringPrintf(
"https://chrome-staging.corp.google.com/chrome/v2/whats-new/"
"?version=%d&internal=true",
CHROME_VERSION_MAJOR);
EXPECT_EQ(expected, whats_new::GetV2ServerURLForRender(*GetRegistry(), true)
.possibly_invalid_spec());
}
IN_PROC_BROWSER_TEST_F(WhatsNewFetcherBrowserTest,
GetV2ServerURLForRenderWithOneEnabled) {
whats_new::WhatsNewRegistry* registry = GetRegistry();
registry->RegisterModule(whats_new::WhatsNewModule(kTestModuleEnabled, ""));
registry->RegisterModule(
whats_new::WhatsNewModule("", "", BrowserCommand::kNoOpCommand));
std::string expected = base::StringPrintf(
"https://www.google.com/chrome/v2/whats-new/?version=%d",
CHROME_VERSION_MAJOR);
// Enabled modules will be sent with `enabled` parameter.
expected.append(base::StringPrintf("&enabled=%s", kTestModuleEnabled.name));
expected.append("&internal=true");
EXPECT_EQ(expected, whats_new::GetV2ServerURLForRender(*GetRegistry())
.possibly_invalid_spec());
}
IN_PROC_BROWSER_TEST_F(WhatsNewFetcherBrowserTest,
GetV2ServerURLForRenderWithMultipleEnabled) {
whats_new::WhatsNewRegistry* registry = GetRegistry();
registry->RegisterModule(whats_new::WhatsNewModule(kTestModuleEnabled, ""));
registry->RegisterModule(whats_new::WhatsNewModule(kTestModule2Enabled, ""));
registry->RegisterModule(
whats_new::WhatsNewModule("", "", BrowserCommand::kNoOpCommand));
std::string expected = base::StringPrintf(
"https://www.google.com/chrome/v2/whats-new/?version=%d",
CHROME_VERSION_MAJOR);
// Multiple enabled features will be comma-separated (url-encoded).
expected.append(base::StringPrintf(
"&enabled=%s%%2C%s", kTestModuleEnabled.name, kTestModule2Enabled.name));
expected.append("&internal=true");
EXPECT_EQ(expected, whats_new::GetV2ServerURLForRender(*GetRegistry())
.possibly_invalid_spec());
}
IN_PROC_BROWSER_TEST_F(WhatsNewFetcherBrowserTest,
GetV2ServerURLForRenderEnabledAndRolled) {
whats_new::WhatsNewRegistry* registry = GetRegistry();
registry->RegisterModule(whats_new::WhatsNewModule(kTestModuleEnabled, ""));
// Will be ignored - disabled by experiment
registry->RegisterModule(whats_new::WhatsNewModule(kTestModuleDisabled, ""));
registry->RegisterModule(
whats_new::WhatsNewModule(kTestModuleEnabledByDefault, ""));
// Will be ignored - disabled by default
registry->RegisterModule(
whats_new::WhatsNewModule(kTestModuleDisabledByDefault, ""));
// Will be ignored - no feature.
registry->RegisterModule(
whats_new::WhatsNewModule("", "", BrowserCommand::kNoOpCommand));
std::string expected = base::StringPrintf(
"https://www.google.com/chrome/v2/whats-new/?version=%d",
CHROME_VERSION_MAJOR);
// Enabled modules will be sent with `enabled` parameter.
expected.append(base::StringPrintf("&enabled=%s", kTestModuleEnabled.name));
// Enabled by default modules will be sent with `rolled` parameter.
expected.append(
base::StringPrintf("&rolled=%s", kTestModuleEnabledByDefault.name));
expected.append("&internal=true");
EXPECT_EQ(expected, whats_new::GetV2ServerURLForRender(*GetRegistry())
.possibly_invalid_spec());
}
class WhatsNewFetcherOneCustomizationBrowserTest
: public WhatsNewFetcherBrowserTest {
public:
void InitFeatures() override {
feature_list_.InitWithFeaturesAndParameters(
{{kTestModuleEnabled, {{whats_new::kCustomizationParam, "abc"}}},
{kTestModule2Enabled, {{}}}},
{kTestModuleDisabled});
}
};
IN_PROC_BROWSER_TEST_F(WhatsNewFetcherOneCustomizationBrowserTest,
GetV2ServerURLForRender) {
whats_new::WhatsNewRegistry* registry = GetRegistry();
registry->RegisterModule(whats_new::WhatsNewModule(kTestModuleEnabled, ""));
// Will be ignored - disabled by experiment
registry->RegisterModule(whats_new::WhatsNewModule(kTestModuleDisabled, ""));
registry->RegisterModule(
whats_new::WhatsNewModule(kTestModuleEnabledByDefault, ""));
// Will be ignored - disabled by default
registry->RegisterModule(
whats_new::WhatsNewModule(kTestModuleDisabledByDefault, ""));
// Will be ignored - no feature.
registry->RegisterModule(
whats_new::WhatsNewModule("", "", BrowserCommand::kNoOpCommand));
std::string expected = base::StringPrintf(
"https://www.google.com/chrome/v2/whats-new/?version=%d",
CHROME_VERSION_MAJOR);
// Enabled modules will be sent with `enabled` parameter.
expected.append(base::StringPrintf("&enabled=%s", kTestModuleEnabled.name));
// Enabled by default modules will be sent with `rolled` parameter.
expected.append(
base::StringPrintf("&rolled=%s", kTestModuleEnabledByDefault.name));
// Customization
expected.append("&customization=abc");
expected.append("&internal=true");
EXPECT_EQ(expected, whats_new::GetV2ServerURLForRender(*GetRegistry())
.possibly_invalid_spec());
}
class WhatsNewFetcherMultipleCustomizationsBrowserTest
: public WhatsNewFetcherBrowserTest {
public:
void InitFeatures() override {
feature_list_.InitWithFeaturesAndParameters(
{{kTestModuleEnabled, {{whats_new::kCustomizationParam, "abc"}}},
{kTestModule2Enabled, {{whats_new::kCustomizationParam, "def"}}},
{kTestEditionEnabled, {{whats_new::kCustomizationParam, "hij"}}}},
{});
}
};
IN_PROC_BROWSER_TEST_F(WhatsNewFetcherMultipleCustomizationsBrowserTest,
GetV2ServerURLForRender) {
whats_new::WhatsNewRegistry* registry = GetRegistry();
registry->RegisterModule(whats_new::WhatsNewModule(kTestModuleEnabled, ""));
registry->RegisterModule(whats_new::WhatsNewModule(kTestModule2Enabled, ""));
registry->RegisterEdition(
whats_new::WhatsNewEdition(kTestEditionEnabled, ""));
// Will be ignored - no feature.
registry->RegisterModule(
whats_new::WhatsNewModule("", "", BrowserCommand::kNoOpCommand));
std::string expected = base::StringPrintf(
"https://www.google.com/chrome/v2/whats-new/?version=%d",
CHROME_VERSION_MAJOR);
// Enabled modules will be sent with `enabled` parameter.
auto enabled =
base::JoinString({kTestEditionEnabled.name, kTestModuleEnabled.name,
kTestModule2Enabled.name},
std::string("%2C"));
expected.append(base::StringPrintf("&enabled=%s", enabled));
// Customizations
auto customizations =
base::JoinString({"abc", "def", "hij"}, std::string("%2C"));
expected.append(base::StringPrintf("&customization=%s", customizations));
expected.append("&internal=true");
EXPECT_EQ(expected, whats_new::GetV2ServerURLForRender(*GetRegistry())
.possibly_invalid_spec());
}
|
